@arcgis/eslint-config 5.1.0-next.67 → 5.1.0-next.69

package/dist/config/index.js

@@ -458,7 +458,13 @@ const defaultConfig = [
       "@typescript-eslint/no-duplicate-type-constituents": ["warn"],
       "@typescript-eslint/no-unnecessary-boolean-literal-compare": ["warn"],
       "@typescript-eslint/no-extra-non-null-assertion": ["warn"],
-      "@typescript-eslint/no-unnecessary-type-arguments": ["warn"],
+      // False positive for the following:
+      // this.listen<CustomEvent>("arcgisChartsJSDataProcessComplete", this.handleDataProcessComplete);
+      "@typescript-eslint/no-unnecessary-type-arguments": "off",
+      // The autofix creates TS errors in makeT9nController(). This is a new
+      // rule - give it more time to catch the bug cases. Also, this rule
+      // changes runtime behavior, and may lead to breaking changes.
+      "@typescript-eslint/no-useless-default-assignment": "off",
       "@typescript-eslint/no-unnecessary-type-assertion": ["warn"],
       "@typescript-eslint/prefer-includes": ["warn"],
       "@typescript-eslint/prefer-reduce-type-parameter": ["warn"],
@@ -599,6 +605,18 @@ const defaultConfig = [
       // Allow empty "files" field to explicitly indicate that no files
       // should be included in the package
       "package-json/no-empty-fields": ["error", { ignoreProperties: ["files"] }],
+      // We use license instead
+      "package-json/require-attribution": "off",
+      // We are not open source
+      "package-json/require-repository": "off",
+      // This option is tricky to set right, especially for web component
+      // libraries that have many side effect entrypoints. It can also get out
+      // of date easily. If we don't explicitly indicate sideEffects, bundlers
+      // have good default AST-based heuristics.
+      "package-json/require-sideEffects": "off",
+      // Can't address these till 6.0 without breaking changes.
+      // Most errors are in react wrappers which will be dropped in 6.0.
+      "package-json/require-exports": "off",
       // Enforce a specific property order for better readability and consistency
       "package-json/order-properties": [
         "warn",

package/dist/config/lumina.js

@@ -29,6 +29,8 @@ const storybookConfig = [
       "storybook/no-title-property-in-meta": "off",
       // Not applicable as we have a central Storybook config (@arcgis/storybook-utils)
       "storybook/no-uninstalled-addons": "off",
+      // Not that helpful as we have a central Storybook config (@arcgis/storybook-utils)
+      "storybook/no-renderer-packages": "off",
       // We never used storiesOf, and it's no longer included in Storybook
       "storybook/no-stories-of": "off",
       // Redundant with TypeScript

package/dist/{estree-Or2bG8yJ.js → estree-C7gwzhFc.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils, AST_NODE_TYPES } from "@typescript-eslint/utils";
-const version = "5.1.0-next.67";
+const version = "5.1.0-next.69";
 const packageJson = {
   version
 };

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin, l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, d as isCreateEvent, h as hasDecorator, f as getName, j as checkForLuminaJsx, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-Or2bG8yJ.js";
+import { m as makeEslintPlugin, l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, d as isCreateEvent, h as hasDecorator, f as getName, j as checkForLuminaJsx, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-C7gwzhFc.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import ts from "typescript";
 import { camelToKebab } from "@arcgis/toolkit/string";
@@ -1354,20 +1354,26 @@ plugin.createRule({
     return {
       "Program:exit"() {
         const source = context.sourceCode.text;
-        for (const match of source.matchAll(/@(?:internal|private)\b/gu)) {
-          const idx = match.index;
-          const lineStart = source.lastIndexOf("\n", idx - 1) + 1;
-          const before = source.slice(lineStart, idx).trim();
-          if (before === "*" || before === "/**") {
+        for (const comment of context.sourceCode.getAllComments()) {
+          const commentText = source.slice(comment.range[0], comment.range[1]);
+          if (!commentText.startsWith("/**")) {
             continue;
           }
-          context.report({
-            messageId: "inlineExposure",
-            loc: {
-              start: context.sourceCode.getLocFromIndex(idx - 1),
-              end: context.sourceCode.getLocFromIndex(idx + match[0].length)
+          for (const match of comment.value.matchAll(/@(?:internal|private)\b/gu)) {
+            const idx = comment.range[0] + 2 + match.index;
+            const lineStart = source.lastIndexOf("\n", idx - 1) + 1;
+            const before = source.slice(lineStart, idx).trim();
+            if (before === "*" || before === "/**") {
+              continue;
             }
-          });
+            context.report({
+              messageId: "inlineExposure",
+              loc: {
+                start: context.sourceCode.getLocFromIndex(idx - 1),
+                end: context.sourceCode.getLocFromIndex(idx + match[0].length)
+              }
+            });
+          }
         }
       }
     };

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin, e as extractDeclareElementsInterface, g as getComponentDeclaration } from "../../estree-Or2bG8yJ.js";
+import { m as makeEslintPlugin, e as extractDeclareElementsInterface, g as getComponentDeclaration } from "../../estree-C7gwzhFc.js";
 import { resolve } from "path/posix";
 import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const plugin = makeEslintPlugin(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "5.1.0-next.67",
+  "version": "5.1.0-next.69",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "main": "index.js",
@@ -23,21 +23,21 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@eslint/js": "^9.39.1",
-    "@eslint/markdown": "^7.5.1",
+    "@eslint/js": "^10.0.1",
+    "@eslint/markdown": "^8.0.1",
     "@types/confusing-browser-globals": "^1.0.3",
-    "@typescript-eslint/utils": "^8.46.4",
+    "@typescript-eslint/utils": "^8.58.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint-plugin-package-json": "^0.88.1",
-    "eslint-plugin-storybook": "^0.12.0",
+    "eslint-plugin-package-json": "~0.91.1",
+    "eslint-plugin-storybook": "^10.3.4",
     "globals": "^16.5.0",
-    "jsonc-eslint-parser": "^2.0.0",
+    "jsonc-eslint-parser": "^3.1.0",
     "tslib": "^2.8.1",
-    "typescript": "~5.9.3",
-    "typescript-eslint": "^8.46.3",
-    "@arcgis/toolkit": "5.1.0-next.67"
+    "typescript": "~6.0.2",
+    "typescript-eslint": "^8.58.0",
+    "@arcgis/toolkit": "5.1.0-next.69"
   },
   "peerDependencies": {
-    "eslint": "^9.39.1"
+    "eslint": "^10.2.0"
   }
 }