@arcgis/eslint-config 5.1.0-next.11 → 5.1.0-next.112

package/README.md

@@ -8,5 +8,5 @@ It is not intended to be used directly, but rather used as a dependency by other
 
 ## License
 
-This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package, and at https://js.arcgis.com/5.0/LICENSE.txt.
-For third party notices, see https://js.arcgis.com/5.0/third-party-notices.txt.
+This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package, and at https://js.arcgis.com/5.1/LICENSE.txt.
+For third party notices, see https://js.arcgis.com/5.1/third-party-notices.txt.

package/dist/config/index.js

@@ -213,6 +213,18 @@ const defaultConfig = [
       "@typescript-eslint/restrict-plus-operands": ["warn", { allowNumberAndString: true }],
       // We often actually have control characters in our regexes
       "no-control-regex": "off",
+      "@typescript-eslint/no-restricted-imports": [
+        "error",
+        {
+          paths: [
+            {
+              name: "commander",
+              importNames: ["Command"],
+              message: "Import from @commander-js/extra-typings instead."
+            }
+          ]
+        }
+      ],
       // Functions that deal with JSON.stringify/localStorage may have a type
       // parameter as a more readable alternative to a type assertion.
       // Also, this rule is quite complicated/expensive.
@@ -446,7 +458,13 @@ const defaultConfig = [
       "@typescript-eslint/no-duplicate-type-constituents": ["warn"],
       "@typescript-eslint/no-unnecessary-boolean-literal-compare": ["warn"],
       "@typescript-eslint/no-extra-non-null-assertion": ["warn"],
-      "@typescript-eslint/no-unnecessary-type-arguments": ["warn"],
+      // False positive for the following:
+      // this.listen<CustomEvent>("arcgisChartsJSDataProcessComplete", this.handleDataProcessComplete);
+      "@typescript-eslint/no-unnecessary-type-arguments": "off",
+      // The autofix creates TS errors in makeT9nController(). This is a new
+      // rule - give it more time to catch the bug cases. Also, this rule
+      // changes runtime behavior, and may lead to breaking changes.
+      "@typescript-eslint/no-useless-default-assignment": "off",
       "@typescript-eslint/no-unnecessary-type-assertion": ["warn"],
       "@typescript-eslint/prefer-includes": ["warn"],
       "@typescript-eslint/prefer-reduce-type-parameter": ["warn"],
@@ -587,6 +605,18 @@ const defaultConfig = [
       // Allow empty "files" field to explicitly indicate that no files
       // should be included in the package
       "package-json/no-empty-fields": ["error", { ignoreProperties: ["files"] }],
+      // We use license instead
+      "package-json/require-attribution": "off",
+      // We are not open source
+      "package-json/require-repository": "off",
+      // This option is tricky to set right, especially for web component
+      // libraries that have many side effect entrypoints. It can also get out
+      // of date easily. If we don't explicitly indicate sideEffects, bundlers
+      // have good default AST-based heuristics.
+      "package-json/require-sideEffects": "off",
+      // Can't address these till 6.0 without breaking changes.
+      // Most errors are in react wrappers which will be dropped in 6.0.
+      "package-json/require-exports": "off",
       // Enforce a specific property order for better readability and consistency
       "package-json/order-properties": [
         "warn",

package/dist/config/lumina.js

@@ -29,10 +29,16 @@ const storybookConfig = [
       "storybook/no-title-property-in-meta": "off",
       // Not applicable as we have a central Storybook config (@arcgis/storybook-utils)
       "storybook/no-uninstalled-addons": "off",
+      // Not that helpful as we have a central Storybook config (@arcgis/storybook-utils)
+      "storybook/no-renderer-packages": "off",
       // We never used storiesOf, and it's no longer included in Storybook
       "storybook/no-stories-of": "off",
       // Redundant with TypeScript
-      "storybook/context-in-play-function": "off"
+      "storybook/context-in-play-function": "off",
+      // Enforces writing satisfies Meta after the meta object definition to ensure that stories use the correct properties in the metadata.
+      "storybook/meta-satisfies-type": "error",
+      // In our Lumina stories, render args should infer from Meta<T>/StoryObj<T>.
+      "webgis/no-story-render-args-type-annotation": "error"
     }
   }
 ];

package/dist/{estree-DYv2wwWx.js → estree-C51QozkW.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils, AST_NODE_TYPES } from "@typescript-eslint/utils";
-const version = "5.1.0-next.11";
+const version = "5.1.0-next.112";
 const packageJson = {
   version
 };
@@ -81,6 +81,7 @@ function getComponentDeclaration(node) {
   }
   return;
 }
+const sourceCodeDeclaresComponent = (sourceCode) => sourceCode.text.includes("interface DeclareElements");
 function isCreateEvent(node) {
   return node.value?.type === AST_NODE_TYPES.CallExpression && node.value.callee.type === AST_NODE_TYPES.Identifier && node.value.callee.name === "createEvent" && !node.static;
 }
@@ -144,16 +145,17 @@ export {
   luminaEntrypointName as a,
   luminaTestEntrypointName as b,
   getProperty as c,
-  checkForLuminaJsx as d,
+  isCreateEvent as d,
   extractDeclareElementsInterface as e,
-  isCreateEvent as f,
+  getName as f,
   getComponentDeclaration as g,
   hasDecorator as h,
   isGetterWithoutSetter as i,
-  getName as j,
+  checkForLuminaJsx as j,
   isBindThisCallee as k,
   luminaJsxExportName as l,
   makeEslintPlugin as m,
   parsePropertyDecorator as p,
+  sourceCodeDeclaresComponent as s,
   unwrapExpression as u
 };

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin, l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, d as checkForLuminaJsx, e as extractDeclareElementsInterface, f as isCreateEvent, h as hasDecorator, j as getName, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-DYv2wwWx.js";
+import { m as makeEslintPlugin, l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, d as isCreateEvent, h as hasDecorator, f as getName, j as checkForLuminaJsx, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-C51QozkW.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import ts from "typescript";
 import { camelToKebab } from "@arcgis/toolkit/string";
@@ -7,16 +7,16 @@ const plugin = makeEslintPlugin(
   (rule) => `https://devtopia.esri.com/WebGIS/arcgis-web-components/tree/main/packages/support-packages/eslint-config/src/plugins/lumina/rules/${rule}.ts`
 );
 const importDeclaration = `import { ${luminaJsxExportName} } from "${luminaEntrypointName}";`;
-const description$l = `To use Lumina's JSX, you need to ${importDeclaration}`;
+const description$m = `To use Lumina's JSX, you need to ${importDeclaration}`;
 plugin.createRule({
   name: "add-missing-jsx-import",
   meta: {
     docs: {
-      description: description$l,
+      description: description$m,
       defaultLevel: "error"
     },
     messages: {
-      addMissingJsxImport: description$l
+      addMissingJsxImport: description$m
     },
     type: "problem",
     schema: [],
@@ -73,12 +73,12 @@ plugin.createRule({
     };
   }
 });
-const description$k = "Auto add { type: Boolean } or { type: Number } where necessary";
+const description$l = "Auto add { type: Boolean } or { type: Number } where necessary";
 plugin.createRule({
   name: "auto-add-type",
   meta: {
     docs: {
-      description: description$k,
+      description: description$l,
       defaultLevel: "warn"
     },
     messages: {
@@ -96,6 +96,9 @@ More information: https://devtopia.esri.com/WebGIS/arcgis-web-components/issues/
   },
   defaultOptions: [],
   create(context) {
+    if (!sourceCodeDeclaresComponent(context.sourceCode)) {
+      return {};
+    }
     const services = ESLintUtils.getParserServices(context);
     return {
       Decorator(decorator) {
@@ -112,7 +115,7 @@ More information: https://devtopia.esri.com/WebGIS/arcgis-web-components/issues/
         const typeProperty = getProperty(properties, "type");
         const converterProperty = getProperty(properties, "converter");
         const isTrivialType = trivialType === "Number" || trivialType === "Boolean";
-        if (isTrivialType && typeProperty !== void 0 && typeProperty.type === AST_NODE_TYPES.Identifier && (typeProperty.name === "Number" || typeProperty.name === "Boolean")) {
+        if (isTrivialType && typeProperty?.type === AST_NODE_TYPES.Identifier && (typeProperty.name === "Number" || typeProperty.name === "Boolean")) {
           context.report({
             node: typeProperty,
             messageId: "noUnnecessaryType",
@@ -274,6 +277,9 @@ plugin.createRule({
     type: "problem"
   },
   create(context) {
+    if (!sourceCodeDeclaresComponent(context.sourceCode)) {
+      return {};
+    }
     const bannedEventToMessageLookup = /* @__PURE__ */ new Map();
     context.options.forEach((option) => {
       const event = typeof option === "string" ? option : option.event;
@@ -294,32 +300,24 @@ plugin.createRule({
         });
       }
     }
-    const luminaJsxCheck = checkForLuminaJsx();
     return {
-      "ImportDeclaration": luminaJsxCheck,
       "CallExpression:matches([callee.property.name=addEventListener], [callee.property.name=removeEventListener]), CallExpression[callee.object.type=ThisExpression][callee.property.name=listen]"(node) {
-        if (!luminaJsxCheck.isLuminaJsx) {
-          return;
-        }
         const eventName = node.arguments[0].value;
         checkEvent(node, eventName);
       },
       "CallExpression[callee.object.type=ThisExpression][callee.property.name=listenOn]"(node) {
-        if (!luminaJsxCheck.isLuminaJsx) {
-          return;
-        }
         const eventName = node.arguments[1].value;
         checkEvent(node, eventName);
       }
     };
   }
 });
-const description$j = `Lumina component must be declared in a TSX file with a matching folder name located inside of src/components folder.`;
+const description$k = `Lumina component must be declared in a TSX file with a matching folder name located inside of src/components folder.`;
 plugin.createRule({
   name: "component-placement-rules",
   meta: {
     docs: {
-      description: description$j,
+      description: description$k,
       defaultLevel: "error"
     },
     messages: {
@@ -358,7 +356,7 @@ plugin.createRule({
     };
   }
 });
-const description$i = `Enforce consistent event naming.`;
+const description$j = `Enforce consistent event naming.`;
 const defaultOptions$1 = [
   {
     eventNamespaces: ["arcgis"],
@@ -369,7 +367,7 @@ plugin.createRule({
   name: "consistent-event-naming",
   meta: {
     docs: {
-      description: description$i,
+      description: description$j,
       defaultLevel: "warn"
     },
     messages: {
@@ -470,12 +468,12 @@ Discussion: https://devtopia.esri.com/WebGIS/arcgis-web-components/discussions/3
   }
 });
 const capitalAfterLower = /(?<=[a-z\d])[A-Z]/u;
-const description$h = `Enforce consistent usage of ? for marking property as nullable, rather than |null, |undefined or |Nil.`;
+const description$i = `Enforce consistent usage of ? for marking property as nullable, rather than |null, |undefined or |Nil.`;
 plugin.createRule({
   name: "consistent-nullability",
   meta: {
     docs: {
-      description: description$h,
+      description: description$i,
       // TODO: enable this by default
       defaultLevel: "off"
     },
@@ -551,18 +549,18 @@ plugin.createRule({
     };
   }
 });
-const description$g = `Enforce that @property(), @method() and createEvent() members are used in the correct context.`;
+const description$h = `Enforce that @property(), @method() and createEvent() members are used in the correct context.`;
 plugin.createRule({
   name: "decorators-context",
   meta: {
     docs: {
-      description: description$g,
+      description: description$h,
       defaultLevel: "error"
     },
     messages: {
       publicApiMustBePublic: `@property(), @method() and createEvent() members must not have private or protected modifier.
       
-If you wish to hide this member from public documentation, use @private or @protected JSDoc tags instead. Documentation: https://webgis.esri.com/references/lumina/documenting-components#excluding-api-from-public-documentation`,
+If you wish to hide this member from public documentation, use @private or @internal JSDoc tags instead. Documentation: https://webgis.esri.com/references/api-extractor/tags-reference`,
       noPropertyDecoratorOnMethods: `Methods must not have @property() nor @state() decorator. Did you mean @property() instead?`,
       noCombinedPropertyEvent: `Property may either be an event (initialized with createEvent()) or a property (has @property() decorator), but not both`,
       noCombinedPropertyState: `Property may either be a state (initialized with @state()) or a property (has @property() decorator), but not both`,
@@ -574,6 +572,9 @@ If you wish to hide this member from public documentation, use @private or @prot
   },
   defaultOptions: [],
   create(context) {
+    if (!sourceCodeDeclaresComponent(context.sourceCode)) {
+      return {};
+    }
     return {
       PropertyDefinition(node) {
         const hasPropertyDecorator = hasDecorator(node, "property");
@@ -650,7 +651,7 @@ function isLuminaJsxType(type) {
 }
 const hasTypeFlag = (type, flag) => type.flags & flag ? true : (type.flags & ts.TypeFlags.Union) !== 0 && type.types.some((t) => hasTypeFlag(t, flag));
 const literalTypeFlag = ts.TypeFlags.StringLike | ts.TypeFlags.NumberLike | ts.TypeFlags.BooleanLike;
-const description$f = `Need to add explicit type annotation: {{ setterType }}
+const description$g = `Need to add explicit type annotation: {{ setterType }}
 
 Explanation:
 Lumina automatically creates an attribute for a property if property type includes a literal type (string|number|boolean).
@@ -661,11 +662,11 @@ plugin.createRule({
   name: "explicit-setter-type",
   meta: {
     docs: {
-      description: description$f,
+      description: description$g,
       defaultLevel: "error"
     },
     messages: {
-      explicitSetterType: description$f,
+      explicitSetterType: description$g,
       addExplicitSetterType: `Add {{ setterType }} type annotation`
     },
     type: "problem",
@@ -1211,16 +1212,16 @@ function isCreateElementComponent(node) {
   }
   return false;
 }
-const description$e = `Use @internal or @private JSDoc tag over @ignore. See https://webgis.esri.com/references/lumina/documenting-components#excluding-api-from-public-documentation`;
+const description$f = `Use @internal or @private JSDoc tag over @ignore. See https://webgis.esri.com/references/api-extractor/tags-reference`;
 plugin.createRule({
   name: "no-ignore-jsdoc-tag",
   meta: {
     docs: {
-      description: description$e,
+      description: description$f,
       defaultLevel: "error"
     },
     messages: {
-      noIgnoreJsDocTag: description$e
+      noIgnoreJsDocTag: description$f
     },
     type: "problem",
     schema: []
@@ -1249,12 +1250,12 @@ plugin.createRule({
   }
 });
 const reIgnore = /\* @ignore/gu;
-const description$d = `Detect incorrect usage of dynamic JSX tag name`;
+const description$e = `Detect incorrect usage of dynamic JSX tag name`;
 plugin.createRule({
   name: "no-incorrect-dynamic-tag-name",
   meta: {
     docs: {
-      description: description$d,
+      description: description$e,
       defaultLevel: "error"
     },
     messages: {
@@ -1297,18 +1298,18 @@ plugin.createRule({
     };
   }
 });
-const description$c = `If inline arrow function is passed to ref, it will be called again on each render.
+const description$d = `If inline arrow function is passed to ref, it will be called again on each render.
 
 If this is not desirable, see alternatives: https://webgis.esri.com/references/lumina/jsx#refs`;
 plugin.createRule({
   name: "no-inline-arrow-in-ref",
   meta: {
     docs: {
-      description: description$c,
+      description: description$d,
       defaultLevel: "warn"
     },
     messages: {
-      errorInlineArrow: description$c
+      errorInlineArrow: description$d
     },
     type: "problem",
     schema: []
@@ -1334,16 +1335,16 @@ plugin.createRule({
     };
   }
 });
-const description$b = `Put @internal and @private on their own JSDoc line, not inline.`;
+const description$c = `Put @internal and @private on their own JSDoc line, not inline.`;
 plugin.createRule({
   name: "no-inline-exposure-jsdoc-tag",
   meta: {
     docs: {
-      description: description$b,
+      description: description$c,
       defaultLevel: "error"
     },
     messages: {
-      inlineExposure: description$b
+      inlineExposure: description$c
     },
     type: "problem",
     schema: []
@@ -1353,25 +1354,75 @@ plugin.createRule({
     return {
       "Program:exit"() {
         const source = context.sourceCode.text;
-        for (const match of source.matchAll(/@(?:internal|private)\b/gu)) {
-          const idx = match.index;
-          const lineStart = source.lastIndexOf("\n", idx - 1) + 1;
-          const before = source.slice(lineStart, idx).trim();
-          if (before === "*" || before === "/**") {
+        for (const comment of context.sourceCode.getAllComments()) {
+          const commentText = source.slice(comment.range[0], comment.range[1]);
+          if (!commentText.startsWith("/**")) {
             continue;
           }
-          context.report({
-            messageId: "inlineExposure",
-            loc: {
-              start: context.sourceCode.getLocFromIndex(idx - 1),
-              end: context.sourceCode.getLocFromIndex(idx + match[0].length)
+          for (const match of comment.value.matchAll(/@(?:internal|private)\b/gu)) {
+            const idx = comment.range[0] + 2 + match.index;
+            const lineStart = source.lastIndexOf("\n", idx - 1) + 1;
+            const before = source.slice(lineStart, idx).trim();
+            if (before === "*" || before === "/**") {
+              continue;
             }
-          });
+            context.report({
+              messageId: "inlineExposure",
+              loc: {
+                start: context.sourceCode.getLocFromIndex(idx - 1),
+                end: context.sourceCode.getLocFromIndex(idx + match[0].length)
+              }
+            });
+          }
         }
       }
     };
   }
 });
+const absoluteDocsBaseUrl = "https://next.gha.afd.arcgis.com/";
+const description$b = `xref:// URLs are not supported in JSDoc. Use absolute links to ${absoluteDocsBaseUrl} instead.`;
+plugin.createRule({
+  name: "no-jsdoc-xref-links",
+  meta: {
+    docs: {
+      description: description$b,
+      defaultLevel: "error"
+    },
+    messages: {
+      noJsDocXrefLinks: description$b
+    },
+    type: "problem",
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    return {
+      "Program:exit"() {
+        const source = context.sourceCode.text;
+        if (!source.includes("xref://")) {
+          return;
+        }
+        for (const comment of context.sourceCode.getAllComments()) {
+          const commentText = source.slice(comment.range[0], comment.range[1]);
+          if (!commentText.startsWith("/**") || !commentText.includes("xref://")) {
+            continue;
+          }
+          for (const match of commentText.matchAll(reXrefUrl)) {
+            const idx = comment.range[0] + (match.index ?? 0);
+            context.report({
+              messageId: "noJsDocXrefLinks",
+              loc: {
+                start: context.sourceCode.getLocFromIndex(idx),
+                end: context.sourceCode.getLocFromIndex(idx + match[0].length)
+              }
+            });
+          }
+        }
+      }
+    };
+  }
+});
+const reXrefUrl = /xref:\/\/[\w./#-]+/gu;
 const description$a = `directives={} prop value must be an array literal. Documentation: https://webgis.esri.com/references/lumina/jsx#lit-directives`;
 plugin.createRule({
   name: "no-invalid-directives-prop",
@@ -1525,8 +1576,10 @@ plugin.createRule({
   },
   defaultOptions: [],
   create(context) {
+    if (!sourceCodeDeclaresComponent(context.sourceCode)) {
+      return {};
+    }
     let className;
-    const hasLuminaDeclarations = context.sourceCode.text.includes("interface DeclareElements");
     return {
       TSModuleDeclaration(node) {
         const luminaDeclarationInterface = extractDeclareElementsInterface(node);
@@ -1536,7 +1589,7 @@ plugin.createRule({
         className = getComponentDeclaration(luminaDeclarationInterface)?.typeAnnotation?.typeAnnotation.typeName.name;
       },
       ExportNamedDeclaration(node) {
-        if (!hasLuminaDeclarations && className === void 0) {
+        if (className === void 0) {
           return;
         }
         if (node.exportKind === "type") {
@@ -1571,7 +1624,7 @@ plugin.createRule({
         });
       },
       ExportDefaultDeclaration(node) {
-        if (!hasLuminaDeclarations && className === void 0) {
+        if (className === void 0) {
           return;
         }
         context.report({
@@ -1580,7 +1633,7 @@ plugin.createRule({
         });
       },
       ExportAllDeclaration(node) {
-        if (!hasLuminaDeclarations && className === void 0) {
+        if (className === void 0) {
           return;
         }
         if (node.exportKind === "type") {
@@ -1731,7 +1784,7 @@ plugin.createRule({
           return;
         }
         const argument = functionParent.params.at(0);
-        if (argument === void 0 || argument.type !== AST_NODE_TYPES.Identifier || argument.name !== eventVariableName) {
+        if (argument?.type !== AST_NODE_TYPES.Identifier || argument.name !== eventVariableName) {
           return;
         }
         const reportPossiblyUnnecessaryTypeAssertion = () => context.report({

package/dist/plugins/lumina/rules/no-jsdoc-xref-links.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import('@typescript-eslint/utils/ts-eslint').RuleModule<"noJsDocXrefLinks", [], import('../../utils/makePlugin.ts').CommonDocs, import('@typescript-eslint/utils/ts-eslint').RuleListener>;
+export default _default;

package/dist/plugins/lumina/utils/estree.d.ts

@@ -17,6 +17,9 @@ export declare function getComponentDeclaration(node: TSESTree.TSInterfaceDeclar
         };
     };
 } | undefined;
+export declare const sourceCodeDeclaresComponent: (sourceCode: {
+    readonly text: string;
+}) => boolean;
 export declare function isCreateEvent(node: TSESTree.PropertyDefinition): boolean;
 export declare const getProperty: (properties: TSESTree.ObjectLiteralElement[] | undefined, name: string) => TSESTree.Property["value"] | undefined;
 export declare function isGetterWithoutSetter(node: TSESTree.MethodDefinition | TSESTree.PropertyDefinition): boolean;

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin, e as extractDeclareElementsInterface, g as getComponentDeclaration } from "../../estree-DYv2wwWx.js";
+import { m as makeEslintPlugin, e as extractDeclareElementsInterface, g as getComponentDeclaration } from "../../estree-C51QozkW.js";
 import { resolve } from "path/posix";
 import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const plugin = makeEslintPlugin(
@@ -7,16 +7,16 @@ const plugin = makeEslintPlugin(
 );
 const isTestFile = (filePath) => filePath.includes("/test") || filePath.includes(".test") || filePath.includes(".spec") || filePath.includes("e2e") || filePath.includes("__") || filePath.includes("/.");
 const isStorybookFile = (filePath) => filePath.includes(".stories");
-const description$5 = `Imports of files outside the src/ folder are not-portable and likely to break for consumers of this package.`;
+const description$6 = `Imports of files outside the src/ folder are not-portable and likely to break for consumers of this package.`;
 plugin.createRule({
   name: "no-import-outside-src",
   meta: {
     docs: {
-      description: description$5,
+      description: description$6,
       defaultLevel: "error"
     },
     messages: {
-      noImportOutsideSrc: description$5
+      noImportOutsideSrc: description$6
     },
     type: "problem",
     schema: []
@@ -29,7 +29,7 @@ plugin.createRule({
       return {};
     }
     const basePath = fileName.slice(0, srcIndex + "/src/".length);
-    if (isTestFile(fileName)) {
+    if (isTestFile(fileName) || isStorybookFile(fileName)) {
       return {};
     }
     return {
@@ -50,16 +50,16 @@ plugin.createRule({
     };
   }
 });
-const description$4 = `Having two JSDoc comments next to each other is most likely a mistake - consider combining them into one, or separating them for clarity.`;
+const description$5 = `Having two JSDoc comments next to each other is most likely a mistake - consider combining them into one, or separating them for clarity.`;
 plugin.createRule({
   name: "no-touching-jsdoc",
   meta: {
     docs: {
-      description: description$4,
+      description: description$5,
       defaultLevel: "warn"
     },
     messages: {
-      noTouchingJsDoc: description$4
+      noTouchingJsDoc: description$5
     },
     type: "problem",
     schema: []
@@ -95,17 +95,17 @@ plugin.createRule({
   }
 });
 const reTouchingJsDoc = /\*\/\s+\/\*\*/gu;
-const description$3 = `@arcgis/core imports need to end with .js for better compatibility with ESM CDN builds for @arcgis/core and other packages.`;
+const description$4 = `@arcgis/core imports need to end with .js for better compatibility with ESM CDN builds for @arcgis/core and other packages.`;
 const packagesToEnforce = ["@arcgis/core/", "@amcharts/amcharts4/", "@amcharts/amcharts5/"];
 plugin.createRule({
   name: "require-js-in-imports",
   meta: {
     docs: {
-      description: description$3,
+      description: description$4,
       defaultLevel: "warn"
     },
     messages: {
-      requireJsInCoreImport: description$3
+      requireJsInCoreImport: description$4
     },
     type: "problem",
     fixable: "code",
@@ -117,7 +117,7 @@ plugin.createRule({
       return {};
     }
     function updateSpecifier(node) {
-      if (node.source.type !== AST_NODE_TYPES.Literal || node.importKind === "type") {
+      if (node.source.type !== AST_NODE_TYPES.Literal) {
         return;
       }
       const specifier = node.source.value;
@@ -139,17 +139,17 @@ plugin.createRule({
     };
   }
 });
-const description$2 = "Using .d.ts files is discouraged. Prefer .ts files instead, as they are type-checked and not in global scope.";
+const description$3 = "Using .d.ts files is discouraged. Prefer .ts files instead, as they are type-checked and not in global scope.";
 const allowedNames = /* @__PURE__ */ new Set(["vite-env.d.ts", "components.d.ts"]);
 plugin.createRule({
   name: "no-dts-files",
   meta: {
     docs: {
-      description: description$2,
+      description: description$3,
       defaultLevel: "warn"
     },
     messages: {
-      avoidDtsFiles: description$2
+      avoidDtsFiles: description$3
     },
     type: "suggestion",
     schema: []
@@ -179,12 +179,12 @@ plugin.createRule({
     };
   }
 });
-const description$1 = `Enforce consistent logging so that ArcGIS developers can easily debug errors or warnings logged by our web components, which may lack a meaningful context in compiled code. See [our documentation on @arcgis/toolkit/log](https://webgis.esri.com/references/toolkit/log).`;
+const description$2 = `Enforce consistent logging so that ArcGIS developers can easily debug errors or warnings logged by our web components, which may lack a meaningful context in compiled code. See [our documentation on @arcgis/toolkit/log](https://webgis.esri.com/references/toolkit/log).`;
 plugin.createRule({
   name: "consistent-logging",
   meta: {
     docs: {
-      description: description$1,
+      description: description$2,
       defaultLevel: "off"
       // NOTE: this is turned on conditionally in root eslint config
     },
@@ -217,16 +217,16 @@ plugin.createRule({
     };
   }
 });
-const description = `Do not use links like [](#something) as they are not portable across .d.ts, and are not validated at build time. Use {@link } syntax, or absolute links. See https://webgis.esri.com/webgis/core/core/documenting-api#link`;
+const description$1 = `Do not use links like [](#something) as they are not portable across .d.ts, and are not validated at build time. Use {@link } syntax, or absolute links. See https://webgis.esri.com/references/api-extractor/tags-reference#link)`;
 plugin.createRule({
   name: "no-unsafe-hash-links",
   meta: {
     docs: {
-      description,
+      description: description$1,
       defaultLevel: "warn"
     },
     messages: {
-      error: description
+      error: description$1
     },
     type: "problem",
     schema: [],
@@ -272,6 +272,47 @@ function computeReplacement(declareElementsInterface, anchor) {
   const tagName = declaration.key.value;
   return `components/${tagName}#${anchor}`;
 }
+const description = "In Storybook render functions, let `args` infer from `Meta<T>` or `StoryObj<T>` instead of annotating the render parameter.";
+plugin.createRule({
+  name: "no-story-render-args-type-annotation",
+  meta: {
+    docs: {
+      description,
+      defaultLevel: "off"
+    },
+    messages: {
+      noStoryRenderArgsTypeAnnotation: "Do not annotate `render(args)` in stories. Type the story with `Meta<T>` or `StoryObj<T>` and let `args` infer from that."
+    },
+    schema: [],
+    type: "suggestion",
+    fixable: "code"
+  },
+  defaultOptions: [],
+  create(context) {
+    if (!isStorybookFile(context.filename)) {
+      return {};
+    }
+    return {
+      Property(node) {
+        if (!isRenderProperty(node)) {
+          return;
+        }
+        const [firstParameter] = node.value.params;
+        if (firstParameter?.type !== AST_NODE_TYPES.Identifier || firstParameter.typeAnnotation === void 0) {
+          return;
+        }
+        context.report({
+          node: firstParameter.typeAnnotation,
+          messageId: "noStoryRenderArgsTypeAnnotation",
+          fix: (fixer) => fixer.remove(firstParameter.typeAnnotation)
+        });
+      }
+    };
+  }
+});
+function isRenderProperty(node) {
+  return node.key.type === AST_NODE_TYPES.Identifier && node.key.name === "render" && (node.value.type === AST_NODE_TYPES.ArrowFunctionExpression || node.value.type === AST_NODE_TYPES.FunctionExpression);
+}
 const webgisPlugin = plugin.finalize();
 export {
   webgisPlugin

package/dist/plugins/webgis/rules/no-story-render-args-type-annotation.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import('@typescript-eslint/utils/ts-eslint').RuleModule<"noStoryRenderArgsTypeAnnotation", [], import('../../utils/makePlugin.ts').CommonDocs, import('@typescript-eslint/utils/ts-eslint').RuleListener>;
+export default _default;

package/dist/utils/disable-rules.d.ts

@@ -0,0 +1,24 @@
+import { TSESLint } from '@typescript-eslint/utils';
+/**
+ * A utility for temporary running ESLint with only specific rules enabled.
+ *
+ * @param config flat config
+ * @param enabledRules exceptions
+ * @param disableTypeChecking make ESLint much faster by temporary disabling
+ * type-aware linting.
+ * @returns a new flat config array where every rule is disabled,
+ * except for rules explicitly listed in `enabledRules`.
+ *
+ * @example
+ * const config = [
+ *  // Your ESLint flat config
+ * ];
+ * export default disableAllRulesExcept(
+ *   config,
+ *   {
+ *     "rule-name-1": "error",
+ *   },
+ *   true,
+ * );
+ */
+export declare function disableAllRulesExcept(config: TSESLint.FlatConfig.ConfigArray, enabledRules: Record<string, TSESLint.FlatConfig.RuleLevel>, disableTypeChecking: boolean): TSESLint.FlatConfig.ConfigArray;

package/dist/utils/disable-rules.js

@@ -0,0 +1,47 @@
+function disableAllRulesExcept(config, enabledRules, disableTypeChecking) {
+  return config.map((entry) => applyRulesAndOptions(entry, enabledRules, disableTypeChecking));
+}
+function applyRulesAndOptions(entry, enabledRules, disableTypeChecking) {
+  if (!entry || typeof entry !== "object") {
+    return entry;
+  }
+  const nextEntry = entry.rules ? {
+    ...entry,
+    rules: Object.fromEntries(
+      Object.keys(entry.rules).map((ruleName) => {
+        const override = enabledRules[ruleName];
+        return [ruleName, override ?? "off"];
+      })
+    )
+  } : entry;
+  return tweakOptions(nextEntry, disableTypeChecking);
+}
+function tweakOptions(entry, disableTypeChecking) {
+  if (entry.linterOptions !== void 0) {
+    entry = {
+      ...entry,
+      linterOptions: {
+        ...entry.linterOptions,
+        reportUnusedDisableDirectives: "off",
+        reportUnusedInlineConfigs: "off"
+      }
+    };
+  }
+  if (disableTypeChecking && entry.languageOptions?.parserOptions) {
+    entry = {
+      ...entry,
+      languageOptions: {
+        ...entry.languageOptions,
+        parserOptions: {
+          ...entry.languageOptions.parserOptions,
+          project: void 0,
+          projectService: void 0
+        }
+      }
+    };
+  }
+  return entry;
+}
+export {
+  disableAllRulesExcept
+};

package/package.json

@@ -1,18 +1,18 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "5.1.0-next.11",
-  "description": "ESLint configuration for arcgis-web-components",
+  "version": "5.1.0-next.112",
+  "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
-  "main": "index.js",
-  "module": "dist/index.js",
-  "types": "dist/index.d.ts",
   "exports": {
     ".": "./dist/config/index.js",
+    "./ts": "./src/config/index.ts",
     "./application": "./dist/config/applications.js",
     "./extra": "./dist/config/extra.js",
     "./lumina": "./dist/config/lumina.js",
+    "./lumina/ts": "./src/config/lumina.ts",
     "./plugins/webgis": "./dist/plugins/webgis/index.js",
     "./plugins/lumina": "./dist/plugins/lumina/index.js",
+    "./utils/disable-rules": "./dist/utils/disable-rules.js",
     "./package.json": "./package.json"
   },
   "files": [
@@ -20,21 +20,21 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@eslint/js": "^9.39.1",
-    "@eslint/markdown": "^7.5.1",
+    "@eslint/js": "^10.0.1",
+    "@eslint/markdown": "^8.0.1",
     "@types/confusing-browser-globals": "^1.0.3",
-    "@typescript-eslint/utils": "^8.46.4",
+    "@typescript-eslint/utils": "^8.58.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint-plugin-package-json": "^0.88.1",
-    "eslint-plugin-storybook": "^0.12.0",
+    "eslint-plugin-package-json": "~0.91.1",
+    "eslint-plugin-storybook": "^10.3.4",
     "globals": "^16.5.0",
-    "jsonc-eslint-parser": "^2.0.0",
+    "jsonc-eslint-parser": "^3.1.0",
     "tslib": "^2.8.1",
-    "typescript": "~5.9.3",
-    "typescript-eslint": "^8.46.3",
-    "@arcgis/toolkit": "5.1.0-next.11"
+    "typescript": "~6.0.2",
+    "typescript-eslint": "^8.58.0",
+    "@arcgis/toolkit": "5.1.0-next.112"
   },
   "peerDependencies": {
-    "eslint": "^9.39.1"
+    "eslint": "^10.2.0"
   }
 }