@arcgis/eslint-config 4.34.0-next.4 → 4.34.0-next.40

package/dist/config/index.js

@@ -22,8 +22,7 @@ const defaultConfig = [
     languageOptions: {
       globals: {
         ...globals.browser,
-        ...globals.node,
-        ...globals.jest
+        ...globals.node
       },
       ecmaVersion: "latest",
       sourceType: "module"
@@ -539,7 +538,8 @@ const defaultConfig = [
       "@typescript-eslint/no-unsafe-enum-comparison": "off",
       // Developer may actually mean to use ||
       // Also, refactoring this out may break things
-      "@typescript-eslint/prefer-nullish-coalescing": "off"
+      "@typescript-eslint/prefer-nullish-coalescing": "off",
+      "@typescript-eslint/no-unnecessary-type-conversion": "warn"
       //#endregion
       // TODO: go over https://typescript-eslint.io/linting/troubleshooting/performance-troubleshooting
     }

package/dist/config/lumina.js

@@ -126,7 +126,7 @@ declare global {
             {
               group: ["/@lit/context"],
               importNames: ["ContextProvider", "ContextConsumer", "provide", "consume"],
-              message: `For lazy-loading compatibility, import the useContextProvider() and the useContextConsumer() controllers from @arcgis/lumina rather than directly calling the Lit's controllers/decorators.`,
+              message: `For lazy-loading compatibility, import the useContextProvider() and the useContextConsumer() controllers from @arcgis/lumina/context rather than directly calling the Lit's controllers/decorators. See https://qawebgis.esri.com/components/lumina/state-management#lit-context`,
               caseSensitive: true
             },
             {

package/dist/{makePlugin-Ca089k86.js → makePlugin-BWc0voYM.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "4.34.0-next.4";
+const version = "4.34.0-next.40";
 function makeEslintPlugin(pluginName, urlCreator) {
   const rules = [];
   const creator = ESLintUtils.RuleCreator(urlCreator);

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-Ca089k86.js";
+import { m as makeEslintPlugin } from "../../makePlugin-BWc0voYM.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import ts from "typescript";
 import { camelToKebab } from "@arcgis/components-utils";
@@ -1277,7 +1277,7 @@ plugin.createRule({
           return;
         }
         if (isCreateElementComponent(node)) {
-          return void context.report({
+          return context.report({
             node,
             messageId: "default"
           });

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-Ca089k86.js";
+import { m as makeEslintPlugin } from "../../makePlugin-BWc0voYM.js";
 import { resolve } from "node:path/posix";
 import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const plugin = makeEslintPlugin(
@@ -94,9 +94,10 @@ plugin.createRule({
   }
 });
 const reTouchingJsDoc = /\*\/\s+\/\*\*/gu;
-const description$1 = `@arcgis/core imports need to end with .js for better compatibility with @arcgis/core ESM CDN builds.`;
+const description$1 = `@arcgis/core imports need to end with .js for better compatibility with ESM CDN builds for @arcgis/core and other packages.`;
+const packagesToEnforce = ["@arcgis/core/", "@amcharts/amcharts4/", "@amcharts/amcharts5/"];
 plugin.createRule({
-  name: "require-js-in-core-import",
+  name: "require-js-in-imports",
   meta: {
     docs: {
       description: description$1,
@@ -119,7 +120,7 @@ plugin.createRule({
         return;
       }
       const specifier = node.source.value;
-      if (typeof specifier !== "string" || !specifier.startsWith("@arcgis/core/") || // Already ends with .js or .json
+      if (typeof specifier !== "string" || !packagesToEnforce.some((pkg) => specifier.startsWith(pkg)) || // Already ends with .js or .json
       specifier.includes(".")) {
         return;
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "4.34.0-next.4",
+  "version": "4.34.0-next.40",
   "description": "ESLint configuration for arcgis-web-components",
   "type": "module",
   "main": "index.js",
@@ -20,17 +20,17 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/components-utils": "4.34.0-next.4",
-    "@eslint/js": "^9.23.0",
+    "@arcgis/components-utils": "4.34.0-next.40",
+    "@eslint/js": "^9.29.0",
     "@types/confusing-browser-globals": "^1.0.3",
     "confusing-browser-globals": "^1.0.11",
     "eslint-plugin-storybook": "^0.12.0",
     "globals": "^15.12.0",
     "tslib": "^2.8.1",
     "typescript": "~5.8.3",
-    "typescript-eslint": "^8.28.0"
+    "typescript-eslint": "^8.35.0"
   },
   "peerDependencies": {
-    "eslint": "^9.23.0"
+    "eslint": "^9.29.0"
   }
 }