@arcgis/eslint-config 4.34.0-next.16 → 4.34.0-next.160

package/LICENSE.md

@@ -1,6 +1,6 @@
 # Licensing
 
-COPYRIGHT © 2025 Esri
+COPYRIGHT © Esri
 
 All rights reserved under the copyright laws of the United States and applicable international laws, treaties, and conventions.
 

package/README.md

@@ -8,14 +8,6 @@ It is not intended to be used directly, but rather used as a dependency by other
 
 ## License
 
-COPYRIGHT © 2025 Esri
+COPYRIGHT © Esri
 
-All rights reserved under the copyright laws of the United States and applicable international laws, treaties, and conventions.
-
-This material is licensed for use under the Esri Master License Agreement (MLA), and is bound by the terms of that agreement. You may redistribute and use this code without modification, provided you adhere to the terms of the MLA and include this copyright notice.
-
-See use restrictions at <http://www.esri.com/legal/pdfs/mla_e204_e300/english>
-
-For additional information, contact: Environmental Systems Research Institute, Inc. Attn: Contracts and Legal Services Department 380 New York Street Redlands, California, USA 92373 USA
-
-email: contracts@esri.com
+This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package.

package/dist/config/applications.d.ts

@@ -1,5 +1,35 @@
 import { TSESLint } from '@typescript-eslint/utils';
-declare const _default: (TSESLint.FlatConfig.Config | import("eslint").Linter.Config<import("eslint").Linter.RulesRecord> | {
-    readonly rules: Readonly<import("eslint").Linter.RulesRecord>;
+declare const _default: (import("eslint").Linter.Config<import("eslint").Linter.RulesRecord> | {
+    name: string;
+    files: string[];
+    language: string;
+    plugins: {};
+    rules: {
+        readonly "markdown/fenced-code-language": "error";
+        readonly "markdown/heading-increment": "error";
+        readonly "markdown/no-duplicate-definitions": "error";
+        readonly "markdown/no-empty-definitions": "error";
+        readonly "markdown/no-empty-images": "error";
+        readonly "markdown/no-empty-links": "error";
+        readonly "markdown/no-invalid-label-refs": "error";
+        readonly "markdown/no-missing-atx-heading-space": "error";
+        readonly "markdown/no-missing-label-refs": "error";
+        readonly "markdown/no-missing-link-fragments": "error";
+        readonly "markdown/no-multiple-h1": "error";
+        readonly "markdown/no-reversed-media-syntax": "error";
+        readonly "markdown/require-alt-text": "error";
+        readonly "markdown/table-column-count": "error";
+    };
+} | {
+    files: (string | string[])[];
+    ignores?: string[];
+    language?: string;
+    languageOptions?: TSESLint.FlatConfig.LanguageOptions;
+    linterOptions?: TSESLint.FlatConfig.LinterOptions;
+    name?: string;
+    plugins?: TSESLint.FlatConfig.Plugins;
+    processor?: string | TSESLint.FlatConfig.Processor;
+    rules?: TSESLint.FlatConfig.Rules;
+    settings?: TSESLint.FlatConfig.Settings;
 })[];
 export default _default;

package/dist/config/index.d.ts

@@ -1,5 +1,35 @@
 import { TSESLint } from '@typescript-eslint/utils';
-declare const _default: (TSESLint.FlatConfig.Config | import("eslint").Linter.Config<import("eslint").Linter.RulesRecord> | {
-    readonly rules: Readonly<import("eslint").Linter.RulesRecord>;
+declare const _default: (import("eslint").Linter.Config<import("eslint").Linter.RulesRecord> | {
+    name: string;
+    files: string[];
+    language: string;
+    plugins: {};
+    rules: {
+        readonly "markdown/fenced-code-language": "error";
+        readonly "markdown/heading-increment": "error";
+        readonly "markdown/no-duplicate-definitions": "error";
+        readonly "markdown/no-empty-definitions": "error";
+        readonly "markdown/no-empty-images": "error";
+        readonly "markdown/no-empty-links": "error";
+        readonly "markdown/no-invalid-label-refs": "error";
+        readonly "markdown/no-missing-atx-heading-space": "error";
+        readonly "markdown/no-missing-label-refs": "error";
+        readonly "markdown/no-missing-link-fragments": "error";
+        readonly "markdown/no-multiple-h1": "error";
+        readonly "markdown/no-reversed-media-syntax": "error";
+        readonly "markdown/require-alt-text": "error";
+        readonly "markdown/table-column-count": "error";
+    };
+} | {
+    files: (string | string[])[];
+    ignores?: string[];
+    language?: string;
+    languageOptions?: TSESLint.FlatConfig.LanguageOptions;
+    linterOptions?: TSESLint.FlatConfig.LinterOptions;
+    name?: string;
+    plugins?: TSESLint.FlatConfig.Plugins;
+    processor?: string | TSESLint.FlatConfig.Processor;
+    rules?: TSESLint.FlatConfig.Rules;
+    settings?: TSESLint.FlatConfig.Settings;
 })[];
 export default _default;

package/dist/config/index.js

@@ -4,11 +4,17 @@ import restrictedGlobals from "confusing-browser-globals";
 import globals from "globals";
 import { webgisPlugin } from "../plugins/webgis/index.js";
 import { globalIgnores } from "eslint/config";
+import markdown from "@eslint/markdown";
 const defaultConfig = [
   globalIgnores(["**/www", "**/dist", "**/assets", "**/coverage", "**/.docs"]),
-  eslint.configs.recommended,
-  ...tsEslint.configs.strictTypeChecked,
-  ...tsEslint.configs.stylisticTypeChecked,
+  {
+    files: ["**/*.js", "**/*.mjs", "**/*.cjs"],
+    ...eslint.configs.recommended
+  },
+  ...[...tsEslint.configs.strictTypeChecked, ...tsEslint.configs.stylisticTypeChecked].map((config) => ({
+    ...config,
+    files: ["**/*.ts", "**/*.tsx"]
+  })),
   {
     ...webgisPlugin.configs.recommended,
     files: ["**/*.ts", "**/*.tsx"]
@@ -22,8 +28,7 @@ const defaultConfig = [
     languageOptions: {
       globals: {
         ...globals.browser,
-        ...globals.node,
-        ...globals.jest
+        ...globals.node
       },
       ecmaVersion: "latest",
       sourceType: "module"
@@ -539,11 +544,28 @@ const defaultConfig = [
       "@typescript-eslint/no-unsafe-enum-comparison": "off",
       // Developer may actually mean to use ||
       // Also, refactoring this out may break things
-      "@typescript-eslint/prefer-nullish-coalescing": "off"
+      "@typescript-eslint/prefer-nullish-coalescing": "off",
+      "@typescript-eslint/no-unnecessary-type-conversion": "warn"
       //#endregion
       // TODO: go over https://typescript-eslint.io/linting/troubleshooting/performance-troubleshooting
     }
   },
+  ...markdown.configs.recommended,
+  {
+    files: ["**/*.md"],
+    language: "markdown/gfm",
+    languageOptions: {
+      frontmatter: "yaml"
+    },
+    rules: {
+      // we don't really use label refs and currently this rule does errors on GFM alerts.
+      // https://github.com/eslint/markdown/issues/294
+      "markdown/no-missing-label-refs": ["off"],
+      // We allow frontmatter titles to be different from the h1 by setting to "" which never matches
+      // This is useful to have a shorter title in the TOC than on the page.
+      "markdown/no-multiple-h1": ["error", { frontmatterTitle: "" }]
+    }
+  },
   {
     // Don't do type-aware linting for untyped files
     files: ["**/*.js"],

package/dist/config/lumina.js

@@ -126,7 +126,7 @@ declare global {
             {
               group: ["/@lit/context"],
               importNames: ["ContextProvider", "ContextConsumer", "provide", "consume"],
-              message: `For lazy-loading compatibility, import the useContextProvider() and the useContextConsumer() controllers from @arcgis/lumina rather than directly calling the Lit's controllers/decorators.`,
+              message: `For lazy-loading compatibility, import the useContextProvider() and the useContextConsumer() controllers from @arcgis/lumina/context rather than directly calling the Lit's controllers/decorators. See https://qawebgis.esri.com/components/lumina/state-management#lit-context`,
               caseSensitive: true
             },
             {

package/dist/{makePlugin-aauNgjXD.js → makePlugin-C-toyvI0.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "4.34.0-next.16";
+const version = "4.34.0-next.160";
 function makeEslintPlugin(pluginName, urlCreator) {
   const rules = [];
   const creator = ESLintUtils.RuleCreator(urlCreator);

package/dist/plugins/lumina/index.js

@@ -1,7 +1,7 @@
-import { m as makeEslintPlugin } from "../../makePlugin-aauNgjXD.js";
+import { m as makeEslintPlugin } from "../../makePlugin-C-toyvI0.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import ts from "typescript";
-import { camelToKebab } from "@arcgis/components-utils";
+import { camelToKebab } from "@arcgis/toolkit/string";
 const plugin = makeEslintPlugin(
   "lumina",
   (rule) => `https://devtopia.esri.com/WebGIS/arcgis-web-components/tree/main/packages/support-packages/eslint-config/src/plugins/lumina/rules/${rule}.ts`
@@ -1131,12 +1131,12 @@ ${newBodyContent}
 }`;
   return newBody;
 }
-const baseDescription$3 = `Consistently sort component members`;
+const baseDescription$2 = `Consistently sort component members`;
 plugin.createRule({
   name: "member-ordering",
   meta: {
     docs: {
-      description: baseDescription$3,
+      description: baseDescription$2,
       defaultLevel: "warn"
     },
     messages: {
@@ -1277,7 +1277,7 @@ plugin.createRule({
           return;
         }
         if (isCreateElementComponent(node)) {
-          return void context.report({
+          return context.report({
             node,
             messageId: "default"
           });
@@ -1385,16 +1385,15 @@ plugin.createRule({
     };
   }
 });
-const baseDescription$2 = `Do not pass an inline arrow function to a ref prop - such syntax creates a new function on each render, which makes Lit call ref callback again on each render.`;
-const description$b = `${baseDescription$2}
+const description$b = `If inline arrow function is passed to ref, it will be called again on each render.
 
-Alternatives: https://qawebgis.esri.com/components/lumina/jsx#refs`;
+If this is not desirable, see alternatives: https://qawebgis.esri.com/components/lumina/jsx#refs`;
 plugin.createRule({
   name: "no-inline-arrow-in-ref",
   meta: {
     docs: {
-      description: baseDescription$2,
-      defaultLevel: "error"
+      description: description$b,
+      defaultLevel: "warn"
     },
     messages: {
       errorInlineArrow: description$b

package/dist/plugins/webgis/index.js

@@ -1,5 +1,5 @@
-import { m as makeEslintPlugin } from "../../makePlugin-aauNgjXD.js";
-import { resolve } from "node:path/posix";
+import { m as makeEslintPlugin } from "../../makePlugin-C-toyvI0.js";
+import { resolve } from "path/posix";
 import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const plugin = makeEslintPlugin(
   "webgis",
@@ -120,8 +120,10 @@ plugin.createRule({
         return;
       }
       const specifier = node.source.value;
+      const lastSlashIndex = specifier?.toString().lastIndexOf("/") ?? 0;
+      const dotSearchIndex = lastSlashIndex === -1 ? 0 : lastSlashIndex + 1;
       if (typeof specifier !== "string" || !packagesToEnforce.some((pkg) => specifier.startsWith(pkg)) || // Already ends with .js or .json
-      specifier.includes(".")) {
+      specifier.includes(".", dotSearchIndex)) {
         return;
       }
       context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "4.34.0-next.16",
+  "version": "4.34.0-next.160",
   "description": "ESLint configuration for arcgis-web-components",
   "type": "module",
   "main": "index.js",
@@ -20,17 +20,18 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/components-utils": "4.34.0-next.16",
-    "@eslint/js": "^9.23.0",
+    "@arcgis/toolkit": "4.34.0-next.160",
+    "@eslint/js": "^9.29.0",
+    "@eslint/markdown": "^6.6.0",
     "@types/confusing-browser-globals": "^1.0.3",
     "confusing-browser-globals": "^1.0.11",
     "eslint-plugin-storybook": "^0.12.0",
-    "globals": "^15.12.0",
+    "globals": "^16.3.0",
     "tslib": "^2.8.1",
     "typescript": "~5.8.3",
-    "typescript-eslint": "^8.28.0"
+    "typescript-eslint": "^8.35.0"
   },
   "peerDependencies": {
-    "eslint": "^9.23.0"
+    "eslint": "^9.29.0"
   }
 }