@arcgis/eslint-config 4.33.0-next.97 → 4.33.0-next.99

package/dist/{makePlugin-B-FfUnYf.js → makePlugin-DjYsAJ7j.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "4.33.0-next.97";
+const version = "4.33.0-next.99";
 function makeEslintPlugin(pluginName, urlCreator) {
   const rules = [];
   const creator = ESLintUtils.RuleCreator(urlCreator);

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-B-FfUnYf.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DjYsAJ7j.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import ts from "typescript";
 import { camelToKebab } from "@arcgis/components-utils";

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-B-FfUnYf.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DjYsAJ7j.js";
 import { resolve } from "node:path/posix";
 import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const plugin = makeEslintPlugin(
@@ -6,16 +6,16 @@ const plugin = makeEslintPlugin(
   (rule) => `https://devtopia.esri.com/WebGIS/arcgis-web-components/tree/main/packages/support-packages/eslint-config/src/plugins/webgis/rules/${rule}.ts`
 );
 const isTestFile = (filePath) => filePath.includes("/test") || filePath.includes(".test") || filePath.includes(".spec") || filePath.includes("e2e") || filePath.includes("__") || filePath.includes("/.");
-const description$2 = `Imports of files outside the src/ folder are not-portable and likely to break for consumers of this package.`;
+const description$3 = `Imports of files outside the src/ folder are not-portable and likely to break for consumers of this package.`;
 plugin.createRule({
   name: "no-import-outside-src",
   meta: {
     docs: {
-      description: description$2,
+      description: description$3,
       defaultLevel: "error"
     },
     messages: {
-      noImportOutsideSrc: description$2
+      noImportOutsideSrc: description$3
     },
     type: "problem",
     schema: []
@@ -49,16 +49,16 @@ plugin.createRule({
     };
   }
 });
-const description$1 = `Having two JSDoc comments next to each other is most likely a mistake - consider combining them into one, or separating them for clarity.`;
+const description$2 = `Having two JSDoc comments next to each other is most likely a mistake - consider combining them into one, or separating them for clarity.`;
 plugin.createRule({
   name: "no-touching-jsdoc",
   meta: {
     docs: {
-      description: description$1,
+      description: description$2,
       defaultLevel: "warn"
     },
     messages: {
-      noTouchingJsDoc: description$1
+      noTouchingJsDoc: description$2
     },
     type: "problem",
     schema: []
@@ -94,16 +94,16 @@ plugin.createRule({
   }
 });
 const reTouchingJsDoc = /\*\/\s+\/\*\*/gu;
-const description = `@arcgis/core imports need to end with .js for better compatibility with @arcgis/core ESM CDN builds.`;
+const description$1 = `@arcgis/core imports need to end with .js for better compatibility with @arcgis/core ESM CDN builds.`;
 plugin.createRule({
   name: "require-js-in-core-import",
   meta: {
     docs: {
-      description,
+      description: description$1,
       defaultLevel: "warn"
     },
     messages: {
-      requireJsInCoreImport: description
+      requireJsInCoreImport: description$1
     },
     type: "problem",
     fixable: "code",
@@ -135,6 +135,46 @@ plugin.createRule({
     };
   }
 });
+const description = "Using .d.ts files is discouraged. Prefer .ts files instead, as they are type-checked and not in global scope.";
+const allowedNames = /* @__PURE__ */ new Set(["vite-env.d.ts", "component.d.ts"]);
+plugin.createRule({
+  name: "no-dts-files",
+  meta: {
+    docs: {
+      description,
+      defaultLevel: "warn"
+    },
+    messages: {
+      avoidDtsFiles: description
+    },
+    type: "suggestion",
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    if (!context.filename.endsWith(".d.ts")) {
+      return {};
+    }
+    if (isTestFile(context.filename)) {
+      return {};
+    }
+    const lastSegment = context.filename.split("/").pop();
+    if (lastSegment !== void 0 && allowedNames.has(lastSegment)) {
+      return {};
+    }
+    if (context.sourceCode.text.includes("\ndeclare ") || context.sourceCode.text.startsWith("declare ") || context.sourceCode.text.includes("export declare ") || context.sourceCode.text.includes("/// <reference")) {
+      return {};
+    }
+    return {
+      Program(node) {
+        context.report({
+          node,
+          messageId: "avoidDtsFiles"
+        });
+      }
+    };
+  }
+});
 const webgisPlugin = plugin.finalize();
 export {
   webgisPlugin

package/dist/plugins/webgis/rules/no-dts-files.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import('@typescript-eslint/utils/ts-eslint').RuleModule<"avoidDtsFiles", [], import('../../utils/makePlugin').CommonDocs, import('@typescript-eslint/utils/ts-eslint').RuleListener>;
+export default _default;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "4.33.0-next.97",
+  "version": "4.33.0-next.99",
   "description": "ESLint configuration for arcgis-web-components",
   "type": "module",
   "main": "index.js",
@@ -19,7 +19,7 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/components-utils": "4.33.0-next.97",
+    "@arcgis/components-utils": "4.33.0-next.99",
     "@eslint/js": "^9.17.0",
     "@types/confusing-browser-globals": "^1.0.3",
     "confusing-browser-globals": "^1.0.11",