@arcgis/eslint-config 4.32.0-next.75 → 4.32.0-next.76

package/dist/{chunk-7G6OXZK7.js → chunk-CXLY7EQM.js}

@@ -1,5 +1,5 @@
 // package.json
-var version = "4.32.0-next.75";
+var version = "4.32.0-next.76";
 
 // src/plugins/utils/makePlugin.ts
 function makeEslintPlugin(pluginName, rules) {

package/dist/{chunk-2NFXJSOF.js → chunk-PXSYKWKU.js}

@@ -1,6 +1,6 @@
 import {
   makeEslintPlugin
-} from "./chunk-7G6OXZK7.js";
+} from "./chunk-CXLY7EQM.js";
 
 // src/plugins/lumina/rules/add-missing-jsx-import.ts
 import { AST_NODE_TYPES as AST_NODE_TYPES2 } from "@typescript-eslint/utils";

package/dist/{chunk-LVYAWX7T.js → chunk-Y7ZXXVWO.js}

@@ -1,6 +1,6 @@
 import {
   makeEslintPlugin
-} from "./chunk-7G6OXZK7.js";
+} from "./chunk-CXLY7EQM.js";
 
 // src/plugins/webgis/utils/creator.ts
 import { ESLintUtils } from "@typescript-eslint/utils";

package/dist/config/index.js

@@ -3,8 +3,8 @@ import {
 } from "../chunk-WAWBOPY7.js";
 import {
   webgis_default
-} from "../chunk-LVYAWX7T.js";
-import "../chunk-7G6OXZK7.js";
+} from "../chunk-Y7ZXXVWO.js";
+import "../chunk-CXLY7EQM.js";
 
 // src/config/index.ts
 import eslint from "@eslint/js";
@@ -37,13 +37,13 @@ var config_default = [
       sourceType: "module"
     },
     rules: {
+      //#region Disable rules redundant with Typescript
       /**
-       *
        * The following rules are disabled because they are redundant with
        * TypeScript. No need to needlessly slow down ESLint and clutter the
        * error messages.
-       *
        */
+      // TypeScript reports this
       "no-unused-labels": "off",
       "@typescript-eslint/no-unused-vars": [
         "off",
@@ -59,27 +59,58 @@ var config_default = [
       ],
       // Redundant with TypeScript, but has autofix, so enabled for convenience
       "no-unsafe-negation": "warn",
+      // TypeScript reports this
       "no-unused-private-class-members": "off",
+      // TypeScript detects re-declarations like this
+      "no-case-declarations": "off",
+      // Narrow use case. Even less with TypeScript
+      "no-ex-assign": "off",
+      // Redundant with no-restricted-globals and with TypeScript
+      "no-global-assign": "off",
+      // Redundant with prefer-regex-literals, which enforces regex literal
+      // syntax, which is checked by TypeScript
+      "no-invalid-regexp": "off",
+      // TypeScript reports this as syntax error
+      "no-nonoctal-decimal-escape": "off",
+      // TypeScript reports this as syntax error
+      "no-octal": "off",
+      // TypeScript reports this as type error
+      "no-unsafe-optional-chaining": "off",
+      // TypeScript emits an error for with() statements
+      "no-with": "off",
+      // TypeScript reports this as a type error
+      "valid-typeof": "off",
+      // TypeScript reports this
+      "@typescript-eslint/prefer-namespace-keyword": "off",
+      //#endregion
+      //#region Disable rules Redundant with Prettier
       /**
-       *
        * The following rules are redundant with Prettier
-       *
        */
       "no-unexpected-multiline": "off",
+      // Outside of comments, this is redundant with Prettier.
+      // In comments, it is not an issue since comments are stripped in minified
+      // builds
+      "no-irregular-whitespace": "off",
+      //#endregion
+      //#region Disable obsolete rules
       /**
-       *
        * Obsolete rules (rules that enforced constraints that are no longer
        * present in the language, or that are no longer relevant)
-       *
        */
       // Namespaces are needed for defining custom elements
       "@typescript-eslint/no-namespace": "off",
       // A lot of false positives when dealing with Arcade
       "no-template-curly-in-string": "off",
+      // We don't use TSLint
+      "@typescript-eslint/ban-tslint-comment": "off",
+      //#endregion
+      //#region Disable rules that were moved to extra config
       /**
        *
        * The following default rules are disabled in favor of moving them into the
-       * @arcgis/eslint-config/extra due to huge number of false positives
+       * @arcgis/eslint-config/extra due to huge number of false positives or
+       * performance issues.
        *
        */
       // Disabled as per https://devtopia.esri.com/WebGIS/arcgis-web-components/discussions/446#discussioncomment-3166
@@ -95,6 +126,8 @@ var config_default = [
        * type
        */
       "@typescript-eslint/no-useless-constructor": "off",
+      //#endregion
+      //#region Detect possible bugs
       /**
        *
        * The following rules report what is a possible bug. If you are sure that the
@@ -114,11 +147,8 @@ var config_default = [
       // with TypeScript in some cases, but it provides a less-confusing error
       // message (for example in .reduce())
       "array-callback-return": "warn",
-      "no-unsafe-optional-chaining": ["error", { disallowArithmeticOperators: true }],
-      "no-div-regex": "error",
       // Good rule to have, but many false positives, so only a warning
       "require-atomic-updates": "warn",
-      "func-name-matching": ["warn", { considerPropertyDescriptor: true }],
       "grouped-accessor-pairs": "error",
       "no-extra-bind": "warn",
       "no-multi-assign": "error",
@@ -235,8 +265,6 @@ var config_default = [
       // "no-console": 'error',
       "no-eval": "error",
       "no-extend-native": "error",
-      "no-iterator": "error",
-      "no-proto": "error",
       "@typescript-eslint/no-restricted-imports": [
         "error",
         {
@@ -263,6 +291,9 @@ var config_default = [
           ignoreVoidOperator: true
         }
       ],
+      // Conflicts with @typescript-eslint/no-confusing-void-expression
+      // See https://github.com/typescript-eslint/typescript-eslint/issues/4507
+      "@typescript-eslint/no-meaningless-void-operator": "off",
       "@typescript-eslint/no-empty-function": [
         // There can be use cases for this (when providing a callback is required
         // but you don't want to do anything)
@@ -277,12 +308,18 @@ var config_default = [
       "func-style": ["error", "declaration", { allowArrowFunctions: true }],
       "no-new-func": "error",
       "no-new-wrappers": "error",
-      "no-octal-escape": "error",
+      "@typescript-eslint/no-misused-promises": [
+        "warn",
+        {
+          // Redundant with TypeScript
+          checksSpreads: false
+        }
+      ],
+      //#endregion
+      //#region Report consistency issues
       // TODO: make these more or less strict as needed
       /**
-       *
        * Consistency and clean code rules
-       *
        */
       "arrow-body-style": "warn",
       // This rule is a good idea, but not autofixable, so is only a warning
@@ -444,7 +481,8 @@ var config_default = [
       "@typescript-eslint/consistent-type-exports": ["warn", { fixMixedExportsWithInlineTypeSpecifier: true }],
       "@typescript-eslint/consistent-type-imports": "warn",
       "default-param-last": "off",
-      "@typescript-eslint/default-param-last": "warn",
+      // `undefined` can also be used to trigger default value
+      "@typescript-eslint/default-param-last": "off",
       "@typescript-eslint/explicit-function-return-type": [
         // Providing explicit type improves type-checking performance and
         // catches bugs (when actual return type is not what you are expecting,
@@ -459,9 +497,9 @@ var config_default = [
       ],
       "max-params": "off",
       // Two spaces is more readable than " {2}"
-      "no-regex-spaces": ["off"],
-      "prefer-const": ["warn"],
-      "no-var": ["warn"],
+      "no-regex-spaces": "off",
+      "prefer-const": "warn",
+      "no-var": "error",
       // Prefer passing parameters as an object instead to be less error prone
       // and make adding/removing properties require less refactoring
       "@typescript-eslint/max-params": ["warn", { max: 5 }],
@@ -471,7 +509,6 @@ var config_default = [
       "@typescript-eslint/non-nullable-type-assertion-style": ["warn"],
       "@typescript-eslint/dot-notation": "warn",
       "@typescript-eslint/prefer-function-type": ["warn"],
-      "@typescript-eslint/prefer-namespace-keyword": ["warn"],
       "@typescript-eslint/prefer-optional-chain": ["warn"],
       "@typescript-eslint/prefer-string-starts-ends-with": ["warn"],
       "@typescript-eslint/no-array-constructor": ["warn"],
@@ -574,6 +611,7 @@ var config_default = [
       // reports when component tries to emit an event that is marked as
       // deprecated.
       "@typescript-eslint/no-deprecated": "warn"
+      //#endregion
       // TODO: go over https://typescript-eslint.io/linting/troubleshooting/performance-troubleshooting
     }
   },

package/dist/config/lumina.js

@@ -3,8 +3,8 @@ import {
 } from "../chunk-WAWBOPY7.js";
 import {
   lumina_default
-} from "../chunk-2NFXJSOF.js";
-import "../chunk-7G6OXZK7.js";
+} from "../chunk-PXSYKWKU.js";
+import "../chunk-CXLY7EQM.js";
 
 // src/config/storybook.ts
 import eslintPluginStorybook from "eslint-plugin-storybook";
@@ -12,9 +12,18 @@ var storybookConfig = [
   {
     ignores: ["**/storybook-static*"]
   },
-  ...eslintPluginStorybook.configs["flat/recommended"],
-  ...eslintPluginStorybook.configs["flat/addon-interactions"],
-  ...eslintPluginStorybook.configs["flat/csf-strict"],
+  ...eslintPluginStorybook.configs["flat/recommended"].map((config) => ({
+    ...config,
+    files: ["**/*.stories.@(ts|tsx)"]
+  })),
+  ...eslintPluginStorybook.configs["flat/addon-interactions"].map((config) => ({
+    ...config,
+    files: ["**/*.stories.@(ts|tsx)"]
+  })),
+  ...eslintPluginStorybook.configs["flat/csf-strict"].map((config) => ({
+    ...config,
+    files: ["**/*.stories.@(ts|tsx)"]
+  })),
   {
     files: ["**/*.stories.@(ts|tsx)"],
     rules: {
@@ -22,14 +31,16 @@ var storybookConfig = [
       "storybook/await-interactions": "off",
       // Not applicable in our web-component setup
       "storybook/csf-component": "off",
-      // We don't have deprecated usages
+      // This rule is for detecting usages of deprecated feature that we don't use
       "storybook/hierarchy-separator": "off",
       // Not applicable in our web-component setup
       "storybook/no-title-property-in-meta": "off",
       // Not applicable as we have a central Storybook config (@arcgis/storybook-utils)
       "storybook/no-uninstalled-addons": "off",
       // We never used storiesOf, and it's no longer included in Storybook
-      "storybook/no-stories-of": "off"
+      "storybook/no-stories-of": "off",
+      // Redundant with TypeScript
+      "storybook/context-in-play-function": "off"
     }
   }
 ];

package/dist/plugins/lumina/index.js

@@ -1,7 +1,7 @@
 import {
   lumina_default
-} from "../../chunk-2NFXJSOF.js";
-import "../../chunk-7G6OXZK7.js";
+} from "../../chunk-PXSYKWKU.js";
+import "../../chunk-CXLY7EQM.js";
 export {
   lumina_default as default
 };

package/dist/plugins/webgis/index.js

@@ -1,7 +1,7 @@
 import {
   webgis_default
-} from "../../chunk-LVYAWX7T.js";
-import "../../chunk-7G6OXZK7.js";
+} from "../../chunk-Y7ZXXVWO.js";
+import "../../chunk-CXLY7EQM.js";
 export {
   webgis_default as default
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "4.32.0-next.75",
+  "version": "4.32.0-next.76",
   "description": "ESLint configuration for arcgis-web-components",
   "type": "module",
   "main": "index.js",
@@ -20,7 +20,7 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/components-utils": "4.32.0-next.75",
+    "@arcgis/components-utils": "4.32.0-next.76",
     "@eslint/js": "^9.17.0",
     "@types/confusing-browser-globals": "^1.0.3",
     "confusing-browser-globals": "^1.0.11",