@arcgis/components-build-utils 4.34.0-next.126 → 4.34.0-next.127

package/dist/index.cjs

@@ -3,10 +3,10 @@ Object.defineProperty(exports, Symbol.toStringTag, { value: "Module" });
 const node_fs = require("node:fs");
 const promises = require("node:fs/promises");
 const node_child_process = require("node:child_process");
-const node_path = require("node:path");
+const path$1 = require("path");
 const node_url = require("node:url");
-const posix = require("node:path/posix");
-const win32 = require("node:path/win32");
+const posix = require("path/posix");
+const win32 = require("path/win32");
 const dts = require("vite-plugin-dts");
 const node_module = require("node:module");
 const existsAsync = async (file) => (
@@ -16,17 +16,17 @@ const existsAsync = async (file) => (
 );
 const sh = (command, cwd) => node_child_process.execSync(command.trim(), { encoding: "utf8", cwd }).trim();
 async function createFileIfNotExists(filePath, content) {
-  await promises.mkdir(node_path.dirname(filePath), { recursive: true });
+  await promises.mkdir(path$1.dirname(filePath), { recursive: true });
   if (!await existsAsync(filePath)) {
     await promises.writeFile(filePath, content, { encoding: "utf8" });
   }
 }
 function findPath(target, startDirectory = process.cwd()) {
-  const resolvedStartDirectory = startDirectory.startsWith("file:///") ? node_path.dirname(node_url.fileURLToPath(startDirectory)) : node_path.resolve(startDirectory);
-  const parentPath = resolvedStartDirectory.split(node_path.sep);
+  const resolvedStartDirectory = startDirectory.startsWith("file:///") ? path$1.dirname(node_url.fileURLToPath(startDirectory)) : path$1.resolve(startDirectory);
+  const parentPath = resolvedStartDirectory.split(path$1.sep);
   while (parentPath.length > 2) {
-    const fullPath = node_path.join(
-      ...node_path.sep === "/" ? ["/"] : [],
+    const fullPath = path$1.join(
+      ...path$1.sep === "/" ? ["/"] : [],
       ...parentPath,
       target
     );
@@ -38,11 +38,11 @@ function findPath(target, startDirectory = process.cwd()) {
   return void 0;
 }
 async function asyncFindPath(target, startDirectory = process.cwd()) {
-  const resolvedStartDirectory = startDirectory.startsWith("file:///") ? node_path.dirname(node_url.fileURLToPath(startDirectory)) : node_path.resolve(startDirectory);
-  const parentPath = resolvedStartDirectory.split(node_path.sep);
+  const resolvedStartDirectory = startDirectory.startsWith("file:///") ? path$1.dirname(node_url.fileURLToPath(startDirectory)) : path$1.resolve(startDirectory);
+  const parentPath = resolvedStartDirectory.split(path$1.sep);
   while (parentPath.length > 2) {
-    const fullPath = node_path.join(
-      ...node_path.sep === "/" ? ["/"] : [],
+    const fullPath = path$1.join(
+      ...path$1.sep === "/" ? ["/"] : [],
       ...parentPath,
       target
     );
@@ -73,7 +73,7 @@ function fixMatchFilesSyntax(pattern) {
   }
   return pattern.endsWith("/*") ? `${pattern}*` : pattern.endsWith("/") ? `${pattern}**` : `${pattern}/**`;
 }
-const isPosix = node_path.sep === posix.sep;
+const isPosix = path$1.sep === posix.sep;
 const toPosixPathSeparators = (relativePath) => relativePath.includes(win32.sep) ? relativePath.replaceAll(win32.sep, posix.sep) : relativePath;
 const normalizePath = isPosix ? (path2) => path2 : toPosixPathSeparators;
 const toWin32PathSeparators = (relativePath) => relativePath.includes(posix.sep) ? relativePath.replaceAll(posix.sep, win32.sep) : relativePath;
@@ -266,34 +266,34 @@ function externalizeDependencies(options) {
     ...packageJson.peerDependencies,
     ...packageJson.optionalDependencies
   });
-  const bundleIn = options.bundleIn?.map(stringToStartsWithGlob) ?? [];
+  const bundleIn = options.bundleIn?.map(stringToStartsWithGlob);
   const externalize = [
     ...options.externalize?.map(stringToStartsWithGlob) ?? [],
-    ...externalDependencies.length > 0 ? [new RegExp(`^(?:${externalDependencies.join("|")})(?:/.+)?$`, "u")] : []
+    /^node:/u,
+    new RegExp(
+      `^(?:${externalDependencies.join("|")}${externalDependencies.length === 0 ? "" : "|"}${node_module.builtinModules.join("|")})(?:/.+)?$`,
+      "u"
+    )
   ];
-  const isExternalized = (id) => externalize.some((regex) => regex.test(id));
-  const isBundledIn = (id) => bundleIn.some((regex) => regex.test(id));
   const plugin = {
     name: "@arcgis/components-build-utils:externalize-dependencies",
     apply: "build",
     enforce: "pre",
-    resolveId(specifier, _, { isEntry }) {
-      if (
-        // Ignore entry points
-        isEntry || // Ignore virtual modules
-        specifier.startsWith("\0") || // Ignore relative
-        specifier.startsWith(".") || path.isAbsolute(specifier)
-      ) {
-        return null;
-      }
-      if (node_module.isBuiltin(specifier)) {
-        return {
-          id: specifier.startsWith("node:") ? specifier : `node:${specifier}`,
-          external: true,
-          moduleSideEffects: false
-        };
+    // Rolldown also has "external" option, which can be provided regexes.
+    // Theoretically that would be more efficient due to less communication
+    // overhead, but in practice they always evaluate it on the JS side:
+    // https://github.com/rolldown/rolldown/blob/4f996e637732a26ca04972975884abad5183292b/packages/rolldown/src/utils/bindingify-input-options.ts#L167
+    // https://github.com/rolldown/rolldown/blob/4f996e637732a26ca04972975884abad5183292b/crates/rolldown_binding/src/utils/normalize_binding_options.rs#L130
+    resolveId: {
+      filter: {
+        id: {
+          include: externalize,
+          exclude: bundleIn
+        }
+      },
+      handler() {
+        return false;
       }
-      return isExternalized(specifier) && !isBundledIn(specifier) ? false : null;
     }
   };
   return plugin;
@@ -315,7 +315,6 @@ exports.normalizePath = normalizePath;
 exports.path = path;
 exports.retrievePackageJson = retrievePackageJson;
 exports.sh = sh;
-exports.stringToStartsWithGlob = stringToStartsWithGlob;
 exports.toPosixPathSeparators = toPosixPathSeparators;
 exports.toSystemPathSeparators = toSystemPathSeparators;
 exports.vitePresetPlugin = vitePresetPlugin;

package/dist/index.d.cts

@@ -2,4 +2,4 @@ export * from './file';
 export * from './glob';
 export * from './path';
 export * from './packageJson';
-export * from './vite';
+export { vitePresetPlugin, type DependencyManagementOptions, externalizeDependencies } from './vite';

package/dist/index.d.ts

@@ -2,4 +2,4 @@ export * from './file';
 export * from './glob';
 export * from './path';
 export * from './packageJson';
-export * from './vite';
+export { vitePresetPlugin, type DependencyManagementOptions, externalizeDependencies } from './vite';

package/dist/index.js

@@ -1,12 +1,12 @@
 import { access, existsSync, readFileSync } from "node:fs";
 import { constants, mkdir, writeFile, readFile } from "node:fs/promises";
 import { execSync } from "node:child_process";
-import { dirname, resolve, sep, join } from "node:path";
+import { dirname, resolve, sep, join } from "path";
 import { fileURLToPath } from "node:url";
-import posix from "node:path/posix";
-import win32 from "node:path/win32";
+import posix from "path/posix";
+import win32 from "path/win32";
 import dts from "vite-plugin-dts";
-import { isBuiltin } from "node:module";
+import { builtinModules } from "node:module";
 const existsAsync = async (file) => (
   // Using un-promisified version because promises version creates exceptions
   // which interferes with debugging when "Pause on caught exceptions" is enabled
@@ -264,34 +264,34 @@ function externalizeDependencies(options) {
     ...packageJson.peerDependencies,
     ...packageJson.optionalDependencies
   });
-  const bundleIn = options.bundleIn?.map(stringToStartsWithGlob) ?? [];
+  const bundleIn = options.bundleIn?.map(stringToStartsWithGlob);
   const externalize = [
     ...options.externalize?.map(stringToStartsWithGlob) ?? [],
-    ...externalDependencies.length > 0 ? [new RegExp(`^(?:${externalDependencies.join("|")})(?:/.+)?$`, "u")] : []
+    /^node:/u,
+    new RegExp(
+      `^(?:${externalDependencies.join("|")}${externalDependencies.length === 0 ? "" : "|"}${builtinModules.join("|")})(?:/.+)?$`,
+      "u"
+    )
   ];
-  const isExternalized = (id) => externalize.some((regex) => regex.test(id));
-  const isBundledIn = (id) => bundleIn.some((regex) => regex.test(id));
   const plugin = {
     name: "@arcgis/components-build-utils:externalize-dependencies",
     apply: "build",
     enforce: "pre",
-    resolveId(specifier, _, { isEntry }) {
-      if (
-        // Ignore entry points
-        isEntry || // Ignore virtual modules
-        specifier.startsWith("\0") || // Ignore relative
-        specifier.startsWith(".") || path.isAbsolute(specifier)
-      ) {
-        return null;
-      }
-      if (isBuiltin(specifier)) {
-        return {
-          id: specifier.startsWith("node:") ? specifier : `node:${specifier}`,
-          external: true,
-          moduleSideEffects: false
-        };
+    // Rolldown also has "external" option, which can be provided regexes.
+    // Theoretically that would be more efficient due to less communication
+    // overhead, but in practice they always evaluate it on the JS side:
+    // https://github.com/rolldown/rolldown/blob/4f996e637732a26ca04972975884abad5183292b/packages/rolldown/src/utils/bindingify-input-options.ts#L167
+    // https://github.com/rolldown/rolldown/blob/4f996e637732a26ca04972975884abad5183292b/crates/rolldown_binding/src/utils/normalize_binding_options.rs#L130
+    resolveId: {
+      filter: {
+        id: {
+          include: externalize,
+          exclude: bundleIn
+        }
+      },
+      handler() {
+        return false;
       }
-      return isExternalized(specifier) && !isBundledIn(specifier) ? false : null;
     }
   };
   return plugin;
@@ -314,7 +314,6 @@ export {
   path,
   retrievePackageJson,
   sh,
-  stringToStartsWithGlob,
   toPosixPathSeparators,
   toSystemPathSeparators,
   vitePresetPlugin

package/dist/vite.d.cts

@@ -78,3 +78,6 @@ export declare function externalizeDependencies(options: DependencyManagementOpt
  * "monaco-editor/sub-path", but not "monaco-editor-beta".
  */
 export declare const stringToStartsWithGlob: (option: RegExp | string) => RegExp;
+export declare const exportsForTests: {
+    stringToStartsWithGlob: (option: RegExp | string) => RegExp;
+};

package/dist/vite.d.ts

@@ -78,3 +78,6 @@ export declare function externalizeDependencies(options: DependencyManagementOpt
  * "monaco-editor/sub-path", but not "monaco-editor-beta".
  */
 export declare const stringToStartsWithGlob: (option: RegExp | string) => RegExp;
+export declare const exportsForTests: {
+    stringToStartsWithGlob: (option: RegExp | string) => RegExp;
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/components-build-utils",
-  "version": "4.34.0-next.126",
+  "version": "4.34.0-next.127",
   "description": "Collection of common internal build-time patterns and utilities for ArcGIS Maps SDK for JavaScript components.",
   "homepage": "https://developers.arcgis.com/javascript/latest/",
   "type": "module",