@arcgis/codemod 5.2.0-next.9 → 5.2.0-next.91

package/LICENSE.md

@@ -1,12 +1,14 @@
 # Licensing
 
-COPYRIGHT © Esri
+COPYRIGHT Esri
 
 All rights reserved under the copyright laws of the United States and applicable international laws, treaties, and conventions.
 
-This material is licensed for use under the [Esri Master License Agreement (MLA)](https://www.esri.com/content/dam/esrisites/en-us/media/legal/ma-full/ma-full.pdf), and is bound by the terms of that agreement.
+This material is licensed for use under the Esri Master License Agreement (MLA), and is bound by the terms of that agreement.
 You may redistribute and use this code without modification, provided you adhere to the terms of the MLA and include this copyright notice.
 
+See use restrictions at https://www.esri.com/content/dam/esrisites/en-us/media/legal/ma-full/ma-full.pdf.
+
 For additional information, contact:
 Environmental Systems Research Institute, Inc.
 Attn: Contracts and Legal Services Department

package/README.md

@@ -8,6 +8,7 @@ This package provides automated refactors to help migrate away from deprecated o
 
 - Automated refactor to remove `__esri` namespace usage
 - Converts global namespace types to explicit `@arcgis/core` imports
+- Normalizes legacy Calcite icon names
 - Detects edge cases and warns when changes can’t be safely automated
 - Respects `.gitignore` by default
 
@@ -17,9 +18,18 @@ This package provides automated refactors to help migrate away from deprecated o
 - A project using the ArcGIS Maps SDK for JavaScript
 - This codemod operates exclusively on TypeScript files. Do not need to run this tool, if the project does not use TypeScript.
 
+## Before you begin
+
+If your project uses **ESLint, Prettier, or other formatters/linters**, run them after the codemod to ensure consistent formatting.
+
+> [!Note]
+> This codemod modifies files in place and does not provide an interactive dry-run mode. We recommend running it in a project that is under version control (Git) so you can review changes using `git diff` or your IDE’s diff tools. If your project is not under version control, create a backup before running the codemod.
+
 ## Usage
 
-The codemod replaces `__esri` types with explicit imports from @arcgis/core.
+### Refactor out the `__esri` namespace
+
+The `refactor-out-esri-namespace` codemod replaces `__esri` types with explicit imports from `@arcgis/core`.
 
 > Note: Before running the codemod, update all `@arcgis/*` packages in your `package.json` to the most recent version.
 
@@ -36,7 +46,7 @@ You can manually run it on a different directory by providing an argument:
 npx @arcgis/codemod run refactor-out-esri-namespace target-directory
 ```
 
-### What codemod does
+#### What the codemod does
 
 **Before:**
 
@@ -56,7 +66,7 @@ let geometry: Geometry;
 let featureSet: FeatureSet;
 ```
 
-### Warnings (Manual review required)
+#### Warnings (manual review required)
 
 The codemod will emit warnings for cases it cannot safely rewrite, including:
 
@@ -65,11 +75,36 @@ The codemod will emit warnings for cases it cannot safely rewrite, including:
 - Unresolvable symbols
 
 These will be reported in the console, manually review all changes before committing.
-If your project uses **ESLint, Prettier, or other formatters/linters**, run them after the codemod to ensure consistent formatting.
 
-> Note: This codemod modifies files in place and does not provide an interactive dry-run mode. We recommend running it in a project that is under version control (Git) so you can review changes using `git diff` or your IDE’s diff tools. If your project is not under version control, create a backup before running the codemod.
+### Normalize Calcite icon names
+
+The `normalize-calcite-icon-names` codemod updates camelCase and legacy Calcite icon names to their normalized kebab-case equivalents. It handles icon attributes on Calcite components and traces icon values through variables, properties, assignments, function returns, and forwarded component properties. This helps prepare for [calcite-design-system#14967](https://github.com/Esri/calcite-design-system/issues/14967) and [calcite-design-system#14966](https://github.com/Esri/calcite-design-system/issues/14966).
+
+Run it in the root of your project:
+
+```sh
+npx @arcgis/codemod run normalize-calcite-icon-names
+```
+
+You can also provide a target directory:
+
+```sh
+npx @arcgis/codemod run normalize-calcite-icon-names target-directory
+```
+
+**Before:**
+
+```tsx
+<calcite-button iconStart="i3dGlasses" iconEnd="arrowLeft10" />
+```
+
+**After:**
+
+```tsx
+<calcite-button iconStart="3d-glasses" iconEnd="arrow-left-10" />
+```
 
 ## License
 
-This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package, and at https://js.arcgis.com/5.1/LICENSE.txt.
-For third party notices, see https://js.arcgis.com/5.1/third-party-notices.txt.
+This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package, and at https://js.arcgis.com/5.2/LICENSE.txt.
+For third party notices, see https://js.arcgis.com/5.2/third-party-notices.txt.

package/dist/{actions-BBxr-9ge.js → actions-Cc94nYsB.js}

@@ -1,6 +1,6 @@
-import { path as T } from "@arcgis/components-build-utils";
+import { path as T } from "@arcgis/node-toolkit/path";
 import { SyntaxKind as g } from "ts-morph";
-import { g as x } from "./cli-DPzs7oKq.js";
+import { g as x } from "./cli-DJQ7NdBK.js";
 import { ModuleResolutionKind as D } from "typescript";
 import { capitalize as S } from "@arcgis/toolkit/string";
 import { log as q } from "@arcgis/toolkit/log";

package/dist/cli-DJQ7NdBK.js

@@ -0,0 +1,269 @@
+import { log as y } from "@arcgis/toolkit/log";
+import { Command as U } from "@commander-js/extra-typings";
+import { statSync as B } from "node:fs";
+import { getCwd as k, path as e, toPosixPathSeparators as W } from "@arcgis/node-toolkit/path";
+import "ts-morph";
+import c from "typescript";
+import { existsAsync as q, asyncFindPath as M } from "@arcgis/node-toolkit/file";
+import { asyncRetrievePackageJson as L } from "@arcgis/node-toolkit/packageJson";
+import { glob as $ } from "tinyglobby";
+import { gitIgnoreFileToGlobs as A } from "@arcgis/node-toolkit/glob";
+import { identity as _ } from "@arcgis/toolkit/function";
+import { styleText as F } from "node:util";
+const z = (t, o, n) => {
+  const r = t[o];
+  return r ? typeof r == "function" ? r() : Promise.resolve(r) : new Promise((l, i) => {
+    (typeof queueMicrotask == "function" ? queueMicrotask : setTimeout)(i.bind(null, /* @__PURE__ */ new Error("Unknown variable dynamic import: " + o + (o.split("/").length !== n ? ". Note that variables only represent file names one level deep." : ""))));
+  });
+}, ye = {
+  allowImportingTsExtensions: !0,
+  allowJs: !0,
+  allowArbitraryExtensions: !0,
+  allowSyntheticDefaultImports: !0,
+  checkJs: !0,
+  experimentalDecorators: !0,
+  forceConsistentCasingInFileNames: !1,
+  isolatedModules: !1,
+  isolatedDeclarations: !1,
+  jsx: c.JsxEmit.Preserve,
+  lib: ["lib.esnext.d.ts", "lib.dom.d.ts"],
+  module: c.ModuleKind.ESNext,
+  moduleResolution: c.ModuleResolutionKind.Bundler,
+  moduleDetection: c.ModuleDetectionKind.Auto,
+  strict: !1,
+  target: c.ScriptTarget.ESNext,
+  resolveJsonModule: !0,
+  esModuleInterop: !0
+}, j = {
+  codemod: void 0,
+  codemodName: void 0,
+  projectsData: void 0,
+  project: void 0
+};
+async function H() {
+  const { ignorePatterns: t, globRoot: o } = await Q(), n = await V(o);
+  return t.push(...n), { ignorePatterns: t, globRoot: o };
+}
+async function Q() {
+  const t = [];
+  let o, n = k(), r = e.dirname(n);
+  do {
+    o = r;
+    const l = e.join(o, ".gitignore");
+    if (await q(l)) {
+      n = e.dirname(l);
+      const g = e.relative(n, k()).split("/"), P = A(l);
+      for (const u of P) {
+        const h = u.startsWith("!") ? u.slice(1) : u, p = h.search(/[*?[]/u), w = p === -1 ? h : h.slice(0, p), v = w.split("/"), s = p !== -1 && !w.endsWith("/");
+        let a = !0;
+        const d = Math.min(g.length, v.length);
+        for (let m = 0; m < d; m++) {
+          const f = v[m];
+          if (!(s && m === v.length - 1 ? g[m].startsWith(f) : g[m] === f) && f !== "") {
+            a = !1;
+            break;
+          }
+        }
+        a && (u.startsWith("!") || t.push(u));
+      }
+    }
+    r = e.dirname(o);
+  } while (r !== o);
+  return { ignorePatterns: t, globRoot: n };
+}
+async function V(t) {
+  return (await $("**/.gitignore", {
+    cwd: k(),
+    // Gitignore files are unlikely to be symbolic links
+    followSymbolicLinks: !1,
+    // Don't look for ignore files in these places for speed:
+    ignore: [
+      // Hardcoded ignores in TypeScript
+      "**/node_modules/**",
+      "**/bower_components/**",
+      "**/jspm_packages/**",
+      // Default build output folder in bundlers
+      "**/dist/**"
+    ],
+    // Not applicable for our glob pattern
+    expandDirectories: !1
+  })).flatMap((n) => {
+    const r = e.relative(t, e.dirname(n)), l = A(n), i = [];
+    for (const g of l)
+      g.startsWith("!") || i.push(e.join(r, g));
+    return i;
+  });
+}
+const X = ["js", "jsx", "mjs", "cjs"], Y = ["ts", "tsx", "mts", "cts"], Z = ["json"], ee = `**/*.{${[...X, ...Y, ...Z].join(",")}}`;
+async function te() {
+  const t = await H(), o = e.join(process.cwd(), ee), n = await $(o, {
+    cwd: t.globRoot,
+    ignore: t.ignorePatterns,
+    // The files we are looking for are unlikely to be symbolic links
+    followSymbolicLinks: !1,
+    // Not applicable for our glob pattern
+    expandDirectories: !1
+    // Files and folders starting with . are excluded (matches TypeScript's
+    // default behavior). If any tsconfig.json explicitly includes such files,
+    // they will still be codemodded.
+  });
+  let r = e.relative(t.globRoot, process.cwd());
+  r !== "" && (r += "/");
+  const l = e.join(e.resolve(t.globRoot), "/"), i = l.length + r.length, g = [], P = [], u = /* @__PURE__ */ new Set();
+  for (const s of n) {
+    const a = l + s;
+    if (s.endsWith(".json")) {
+      const d = e.basename(s);
+      d === "package.json" ? g.push(a) : (d.startsWith("tsconfig.") || d.startsWith("jsconfig.")) && P.push(a);
+    } else {
+      const d = s.slice(r.length);
+      u.add(d);
+    }
+  }
+  let h = await M("tsconfig.json", e.dirname(process.cwd()));
+  h !== void 0 && (h = W(h), P.push(h)), P.sort((s, a) => {
+    const d = a.split("/").length - s.split("/").length;
+    if (d !== 0)
+      return d;
+    const m = e.basename(s), f = e.basename(a);
+    return m === f ? 0 : m.endsWith("tsconfig.json") ? -1 : f.endsWith("tsconfig.json") ? 1 : m.endsWith("tsconfig.build.json") ? -1 : f.endsWith("tsconfig.build.json") ? 1 : m.localeCompare(f);
+  });
+  let p = await M("package.json");
+  p !== void 0 && (p = W(p));
+  const w = [], v = /* @__PURE__ */ new Set();
+  if (await Promise.all(
+    P.map(async (s) => {
+      const a = e.relative(process.cwd(), s), d = c.readConfigFile(s, c.sys.readFile);
+      if (d.error !== void 0) {
+        y(
+          "error",
+          a,
+          c.formatDiagnosticsWithColorAndContext([d.error], {
+            getCanonicalFileName: _,
+            getCurrentDirectory: c.sys.getCurrentDirectory,
+            getNewLine: () => c.sys.newLine
+          })
+        );
+        return;
+      }
+      const m = e.basename(a), f = c.parseJsonConfigFileContent(
+        d.config,
+        c.sys,
+        e.dirname(s),
+        void 0,
+        m
+      ), R = 18003;
+      f.errors.filter((b) => b.code !== R).length > 0 && y(
+        "warn",
+        a,
+        c.formatDiagnosticsWithColorAndContext(f.errors, {
+          getCanonicalFileName: _,
+          getCurrentDirectory: c.sys.getCurrentDirectory,
+          getNewLine: () => c.sys.newLine
+        })
+      );
+      const E = s === h, O = a === m, N = f.fileNames.filter((b) => {
+        const D = b.slice(i);
+        return u.delete(D) ? (v.add(D), !0) : v.has(D) || D.endsWith(".json") || b.includes("node_modules") ? !1 : !E;
+      });
+      if (N.length === 0)
+        return;
+      P.length === 1 && (E || O) && u.clear();
+      const S = e.dirname(s);
+      let x = S, C = p;
+      do {
+        const b = e.join(x, "package.json");
+        if (g.includes(b)) {
+          C = b;
+          break;
+        }
+      } while (x !== t.globRoot && (x = e.dirname(x)));
+      const J = C === void 0 ? void 0 : { filePath: C, contents: await L(e.dirname(C)) }, K = {
+        typeScriptConfig: {
+          filePath: s,
+          compilerOptions: f.options
+        },
+        packageJson: J,
+        logName: F("blue", J?.contents?.name ?? S),
+        cwd: S,
+        filePaths: N
+      };
+      w.push(K);
+    })
+  ), u.size > 0) {
+    const s = p === void 0 ? void 0 : {
+      filePath: p,
+      contents: await L(e.dirname(p))
+    };
+    w.push({
+      typeScriptConfig: void 0,
+      packageJson: s,
+      cwd: process.cwd(),
+      logName: F("blue", s?.contents?.name ?? process.cwd()),
+      filePaths: Array.from(u).map((a) => e.join(process.cwd(), a))
+    });
+  }
+  return w.sort((s, a) => s.cwd.localeCompare(a.cwd)), j.projectsData = w, w;
+}
+let T = !1;
+function oe() {
+  T || (T = !0, process.exitCode !== void 0 && process.exitCode !== 0 ? y(
+    "warn",
+    j.codemodName,
+    "One or more exceptions occurred during the codemod run. Please review the output above."
+  ) : y(
+    "info",
+    j.codemodName,
+    `${F("green", "Codemod completed successfully.")} Recommended next steps:
+- Review the codemod changes.
+- If your project uses ESLint, run ESLint autofix on the changed files.
+- If your project uses Prettier, run Prettier on the changed files.
+- If your project uses TypeScript, run type checking to ensure there are no type errors.`
+  ));
+}
+async function se(t, o) {
+  j.codemod = t, j.codemodName = o;
+  const n = await te();
+  if (n.length === 0) {
+    y("error", o, `Failed to find any .js or .ts files in ${process.cwd()} to run the codemod on.`), process.exitCode = 1;
+    return;
+  }
+  await t.run(n), oe();
+}
+const I = new U();
+I.name("@arcgis/codemod").description("Codemod for migrating or refactoring usages of ArcGIS Maps SDK for JavaScript");
+I.command("run").description("Run a single codemod").argument("<codemodName>", "Name of the transform").argument("[path]", "Directory to transform", process.cwd()).action(ne);
+async function ne(t, o) {
+  const n = B(o, { throwIfNoEntry: !1 });
+  if (n === void 0) {
+    y("error", "@arcgis/codemod", `Failed to find the target path: ${o}`), process.exitCode = 1;
+    return;
+  }
+  const r = n.isFile();
+  process.chdir(r ? e.dirname(o) : o);
+  let l;
+  try {
+    l = await z(/* @__PURE__ */ Object.assign({ "./codemods/api-extractor-strict-mode/codemod.ts": () => import("./codemod-CUdF3oIK.js"), "./codemods/lumina-component-extras-improvements/codemod.ts": () => import("./codemod-CPBSioID.js"), "./codemods/node-toolkit/codemod.ts": () => import("./codemod-ByVDKNVh.js"), "./codemods/normalize-calcite-icon-names/codemod.ts": () => import("./codemod-TKeUnFf8.js"), "./codemods/refactor-out-esri-namespace/codemod.ts": () => import("./codemod-CDDi4e40.js"), "./codemods/toolkit-5.2-renames/codemod.ts": () => import("./codemod-DgA0GL73.js") }), `./codemods/${t}/codemod.ts`, 4);
+  } catch (i) {
+    if (
+      // direct Node execution
+      typeof i == "object" && i !== null && "code" in i && i.code === "ERR_MODULE_NOT_FOUND" && "url" in i && typeof i.url == "string" && i.url.endsWith(`${e.sep}${t}${e.sep}codemod.ts`) || // Vite build execution
+      String(i).includes("Unknown variable dynamic import:")
+    ) {
+      y("error", "@arcgis/codemod", `Can't find codemod by name "${t}".`), process.exitCode = 1;
+      return;
+    } else
+      throw i;
+  }
+  if (typeof l.codemod != "object" || l.codemod === null) {
+    y("error", "@arcgis/codemod", `Can't find codemod by name "${t}".`), process.exitCode = 1;
+    return;
+  }
+  await se(l.codemod, F("blue", t));
+}
+I.parse();
+export {
+  ye as d,
+  j as g,
+  oe as p
+};

package/dist/cli.js

@@ -1,6 +1,6 @@
-import "./cli-DPzs7oKq.js";
+import "./cli-DJQ7NdBK.js";
 import "@arcgis/toolkit/log";
 import "@commander-js/extra-typings";
 import "node:fs";
-import "@arcgis/components-build-utils";
+import "@arcgis/node-toolkit/path";
 import "node:util";

package/dist/codemod-ByVDKNVh.js

@@ -0,0 +1,140 @@
+var p = (i, o) => (o = Symbol[i]) ? o : /* @__PURE__ */ Symbol.for("Symbol." + i), f = (i) => {
+  throw TypeError(i);
+};
+var g = (i, o, a) => {
+  if (o != null) {
+    typeof o != "object" && typeof o != "function" && f("Object expected");
+    var n, t;
+    a && (n = o[p("asyncDispose")]), n === void 0 && (n = o[p("dispose")], a && (t = n)), typeof n != "function" && f("Object not disposable"), t && (n = function() {
+      try {
+        t.call(this);
+      } catch (r) {
+        return Promise.reject(r);
+      }
+    }), i.push([a, n, o]);
+  } else a && i.push([a]);
+  return o;
+}, m = (i, o, a) => {
+  var n = typeof SuppressedError == "function" ? SuppressedError : function(e, s, c, l) {
+    return l = Error(c), l.name = "SuppressedError", l.error = e, l.suppressed = s, l;
+  }, t = (e) => o = a ? new n(e, o, "An error was suppressed during disposal") : (a = !0, e), r = (e) => {
+    for (; e = i.pop(); )
+      try {
+        var s = e[1] && e[1].call(e[2]);
+        if (e[0]) return Promise.resolve(s).then(r, (c) => (t(c), r()));
+      } catch (c) {
+        t(c);
+      }
+    if (a) throw o;
+  };
+  return r();
+};
+import { f as h, p as P } from "./actions-Cc94nYsB.js";
+import { log as k } from "@arcgis/toolkit/log";
+import { writeFile as u } from "node:fs/promises";
+import { c as y } from "./useProjectInstance-PcBD3mbo.js";
+import { p as x, g as J } from "./cli-DJQ7NdBK.js";
+async function v(i, o) {
+  const a = /* @__PURE__ */ new Set();
+  for (const n of i) {
+    const t = n.packageJson;
+    if (t === void 0 || a.has(t.filePath))
+      continue;
+    a.add(t.filePath);
+    const r = t.contents;
+    try {
+      const e = await o(r, t.filePath);
+      r !== e && await u(t.filePath, `${JSON.stringify(e, null, 2)}
+`, "utf8");
+    } catch (e) {
+      process.exitCode = 1, k(
+        "error",
+        h(t.filePath),
+        `Error occurred while migrating: ${String(e)}`,
+        typeof e == "object" && e !== null && "stack" in e ? { detail: { stack: e.stack } } : void 0
+      );
+    }
+  }
+}
+function D(i, o) {
+  for (const a of ["dependencies", "devDependencies", "peerDependencies", "optionalDependencies"]) {
+    const n = i[a];
+    if (n) {
+      const t = o(n, a);
+      t !== n && (i = { ...i, [a]: t });
+    }
+  }
+  return i;
+}
+const d = "@arcgis/components-build-utils", S = {
+  [d]: {
+    existsAsync: { do: "rename", specifier: "@arcgis/node-toolkit/file" },
+    // Command-string helpers require manual tokenization before using command-plus-args helpers.
+    sh: { do: "rename", specifier: "@arcgis/node-toolkit/shell" },
+    // sp was removed from node-toolkit; collectOutputSync is the closest return-value replacement.
+    sp: { do: "rename", name: "collectOutputSync", specifier: "@arcgis/node-toolkit/shell" },
+    asyncSh: { do: "rename", specifier: "@arcgis/node-toolkit/shell" },
+    findPath: { do: "rename", specifier: "@arcgis/node-toolkit/file" },
+    asyncFindPath: { do: "rename", specifier: "@arcgis/node-toolkit/file" },
+    createFileIfNotExists: { do: "rename", specifier: "@arcgis/node-toolkit/file" },
+    gitIgnoreFileToGlobs: { do: "rename", specifier: "@arcgis/node-toolkit/glob" },
+    gitIgnoreToGlob: { do: "rename", specifier: "@arcgis/node-toolkit/glob" },
+    isPosix: { do: "rename", specifier: "@arcgis/node-toolkit/path" },
+    toPosixPathSeparators: { do: "rename", specifier: "@arcgis/node-toolkit/path" },
+    normalizePath: { do: "rename", specifier: "@arcgis/node-toolkit/path" },
+    toSystemPathSeparators: { do: "rename", specifier: "@arcgis/node-toolkit/path" },
+    getCwd: { do: "rename", specifier: "@arcgis/node-toolkit/path" },
+    path: { do: "rename", specifier: "@arcgis/node-toolkit/path" },
+    PackageJson: { do: "rename", specifier: "@arcgis/node-toolkit/packageJson" },
+    retrievePackageJson: { do: "rename", specifier: "@arcgis/node-toolkit/packageJson" },
+    asyncRetrievePackageJson: { do: "rename", specifier: "@arcgis/node-toolkit/packageJson" },
+    fetchPackageLocation: { do: "rename", specifier: "@arcgis/node-toolkit/packageJson" },
+    detectPackageManager: { do: "rename", specifier: "@arcgis/node-toolkit/packageJson" },
+    DependencyManagementOptions: {
+      do: "rename",
+      specifier: "@arcgis/node-toolkit/vite/externalizeDependenciesPlugin"
+    },
+    vitePresetPlugin: { do: "rename", specifier: "@arcgis/node-toolkit/vite/presetPlugin" },
+    externalizeDependencies: {
+      do: "rename",
+      specifier: "@arcgis/node-toolkit/vite/externalizeDependenciesPlugin"
+    }
+  }
+}, C = {
+  meta: {
+    needsTypeInformation: !1
+  },
+  async run(i) {
+    await v(
+      i,
+      (r) => D(
+        r,
+        (e) => e[d] ? {
+          ...e,
+          [d]: void 0,
+          "@arcgis/node-toolkit": e[d]
+        } : e
+      )
+    );
+    for (const r of i) {
+      var o = [];
+      try {
+        const e = g(o, y(r));
+        for (const s of e.getCodemodFiles())
+          P(s, S);
+      } catch (a) {
+        var n = a, t = !0;
+      } finally {
+        m(o, n, t);
+      }
+    }
+    x(), k(
+      "info",
+      J.codemodName,
+      "Next step: run npm install/pnpm install/yarn install to get @arcgis/node-toolkit package installed."
+    );
+  }
+};
+export {
+  C as codemod
+};