@arcforgelabs/flow 2026.11.5 → 2026.11.7

package/server/ui/monitoring.js

@@ -126,6 +126,62 @@ export function scrubRecordingEvent(event) {
   return { ...event, data: { ...event.data, payload: next } };
 }
 
+// Private data in an event's words. Flow's own lines name a step and a code;
+// the text they pass on from the database, Xero or Seazona can hold a name,
+// an email, an amount or a record id. Each becomes a placeholder, so the event
+// keeps the fault and drops the data, and the same fault with other records
+// is one issue in Sentry, not one issue per record.
+const TEXT_MASKS = [
+  [/[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}/gi, '<email>'],
+  [/\b\d{4}-\d{2}-\d{2}(T[\d:.]+Z?)?\b/g, '<time>'],
+  [/\b[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}\b/gi, '<id>'],
+  // A database's "Key (column)=(value)".
+  [/\(([^()\n]{1,200})\)=\(([^()\n]{0,200})\)/g, '(<field>)=(<value>)'],
+  // Quoted text: a contact, a reference, a file name. An apostrophe inside a
+  // word ("Flow's") is not a quote.
+  [/"[^"\n]{1,200}"|“[^”\n]{1,200}”|‘[^’\n]{1,200}’|(?<![\w'])'[^'\n]{1,200}'(?![\w'])/g, '<text>'],
+  [/[$£€]\s?\d[\d,]*(\.\d+)?|\b\d[\d,]*\.\d{2}\b/g, '<amount>'],
+  [/\b[A-Z]{2,6}-\d{2,}\b/g, '<ref>'],
+  [/\+?\d[\d ().-]{6,}\d/g, '<number>'],
+  [/\b\d{3,}\b/g, '<n>'],
+];
+// Only the address-like words: for what a person types in a problem report,
+// where a number can be the point of the report.
+const CONTACT_MASKS = TEXT_MASKS.slice(0, 1).concat([[/\+?\d[\d ()-]{8,}\d/g, '<number>']]);
+export function maskText(value, masks = TEXT_MASKS) {
+  if (typeof value !== 'string') return value;
+  return masks.reduce((text, [pattern, mark]) => text.replace(pattern, mark), value);
+}
+
+// Every event before it leaves Flow, on the server and in the browser
+// (beforeSend). The words are masked (maskText); a request keeps its path,
+// never its body, query string, cookies or headers; the person is their Flow
+// id only. A problem report keeps what the person typed, with addresses and
+// phone numbers masked, and keeps their email only when they asked for a
+// response (notify=yes, tagNotify).
+export function scrubEvent(event) {
+  if (!event || typeof event !== 'object') return event;
+  const report = event.type === 'feedback';
+  if (!report) {
+    event.message = maskText(event.message);
+    if (event.logentry) event.logentry = { ...event.logentry, message: maskText(event.logentry.message), formatted: maskText(event.logentry.formatted), params: undefined };
+    for (const value of event.exception?.values ?? []) value.value = maskText(value.value);
+    if (event.extra) event.extra = Object.fromEntries(Object.entries(event.extra).map(([key, value]) => [key, maskText(typeof value === 'string' ? value : '<data>')]));
+  }
+  if (Array.isArray(event.breadcrumbs)) {
+    event.breadcrumbs = event.breadcrumbs.map(({ data, message, ...crumb }) => ({ ...crumb, ...(message ? { message: maskText(message) } : {}), ...(data?.url ? { data: { url: withoutQuery(data.url), method: data.method, status_code: data.status_code } } : {}) }));
+  }
+  if (event.request) event.request = { method: event.request.method, url: withoutQuery(event.request.url) };
+  if (event.user) event.user = event.user.id == null ? {} : { id: event.user.id };
+  const feedback = event.contexts?.feedback;
+  if (feedback) {
+    const keepContact = event.tags?.notify === 'yes';
+    event.contexts.feedback = { ...feedback, message: maskText(feedback.message, CONTACT_MASKS), name: undefined, contact_email: keepContact ? feedback.contact_email : undefined };
+    if (keepContact && feedback.contact_email) event.user = { ...event.user, email: feedback.contact_email };
+  }
+  return event;
+}
+
 /** Resolves to a function that opens the "Report a problem" form, or null. */
 export async function startMonitoring({ flow, person }) {
   const config = await flow('/api/monitoring');
@@ -142,7 +198,9 @@ export async function startMonitoring({ flow, person }) {
     showName: false,
     // The form fills in the signed-in person's name and email (setUser).
     useSentryUser: { name: 'username', email: 'email' },
-    enableScreenshot: true,
+    // A screenshot is the screen as it is, names and all: off unless the
+    // installation turns it on (SENTRY_SCREENSHOT).
+    enableScreenshot: Boolean(config.screenshot),
     triggerLabel: 'Report a problem',
     formTitle: 'Report a problem',
     messageLabel: 'What went wrong?',
@@ -180,13 +238,15 @@ export async function startMonitoring({ flow, person }) {
     // Replay: never a whole visit, only the minute before a report or error.
     replaysSessionSampleRate: 0,
     replaysOnErrorSampleRate: config.replay ? 1 : 0,
+    beforeSend: scrubEvent,
     beforeSendSpan: scrubSpan,
     initialScope: { tags: config.tags ?? {} },
   });
   // Read when the report is sent: the tick box of the form open now.
   let wantsResponse = false;
-  Sentry.getClient()?.on('beforeSendFeedback', (event) => tagNotify(event, wantsResponse));
-  // Who reported or met the error, so the lab can follow up.
+  Sentry.getClient()?.on('beforeSendFeedback', (event) => { tagNotify(event, wantsResponse); scrubEvent(event); });
+  // Fills in the report form. Events keep only the Flow id (scrubEvent); a
+  // report keeps the email only when the person asks for a response.
   Sentry.setUser({ id: person.id, email: person.email, username: person.name || undefined });
   const feedback = config.feedback ? Sentry.getFeedback() : null;
   if (!feedback) return null;

package/server/ui/price-list.js

@@ -245,8 +245,11 @@ export async function renderPriceList(main, ui) {
       type: 'button', role: 'tab', 'aria-selected': String(tab === id), onclick: () => { tab = id; draw(); },
     }, label, h('span', { class: 'fx-tabs__count' }, String(count)))));
 
+    // A list Flow could not read: its differences are not shown.
+    const unread = (data.unread ?? []).length
+      ? notice(`${data.unread.map((u) => u.name).join(' and ')} list not read, so its differences are not shown. Flow reads it again at its next sync, in a few minutes: reload this page then. If it stays, open Integrations.`, 'warn') : null;
     if (!shown.length) {
-      host.replaceChildren(h('p', { class: 'fx-empty' }, words || view.groups.length ? 'No code matches.' : tab === 'archived' ? 'No archived codes.' : 'No codes yet.'));
+      host.replaceChildren(...[unread, h('p', { class: 'fx-empty' }, words || view.groups.length ? 'No code matches.' : tab === 'archived' ? 'No archived codes.' : 'No codes yet.')].filter(Boolean));
     } else {
       const columns = view.columns.map((id) => ({ id, label: PRICE_COLUMNS[id], ...COLUMN_DEFS[id] }));
       const itemRow = (item) => h('tr', { class: 'fx-row-link', tabindex: '0', onclick: () => edit(item), onkeydown: (event) => { if (event.key === 'Enter') edit(item); } },
@@ -260,7 +263,7 @@ export async function renderPriceList(main, ui) {
         open: !folded.has(label), onFold: () => { if (folded.has(label)) folded.delete(label); else folded.add(label); draw(); },
         span: columns.length + 1,
       });
-      host.replaceChildren(heads.table({
+      host.replaceChildren(...[unread].filter(Boolean), heads.table({
         className: 'fx-table--rows fx-price__table', columns,
         rows: groups.map((g) => h('tbody', {}, g.label == null ? null : head(g), g.label != null && folded.has(g.label) ? null : g.jobs.map(itemRow))),
       }));

package/skills/flow/SKILL.md

@@ -54,6 +54,7 @@ for sends, voids and deletes get the person's yes in the chat.
 | Add a rule | `flow.sh post invoicing/rules '{"name":"...","conditions":[{"field":"job_total","test":"at_most","value":0}],"action":{"kind":"wait"}}'` |
 | Change or turn off a rule | `flow.sh put invoicing/rules/<id> '{"enabled":false}'` |
 | Delete a rule | `flow.sh delete invoicing/rules/<id>` |
+| Remakes are never billed | `flow.sh post invoicing/rules '{"name":"Remake","conditions":[{"field":"remake","test":"is","value":true}],"action":{"kind":"non_chargeable"}}'` |
 | Rule that offers an item (shipping) | `flow.sh post invoicing/rules '{"name":"Shipping","conditions":[{"field":"line_item","test":"has_not","value":"S/H"}],"action":{"kind":"pending","note":"Add shipping, or skip with a reason.","addItem":"S/H"}}'` |
 | Add the rule's item to a draft | `flow.sh post invoicing/invoices/<id>/rules/<ruleId>/add-item '{}'` |
 | Skip a rule for one job | on its draft: `flow.sh post invoicing/invoices/<id>/rules/<ruleId>/exception '{"reason":"..."}'`; no draft yet: `flow.sh post invoicing/jobs/<jobId>/rules/<ruleId>/exception '{"reason":"..."}'` |
@@ -70,6 +71,10 @@ the person's reason for a skip. An exception ends when the job's lines change
 (`current: false` in the rule's exceptions list): ask the person again. The work system must get the item too: tell
 the person which jobs show "needs <item>" on the job board.
 
+A matching `non_chargeable` rule wins over wait rules, and it releases old
+held history jobs that have no accounting invoice. Settle reconciliation work
+(remakes, own clinics) with rules, never with one-off clean-ups.
+
 Keep the rules few and clear. When you work with rules, read all of them
 (`flow.sh get invoicing/rules`) and look for rules that do the same job, that
 overlap, or that no longer match anything. Show the person a short list: which
@@ -139,8 +144,33 @@ How to read `price-list`:
 - `items`: each Flow code with its `links` (the linked Xero item or Seazona
   product, as `record`) and `findings`. A finding `kind` is `price` (Flow and
   the other system differ: `flow` and `other` in cents), `tax`, `missing` (the
-  linked record is gone) or `not_linked` (no Xero item for this code).
+  linked record is gone), `not_linked` (no Xero item for this code) or `code`
+  (the linked Xero item has another code while another Xero item has the
+  Flow code: check that the link is the right one).
 - `unlinked`: Xero items and Seazona products that no Flow code has yet.
+- `unread`: lists Flow could not read now. Their differences are not shown,
+  so say "not read", never "no differences", and read again later.
+
+How the three lists fit:
+
+- Each system keeps its own names and codes. Flow joins them by links, never
+  by renaming. Do not ask the person to rename a record only to match.
+- Many Seazona products can link to one Flow code (two names, one price).
+  One Flow code has one Xero item at most.
+- A send uses the Xero link (by Xero's id), so a Flow code can send as a
+  Xero item with another code. With no link, it sends as the same code.
+- A link to a record that another code had moves it. The answer has `moved`
+  (`price-links`) or `movedFrom` (one link): tell the person which code
+  lost it.
+- The rule field `accounting_item` ("Every item is in accounting") holds a job
+  with a line whose code does not send as a Xero item that sells. The reason
+  names the codes. A lab that must never invoice an item Xero does not have
+  keeps one such rule (Then wait, or pending with a note).
+
+Before you call a difference a new price or a new product, check the mapping:
+a wrong line mapping, a wrong link or a rule is the usual cause. Prices and
+products change seldom. Read the line's `line-labels` row, its mapping and
+the code's links first, and say which one is wrong.
 
 Reconcile steps: