@arcforgelabs/flow 2026.10.35 → 2026.10.37

package/server/ui/job-board.js

@@ -76,66 +76,82 @@ const capital = (text) => (text ? text[0].toUpperCase() + text.slice(1) : text);
 const sentence = (text) => capital(String(text).trim().replace(/\.?$/, '.'));
 
 // One ledger reason (server/core/ledger.js) as a fix: a short label, what is
-// wrong, and what to do.
-function reasonFix(reason, acct) {
-  const fix = (label, todo) => ({ label, text: sentence(reason), todo });
+// wrong, what to do, and where to go to do it (`go`, see GO). A job's fix
+// speaks of Flow's own invoice only. How that invoice stands in an
+// accounting system is the invoice's business, on the invoice page.
+function reasonFix(reason) {
+  const fix = (label, todo, go = null) => ({ label, text: sentence(reason), todo, go });
   if (reason === 'the accounting system was not checked') {
-    return { label: `Not checked in ${acct}`, text: `Flow did not check ${acct} for an invoice for this job yet.`, todo: `Wait for the next check, a few minutes. If it stays, check ${acct} under Settings, Integrations.` };
+    return { label: 'Not checked yet', text: 'Flow did not check for an invoice for this job yet.', todo: 'Wait for the next check, a few minutes. If it stays, check Settings, Integrations.', go: 'integrations' };
   }
   if (reason === 'a line does not map to a price item') {
-    return { label: 'No price code', text: 'A line has a code that is not in the price list.', todo: 'Add the code to the price list, or correct the code in the work system.' };
+    return { label: 'No price code', text: 'A line has a code that is not in the price list.', todo: 'Add the code to the price list, or correct the code in the work system.', go: 'price-list' };
   }
   if (reason === 'the job has no customer contact') {
-    return { label: 'Client not linked', text: 'The client is not linked to a customer in Flow.', todo: 'Link the client to a customer in Flow.' };
+    return { label: 'Client not linked', text: 'The client is not linked to a customer in Flow.', todo: 'Link the client to a customer in Flow.', go: null };
   }
   if (reason === 'the work system report is out of date') {
-    return { label: 'Out of date', text: 'Flow has no news of this job from the work system for more than a day.', todo: 'Check the work system under Settings, Integrations.' };
+    return { label: 'Out of date', text: 'Flow has no news of this job from the work system for more than a day.', todo: 'Check the work system under Settings, Integrations.', go: 'integrations' };
+  }
+  if (reason === 'the job changed after its invoice was made') return fix('Job changed', 'Open the invoice to see what changed. Fix the job in the work system, or adopt its changes on the draft.', 'invoice');
+  if (reason === 'the job status moved back after its invoice was made') return fix('Status moved back', 'Check the job in the work system. Void or hold its invoice if the work is not done.', 'work');
+  if (/deleted in /i.test(reason)) return fix('Deleted', 'Check the job in the work system. Void its invoice if it has one.', 'work');
+  // The matcher found invoices that may be this job's, but no exact link.
+  // Flow holds the job so that it is not invoiced two times.
+  if (/^the accounting evidence is ambiguous/.test(reason)) {
+    return { label: 'Invoice unclear', text: 'Flow cannot tell if this job has an invoice already.', todo: 'Check the invoice number on the job in the work system. Flow holds the job so it is not invoiced two times.', go: 'work' };
+  }
+  if (/^the accounting evidence is conflict/.test(reason)) {
+    return { label: 'Invoice link changed', text: 'A second invoice now answers for this job, or its invoice is gone.', todo: 'Check the invoice number on the job in the work system. Void an extra invoice.', go: 'work' };
+  }
+  if (/^invoice .* was (voided|deleted)$/.test(reason)) {
+    const voided = /voided$/.test(reason);
+    return { label: `Invoice ${voided ? 'voided' : 'deleted'}`, text: `The invoice for this job was ${voided ? 'voided' : 'deleted'}.`, todo: 'Make a new invoice, or close the job.', go: 'invoice' };
+  }
+  if (/^the accounting system reports /.test(reason)) {
+    return { label: 'May be invoiced', text: 'Flow found an invoice that may be for this job.', todo: 'Check the invoice number on the job in the work system.', go: 'work' };
   }
-  if (reason === 'the job changed after its invoice was made') return fix('Job changed', 'Open the invoice to see what changed. Fix the job in the work system, or adopt its changes on the draft.');
-  if (reason === 'the job status moved back after its invoice was made') return fix('Status moved back', 'Check the job in the work system. Void or hold its invoice if the work is not done.');
-  if (/deleted in /i.test(reason)) return fix('Deleted', 'Check the job in the work system. Void its invoice if it has one.');
-  if (/^the accounting evidence is ambiguous/.test(reason)) return fix(`${acct} match unclear`, `Find the invoice for this job in ${acct}, then link it.`);
-  if (/^the accounting evidence is conflict/.test(reason)) return fix(`Two ${acct} invoices`, `Find the right invoice for this job in ${acct}. Void the other.`);
-  if (/^invoice .* was (voided|deleted)$/.test(reason)) return fix(`Invoice ${/voided$/.test(reason) ? 'voided' : 'deleted'}`, 'Make a new invoice, or close the job.');
-  if (/^the accounting system reports /.test(reason)) return fix(`Already in ${acct}`, `Check the invoice in ${acct}. Link it to this job if it is the right one.`);
   if (/^the job is held$/.test(reason)) return fix('On hold', 'Release the hold when the job can be invoiced.');
-  if (/^the job is review$/.test(reason)) return fix('Needs review', 'Check the job and its invoice.');
+  if (/^the job is review$/.test(reason)) return fix('Needs review', 'Check the job and its invoice.', 'invoice');
   if (reason === 'held') return fix('On hold', 'Release the hold when the job can be invoiced.');
-  return fix('Needs review', 'Check the job and its invoice.');
+  return fix('Needs review', 'Check the job and its invoice.', 'invoice');
 }
 
-// One draft problem (server/core/sending.js, and the accounting system's) as a fix.
-function draftFix(problem, acct) {
+// One problem on the job's invoice (server/core/sending.js, and an accounting
+// system's) as a job fix. Flow's own invoice problems keep their words. A
+// problem an accounting system found stays on the invoice page; the job only
+// says that its invoice needs a fix.
+function draftFix(problem) {
   const code = problem.code ?? '';
-  const fix = (label, todo) => ({ label, text: sentence(problem.message ?? label), todo });
+  const fix = (label, todo) => ({ label, text: sentence(problem.message ?? label), todo, go: 'invoice' });
   if (code === 'no_lines') return fix('No lines', 'Open the invoice and add the lines.');
   if (code === 'no_amount') return fix('Total is $0', 'Open the invoice and correct the amounts.');
   if (code === 'line_no_item') return fix('No price code', 'Open the invoice and choose a price item for each line.');
-  if (code.endsWith('_item_missing')) return fix(`Item not in ${acct}`, `Add the item in ${acct}, then sync.`);
-  if (code.endsWith('_contact_missing')) return fix(`Client not in ${acct}`, `Add the client in ${acct}, then sync.`);
-  if (code.endsWith('_contact_ambiguous')) return fix(`Two ${acct} clients`, `Merge or rename the clients in ${acct}, then sync.`);
-  if (code.includes('earlier_version')) return fix(`Old copy in ${acct}`, 'Open the invoice for the steps.');
-  if (code.startsWith('send_') || code.endsWith('_push_failed') || code.endsWith('_outcome_unknown')) return fix('Not sent', 'Open the invoice and send it again.');
-  return fix('Invoice problem', 'Open the invoice to correct it.');
+  if (code.startsWith('send_') || code.endsWith('_push_failed') || code.endsWith('_outcome_unknown')) {
+    return { label: 'Not sent', text: 'The invoice for this job was not sent.', todo: 'Open the invoice and send it again.', go: 'invoice' };
+  }
+  return { label: 'Invoice problem', text: 'The invoice for this job needs a fix before it can be sent.', todo: 'Open the invoice for the steps.', go: 'invoice' };
 }
 
-// What a person must fix on a job, in order: [{ label, text, todo }]. Empty
-// unless invoiceStage is Problem. `accountingName` names the accounting
-// system (for example Xero).
-export function fixes(o, { accountingName = null } = {}) {
+// Where a fix's link goes: Flow's invoice, the job in the work system, or a
+// Flow settings page (jobs.js draws the link).
+export const GO = ['invoice', 'work', 'price-list', 'invoicing-settings', 'integrations'];
+
+// What a person must fix on a job, in order: [{ label, text, todo, go }].
+// Empty unless invoiceStage is Problem.
+export function fixes(o) {
   if (invoiceStage(o) !== 'problem') return [];
-  const acct = accountingName ?? 'the accounting system';
   const found = [];
-  if (PROBLEM_VIEWS.includes(o.view)) found.push(...(o.reasons ?? []).map((r) => reasonFix(r, acct)));
+  if (PROBLEM_VIEWS.includes(o.view)) found.push(...(o.reasons ?? []).map((r) => reasonFix(r)));
   if (o.view === 'ready') {
     found.push(...(o.waitingFor ?? []).filter(isRule).map((r) => ({
-      label: 'Stopped by a rule', text: sentence(r), todo: 'Draft the invoice here, or change the rule under Settings, Invoicing, Rules.',
+      label: 'Stopped by a rule', text: sentence(r), todo: 'Draft the invoice here, or change the rule under Settings, Invoice rules.', go: 'invoicing-settings',
     })));
   }
   if (o.invoiceStatus === 'void') {
-    found.push({ label: 'Invoice void', text: 'The invoice for this job is void.', todo: 'Make a new invoice, or close the job.' });
+    found.push({ label: 'Invoice void', text: 'The invoice for this job is void.', todo: 'Make a new invoice, or close the job.', go: 'invoice' });
   }
-  found.push(...(o.invoiceProblems ?? []).map((p) => draftFix(p, acct)));
+  found.push(...(o.invoiceProblems ?? []).map((p) => draftFix(p)));
   return found;
 }
 
@@ -146,6 +162,14 @@ export function problemSummary(found) {
   return labels.length > 1 ? `${labels[0]} +${labels.length - 1}` : labels[0];
 }
 
+// A system's own record id (a UUID) is not a case number a person reads.
+// Search still finds the job by it (job-board.js matches).
+const RECORD_ID = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
+export function caseNumber(job) {
+  const ref = job.caseRef ?? job.sourceJobRef ?? null;
+  return ref && !RECORD_ID.test(ref) ? ref : null;
+}
+
 // Does a job match the search text? Case, client, practitioner or invoice
 // number; the case is not shown on the board, but a person can find it.
 export function matches(job, q) {

package/server/ui/jobs.js

@@ -14,7 +14,7 @@
 
 import { formatCents } from '/assets/ui/invoicing.js';
 import {
-  FINAL_RANK, fixes, INVOICE_STAGES, invoiceStage, matches, NO_STATUS, orderStatuses, problemSummary, statusRank,
+  caseNumber, FINAL_RANK, fixes, INVOICE_STAGES, invoiceStage, matches, NO_STATUS, orderStatuses, problemSummary, statusRank,
 } from '/assets/ui/job-board.js';
 import {
   DEFAULT_VIEW, fieldGroup, fieldIdOf, fieldLanes, filterCount, filterJobs, groupJobs, GROUPS, laneOf, normaliseJobsView, NOT_SET, sortJobs, SORTS,
@@ -74,7 +74,7 @@ export async function renderJobs(main, ui) {
   const saved = ui.me?.views?.jobs;
   const state = {
     view: normaliseJobsView(saved ?? { ...DEFAULT_VIEW, layout: readLayout() }),
-    q: asked.trim().toLowerCase(), jobs: [], statuses: [], accountingName: null, canDraft: false,
+    q: asked.trim().toLowerCase(), jobs: [], statuses: [], canDraft: false,
     // Custom fields (docs/CUSTOM_FIELDS.md): the lab's fields, the work
     // systems' stage fields, the people a person field can name, and each
     // job's values by job and field.
@@ -99,7 +99,7 @@ export async function renderJobs(main, ui) {
   drawToggle();
   search.addEventListener('input', () => { state.q = search.value.trim(); draw(); });
 
-  const problemsOf = (job) => fixes(job.obligation, { accountingName: state.accountingName });
+  const problemsOf = (job) => fixes(job.obligation);
   const valueKey = (job, fieldId) => `${job.sourceSystem}\u0000${job.sourceJobRef}\u0000${fieldId}`;
   const valueOf = (job, fieldId) => state.values.get(valueKey(job, fieldId)) ?? null;
   const groupable = () => state.fields.filter((f) => f.groupable);
@@ -232,7 +232,6 @@ export async function renderJobs(main, ui) {
       ]);
       state.jobs = body.jobs;
       state.statuses = body.statuses;
-      state.accountingName = body.accountingName;
       state.canDraft = context.canIssue;
       state.fields = fields?.fields ?? [];
       state.systemFields = fields?.systemFields ?? [];
@@ -495,7 +494,7 @@ export async function renderJobs(main, ui) {
     try {
       const { move } = await flow('/api/work/moves', { method: 'POST', body: JSON.stringify({ ...ref, toStatus: status }) });
       job.pendingMove = { to: move.to, from: move.from, requestedAt: move.requestedAt, expiresAt: move.expiresAt, openUrl: move.openUrl, openExact: move.openExact };
-      ui.toast?.(`Waiting for ${system}. Set case ${move.caseRef} to ${move.to} there.`, 'success');
+      ui.toast?.(`Waiting for ${system}. Set ${caseNumber(move) ? `case ${caseNumber(move)}` : 'the case'} to ${move.to} there.`, 'success');
     } catch (error) {
       job.pendingMove = before;
       ui.toast?.(error.message, 'danger');
@@ -512,13 +511,14 @@ export async function renderJobs(main, ui) {
   // system's web app. An exact link opens the order itself; otherwise it
   // opens the lab's home page there, and the person finds the case.
   function openStep(job, system) {
-    const caseRef = job.caseRef ?? job.sourceJobRef;
+    const caseRef = caseNumber(job);
+    const named = caseRef ? `case ${caseRef}` : `the case for ${clientOf(job)}`;
     const url = job.link?.url ?? null;
-    if (!url) return `Open case ${caseRef} in ${system}.`;
+    if (!url) return `Open ${named} in ${system}.`;
     const out = (text) => h('a', { class: 'fx-task__link', href: url, target: '_blank', rel: 'noopener' }, text);
     return job.link.exact
-      ? h('span', {}, out(`Open case ${caseRef} in ${system} ↗`))
-      : h('span', {}, out(`Open ${system} ↗`), ` and find case ${caseRef}.`);
+      ? h('span', {}, out(caseRef ? `Open case ${caseRef} in ${system} ↗` : `Open the case in ${system} ↗`))
+      : h('span', {}, out(`Open ${system} ↗`), ` and find ${named}.`);
   }
 
   // The job panel's custom fields: one control each, saved when it changes.
@@ -681,7 +681,20 @@ export async function renderJobs(main, ui) {
       : stage ? INVOICE_STAGES[stage] : o ? 'Not ready to invoice' : 'No invoice yet';
     const fixBox = found.length ? h('section', { class: 'fx-task__fix', 'aria-label': 'Fix' },
       h('h3', {}, 'Fix'),
-      found.map((f) => h('div', { class: 'fx-task__fixrow' }, h('span', {}, `${f.text} ${f.todo}`)))) : null;
+      found.map((f) => h('div', { class: 'fx-task__fixrow' }, h('span', {}, `${f.text} ${f.todo}`), fixLink(f.go)))) : null;
+    // Each fix's link: Flow's own invoice, the job in the work system, or
+    // the Flow page where the fix is made (job-board.js GO).
+    function fixLink(go) {
+      const inFlow = (href, text) => h('a', { class: 'fx-task__link', href, onclick: (event) => { close(); ui.go(event); } }, text);
+      if (go === 'invoice' && o?.invoiceId) return inFlow(`/invoices/${o.invoiceId}`, 'Open invoice');
+      if (go === 'work' && job.link?.url) {
+        return h('a', { class: 'fx-task__link', href: job.link.url, target: '_blank', rel: 'noopener' }, job.link.exact ? `Open case in ${system} ↗` : `Open ${system} ↗`);
+      }
+      if (go === 'price-list') return inFlow('/price-list', 'Open price list');
+      if (go === 'invoicing-settings') return inFlow('/invoicing-settings', 'Open invoice rules');
+      if (go === 'integrations' && ui.me?.person?.role === 'owner') return inFlow('/integrations', 'Open integrations');
+      return null;
+    }
     const lines = job.lines ?? [];
     const activity = h('ol', {}, h('li', { class: 'fx-dim' }, 'Loading…'));
     element.append(h('div', { class: 'fx-task__grid' },
@@ -697,13 +710,14 @@ export async function renderJobs(main, ui) {
           field(job.dueOn ? 'Due' : 'Ordered', job.dueOn ? fullDate(job.dueOn) : job.orderedOn ? fullDate(job.orderedOn) : null, late ? { class: 'fx-task__late' } : {}),
           job.dueOn ? field('Ordered', job.orderedOn ? fullDate(job.orderedOn) : null) : null,
           field('Total', job.totalCents == null ? null : formatCents(job.totalCents)),
-          field('Case number', job.caseRef ?? job.sourceJobRef, { class: 'fx-mono' }),
+          field('Case number', caseNumber(job), { class: 'fx-mono' }),
           job.link?.url ? field(system, link({ href: job.link.url, target: '_blank', rel: 'noopener' }, job.link.exact ? `Open case in ${system} ↗` : `Open ${system} ↗`)) : null,
           field(`${system} status`, job.status),
           field(`${system} client`, job.workClientName && job.workClientName !== job.clientName ? job.workClientName : null),
           field('Department', job.department),
-          field('Invoice', invoiceText),
-          o?.accountingUrl ? field(state.accountingName ?? 'Accounting', link({ href: o.accountingUrl, target: '_blank', rel: 'noopener' }, `Open in ${state.accountingName ?? 'the accounting system'}`)) : null),
+          // The job links to Flow's invoice only. The invoice page shows its
+          // link to an accounting system (its Linked card).
+          field('Invoice', invoiceText)),
         fixBox,
         state.fields.length ? h('section', { class: 'fx-task__custom', 'aria-label': 'Custom fields' },
           h('h3', {}, 'Fields'),

package/server/ui/routes.js

@@ -11,6 +11,7 @@ import { themeStylesheet } from '../theme/themes.js';
 //   /assets/theme/<file>.js  the theme engine itself, as browser modules
 //   /assets/ui/<file>        Flow's components (flow.css) and page scripts
 //   /assets/fonts/<pkg>/…    the families' faces (server/theme/font-families.js)
+//   /assets/icons/<name>.svg one Lucide icon (lucide-static, ISC), for any page
 // Only the files named here are served. They change only with a release, so
 // browsers may keep them for an hour.
 
@@ -20,7 +21,9 @@ const themeDir = join(here, '..', 'theme');
 const logoDir = join(here, 'logos');
 const LOGO_FILES = new Set(['xero.svg', 'seazona.svg', 'sentry.svg']);
 const THEME_FILES = new Set(['themes.js', 'color-contrast.js', 'openclaw-palettes.js', 'font-families.js']);
-const UI_FILES = new Set(['flow.css', 'appearance.js', 'clerk-appearance.js', 'app.js', 'invoicing.js', 'invoice-notes.js', 'job-change.js', 'invoicing-settings.js', 'automations.js', 'invoice-rules.js', 'line-mappings.js', 'price-list.js', 'custom-fields.js', 'jobs.js', 'job-board.js', 'job-view.js', 'monitoring.js', 'search.js', 'alerts.js', 'flow-mark.svg']);
+const UI_FILES = new Set(['flow.css', 'appearance.js', 'clerk-appearance.js', 'app.js', 'invoicing.js', 'invoice-notes.js', 'job-change.js', 'invoicing-settings.js', 'automations.js', 'invoice-rules.js', 'line-mappings.js', 'price-list.js', 'custom-fields.js', 'jobs.js', 'job-board.js', 'job-view.js', 'monitoring.js', 'search.js', 'alerts.js', 'bulk-bar.js', 'flow-mark.svg']);
+const iconDir = join(dirname(require.resolve('lucide-static/package.json')), 'icons');
+const ICON_FILE = /^[a-z0-9]+(?:-[a-z0-9]+)*\.svg$/;
 const MAX_AGE = '1h';
 
 // Send one named file from dir. Passing dir as root limits the dotfile check
@@ -49,6 +52,13 @@ export function createUiAssetsRouter({ rateLimitPerMinute = 600 } = {}) {
   // Each integration's logo, the maker's own mark (Integrations).
   router.get('/assets/ui/logos/:file', sendFrom(logoDir, LOGO_FILES));
 
+  // The whole Lucide set: a page names any icon, and only the icons a page
+  // uses are fetched. A name outside the set falls through to the 404.
+  router.get('/assets/icons/:file', (req, res, next) => {
+    if (!ICON_FILE.test(req.params.file)) return next();
+    sendNamed(res, next, iconDir, req.params.file);
+  });
+
   for (const name of FONT_PACKAGES) {
     const dir = dirname(require.resolve(`@fontsource-variable/${name}/LICENSE`));
     router.get(`/assets/fonts/${name}/index.css`, (_req, res, next) => sendNamed(res, next, dir, 'index.css'));