@arcasdk/core 0.3.6 → 1.2.0

package/lib/infrastructure/outbound/adapters/{auth → repositories/auth}/auth.repository.js

@@ -10,13 +10,14 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AuthRepository = void 0;
-const access_ticket_entity_1 = require("../../../../domain/entities/access-ticket.entity");
-const parser_1 = require("../../../utils/parser");
-const crypt_data_1 = require("../../../utils/crypt-data");
-const wsdl_path_enum_1 = require("../../../outbound/ports/soap/enums/wsdl-path.enum");
-const endpoints_enum_1 = require("../../../outbound/ports/soap/enums/endpoints.enum");
-const soap_client_1 = require("../soap/soap-client");
-const constants_1 = require("../../../constants");
+const access_ticket_entity_1 = require("../../../../../domain/entities/access-ticket.entity");
+const parser_1 = require("../../../../utils/parser");
+const datetime_ref_1 = require("../../../../utils/datetime-ref");
+const crypt_data_1 = require("../../../../utils/crypt-data");
+const wsdl_path_enum_1 = require("../../../../outbound/ports/soap/enums/wsdl-path.enum");
+const endpoints_enum_1 = require("../../../../outbound/ports/soap/enums/endpoints.enum");
+const soap_client_1 = require("../../soap/soap-client");
+const constants_1 = require("../../../../constants");
 class AuthRepository {
     constructor(config) {
         var _a, _b, _c, _d;
@@ -84,8 +85,8 @@ class AuthRepository {
             const signedTRA = this.signTRA(yield parser_1.Parser.jsonToXml(this.getTRA(serviceName)));
             const client = yield this.createAuthClient();
             const [{ loginCmsReturn }] = yield this.soapClient.call(client, "loginCmsAsync", { in0: signedTRA });
-            const ticket = access_ticket_entity_1.AccessTicket.create((yield parser_1.Parser.xmlToJson(loginCmsReturn))
-                .loginticketresponse);
+            const loginPayload = yield this.parseLoginTicketResponse(loginCmsReturn);
+            const ticket = access_ticket_entity_1.AccessTicket.create(loginPayload);
             if (!this.handleTicket && this.ticketStorage) {
                 yield this.ticketStorage.save(ticket, serviceName);
             }
@@ -107,21 +108,27 @@ class AuthRepository {
      * @returns TRA JSON
      */
     getTRA(serviceName) {
-        const date = new Date();
+        const traTimes = datetime_ref_1.DateTimeRef.now();
         return {
             loginTicketRequest: {
                 $: { version: "1.0" },
                 header: [
                     {
-                        uniqueId: [Math.floor(date.getTime() / 1000)],
-                        generationTime: [new Date(date.getTime() - 600000).toISOString()],
-                        expirationTime: [new Date(date.getTime() + 600000).toISOString()],
+                        uniqueId: [traTimes.wsaaTraUniqueIdSeconds()],
+                        generationTime: [traTimes.wsaaTraGenerationTimeIso()],
+                        expirationTime: [traTimes.wsaaTraExpirationTimeIso()],
                     },
                 ],
                 service: [serviceName],
             },
         };
     }
+    parseLoginTicketResponse(loginCmsReturnXml) {
+        return __awaiter(this, void 0, void 0, function* () {
+            const parsed = yield parser_1.Parser.xmlToJson(loginCmsReturnXml);
+            return parsed.loginticketresponse;
+        });
+    }
     /**
      * Sign TRA (Token Request Authorization) XML
      * @param traXml TRA XML to sign

package/lib/infrastructure/outbound/adapters/repositories/auth/auth.repository.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"auth.repository.js","sourceRoot":"","sources":["../../../../../../src/infrastructure/outbound/adapters/repositories/auth/auth.repository.ts"],"names":[],"mappings":";;;;;;;;;;;;AACA,gFAG+C;AAE/C,yDAAsD;AACtD,qEAAiE;AACjE,iEAAgE;AAMhE,6FAAwF;AACxF,6FAAyF;AAIzF,wDAAoD;AACpD,yDAAoE;AAEpE,MAAa,cAAc;IAUzB,YAAY,MAA4B;;QACtC,IAAI,CAAC,UAAU;YACb,MAAA,MAAM,CAAC,UAAU,mCACjB,IAAI,wBAAU,CAAC,MAAA,MAAM,CAAC,aAAa,mCAAI,mCAAuB,CAAC,CAAC;QAClE,IAAI,CAAC,IAAI,GAAG,MAAM,CAAC,IAAI,CAAC;QACxB,IAAI,CAAC,GAAG,GAAG,MAAM,CAAC,GAAG,CAAC;QACtB,IAAI,CAAC,UAAU,GAAG,MAAA,MAAM,CAAC,UAAU,mCAAI,KAAK,CAAC;QAC7C,IAAI,CAAC,YAAY,GAAG,MAAA,MAAM,CAAC,YAAY,mCAAI,KAAK,CAAC;QACjD,IAAI,CAAC,aAAa,GAAG,MAAM,CAAC,aAAa,CAAC;QAC1C,IAAI,CAAC,iBAAiB,GAAG,MAAM,CAAC,WAAW,CAAC;IAC9C,CAAC;IAED;;;;OAIG;IACW,yBAAyB,CACrC,WAAmB;;YAEnB,IAAI,CAAC,IAAI,CAAC,aAAa;gBAAE,OAAO,IAAI,CAAC;YAErC,MAAM,cAAc,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;YACjE,IAAI,cAAc,IAAI,CAAC,cAAc,CAAC,SAAS,EAAE;gBAAE,OAAO,cAAc,CAAC;YAEzE,OAAO,IAAI,CAAC;QACd,CAAC;KAAA;IAED;;;;OAIG;IACG,KAAK,CAAC,WAAmB;;YAC7B,4EAA4E;YAC5E,IAAI,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC;gBAChD,OAAO,mCAAY,CAAC,MAAM,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;YACrD,CAAC;YAED,MAAM,cAAc,GAAG,MAAM,IAAI,CAAC,yBAAyB,CAAC,WAAW,CAAC,CAAC;YACzE,IAAI,cAAc;gBAAE,OAAO,cAAc,CAAC;YAE1C,OAAO,IAAI,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;QACxC,CAAC;KAAA;IAED;;OAEG;IACW,gBAAgB;;YAC5B,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,UAAU,CAAC,YAAY,CAC/C,6BAAY,CAAC,IAAI,EACjB,EAAE,YAAY,EAAE,IAAI,EAAE,CACvB,CAAC;YACF,IAAI,CAAC,UAAU,CAAC,WAAW,CACzB,MAAM,EACN,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,8BAAa,CAAC,IAAI,CAAC,CAAC,CAAC,8BAAa,CAAC,SAAS,CAC/D,CAAC;YACF,OAAO,MAAM,CAAC;QAChB,CAAC;KAAA;IAED;;;;OAIG;IACG,YAAY,CAAC,WAAmB;;YACpC,MAAM,cAAc,GAAG,MAAM,IAAI,CAAC,yBAAyB,CAAC,WAAW,CAAC,CAAC;YACzE,IAAI,cAAc;gBAAE,OAAO,cAAc,CAAC;YAE1C,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,CAC5B,MAAM,eAAM,CAAC,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,CACjD,CAAC;YAEF,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,gBAAgB,EAAE,CAAC;YAE7C,MAAM,CAAC,EAAE,cAAc,EAAE,CAAC,GAAG,MAAM,IAAI,CAAC,UAAU,CAAC,IAAI,CAErD,MAAM,EAAE,eAAe,EAAE,EAAE,GAAG,EAAE,SAAS,EAAE,CAAC,CAAC;YAE/C,MAAM,YAAY,GAAG,MAAM,IAAI,CAAC,wBAAwB,CAAC,cAAc,CAAC,CAAC;YACzE,MAAM,MAAM,GAAG,mCAAY,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC;YAEjD,IAAI,CAAC,IAAI,CAAC,YAAY,IAAI,IAAI,CAAC,aAAa,EAAE,CAAC;gBAC7C,MAAM,IAAI,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;YACrD,CAAC;YAED,OAAO,MAAM,CAAC;QAChB,CAAC;KAAA;IAED;;;;;OAKG;IACH,aAAa,CAAC,MAAoB,EAAE,IAAY;QAC9C,OAAO,MAAM,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;IACtC,CAAC;IAED;;;;OAIG;IACK,MAAM,CAAC,WAAmB;QAChC,MAAM,QAAQ,GAAG,0BAAW,CAAC,GAAG,EAAE,CAAC;QACnC,OAAO;YACL,kBAAkB,EAAE;gBAClB,CAAC,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE;gBACrB,MAAM,EAAE;oBACN;wBACE,QAAQ,EAAE,CAAC,QAAQ,CAAC,sBAAsB,EAAE,CAAC;wBAC7C,cAAc,EAAE,CAAC,QAAQ,CAAC,wBAAwB,EAAE,CAAC;wBACrD,cAAc,EAAE,CAAC,QAAQ,CAAC,wBAAwB,EAAE,CAAC;qBACtD;iBACF;gBACD,OAAO,EAAE,CAAC,WAAW,CAAC;aACvB;SACF,CAAC;IACJ,CAAC;IAEa,wBAAwB,CACpC,iBAAyB;;YAEzB,MAAM,MAAM,GACV,MAAM,eAAM,CAAC,SAAS,CAAsB,iBAAiB,CAAC,CAAC;YACjE,OAAO,MAAM,CAAC,mBAAmB,CAAC;QACpC,CAAC;KAAA;IAED;;;;OAIG;IACK,OAAO,CAAC,MAAc;QAC5B,MAAM,MAAM,GAAG,IAAI,yBAAY,CAAC,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,GAAG,CAAC,CAAC;QACrD,OAAO,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAC7B,CAAC;CACF;AApJD,wCAoJC"}

package/lib/infrastructure/outbound/adapters/repositories/auth/index.d.ts

@@ -0,0 +1 @@
+export * from "./auth.repository";

package/lib/infrastructure/outbound/adapters/repositories/auth/index.js

@@ -0,0 +1,18 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __exportStar = (this && this.__exportStar) || function(m, exports) {
+    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+__exportStar(require("./auth.repository"), exports);
+//# sourceMappingURL=index.js.map

package/lib/infrastructure/outbound/adapters/repositories/auth/index.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../src/infrastructure/outbound/adapters/repositories/auth/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;AAAA,oDAAkC"}

package/lib/infrastructure/outbound/adapters/{electronic-billing → repositories/electronic-billing}/electronic-billing-repository.d.ts

@@ -1,21 +1,30 @@
-/**
- * Electronic Billing Repository
- * Implements IElectronicBillingRepositoryPort for AFIP/ARCA Electronic Billing
- */
-import { IElectronicBillingRepositoryPort } from "../../../../application/ports/electronic-billing/electronic-billing-repository.port";
-import { BaseSoapRepository } from "../soap/base-soap-repository";
-import { BaseSoapRepositoryConstructorConfig } from "../../../outbound/ports/soap/soap-repository.types";
-import { Voucher } from "../../../../domain/entities/voucher.entity";
-import { ICreateVoucherResult } from "../../../../application/types/result.types";
-import { ServerStatusDto, SalesPointsResultDto, LastVoucherResultDto, VoucherInfoResultDto, VoucherTypesResultDto, ConceptTypesResultDto, DocumentTypesResultDto, AliquotTypesResultDto, CurrencyTypesResultDto, OptionalTypesResultDto, TaxTypesResultDto, IvaReceptorTypesResultDto, CaeaResultDto, CaeaUsageResultDto, CaeaNoMovementResultDto, CountriesResultDto, ActivitiesResultDto, QuotationResultDto, MaxRecordsResultDto } from "../../../../application/dto/electronic-billing.dto";
+import { IElectronicBillingRepositoryPort } from "../../../../../application/ports/electronic-billing/electronic-billing-repository.port";
+import { BaseSoapRepository } from "../../soap/base-soap-repository";
+import { BaseSoapRepositoryConstructorConfig } from "../../../../types/soap-repository.types";
+import { Voucher } from "../../../../../domain/entities/voucher.entity";
+import { ICreateVoucherResult } from "../../../../../application/types/result.types";
+import { ServerStatusDto, SalesPointsResultDto, LastVoucherResultDto, VoucherInfoResultDto, VoucherTypesResultDto, ConceptTypesResultDto, DocumentTypesResultDto, AliquotTypesResultDto, CurrencyTypesResultDto, OptionalTypesResultDto, TaxTypesResultDto, IvaReceptorTypesResultDto, CaeaResultDto, CaeaUsageResultDto, CaeaNoMovementResultDto, CountriesResultDto, ActivitiesResultDto, QuotationResultDto, MaxRecordsResultDto } from "../../../../../application/dto/electronic-billing.dto";
 export declare class ElectronicBillingRepository extends BaseSoapRepository implements IElectronicBillingRepositoryPort {
     private serviceClient?;
     constructor(config: BaseSoapRepositoryConstructorConfig);
     /**
-     * Get or create SOAP client with authentication proxy
-     * Creates SOAP 1.1 or 1.2 client based on useSoap12 configuration
+     * Invalidate the cached SOAP client, forcing re-creation on next call.
+     * Call this when the auth token is refreshed.
+     */
+    invalidateClient(): void;
+    /**
+     * Get or create SOAP client with authentication proxy.
+     * Creates SOAP 1.1 or 1.2 client based on useSoap12 configuration.
      */
     private getClient;
+    /**
+     * Map SOAP Errors to the DTO format. Calls mapSoapErrors only once.
+     */
+    private mapErrors;
+    /**
+     * Build the common det request object shared by createVoucher and informCaeaUsage.
+     */
+    private buildVoucherDetRequest;
     getServerStatus(): Promise<ServerStatusDto>;
     getSalesPoints(): Promise<SalesPointsResultDto>;
     getLastVoucher(salesPoint: number, voucherType: number): Promise<LastVoucherResultDto>;

package/lib/infrastructure/outbound/adapters/{electronic-billing → repositories/electronic-billing}/electronic-billing-repository.js

@@ -10,18 +10,27 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ElectronicBillingRepository = void 0;
-const base_soap_repository_1 = require("../soap/base-soap-repository");
-const service_names_enum_1 = require("../../../outbound/ports/soap/enums/service-names.enum");
-const wsdl_path_enum_1 = require("../../../outbound/ports/soap/enums/wsdl-path.enum");
-const endpoints_enum_1 = require("../../../outbound/ports/soap/enums/endpoints.enum");
-const soap_to_dto_mapper_1 = require("../../../utils/soap-to-dto.mapper");
+const base_soap_repository_1 = require("../../soap/base-soap-repository");
+const service_names_enum_1 = require("../../../../constants/service-names.enum");
+const wsdl_path_enum_1 = require("../../../../outbound/ports/soap/enums/wsdl-path.enum");
+const endpoints_enum_1 = require("../../../../outbound/ports/soap/enums/endpoints.enum");
+const mappers_1 = require("../../../../mappers");
+const afip_errors_1 = require("../../../../utils/afip-errors");
 class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapRepository {
     constructor(config) {
         super(config);
     }
     /**
-     * Get or create SOAP client with authentication proxy
-     * Creates SOAP 1.1 or 1.2 client based on useSoap12 configuration
+     * Invalidate the cached SOAP client, forcing re-creation on next call.
+     * Call this when the auth token is refreshed.
+     */
+    invalidateClient() {
+        this.serviceClient = undefined;
+    }
+    // ── Private helpers ────────────────────────────────────────────────────────
+    /**
+     * Get or create SOAP client with authentication proxy.
+     * Creates SOAP 1.1 or 1.2 client based on useSoap12 configuration.
      */
     getClient() {
         return __awaiter(this, void 0, void 0, function* () {
@@ -34,20 +43,7 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const endpoint = this.production
                 ? endpoints_enum_1.EndpointsEnum.WSFEV1
                 : endpoints_enum_1.EndpointsEnum.WSFEV1_TEST;
-            let client;
-            let soapVersion;
-            if (this.useSoap12) {
-                client = yield this.soapClient.createClient(wsdlName, {
-                    forceSoap12Headers: true,
-                });
-                soapVersion = endpoints_enum_1.SoapServiceVersion.ServiceSoap12;
-            }
-            else {
-                client = yield this.soapClient.createClient(wsdlName, {
-                    forceSoap12Headers: false,
-                });
-                soapVersion = endpoints_enum_1.SoapServiceVersion.ServiceSoap;
-            }
+            const { client, soapVersion } = yield this.createSoapClient(wsdlName);
             this.soapClient.setEndpoint(client, endpoint);
             this.serviceClient = this.createAuthenticatedProxy(client, {
                 serviceName: service_names_enum_1.ServiceNamesEnum.WSFE,
@@ -57,11 +53,58 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             return this.serviceClient;
         });
     }
+    /**
+     * Map SOAP Errors to the DTO format. Calls mapSoapErrors only once.
+     */
+    mapErrors(errors) {
+        const mapped = (0, mappers_1.mapSoapErrors)(errors);
+        return mapped ? { err: mapped } : undefined;
+    }
+    /**
+     * Build the common det request object shared by createVoucher and informCaeaUsage.
+     */
+    buildVoucherDetRequest(voucherData) {
+        return {
+            Concepto: voucherData.Concepto,
+            DocTipo: voucherData.DocTipo,
+            DocNro: voucherData.DocNro,
+            CbteDesde: voucherData.CbteDesde,
+            CbteHasta: voucherData.CbteHasta,
+            CbteFch: voucherData.CbteFch,
+            ImpTotal: voucherData.ImpTotal,
+            ImpTotConc: voucherData.ImpTotConc,
+            ImpNeto: voucherData.ImpNeto,
+            ImpOpEx: voucherData.ImpOpEx,
+            ImpIVA: voucherData.ImpIVA,
+            ImpTrib: voucherData.ImpTrib,
+            FchServDesde: voucherData.FchServDesde,
+            FchServHasta: voucherData.FchServHasta,
+            FchVtoPago: voucherData.FchVtoPago,
+            MonId: voucherData.MonId,
+            MonCotiz: voucherData.MonCotiz,
+            CanMisMonExt: voucherData.CanMisMonExt,
+            CondicionIVAReceptorId: voucherData.CondicionIVAReceptorId,
+            Tributos: voucherData.Tributos
+                ? { Tributo: voucherData.Tributos }
+                : undefined,
+            Iva: voucherData.Iva ? { AlicIva: voucherData.Iva } : undefined,
+            CbtesAsoc: voucherData.CbtesAsoc
+                ? { CbteAsoc: voucherData.CbtesAsoc }
+                : undefined,
+            Compradores: voucherData.Compradores
+                ? { Comprador: voucherData.Compradores }
+                : undefined,
+            Opcionales: voucherData.Opcionales
+                ? { Opcional: voucherData.Opcionales }
+                : undefined,
+        };
+    }
+    // ── Public repository methods ──────────────────────────────────────────────
     getServerStatus() {
         return __awaiter(this, void 0, void 0, function* () {
             const client = yield this.getClient();
             const [output] = yield client.FEDummyAsync({});
-            return (0, soap_to_dto_mapper_1.mapServerStatus)(output.FEDummyResult);
+            return (0, mappers_1.mapServerStatus)(output.FEDummyResult);
         });
     }
     getSalesPoints() {
@@ -71,11 +114,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetPtosVentaResult;
             return {
                 resultGet: {
-                    ptoVenta: (0, soap_to_dto_mapper_1.mapSalesPoints)(result),
+                    ptoVenta: (0, mappers_1.mapSalesPoints)(result),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -87,49 +128,15 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
                 CbteTipo: voucherType,
             });
             const result = output.FECompUltimoAutorizadoResult;
-            return Object.assign(Object.assign({}, (0, soap_to_dto_mapper_1.mapLastVoucher)(result)), { errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined });
+            return Object.assign(Object.assign({}, (0, mappers_1.mapLastVoucher)(result)), { errors: this.mapErrors(result.Errors) });
         });
     }
     createVoucher(voucher) {
         return __awaiter(this, void 0, void 0, function* () {
-            var _a, _b, _c, _d;
+            var _a, _b;
             const client = yield this.getClient();
             const voucherData = voucher.toDTO();
-            const detRequest = {
-                Concepto: voucherData.Concepto,
-                DocTipo: voucherData.DocTipo,
-                DocNro: voucherData.DocNro,
-                CbteDesde: voucherData.CbteDesde,
-                CbteHasta: voucherData.CbteHasta,
-                CbteFch: voucherData.CbteFch,
-                ImpTotal: voucherData.ImpTotal,
-                ImpTotConc: voucherData.ImpTotConc,
-                ImpNeto: voucherData.ImpNeto,
-                ImpOpEx: voucherData.ImpOpEx,
-                ImpIVA: voucherData.ImpIVA,
-                ImpTrib: voucherData.ImpTrib,
-                FchServDesde: voucherData.FchServDesde,
-                FchServHasta: voucherData.FchServHasta,
-                FchVtoPago: voucherData.FchVtoPago,
-                MonId: voucherData.MonId,
-                MonCotiz: voucherData.MonCotiz,
-                CondicionIVAReceptorId: voucherData.CondicionIVAReceptorId,
-                Tributos: voucherData.Tributos
-                    ? { Tributo: voucherData.Tributos }
-                    : undefined,
-                Iva: voucherData.Iva ? { AlicIva: voucherData.Iva } : undefined,
-                CbtesAsoc: voucherData.CbtesAsoc
-                    ? { CbteAsoc: voucherData.CbtesAsoc }
-                    : undefined,
-                Compradores: voucherData.Compradores
-                    ? { Comprador: voucherData.Compradores }
-                    : undefined,
-                Opcionales: voucherData.Opcionales
-                    ? { Opcional: voucherData.Opcionales }
-                    : undefined,
-            };
+            const detRequest = this.buildVoucherDetRequest(voucherData);
             const typedDetRequest = this.useSoap12
                 ? detRequest
                 : detRequest;
@@ -147,10 +154,6 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             });
             const { FECAESolicitarResult } = output;
             const detResponse = (_b = (_a = FECAESolicitarResult.FeDetResp) === null || _a === void 0 ? void 0 : _a.FECAEDetResponse) === null || _b === void 0 ? void 0 : _b[0];
-            if (((_d = (_c = FECAESolicitarResult.Errors) === null || _c === void 0 ? void 0 : _c.Err) === null || _d === void 0 ? void 0 : _d.length) && this.logger) {
-                const errorMessages = FECAESolicitarResult.Errors.Err.map((e) => `${e.Code}: ${e.Msg}`).join(", ");
-                this.logger.error(`Error creating voucher: ${errorMessages}`);
-            }
             const cae = (detResponse === null || detResponse === void 0 ? void 0 : detResponse.Resultado) === "A" ? detResponse.CAE || "" : "";
             const caeFchVto = (detResponse === null || detResponse === void 0 ? void 0 : detResponse.Resultado) === "A" ? detResponse.CAEFchVto || "" : "";
             return {
@@ -172,17 +175,14 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
                     },
                 });
                 const result = output.FECompConsultarResult;
-                const voucherInfo = (0, soap_to_dto_mapper_1.mapVoucherInfo)(result);
+                const voucherInfo = (0, mappers_1.mapVoucherInfo)(result);
                 if (!voucherInfo) {
                     return null;
                 }
-                return Object.assign(Object.assign({}, voucherInfo), { errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                        ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                        : undefined });
+                return Object.assign(Object.assign({}, voucherInfo), { errors: this.mapErrors(result.Errors) });
             }
             catch (error) {
-                // Error 602 means voucher not found
-                if ((error === null || error === void 0 ? void 0 : error.code) === 602) {
+                if ((0, afip_errors_1.isAfipNotFoundError)(error)) {
                     return null;
                 }
                 throw error;
@@ -196,11 +196,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposCbteResult;
             return {
                 resultGet: {
-                    cbteTipo: (0, soap_to_dto_mapper_1.mapParameterTypes)(result, "CbteTipo"),
+                    cbteTipo: (0, mappers_1.mapParameterTypes)(result, "CbteTipo"),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -211,11 +209,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposConceptoResult;
             return {
                 resultGet: {
-                    conceptoTipo: (0, soap_to_dto_mapper_1.mapParameterTypes)(result, "ConceptoTipo"),
+                    conceptoTipo: (0, mappers_1.mapParameterTypes)(result, "ConceptoTipo"),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -226,11 +222,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposDocResult;
             return {
                 resultGet: {
-                    docTipo: (0, soap_to_dto_mapper_1.mapParameterTypes)(result, "DocTipo"),
+                    docTipo: (0, mappers_1.mapParameterTypes)(result, "DocTipo"),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -241,11 +235,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposIvaResult;
             return {
                 resultGet: {
-                    ivaTipo: (0, soap_to_dto_mapper_1.mapAliquotTypes)(result),
+                    ivaTipo: (0, mappers_1.mapAliquotTypes)(result),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -256,11 +248,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposMonedasResult;
             return {
                 resultGet: {
-                    moneda: (0, soap_to_dto_mapper_1.mapParameterTypes)(result, "Moneda"),
+                    moneda: (0, mappers_1.mapParameterTypes)(result, "Moneda"),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -271,11 +261,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposOpcionalResult;
             return {
                 resultGet: {
-                    opcionalTipo: (0, soap_to_dto_mapper_1.mapParameterTypes)(result, "OpcionalTipo"),
+                    opcionalTipo: (0, mappers_1.mapParameterTypes)(result, "OpcionalTipo"),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -286,11 +274,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposTributosResult;
             return {
                 resultGet: {
-                    tributoTipo: (0, soap_to_dto_mapper_1.mapParameterTypes)(result, "TributoTipo"),
+                    tributoTipo: (0, mappers_1.mapParameterTypes)(result, "TributoTipo"),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -303,11 +289,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetCondicionIvaReceptorResult;
             return {
                 resultGet: {
-                    condicionIvaReceptor: (0, soap_to_dto_mapper_1.mapIvaReceptorTypes)(result),
+                    condicionIvaReceptor: (0, mappers_1.mapIvaReceptorTypes)(result),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -320,10 +304,8 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             });
             const result = output.FECAEASolicitarResult;
             return {
-                resultGet: result.ResultGet ? (0, soap_to_dto_mapper_1.mapCaea)(result.ResultGet) : undefined,
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                resultGet: result.ResultGet ? (0, mappers_1.mapCaea)(result.ResultGet) : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -336,10 +318,8 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             });
             const result = output.FECAEAConsultarResult;
             return {
-                resultGet: result.ResultGet ? (0, soap_to_dto_mapper_1.mapCaea)(result.ResultGet) : undefined,
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                resultGet: result.ResultGet ? (0, mappers_1.mapCaea)(result.ResultGet) : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -361,9 +341,7 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
                         },
                     ]
                     : undefined,
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -376,10 +354,8 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             });
             const result = output.FECAEASinMovimientoConsultarResult;
             return {
-                resultGet: (0, soap_to_dto_mapper_1.mapCaeaNoMovement)(result),
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                resultGet: (0, mappers_1.mapCaeaNoMovement)(result),
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -388,42 +364,7 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             var _a, _b;
             const client = yield this.getClient();
             const voucherData = voucher.toDTO();
-            const detRequest = {
-                Concepto: voucherData.Concepto,
-                DocTipo: voucherData.DocTipo,
-                DocNro: voucherData.DocNro,
-                CbteDesde: voucherData.CbteDesde,
-                CbteHasta: voucherData.CbteHasta,
-                CbteFch: voucherData.CbteFch,
-                ImpTotal: voucherData.ImpTotal,
-                ImpTotConc: voucherData.ImpTotConc,
-                ImpNeto: voucherData.ImpNeto,
-                ImpOpEx: voucherData.ImpOpEx,
-                ImpIVA: voucherData.ImpIVA,
-                ImpTrib: voucherData.ImpTrib,
-                FchServDesde: voucherData.FchServDesde,
-                FchServHasta: voucherData.FchServHasta,
-                FchVtoPago: voucherData.FchVtoPago,
-                MonId: voucherData.MonId,
-                MonCotiz: voucherData.MonCotiz,
-                CondicionIVAReceptorId: voucherData.CondicionIVAReceptorId,
-                Tributos: voucherData.Tributos
-                    ? { Tributo: voucherData.Tributos }
-                    : undefined,
-                Iva: voucherData.Iva ? { AlicIva: voucherData.Iva } : undefined,
-                CbtesAsoc: voucherData.CbtesAsoc
-                    ? { CbteAsoc: voucherData.CbtesAsoc }
-                    : undefined,
-                Compradores: voucherData.Compradores
-                    ? { Comprador: voucherData.Compradores }
-                    : undefined,
-                Opcionales: voucherData.Opcionales
-                    ? { Opcional: voucherData.Opcionales }
-                    : undefined,
-                CAEA: caea,
-                PeriodoAsoc: undefined,
-                CbteFchHsGen: undefined,
-            };
+            const detRequest = Object.assign(Object.assign({}, this.buildVoucherDetRequest(voucherData)), { CAEA: caea });
             const typedDetRequest = this.useSoap12
                 ? detRequest
                 : detRequest;
@@ -442,11 +383,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FECAEARegInformativoResult;
             return {
                 resultGet: ((_b = (_a = result.FeDetResp) === null || _a === void 0 ? void 0 : _a.FECAEADetResponse) === null || _b === void 0 ? void 0 : _b[0])
-                    ? (0, soap_to_dto_mapper_1.mapCaeaUsage)(result.FeDetResp.FECAEADetResponse[0])
-                    : undefined,
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
+                    ? (0, mappers_1.mapCaeaUsage)(result.FeDetResp.FECAEADetResponse[0])
                     : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -458,10 +397,8 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             });
             const result = output.FEParamGetCotizacionResult;
             return {
-                resultGet: (0, soap_to_dto_mapper_1.mapQuotation)(result),
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                resultGet: (0, mappers_1.mapQuotation)(result),
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -472,11 +409,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetTiposPaisesResult;
             return {
                 resultGet: {
-                    paisTipo: (0, soap_to_dto_mapper_1.mapCountries)(result),
+                    paisTipo: (0, mappers_1.mapCountries)(result),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -487,11 +422,9 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const result = output.FEParamGetActividadesResult;
             return {
                 resultGet: {
-                    actividadesTipo: (0, soap_to_dto_mapper_1.mapActivities)(result),
+                    actividadesTipo: (0, mappers_1.mapActivities)(result),
                 },
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                errors: this.mapErrors(result.Errors),
             };
         });
     }
@@ -501,10 +434,8 @@ class ElectronicBillingRepository extends base_soap_repository_1.BaseSoapReposit
             const [output] = yield client.FECompTotXRequestAsync({});
             const result = output.FECompTotXRequestResult;
             return {
-                resultGet: (0, soap_to_dto_mapper_1.mapMaxRecords)(result),
-                errors: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors)
-                    ? { err: (0, soap_to_dto_mapper_1.mapSoapErrors)(result.Errors) }
-                    : undefined,
+                resultGet: (0, mappers_1.mapMaxRecords)(result),
+                errors: this.mapErrors(result.Errors),
             };
         });
     }