@arcadialdev/arcality 3.0.2 → 3.0.3

package/src/arcalityClient.mjs

@@ -1,10 +1,10 @@
 // src/arcalityClient.mjs
 // Client for communicating with Arcality Backend
-// Supports arcality.config (primary) and .env (fallback)
-// Includes MOCK MODE for development without backend
-import fs from 'node:fs';
-import path from 'node:path';
-import { getApiKey, getApiUrl, CONFIG_DIR } from './configLoader.mjs';
+// Supports arcality.config (primary) and .env (fallback)
+import fs from 'node:fs';
+import path from 'node:path';
+import { getApiKey, getApiUrl, CONFIG_DIR } from './configLoader.mjs';
+import { isRealProjectId } from './configManager.mjs';
 
 // ── Backend config (internal, not user-configurable) ──
 const DAILY_MISSION_LIMIT = 35;
@@ -97,11 +97,11 @@ function getEffectiveApiKey() {
  * Gets the effective Project ID.
  * Priority: arcality.config > ARCALITY_PROJECT_ID env var
  */
-function loadProjectId() {
-    const localConfig = loadArcalityConfig();
-    if (localConfig?.projectId) return localConfig.projectId;
-    return process.env.ARCALITY_PROJECT_ID || null;
-}
+function loadProjectId() {
+    const localConfig = loadArcalityConfig();
+    const projectId = localConfig?.projectId || process.env.ARCALITY_PROJECT_ID || null;
+    return isRealProjectId(projectId) ? projectId : null;
+}
 
 // ═══════════════════════════════════════════════════════
 // PUBLIC API
@@ -126,11 +126,11 @@ export async function validateApiKey() {
     const key = getEffectiveApiKey();
 
     if (!key) {
-        return { valid: false, error: 'no_api_key', mode: 'mock' };
+        return { valid: false, error: 'no_api_key', mode: 'live' };
     }
 
     if (!key.startsWith('arc_')) {
-        return { valid: false, error: 'invalid_format', mode: 'mock' };
+        return { valid: false, error: 'invalid_format', mode: 'live' };
     }
 
     const apiBase = getEffectiveApiBase();
@@ -162,20 +162,12 @@ export async function validateApiKey() {
             return { ...data, valid: true, mode: 'live' };
         } catch (e) {
             const reason = e?.name === 'AbortError' ? 'timeout (5s)' : (e?.message || 'unknown');
-            console.warn(`⚠️  Backend not available (${apiBase}): ${reason}. Using local mode.`);
+            console.warn(`Backend not available (${apiBase}): ${reason}.`);
+            return { valid: false, error: 'backend_unavailable', mode: 'live', reason };
         }
     }
 
-    // ── MOCK mode: No backend ──
-    const dailyUsed = getLocalDailyUsage();
-    return {
-        valid: true,
-        mode: 'mock',
-        plan: 'internal',
-        daily_used: dailyUsed,
-        daily_limit: DAILY_MISSION_LIMIT,
-        remaining: Math.max(0, DAILY_MISSION_LIMIT - dailyUsed)
-    };
+    return { valid: false, error: 'backend_unavailable', mode: 'live' };
 }
 
 /**
@@ -192,7 +184,10 @@ export async function startMission(prompt, targetUrl) {
     // ── LIVE mode ──
     if (apiBase) {
         try {
-            const projectId = process.env.ARCALITY_PROJECT_ID || loadArcalityConfig()?.projectId;
+            const projectId = process.env.ARCALITY_PROJECT_ID || loadArcalityConfig()?.projectId;
+            if (!isRealProjectId(projectId)) {
+                return { allowed: false, error: 'no_project_id' };
+            }
 
             const controller = new AbortController();
             const timeout = setTimeout(() => controller.abort(), 5000);
@@ -221,38 +216,13 @@ export async function startMission(prompt, targetUrl) {
             return { allowed: true, ...(await res.json()) };
         } catch (e) {
             const reason = e?.name === 'AbortError' ? 'timeout (5s)' : (e?.message || 'unknown');
-            console.warn(`⚠️  startMission failed (${apiBase}): ${reason}. Falling back to mock mode.`);
+            console.warn(`startMission failed (${apiBase}): ${reason}.`);
+            return { allowed: false, error: 'backend_unavailable', reason };
         }
     }
 
-    // ── MOCK mode ──
-    const dailyUsed = getLocalDailyUsage();
-
-    if (dailyUsed >= DAILY_MISSION_LIMIT) {
-        const tomorrow = new Date();
-        tomorrow.setDate(tomorrow.getDate() + 1);
-        tomorrow.setHours(0, 0, 0, 0);
-
-        return {
-            allowed: false,
-            error: 'mission_limit_exceeded',
-            daily_used: dailyUsed,
-            daily_limit: DAILY_MISSION_LIMIT,
-            remaining: 0,
-            resets_at: tomorrow.toISOString()
-        };
-    }
-
-    const newCount = incrementLocalUsage();
-    return {
-        allowed: true,
-        mode: 'mock',
-        mission_id: `mock_${Date.now().toString(36)}`,
-        daily_used: newCount,
-        daily_limit: DAILY_MISSION_LIMIT,
-        remaining: DAILY_MISSION_LIMIT - newCount
-    };
-}
+    return { allowed: false, error: 'backend_unavailable' };
+}
 
 /**
  * Fetches missions from the backend API.
@@ -264,11 +234,10 @@ export async function fetchMissions(projectId, tags) {
     const key = getEffectiveApiKey();
     if (!key) return { success: false, error: 'no_api_key', missions: [] };
 
-    const apiBase = getEffectiveApiBase();
-    if (!apiBase) {
-        // MOCK MODE: Return empty array for now since there's no backend
-        return { success: true, mode: 'mock', missions: [] };
-    }
+    const apiBase = getEffectiveApiBase();
+    if (!apiBase) {
+        return { success: false, error: 'backend_unavailable', missions: [] };
+    }
 
     try {
         const url = new URL(`${apiBase}/api/v1/projects/${projectId}/missions`);
@@ -308,9 +277,10 @@ export async function fetchMissions(projectId, tags) {
  * @param {'success'|'failed'|'cancelled'} result
  * @param {object} usage - Optional usage statistics directly from the AI
  */
-export async function endMission(missionId, result, usage = null, failReason = null, reportUrl = null, failReasoning = null) {
-    const apiBase = getEffectiveApiBase();
-    if (!apiBase || !missionId) return { ok: true };
+export async function endMission(missionId, result, usage = null, failReason = null, reportUrl = null, failReasoning = null) {
+    const apiBase = getEffectiveApiBase();
+    if (!apiBase) return { ok: false, error: 'backend_unavailable' };
+    if (!missionId) return { ok: false, error: 'no_mission_id' };
 
     const key = getEffectiveApiKey();
     try {
@@ -356,7 +326,7 @@ export async function createAdoTask(title, description) {
     }
 
     const projectId = loadProjectId();
-    if (!projectId) {
+    if (!isRealProjectId(projectId)) {
         if (process.env.DEBUG) console.log(`[ADO] No hay Project ID configurado. Omitiendo creación de Task en Azure DevOps.`);
         return { success: false, error: 'no_project_id' };
     }
@@ -415,7 +385,7 @@ export async function createAdoTask(title, description) {
  */
 export async function getEvidenceSasToken(missionId, projectId) {
     const apiBase = getEffectiveApiBase();
-    if (!apiBase || !missionId) return null;
+    if (!apiBase || !missionId || !isRealProjectId(projectId)) return null;
 
     const key = getEffectiveApiKey();
     if (!key) return null;

package/src/configLoader.mjs

@@ -1,9 +1,10 @@
 // src/configLoader.mjs
 // Configuration loader — supports arcality.config (primary) and .env / global config (fallback)
-import fs from 'node:fs';
-import path from 'node:path';
-import os from 'node:os';
-import dotenv from 'dotenv';
+import fs from 'node:fs';
+import path from 'node:path';
+import os from 'node:os';
+import dotenv from 'dotenv';
+import { isRealProjectId } from './configManager.mjs';
 
 dotenv.config();
 
@@ -58,17 +59,22 @@ export function loadConfig() {
         ARCALITY_PROJECT_ID: localConfig?.projectId || process.env.ARCALITY_PROJECT_ID,
     };
 
-    if (!config.ARCALITY_API_KEY) {
-        throw new Error('ARCALITY_API_KEY is not defined. Run `arcality init` or set it in your .env file.');
-    }
-
-    return config;
-}
+    if (!config.ARCALITY_API_KEY) {
+        throw new Error('ARCALITY_API_KEY is not defined. Run `arcality init` or set it in your .env file.');
+    }
+
+    if (!isRealProjectId(config.ARCALITY_PROJECT_ID)) {
+        throw new Error('ARCALITY_PROJECT_ID is not connected to a real Arcality project. Run `arcality init`.');
+    }
+
+    return config;
+}
 
-export function loadProjectId() {
-    const localConfig = loadLocalArcalityConfig();
-    return localConfig?.projectId || process.env.ARCALITY_PROJECT_ID;
-}
+export function loadProjectId() {
+    const localConfig = loadLocalArcalityConfig();
+    const projectId = localConfig?.projectId || process.env.ARCALITY_PROJECT_ID;
+    return isRealProjectId(projectId) ? projectId : null;
+}
 
 
 /**
@@ -127,35 +133,25 @@ export function getApiKey() {
     return { key: null, source: 'none' };
 }
 
-/**
- * Loads additional secrets (like Anthropic) from global config
- */
-export function setupProcessEnv() {
-    const config = loadGlobalConfig();
-    if (!config) return;
-
-    // Load Arcality API Key
-    getApiKey();
-
-    // Load Anthropic API Key if not already in env
-    if (config.anthropic_api_key && !process.env.ANTHROPIC_API_KEY) {
-        process.env.ANTHROPIC_API_KEY = config.anthropic_api_key;
-    }
-
-    // Load default model if exists
-    if (config.model && !process.env.CLAUDE_MODEL) {
-        process.env.CLAUDE_MODEL = config.model;
-    }
-
-    // Also inject arcality.config values into process.env for backward compat
-    const localConfig = loadLocalArcalityConfig();
+/**
+ * Loads supported Arcality runtime values into process.env.
+ */
+export function setupProcessEnv() {
+    const config = loadGlobalConfig();
+    if (!config) return;
+
+    // Load Arcality API Key
+    getApiKey();
+
+    // Also inject arcality.config values into process.env for backward compat
+    const localConfig = loadLocalArcalityConfig();
     if (localConfig) {
         if (localConfig.apiKey && !process.env.ARCALITY_API_KEY) {
             process.env.ARCALITY_API_KEY = localConfig.apiKey;
         }
-        if (localConfig.projectId && !process.env.ARCALITY_PROJECT_ID) {
-            process.env.ARCALITY_PROJECT_ID = localConfig.projectId;
-        }
+        if (isRealProjectId(localConfig.projectId) && !process.env.ARCALITY_PROJECT_ID) {
+            process.env.ARCALITY_PROJECT_ID = localConfig.projectId;
+        }
         if (localConfig.project?.baseUrl && !process.env.BASE_URL) {
             process.env.BASE_URL = localConfig.project.baseUrl;
         }

package/src/configManager.mjs

@@ -5,7 +5,16 @@
 import fs from 'node:fs';
 import path from 'node:path';
 
-const CONFIG_FILENAME = 'arcality.config';
+const CONFIG_FILENAME = 'arcality.config';
+
+export function isRealProjectId(projectId) {
+    const id = String(projectId || '').trim();
+    if (!id) return false;
+    if (id === 'undefined' || id === 'null') return false;
+    if (/^(local|mock)_/i.test(id)) return false;
+    if (/^0{8}-0{4}-0{4}-0{4}-0{12}$/i.test(id)) return false;
+    return true;
+}
 
 /**
  * Resolves the path to arcality.config in the project root.
@@ -59,21 +68,21 @@ export function saveProjectConfig(config, projectRoot) {
  * @param {ArcalityConfig} config
  * @returns {{ valid: boolean, missing: string[] }}
  */
-export function validateConfig(config) {
-    const missing = [];
+export function validateConfig(config) {
+    const missing = [];
 
     if (!config) {
         return { valid: false, missing: ['arcality.config file'] };
     }
 
-    if (!config.apiKey) missing.push('apiKey');
-    if (!config.projectId) missing.push('projectId');
-    if (!config.project?.baseUrl) missing.push('project.baseUrl');
-    if (!config.auth?.username) missing.push('auth.username');
-    if (!config.auth?.password) missing.push('auth.password');
-
-    return { valid: missing.length === 0, missing };
-}
+    if (!config.apiKey) missing.push('apiKey');
+    if (!isRealProjectId(config.projectId)) missing.push('projectId');
+    if (!config.project?.baseUrl) missing.push('project.baseUrl');
+    if (!config.auth?.username) missing.push('auth.username');
+    if (!config.auth?.password) missing.push('auth.password');
+
+    return { valid: missing.length === 0, missing };
+}
 
 /**
  * Creates a fresh arcality.config structure.
@@ -84,30 +93,30 @@ export function createConfig({
     apiKey,
     organizationId,
     projectId,
-    projectName,
-    baseUrl,
-    frameworkDetected,
-    username,
-    password,
-    arcalityVersion,
-    yamlOutputDir = './arcality',
-}) {
-    return {
+    projectName,
+    baseUrl,
+    frameworkDetected,
+    username,
+    password,
+    arcalityVersion,
+    yamlOutputDir = './arcality',
+}) {
+    return {
         version: '1',
         apiKey,
         organizationId: organizationId || null,
         projectId,
         project: {
             name: projectName,
-            baseUrl,
-            frameworkDetected: frameworkDetected || null,
-        },
-        auth: {
-            username,
-            password,
-        },
-        runtime: {
-            yamlOutputDir,
+            baseUrl,
+            frameworkDetected: frameworkDetected || null,
+        },
+        auth: {
+            username,
+            password,
+        },
+        runtime: {
+            yamlOutputDir,
             reuseSuccessfulYamls: true,
             singleConfigurationMode: true,
         },
@@ -122,17 +131,17 @@ export function createConfig({
  * with existing modules that read from process.env.
  * @param {ArcalityConfig} config
  */
-export function injectConfigToEnv(config) {
-    if (!config) return;
+export function injectConfigToEnv(config) {
+    if (!config) return;
 
     if (config.apiKey) process.env.ARCALITY_API_KEY = config.apiKey;
-    if (config.projectId) process.env.ARCALITY_PROJECT_ID = config.projectId;
-    if (config.project?.baseUrl && !process.env.BASE_URL) {
-        process.env.BASE_URL = config.project.baseUrl;
-    }
-    if (config.auth?.username) process.env.LOGIN_USER = config.auth.username;
-    if (config.auth?.password) process.env.LOGIN_PASSWORD = config.auth.password;
-}
+    if (isRealProjectId(config.projectId)) process.env.ARCALITY_PROJECT_ID = config.projectId;
+    if (config.project?.baseUrl && !process.env.BASE_URL) {
+        process.env.BASE_URL = config.project.baseUrl;
+    }
+    if (config.auth?.username) process.env.LOGIN_USER = config.auth.username;
+    if (config.auth?.password) process.env.LOGIN_PASSWORD = config.auth.password;
+}
 
 /**
  * Gets the YAML output directory from config, falling back to default.
@@ -166,7 +175,7 @@ export function ensureYamlOutputDir(config, projectRoot) {
  * @property {string|null} organizationId
  * @property {string} projectId
  * @property {{ name: string, baseUrl: string, frameworkDetected: string|null }} project
- * @property {{ username: string, password: string }} auth
+ * @property {{ username: string, password: string }} auth
  * @property {{ yamlOutputDir: string, reuseSuccessfulYamls: boolean, singleConfigurationMode: boolean }} runtime
  * @property {{ arcalityVersion: string }} meta
  */

package/src/playwrightAssets.mjs

@@ -0,0 +1,27 @@
+import { spawn } from 'node:child_process';
+
+export const PLAYWRIGHT_ASSETS = ['chromium', 'ffmpeg'];
+
+export function getPlaywrightInstallCommand() {
+    return `npx playwright install ${PLAYWRIGHT_ASSETS.join(' ')}`;
+}
+
+export function installPlaywrightAssets({ cwd, stdio = 'inherit' } = {}) {
+    return new Promise((resolve, reject) => {
+        const child = spawn('npx', ['playwright', 'install', ...PLAYWRIGHT_ASSETS], {
+            stdio,
+            shell: true,
+            cwd,
+        });
+
+        child.on('exit', code => {
+            if (code === 0) {
+                resolve();
+                return;
+            }
+
+            reject(new Error(`Playwright install failed with exit code ${code}`));
+        });
+        child.on('error', reject);
+    });
+}

package/src/services/collectiveMemoryService.ts

@@ -16,25 +16,32 @@ const getPid = () => process.env.ARCALITY_PROJECT_ID || '';
 const getOrgId = () => process.env.ARCALITY_ORG_ID;
 const getMissionId = () => process.env.ARCALITY_MISSION_ID || EMPTY_GUID;
 
-const EMPTY_GUID = '00000000-0000-0000-0000-000000000000';
-
-let configWarningLogged = false;
-
-function isConfigured(): boolean {
+const EMPTY_GUID = '00000000-0000-0000-0000-000000000000';
+
+let configWarningLogged = false;
+
+function hasRealProjectId(pid: string): boolean {
+    if (!pid || pid === EMPTY_GUID) return false;
+    if (/^(local|mock)_/i.test(pid)) return false;
+    if (pid === 'undefined' || pid === 'null') return false;
+    return true;
+}
+
+function isConfigured(): boolean {
     const base = getBase();
     const key = getKey();
     const pid = getPid();
     const orgId = getOrgId();
 
-    if (!base || !key || !pid || pid === EMPTY_GUID || !orgId) {
-        if (!configWarningLogged) {
-            const missing = [];
-            if (!base) missing.push('ARCALITY_API_URL');
-            if (!key) missing.push('ARCALITY_API_KEY');
-            if (!pid || pid === EMPTY_GUID) missing.push('ARCALITY_PROJECT_ID');
+    if (!base || !key || !hasRealProjectId(pid) || !orgId) {
+        if (!configWarningLogged) {
+            const missing = [];
+            if (!base) missing.push('ARCALITY_API_URL');
+            if (!key) missing.push('ARCALITY_API_KEY');
+            if (!hasRealProjectId(pid)) missing.push('ARCALITY_PROJECT_ID');
             if (!orgId) missing.push('ARCALITY_ORG_ID');
             
-            console.warn(`[CollectiveMemory] Service disabled. Missing: ${missing.join(', ')}`);
+            if (process.env.DEBUG) console.warn(`[CollectiveMemory] Service disabled. Missing: ${missing.join(', ')}`);
             configWarningLogged = true;
         }
         return false;
@@ -191,8 +198,10 @@ export async function searchPromptPattern(prompt: string, limit: number = 5): Pr
             limit: limit
         };
 
-        console.log(`[PatternSearch] 🔍 Buscando patrones en: ${apiUrl}`);
-        console.log(`[PatternSearch] 📦 Payload: ${JSON.stringify(payload, null, 2)}`);
+        const debugPatternSearch = process.env.DEBUG === 'true' || process.env.ARCALITY_DEBUG === 'true';
+        if (debugPatternSearch) {
+            console.log(`[PatternSearch] POST ${apiUrl} | prompt_chars=${prompt.length} | limit=${limit}`);
+        }
 
         const res = await fetch(apiUrl, {
             method: 'POST',
@@ -204,18 +213,20 @@ export async function searchPromptPattern(prompt: string, limit: number = 5): Pr
         });
 
         if (!res.ok) {
-            console.warn(`[PatternSearch] HTTP ${res.status} from ${apiUrl}`);
-            return [];
-        }
-        const data = await res.json();
-        const results = Array.isArray(data) ? data : (data.matches || data.results || []);
-        console.log(`[PatternSearch] ✅ ${results.length} patrones encontrados.`);
-        return results;
-    } catch (err: any) {
-        console.warn(`[PatternSearch] ⚠️ Error buscando patrones: ${err?.message || 'unknown'}`);
-        return [];
-    }
-}
+            if (debugPatternSearch) console.warn(`[PatternSearch] HTTP ${res.status} from ${apiUrl}`);
+            return [];
+        }
+        const data = await res.json();
+        const results = Array.isArray(data) ? data : (data.matches || data.results || []);
+        if (debugPatternSearch) console.log(`[PatternSearch] ${results.length} patrones encontrados.`);
+        return results;
+    } catch (err: any) {
+        if (process.env.DEBUG === 'true' || process.env.ARCALITY_DEBUG === 'true') {
+            console.warn(`[PatternSearch] Error buscando patrones: ${err?.message || 'unknown'}`);
+        }
+        return [];
+    }
+}
 
 export async function savePromptPattern(patternData: any): Promise<boolean> {
     if (!isConfigured()) return false;

package/tests/_helpers/ArcalityReporter.js

@@ -46,13 +46,16 @@ class ArcalityReporter {
                 fs_1.default.mkdirSync(attachmentsDir, { recursive: true });
             }
             try {
+                let copied = false;
                 if (att.path && fs_1.default.existsSync(att.path)) {
                     fs_1.default.copyFileSync(att.path, destPath);
+                    copied = true;
                 }
                 else if (att.body) {
                     fs_1.default.writeFileSync(destPath, att.body);
+                    copied = true;
                 }
-                return { ...att, path: `attachments/${fileName}` };
+                return copied ? { ...att, path: `attachments/${fileName}` } : att;
             }
             catch (e) {
                 console.error(`Failed to process attachment ${att.name}:`, e);