@arbor-education/design-system.components 4.9.1 → 4.9.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 4.9.2
+
+### Patch Changes
+
+- [#306](https://github.com/arbor-education/design-system.components/pull/306) [`16dd3fb`](https://github.com/arbor-education/design-system.components/commit/16dd3fb0179b03dcd26771fdff8de8107aa90f9f) Thanks [@rickbairstow](https://github.com/rickbairstow)! - MIS-74129 🐛 Fix NaN committed by number cell editor when min or max is omitted
+
 ## 4.9.1
 
 ### Patch Changes

package/dist/components/table/cellEditors/NumberCellEditor.d.ts

@@ -1,8 +1,8 @@
 export type NumberCellEditorProps = {
     value: number | null | undefined;
     onValueChange: (value: number | null) => void;
-    min: number;
-    max: number;
+    min?: number;
+    max?: number;
     step: number;
     disableSpinners: boolean;
 };

package/dist/components/table/cellEditors/NumberCellEditor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"NumberCellEditor.d.ts","sourceRoot":"","sources":["../../../../src/components/table/cellEditors/NumberCellEditor.tsx"],"names":[],"mappings":"AAMA,MAAM,MAAM,qBAAqB,GAAG;IAClC,KAAK,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,CAAC;IACjC,aAAa,EAAE,CAAC,KAAK,EAAE,MAAM,GAAG,IAAI,KAAK,IAAI,CAAC;IAC9C,GAAG,EAAE,MAAM,CAAC;IACZ,GAAG,EAAE,MAAM,CAAC;IACZ,IAAI,EAAE,MAAM,CAAC;IACb,eAAe,EAAE,OAAO,CAAC;CAC1B,CAAC;AAMF,eAAO,MAAM,gBAAgB;YAAW,qBAAqB;;CA6D5D,CAAC"}
+{"version":3,"file":"NumberCellEditor.d.ts","sourceRoot":"","sources":["../../../../src/components/table/cellEditors/NumberCellEditor.tsx"],"names":[],"mappings":"AAMA,MAAM,MAAM,qBAAqB,GAAG;IAClC,KAAK,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,CAAC;IACjC,aAAa,EAAE,CAAC,KAAK,EAAE,MAAM,GAAG,IAAI,KAAK,IAAI,CAAC;IAC9C,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,GAAG,CAAC,EAAE,MAAM,CAAC;IACb,IAAI,EAAE,MAAM,CAAC;IACb,eAAe,EAAE,OAAO,CAAC;CAC1B,CAAC;AAMF,eAAO,MAAM,gBAAgB;YAAW,qBAAqB;;CA6D5D,CAAC"}

package/dist/components/table/cellEditors/NumberCellEditor.js

@@ -3,7 +3,7 @@ import { NumberInput } from '../../formField/inputs/number/NumberInput.js';
 import {} from 'react';
 const clampValue = (value, min, max) => (Math.min(Math.max(value, min), max));
 export const NumberCellEditor = (props) => {
-    const { value, onValueChange, min, max, step, disableSpinners, } = props;
+    const { value, onValueChange, min = -Infinity, max = Infinity, step, disableSpinners, } = props;
     const handleChange = (event) => {
         const nextValue = event.currentTarget.value.trim();
         if (nextValue === '') {

package/dist/components/table/cellEditors/NumberCellEditor.js.map

@@ -1 +1 @@
-{"version":3,"file":"NumberCellEditor.js","sourceRoot":"","sources":["../../../../src/components/table/cellEditors/NumberCellEditor.tsx"],"names":[],"mappings":";AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,gDAAgD,CAAC;AAC7E,OAAO,EAGN,MAAM,OAAO,CAAC;AAWf,MAAM,UAAU,GAAG,CAAC,KAAa,EAAE,GAAW,EAAE,GAAW,EAAE,EAAE,CAAC,CAC9D,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,EAAE,GAAG,CAAC,EAAE,GAAG,CAAC,CACpC,CAAC;AAEF,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAAC,KAA4B,EAAE,EAAE;IAC/D,MAAM,EACJ,KAAK,EACL,aAAa,EACb,GAAG,EACH,GAAG,EACH,IAAI,EACJ,eAAe,GAChB,GAAG,KAAK,CAAC;IAEV,MAAM,YAAY,GAAG,CAAC,KAAoC,EAAE,EAAE;QAC5D,MAAM,SAAS,GAAG,KAAK,CAAC,aAAa,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;QAEnD,IAAI,SAAS,KAAK,EAAE,EAAE,CAAC;YACrB,aAAa,CAAC,IAAI,CAAC,CAAC;YACpB,OAAO;QACT,CAAC;QAED,MAAM,WAAW,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC;QAEtC,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC;YAC/B,aAAa,CAAC,UAAU,CAAC,WAAW,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,CAAC;QACnD,CAAC;IACH,CAAC,CAAC;IAEF,MAAM,aAAa,GAAG,CAAC,KAAsC,EAAE,EAAE;QAC/D,IAAI,KAAK,CAAC,GAAG,KAAK,OAAO,EAAE,CAAC;YAC1B,OAAO;QACT,CAAC;QAED,MAAM,QAAQ,GAAG,KAAK,CAAC,aAAa,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;QAElD,IAAI,QAAQ,KAAK,EAAE,EAAE,CAAC;YACpB,aAAa,CAAC,IAAI,CAAC,CAAC;YACpB,OAAO;QACT,CAAC;QAED,MAAM,WAAW,GAAG,MAAM,CAAC,QAAQ,CAAC,CAAC;QAErC,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC;YAC/B,aAAa,CAAC,UAAU,CAAC,WAAW,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,CAAC;QACnD,CAAC;IACH,CAAC,CAAC;IAEF,OAAO,CACL,cACE,SAAS,EAAC,gCAAgC,YAE1C,KAAC,WAAW,IACV,kBAAkB,EAAC,kCAAkC,EACrD,YAAY,EAAE,KAAK,IAAI,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,EAChD,SAAS,QACT,GAAG,EAAE,GAAG,EACR,GAAG,EAAE,GAAG,EACR,IAAI,EAAE,IAAI,EACV,eAAe,EAAE,eAAe,EAChC,QAAQ,EAAE,YAAY,EACtB,SAAS,EAAE,aAAa,GACxB,GACE,CACP,CAAC;AACJ,CAAC,CAAC;AAEF,gBAAgB,CAAC,WAAW,GAAG,kBAAkB,CAAC"}
+{"version":3,"file":"NumberCellEditor.js","sourceRoot":"","sources":["../../../../src/components/table/cellEditors/NumberCellEditor.tsx"],"names":[],"mappings":";AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,gDAAgD,CAAC;AAC7E,OAAO,EAGN,MAAM,OAAO,CAAC;AAWf,MAAM,UAAU,GAAG,CAAC,KAAa,EAAE,GAAW,EAAE,GAAW,EAAE,EAAE,CAAC,CAC9D,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,EAAE,GAAG,CAAC,EAAE,GAAG,CAAC,CACpC,CAAC;AAEF,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAAC,KAA4B,EAAE,EAAE;IAC/D,MAAM,EACJ,KAAK,EACL,aAAa,EACb,GAAG,GAAG,CAAC,QAAQ,EACf,GAAG,GAAG,QAAQ,EACd,IAAI,EACJ,eAAe,GAChB,GAAG,KAAK,CAAC;IAEV,MAAM,YAAY,GAAG,CAAC,KAAoC,EAAE,EAAE;QAC5D,MAAM,SAAS,GAAG,KAAK,CAAC,aAAa,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;QAEnD,IAAI,SAAS,KAAK,EAAE,EAAE,CAAC;YACrB,aAAa,CAAC,IAAI,CAAC,CAAC;YACpB,OAAO;QACT,CAAC;QAED,MAAM,WAAW,GAAG,MAAM,CAAC,SAAS,CAAC,CAAC;QAEtC,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC;YAC/B,aAAa,CAAC,UAAU,CAAC,WAAW,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,CAAC;QACnD,CAAC;IACH,CAAC,CAAC;IAEF,MAAM,aAAa,GAAG,CAAC,KAAsC,EAAE,EAAE;QAC/D,IAAI,KAAK,CAAC,GAAG,KAAK,OAAO,EAAE,CAAC;YAC1B,OAAO;QACT,CAAC;QAED,MAAM,QAAQ,GAAG,KAAK,CAAC,aAAa,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;QAElD,IAAI,QAAQ,KAAK,EAAE,EAAE,CAAC;YACpB,aAAa,CAAC,IAAI,CAAC,CAAC;YACpB,OAAO;QACT,CAAC;QAED,MAAM,WAAW,GAAG,MAAM,CAAC,QAAQ,CAAC,CAAC;QAErC,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC;YAC/B,aAAa,CAAC,UAAU,CAAC,WAAW,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,CAAC;QACnD,CAAC;IACH,CAAC,CAAC;IAEF,OAAO,CACL,cACE,SAAS,EAAC,gCAAgC,YAE1C,KAAC,WAAW,IACV,kBAAkB,EAAC,kCAAkC,EACrD,YAAY,EAAE,KAAK,IAAI,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,EAChD,SAAS,QACT,GAAG,EAAE,GAAG,EACR,GAAG,EAAE,GAAG,EACR,IAAI,EAAE,IAAI,EACV,eAAe,EAAE,eAAe,EAChC,QAAQ,EAAE,YAAY,EACtB,SAAS,EAAE,aAAa,GACxB,GACE,CACP,CAAC;AACJ,CAAC,CAAC;AAEF,gBAAgB,CAAC,WAAW,GAAG,kBAAkB,CAAC"}

package/dist/components/table/cellEditors/NumberCellEditor.test.d.ts

@@ -0,0 +1,2 @@
+import '@testing-library/jest-dom/vitest';
+//# sourceMappingURL=NumberCellEditor.test.d.ts.map

package/dist/components/table/cellEditors/NumberCellEditor.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"NumberCellEditor.test.d.ts","sourceRoot":"","sources":["../../../../src/components/table/cellEditors/NumberCellEditor.test.tsx"],"names":[],"mappings":"AAGA,OAAO,kCAAkC,CAAC"}

package/dist/components/table/cellEditors/NumberCellEditor.test.js

@@ -0,0 +1,57 @@
+import { jsx as _jsx } from "react/jsx-runtime";
+import { describe, expect, test, vi } from 'vitest';
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import '@testing-library/jest-dom/vitest';
+import { NumberCellEditor } from './NumberCellEditor.js';
+const createProps = (overrides = {}) => ({
+    value: undefined,
+    onValueChange: vi.fn(),
+    step: 1,
+    disableSpinners: true,
+    ...overrides,
+});
+const lastCommittedValue = (onValueChange) => (onValueChange.mock.calls.at(-1)?.[0]);
+describe('NumberCellEditor', () => {
+    test('commits typed numbers unchanged when no min or max is supplied', async () => {
+        const onValueChange = vi.fn();
+        render(_jsx(NumberCellEditor, { ...createProps({ onValueChange }) }));
+        await userEvent.type(screen.getByRole('textbox'), '42');
+        expect(onValueChange).toHaveBeenCalledWith(4);
+        expect(onValueChange).toHaveBeenLastCalledWith(42);
+    });
+    test('commits the typed number on Enter when no min or max is supplied', async () => {
+        const onValueChange = vi.fn();
+        render(_jsx(NumberCellEditor, { ...createProps({ onValueChange }) }));
+        await userEvent.type(screen.getByRole('textbox'), '-1234.5{Enter}');
+        expect(lastCommittedValue(onValueChange)).toBe(-1234.5);
+    });
+    test('clamps to min and leaves values above min unchanged when only min is supplied', async () => {
+        const onValueChange = vi.fn();
+        render(_jsx(NumberCellEditor, { ...createProps({ onValueChange, min: 10 }) }));
+        await userEvent.type(screen.getByRole('textbox'), '5');
+        expect(lastCommittedValue(onValueChange)).toBe(10);
+        await userEvent.clear(screen.getByRole('textbox'));
+        await userEvent.type(screen.getByRole('textbox'), '500');
+        expect(lastCommittedValue(onValueChange)).toBe(500);
+    });
+    test('clamps to max and leaves values below max unchanged when only max is supplied', async () => {
+        const onValueChange = vi.fn();
+        render(_jsx(NumberCellEditor, { ...createProps({ onValueChange, max: 100 }) }));
+        await userEvent.type(screen.getByRole('textbox'), '500');
+        expect(lastCommittedValue(onValueChange)).toBe(100);
+        await userEvent.clear(screen.getByRole('textbox'));
+        await userEvent.type(screen.getByRole('textbox'), '-500');
+        expect(lastCommittedValue(onValueChange)).toBe(-500);
+    });
+    test('clamps out-of-range values when both min and max are supplied', async () => {
+        const onValueChange = vi.fn();
+        render(_jsx(NumberCellEditor, { ...createProps({ onValueChange, min: 0, max: 100 }) }));
+        await userEvent.type(screen.getByRole('textbox'), '-5');
+        expect(lastCommittedValue(onValueChange)).toBe(0);
+        await userEvent.clear(screen.getByRole('textbox'));
+        await userEvent.type(screen.getByRole('textbox'), '250{Enter}');
+        expect(lastCommittedValue(onValueChange)).toBe(100);
+    });
+});
+//# sourceMappingURL=NumberCellEditor.test.js.map

package/dist/components/table/cellEditors/NumberCellEditor.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"NumberCellEditor.test.js","sourceRoot":"","sources":["../../../../src/components/table/cellEditors/NumberCellEditor.test.tsx"],"names":[],"mappings":";AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AACpD,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,SAAS,MAAM,6BAA6B,CAAC;AACpD,OAAO,kCAAkC,CAAC;AAC1C,OAAO,EAAE,gBAAgB,EAA8B,MAAM,uBAAuB,CAAC;AAErF,MAAM,WAAW,GAAG,CAAC,YAA4C,EAAE,EAAyB,EAAE,CAAC,CAAC;IAC9F,KAAK,EAAE,SAAS;IAChB,aAAa,EAAE,EAAE,CAAC,EAAE,EAAE;IACtB,IAAI,EAAE,CAAC;IACP,eAAe,EAAE,IAAI;IACrB,GAAG,SAAS;CACb,CAAC,CAAC;AAEH,MAAM,kBAAkB,GAAG,CAAC,aAAuC,EAAE,EAAE,CAAC,CACtE,aAAa,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CACrC,CAAC;AAEF,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,IAAI,CAAC,gEAAgE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC9B,MAAM,CAAC,KAAC,gBAAgB,OAAK,WAAW,CAAC,EAAE,aAAa,EAAE,CAAC,GAAI,CAAC,CAAC;QAEjE,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,IAAI,CAAC,CAAC;QAExD,MAAM,CAAC,aAAa,CAAC,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC;QAC9C,MAAM,CAAC,aAAa,CAAC,CAAC,wBAAwB,CAAC,EAAE,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAClF,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC9B,MAAM,CAAC,KAAC,gBAAgB,OAAK,WAAW,CAAC,EAAE,aAAa,EAAE,CAAC,GAAI,CAAC,CAAC;QAEjE,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,gBAAgB,CAAC,CAAC;QAEpE,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,+EAA+E,EAAE,KAAK,IAAI,EAAE;QAC/F,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC9B,MAAM,CAAC,KAAC,gBAAgB,OAAK,WAAW,CAAC,EAAE,aAAa,EAAE,GAAG,EAAE,EAAE,EAAE,CAAC,GAAI,CAAC,CAAC;QAE1E,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,GAAG,CAAC,CAAC;QACvD,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAEnD,MAAM,SAAS,CAAC,KAAK,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC,CAAC;QACnD,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,KAAK,CAAC,CAAC;QACzD,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,+EAA+E,EAAE,KAAK,IAAI,EAAE;QAC/F,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC9B,MAAM,CAAC,KAAC,gBAAgB,OAAK,WAAW,CAAC,EAAE,aAAa,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,GAAI,CAAC,CAAC;QAE3E,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,KAAK,CAAC,CAAC;QACzD,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAEpD,MAAM,SAAS,CAAC,KAAK,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC,CAAC;QACnD,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,MAAM,CAAC,CAAC;QAC1D,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,+DAA+D,EAAE,KAAK,IAAI,EAAE;QAC/E,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAC9B,MAAM,CAAC,KAAC,gBAAgB,OAAK,WAAW,CAAC,EAAE,aAAa,EAAE,GAAG,EAAE,CAAC,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,GAAI,CAAC,CAAC;QAEnF,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,IAAI,CAAC,CAAC;QACxD,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAElD,MAAM,SAAS,CAAC,KAAK,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC,CAAC;QACnD,MAAM,SAAS,CAAC,IAAI,CAAC,MAAM,CAAC,SAAS,CAAC,SAAS,CAAC,EAAE,YAAY,CAAC,CAAC;QAChE,MAAM,CAAC,kBAAkB,CAAC,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IACtD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arbor-education/design-system.components",
-  "version": "4.9.1",
+  "version": "4.9.2",
   "description": "The component library for the design system (the baby)",
   "main": "dist/index.js",
   "type": "module",

package/src/components/table/cellEditors/NumberCellEditor.test.tsx

@@ -0,0 +1,74 @@
+import { describe, expect, test, vi } from 'vitest';
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import '@testing-library/jest-dom/vitest';
+import { NumberCellEditor, type NumberCellEditorProps } from './NumberCellEditor.js';
+
+const createProps = (overrides: Partial<NumberCellEditorProps> = {}): NumberCellEditorProps => ({
+  value: undefined,
+  onValueChange: vi.fn(),
+  step: 1,
+  disableSpinners: true,
+  ...overrides,
+});
+
+const lastCommittedValue = (onValueChange: ReturnType<typeof vi.fn>) => (
+  onValueChange.mock.calls.at(-1)?.[0]
+);
+
+describe('NumberCellEditor', () => {
+  test('commits typed numbers unchanged when no min or max is supplied', async () => {
+    const onValueChange = vi.fn();
+    render(<NumberCellEditor {...createProps({ onValueChange })} />);
+
+    await userEvent.type(screen.getByRole('textbox'), '42');
+
+    expect(onValueChange).toHaveBeenCalledWith(4);
+    expect(onValueChange).toHaveBeenLastCalledWith(42);
+  });
+
+  test('commits the typed number on Enter when no min or max is supplied', async () => {
+    const onValueChange = vi.fn();
+    render(<NumberCellEditor {...createProps({ onValueChange })} />);
+
+    await userEvent.type(screen.getByRole('textbox'), '-1234.5{Enter}');
+
+    expect(lastCommittedValue(onValueChange)).toBe(-1234.5);
+  });
+
+  test('clamps to min and leaves values above min unchanged when only min is supplied', async () => {
+    const onValueChange = vi.fn();
+    render(<NumberCellEditor {...createProps({ onValueChange, min: 10 })} />);
+
+    await userEvent.type(screen.getByRole('textbox'), '5');
+    expect(lastCommittedValue(onValueChange)).toBe(10);
+
+    await userEvent.clear(screen.getByRole('textbox'));
+    await userEvent.type(screen.getByRole('textbox'), '500');
+    expect(lastCommittedValue(onValueChange)).toBe(500);
+  });
+
+  test('clamps to max and leaves values below max unchanged when only max is supplied', async () => {
+    const onValueChange = vi.fn();
+    render(<NumberCellEditor {...createProps({ onValueChange, max: 100 })} />);
+
+    await userEvent.type(screen.getByRole('textbox'), '500');
+    expect(lastCommittedValue(onValueChange)).toBe(100);
+
+    await userEvent.clear(screen.getByRole('textbox'));
+    await userEvent.type(screen.getByRole('textbox'), '-500');
+    expect(lastCommittedValue(onValueChange)).toBe(-500);
+  });
+
+  test('clamps out-of-range values when both min and max are supplied', async () => {
+    const onValueChange = vi.fn();
+    render(<NumberCellEditor {...createProps({ onValueChange, min: 0, max: 100 })} />);
+
+    await userEvent.type(screen.getByRole('textbox'), '-5');
+    expect(lastCommittedValue(onValueChange)).toBe(0);
+
+    await userEvent.clear(screen.getByRole('textbox'));
+    await userEvent.type(screen.getByRole('textbox'), '250{Enter}');
+    expect(lastCommittedValue(onValueChange)).toBe(100);
+  });
+});

package/src/components/table/cellEditors/NumberCellEditor.tsx

@@ -7,8 +7,8 @@ import {
 export type NumberCellEditorProps = {
   value: number | null | undefined;
   onValueChange: (value: number | null) => void;
-  min: number;
-  max: number;
+  min?: number;
+  max?: number;
   step: number;
   disableSpinners: boolean;
 };
@@ -21,8 +21,8 @@ export const NumberCellEditor = (props: NumberCellEditorProps) => {
   const {
     value,
     onValueChange,
-    min,
-    max,
+    min = -Infinity,
+    max = Infinity,
     step,
     disableSpinners,
   } = props;