@arbor-education/design-system.components 0.24.0 โ 0.24.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +6 -0
- package/CONTRIBUTING.md +24 -22
- package/package.json +1 -1
- package/src/docs/Contributing.mdx +7 -0
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,11 @@
|
|
|
1
1
|
# Changelog
|
|
2
2
|
|
|
3
|
+
## 0.24.1
|
|
4
|
+
|
|
5
|
+
### Patch Changes
|
|
6
|
+
|
|
7
|
+
- [#201](https://github.com/arbor-education/design-system.components/pull/201) [`96bdfeb`](https://github.com/arbor-education/design-system.components/commit/96bdfebc8dfb69e88ba0bede7102d6688e6d3ef0) Thanks [@angusmglfraser](https://github.com/angusmglfraser)! - FRENDS-90 ๐ Update contributing guidelines to reflect current versioning conventions and notes on proper use of changesets
|
|
8
|
+
|
|
3
9
|
## 0.24.0
|
|
4
10
|
|
|
5
11
|
### Minor Changes
|
package/CONTRIBUTING.md
CHANGED
|
@@ -60,18 +60,18 @@ Format: `{JIRA-TICKET} {gitmoji} {Short, imperative description}`
|
|
|
60
60
|
- Keep it under 72 characters
|
|
61
61
|
|
|
62
62
|
**Common gitmoji:**
|
|
63
|
-
| Emoji | Use for
|
|
64
|
-
|
|
65
|
-
| โจ
|
|
66
|
-
| ๐
|
|
67
|
-
| โป๏ธ
|
|
68
|
-
| ๐
|
|
69
|
-
| ๐งช
|
|
70
|
-
| ๐
|
|
71
|
-
| โฌ๏ธ
|
|
72
|
-
| ๐ง
|
|
73
|
-
| ๐ฅ
|
|
74
|
-
| โฟ๏ธ
|
|
63
|
+
| Emoji | Use for |
|
|
64
|
+
| ----- | ------------------------------ |
|
|
65
|
+
| โจ | New feature |
|
|
66
|
+
| ๐ | Bug fix |
|
|
67
|
+
| โป๏ธ | Refactor (no behaviour change) |
|
|
68
|
+
| ๐ | Styling / visual change |
|
|
69
|
+
| ๐งช | Tests only |
|
|
70
|
+
| ๐ | Documentation |
|
|
71
|
+
| โฌ๏ธ | Dependency upgrade |
|
|
72
|
+
| ๐ง | Config / tooling change |
|
|
73
|
+
| ๐ฅ | Breaking change |
|
|
74
|
+
| โฟ๏ธ | Accessibility improvement |
|
|
75
75
|
|
|
76
76
|
### Description
|
|
77
77
|
|
|
@@ -130,24 +130,16 @@ Run through this checklist yourself before requesting review:
|
|
|
130
130
|
### Hard rules for agents
|
|
131
131
|
|
|
132
132
|
1. **One PR per Jira ticket.** Never combine work from multiple tickets into a single PR, even if the work seems related.
|
|
133
|
-
|
|
134
133
|
2. **Stop and check scope before starting.** Before writing any code, identify the minimal set of files required to complete the task. If you find yourself touching more than ~5 files or ~200 lines, pause and ask the human whether the task should be split.
|
|
135
|
-
|
|
136
134
|
3. **Never bundle refactoring with feature work.** If you notice an opportunity to refactor while implementing a feature, stop. Create a note for the human. Do not refactor in the same PR unless explicitly instructed.
|
|
137
|
-
|
|
138
135
|
4. **Never touch files outside the task scope.** Do not "improve" adjacent code, fix unrelated formatting, or clean up files you didn't need to open to complete the task.
|
|
139
|
-
|
|
140
136
|
5. **Never open a PR with failing tests.** All tests must pass. `yarn test:coverage` must complete with 100% of tests passing.
|
|
141
|
-
|
|
142
137
|
6. **Never open a PR with type errors.** `yarn check-types` must pass cleanly.
|
|
143
|
-
|
|
144
138
|
7. **Write a complete PR description.** Use the template. Answer all four questions. Do not leave sections blank.
|
|
145
|
-
|
|
146
139
|
8. **Warn before generating large changes.** If completing a task would require changes to more than 400 lines of meaningful code or more than 10 files, stop and tell the human before proceeding. Ask whether the task should be broken into smaller pieces.
|
|
147
|
-
|
|
148
|
-
9. **Commit atomically.** Each commit should be a coherent, working unit. Do not commit broken intermediate states.
|
|
149
|
-
|
|
140
|
+
9. **Commit atomically.** Each commit should be a coherent, working unit. Do not commit broken intermediate states, and avoid large commits with a broad scope where possible.
|
|
150
141
|
10. **Ask, don't assume.** When the scope or approach is unclear, ask the human rather than making assumptions that lead to larger-than-expected changes.
|
|
142
|
+
11. **Do not write changeset files yourself.** AI agents have a propensity to directly write their own changeset files, which often hallucinate the structure of the files, or the name of the changeset project, which can result in stray changeset files not being added to the changelog on releases. **All** changeset files **must** be generated by running `yarn changeset`.
|
|
151
143
|
|
|
152
144
|
---
|
|
153
145
|
|
|
@@ -183,6 +175,16 @@ See [CLAUDE.md](./CLAUDE.md) for the definitive reference. In summary:
|
|
|
183
175
|
|
|
184
176
|
---
|
|
185
177
|
|
|
178
|
+
## A Note on Versioning
|
|
179
|
+
|
|
180
|
+
Generally we use semantic versioning (https://semver.org/), however, we are reserving version 1.0.0 for the first wide release of this project. Therefore, in the mean time, we follow the following convention with regards to change levels:
|
|
181
|
+
|
|
182
|
+
- Major version bumps are reserved for the first wide release
|
|
183
|
+
- Minor version bumps are for breaking changes
|
|
184
|
+
- Patch version bumps are for all other changes (including added functionality)
|
|
185
|
+
|
|
186
|
+
---
|
|
187
|
+
|
|
186
188
|
## Resources
|
|
187
189
|
|
|
188
190
|
- [gitmoji reference](https://gitmoji.dev/)
|
package/package.json
CHANGED
|
@@ -205,6 +205,13 @@ Never push directly to `main` โ all work goes through a branch and PR.
|
|
|
205
205
|
- **Under 400 lines** of meaningful code change โ if it's bigger, split it.
|
|
206
206
|
- **Fill in the PR template** โ every section, no placeholders.
|
|
207
207
|
|
|
208
|
+
### Changesets
|
|
209
|
+
|
|
210
|
+
- **Every PR requires a changeset.** These should be generated by running `yarn changeset`, which takes you through a prompt to specify the change level and to give a brief description of your change
|
|
211
|
+
- **Do not let an AI create a changeset file for you.** AI Agents have a propensity to directly write their own changeset files, which often hallucinate the structure of the files, or the name of the changeset project, which can result in stray changeset files not being added to the changelog on releases. Generate **all** changeset files via `yarn changeset`.
|
|
212
|
+
- **Do not use backticks or quotes in your changeset description** - these break the release automation
|
|
213
|
+
- Until we are on v1.0.0 as our first wide release, we are not using proper semver. For the time being, use minor version bumps for breaking changes and patch for all other changes, including new functionality.
|
|
214
|
+
|
|
208
215
|
For the full details and the reasoning behind these rules, see [CONTRIBUTING.md](https://github.com/arbor-education/design-system.components/blob/main/CONTRIBUTING.md) on GitHub.
|
|
209
216
|
|
|
210
217
|
---
|