@aravinthan_p/appnest-engine 1.0.20 → 1.0.22

package/appnest-command-line/validateUtils/lint/lint-utils.js

@@ -2,53 +2,46 @@
 
 const fs = require('fs');
 const path = require('path');
+const js = require('@eslint/js');
+const globals = require('globals');
 
 const SKIP_FOLDERS = ['node_modules', 'dist'];
 const BACKEND_EXTENSIONS = ['.js'];
 const FRONTEND_EXTENSIONS = ['.js', '.jsx', '.css'];
 
-const NODE_GLOBALS = {
-  require: 'readonly',
-  module: 'readonly',
-  exports: 'readonly',
-  __dirname: 'readonly',
-  __filename: 'readonly',
-  process: 'readonly',
-  console: 'readonly',
-};
-
-const BROWSER_GLOBALS = {
-  ...NODE_GLOBALS,
-  window: 'readonly',
-  document: 'readonly',
-  navigator: 'readonly',
-  location: 'readonly',
-  localStorage: 'readonly',
-  sessionStorage: 'readonly',
-  fetch: 'readonly',
-  setTimeout: 'readonly',
-  setInterval: 'readonly',
-  clearTimeout: 'readonly',
-  clearInterval: 'readonly',
-  requestAnimationFrame: 'readonly',
-  cancelAnimationFrame: 'readonly',
-  HTMLElement: 'readonly',
-  Element: 'readonly',
-  Event: 'readonly',
-  CustomEvent: 'readonly',
-  URL: 'readonly',
-  URLSearchParams: 'readonly',
-  FormData: 'readonly',
-  Blob: 'readonly',
-  Image: 'readonly',
-  history: 'readonly',
-  screen: 'readonly',
-  alert: 'readonly',
-  confirm: 'readonly',
-  prompt: 'readonly',
-  atob: 'readonly',
-  btoa: 'readonly',
-};
+/**
+ * app-backend policy: CommonJS only (`require`, `module.exports`, `exports.*`).
+ * Not flagged (and expected): `module.exports.foo = fn` — that is CommonJS, not ESM.
+ * Blocked: `import` / `export` / `import()` AST nodes via `no-restricted-syntax`.
+ * Also blocked at parse time (`sourceType: 'script'`): top-level `import`/`export`, `import.meta`.
+ */
+const BACKEND_COMMONJS_ONLY_FORBID_ESM = [
+  {
+    selector: 'ImportDeclaration',
+    message:
+      'app-backend is CommonJS-only — use require(), not import.',
+  },
+  {
+    selector: 'ExportNamedDeclaration',
+    message:
+      'app-backend is CommonJS-only — use module.exports / exports, not export { }.',
+  },
+  {
+    selector: 'ExportDefaultDeclaration',
+    message:
+      'app-backend is CommonJS-only — use module.exports, not export default.',
+  },
+  {
+    selector: 'ExportAllDeclaration',
+    message:
+      'app-backend is CommonJS-only — use CommonJS re-exports, not export *.',
+  },
+  {
+    selector: 'ImportExpression',
+    message:
+      'app-backend is CommonJS-only — use require(), not dynamic import().',
+  },
+];
 
 /**
  * Recursively find files with allowed extensions under dir, skipping certain folders.
@@ -83,44 +76,62 @@ function constructLintMessage(filename, lint) {
 }
 
 /**
- * @param {string} filename
- * @param {string|null} frontendPath
- * @param {string|null} backendPath
+ * Flat ESLint config for app-backend: CommonJS only for backend `.js` sources.
+ * - Allowed: require(), module.exports, exports, normal JS (async/await, const, etc.).
+ * - Rejected: ESM import / export / import() (see BACKEND_COMMONJS_ONLY_FORBID_ESM).
+ * @returns {import('eslint').Linter.Config[]}
+ */
+const getEslintBackendConfig = () => [
+  js.configs.recommended,
+  {
+    files: ['**/*.js'],
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'script',
+      parserOptions: { ecmaVersion: 2022 },
+      globals: globals.node,
+    },
+    rules: {
+      'no-restricted-syntax': ['error', ...BACKEND_COMMONJS_ONLY_FORBID_ESM],
+    },
+  },
+];
+
+/**
+ * Flat ESLint config for app-frontend / app-install-frontend (.js, .jsx).
+ * @param {string} filename - Used to enable JSX parsing for `.jsx` files.
+ * @returns {import('eslint').Linter.Config[]}
  */
-function getEslintConfigForFile(filename, frontendPath, backendPath) {
-  const resolved = path.resolve(filename);
-  const isFrontend = frontendPath && resolved.startsWith(path.resolve(frontendPath));
-  const globals = isFrontend ? BROWSER_GLOBALS : NODE_GLOBALS;
+const getEslintFrontendConfig = (filename) => {
   const isJsx = path.extname(filename).toLowerCase() === '.jsx';
   return [
     {
       // Explicit files so .jsx is matched (ESLint default only matches **/*.js, **/*.mjs)
       files: ['**/*.js', '**/*.jsx'],
+      ...js.configs.recommended,
       languageOptions: {
         ecmaVersion: 2022,
         sourceType: 'module',
         parserOptions: {
           ecmaVersion: 2022,
-          ecmaFeatures: { jsx: isFrontend && isJsx },
+          ecmaFeatures: { jsx: isJsx },
         },
-        globals,
+        globals: globals.browser,
       },
       rules: {
         'no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
-        'no-undef': 'error',
         'no-implicit-globals': 'error',
       },
     },
   ];
-}
+};
 
 module.exports = {
   SKIP_FOLDERS,
   BACKEND_EXTENSIONS,
   FRONTEND_EXTENSIONS,
-  NODE_GLOBALS,
-  BROWSER_GLOBALS,
   spider,
   constructLintMessage,
-  getEslintConfigForFile,
+  getEslintBackendConfig,
+  getEslintFrontendConfig,
 };

package/appnest-command-line/validateUtils/lint/lint.js

@@ -16,7 +16,7 @@ const validate = async ({ projects = {}, fix = false } = {}) => {
   const userDir = process.cwd();
   const appBackendPath = path.resolve(userDir, projects['app-backend'] || 'app-backend');
   const appFrontendPath = path.resolve(userDir, projects['app-frontend'] || 'app-frontend');
-  const appInstallationFrontendPath = path.resolve(userDir, projects['app-installation-frontend'] || 'app-installation-frontend');
+  const appInstallationFrontendPath = path.resolve(userDir, projects['app-install-frontend'] || 'app-install-frontend');
 
   console.log('📂 User Directory:', userDir);
   console.log('📂 App Backend Path:', appBackendPath);
@@ -37,7 +37,7 @@ const validate = async ({ projects = {}, fix = false } = {}) => {
   }
   if (fs.existsSync(appInstallationFrontendPath)) {
     const installationFrontendLints = await lintFrontend(appInstallationFrontendPath, fix);
-    reportLints({ lints: installationFrontendLints, projectName: 'app-installation-frontend', projectPath: appInstallationFrontendPath });
+    reportLints({ lints: installationFrontendLints, projectName: 'app-install-frontend', projectPath: appInstallationFrontendPath });
     lints.push(...installationFrontendLints);
   }
   return lints;
@@ -49,13 +49,13 @@ const validate = async ({ projects = {}, fix = false } = {}) => {
 
 const reportLints = ({ lints, projectName, projectPath }) => {
   if (lints.length === 0 && !fs.existsSync(projectPath)) {
-    console.log(`📋 No ${projectName} project folder found to lint.`);
+    console.log(`📦 ${projectName} project folder not found to lint.`);
     return [];
   }
 
   const errors = lints.filter((l) => l.severity === 2);
   const warnings = lints.filter((l) => l.severity === 1);
-  console.log(`👉 ${projectName} project folder lint report begins.`);
+  console.log(`🏁 Lint report begins for ${projectName} project folder.`);
   if (errors.length) {
     console.log(`\n❌ Lint errors (${errors.length}):`);
     errors.forEach((l) => console.log('  ', l.value));
@@ -67,7 +67,7 @@ const reportLints = ({ lints, projectName, projectPath }) => {
   if (errors.length === 0 && warnings.length === 0) {
     console.log(lints.length > 0 ? '✅ Lint passed with no issues.' : '📋 No lintable files found.');
   }
-  console.log(`👉 ${projectName} project folder lint report ends. 👍`);
+  console.log(`🏁 Lint report ends for ${projectName} project folder.`);
 }
 
 module.exports = {