@aptos-scp/scp-component-store-selling-features-domain-model 2.10.1 → 2.10.3

package/lib/domain/model/Constants.d.ts

@@ -1067,6 +1067,7 @@ export declare enum AssignCustomerForReturnAction {
     Skip = "Skip"
 }
 export declare const DELIVERY_CONTACT_UPDATED_EVENT: string;
+export declare const DELIVERY_ITEM_UPDATED_EVENT: string;
 export declare const PAYMENT_ACCOUNT_LOOKUP_EVENT: string;
 export interface IPaymentAccountLookupEventData {
     deviceId: string;

package/lib/domain/model/Constants.js

@@ -1072,6 +1072,7 @@ var AssignCustomerForReturnAction;
     AssignCustomerForReturnAction["Skip"] = "Skip";
 })(AssignCustomerForReturnAction = exports.AssignCustomerForReturnAction || (exports.AssignCustomerForReturnAction = {}));
 exports.DELIVERY_CONTACT_UPDATED_EVENT = "Delivery.ContactUpdated";
+exports.DELIVERY_ITEM_UPDATED_EVENT = "Delivery.ItemUpdated";
 exports.PAYMENT_ACCOUNT_LOOKUP_EVENT = "PaymentAccount.Lookup";
 exports.CANCEL_PAYMENT_FUNCTION_EVENT = "Cancel.PaymentFunction";
 exports.DELIVERY_SHIPPING_FEE_UPDATED_EVENT = "Delivery.ShippingFeeUpdated";

package/lib/domain/model/VoidInterfaces.js

@@ -1,8 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 function isVoidableLine(transactionLine) {
-    return (transactionLine.voided !== undefined &&
-        transactionLine.preventsTransactionVoid !== undefined);
+    /**
+     * Using "in" to check for the existence of these properties is faster than comparing
+     * to undefined since it is not evaluating the getter method and avoids the extra
+     * calculations on deeply nested decorators.
+     */
+    return "voided" in transactionLine && "preventsTransactionVoid" in transactionLine;
 }
 exports.isVoidableLine = isVoidableLine;
 function lineCanBeVoided(transactionLine) {

package/lib/domain/model/item/ItemLinePromotionDecorator.js

@@ -112,10 +112,18 @@ class ItemLinePromotionDecorator extends ItemLineBaseDiscountDecorator_1.ItemLin
             : this.decoratedTransactionLine.itemSelectedUnitPrice;
     }
     get extendedAmountExcludingTransactionDiscounts() {
-        const resultAmount = this.decoratedTransactionLine.extendedAmountExcludingTransactionDiscounts
+        /**
+         * Creating this constant so that the extendedAmountExcludingTransactionDiscounts
+         * getter on the decorated line is only accessed once.
+         * Accessing the property multiple times causes the calculations on decorated
+         * decorators to be performed multiple times that can be a performance issue on
+         * deeply nested decorators.
+         */
+        const decoratedExtendedAmountExcludingTransactionDiscounts = this.decoratedTransactionLine.extendedAmountExcludingTransactionDiscounts;
+        const resultAmount = decoratedExtendedAmountExcludingTransactionDiscounts
             .abs()
             .minus(this.adjustmentAmount.abs());
-        return this.decoratedTransactionLine.extendedAmountExcludingTransactionDiscounts.isNegative()
+        return decoratedExtendedAmountExcludingTransactionDiscounts.isNegative()
             ? resultAmount.times(-1) // return to negative value for returns.
             : resultAmount;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aptos-scp/scp-component-store-selling-features-domain-model",
-  "version": "2.10.1",
+  "version": "2.10.3",
   "description": "This component library provides the common components to handle the coordination of processing the business events from the UI.",
   "private": false,
   "license": "SEE LICENSE IN LICENSE.md",