@aptos-scp/scp-component-store-selling-features-domain-model 2.10.0 → 2.10.2

package/lib/domain/model/MerchandiseTransaction.d.ts

@@ -254,7 +254,7 @@ export declare class MerchandiseTransaction extends RetailTransaction implements
     get transactionTaxExemptAmount(): Money;
     get transactionTaxAdjustmentAmount(): Money;
     get fiscalError(): IFiscalError;
-    get fiscalizationComplete(): boolean;
+    get hasFiscalizationCompleted(): boolean;
     get tradeType(): MerchandiseTransactionTradeType;
     get taxLotteryNumber(): string;
     get taxLotteryCustomerCode(): string;
@@ -300,7 +300,7 @@ export declare class MerchandiseTransaction extends RetailTransaction implements
     assignFiscalTypeCode(fiscalTypeCode: string): ITransaction;
     assignFiscalTransactionSequenceNumber(fiscalTransactionSequenceNumber: number, fiscalTransactionSequenceNumberGenerator: string): ITransaction;
     setFiscalError(fiscalError: IFiscalError): ITransaction;
-    setFiscalizationComplete(fiscalizationComplete: boolean): ITransaction;
+    setHasFiscalizationCompleted(hasFiscalizationCompleted: boolean): ITransaction;
     assignOrderReferenceSequenceNumber(orderReferenceSequenceNumber: number, orderReferenceSequenceNumberGenerator: string): ITransaction;
     assignInvoiceFiscalTransactionNumber(invoiceTransactionNumber: number, invoiceFiscalTransactionNumber: string): ITransaction;
     assignTaxlotteryNumber(taxLotteryNumber: string): ITransaction;

package/lib/domain/model/MerchandiseTransaction.js

@@ -497,7 +497,7 @@ class MerchandiseTransaction extends RetailTransaction_1.RetailTransaction {
     get fiscalError() {
         return this._fiscalError;
     }
-    get fiscalizationComplete() {
+    get hasFiscalizationCompleted() {
         return this._hasFiscalizationCompleted;
     }
     get tradeType() {
@@ -720,9 +720,9 @@ class MerchandiseTransaction extends RetailTransaction_1.RetailTransaction {
         newTransaction._fiscalError = fiscalError;
         return newTransaction;
     }
-    setFiscalizationComplete(fiscalizationComplete) {
+    setHasFiscalizationCompleted(hasFiscalizationCompleted) {
         const newTransaction = this.clone();
-        newTransaction._hasFiscalizationCompleted = fiscalizationComplete;
+        newTransaction._hasFiscalizationCompleted = hasFiscalizationCompleted;
         return newTransaction;
     }
     assignOrderReferenceSequenceNumber(orderReferenceSequenceNumber, orderReferenceSequenceNumberGenerator) {
@@ -901,7 +901,7 @@ class MerchandiseTransaction extends RetailTransaction_1.RetailTransaction {
             ["transaction.taxExemptAmount", this._transactionTaxExemptAmount],
             ["transaction.transactionTaxAdjustmentAmount", this._transactionTaxAdjustmentAmount],
             ["transaction.fiscalError", this._fiscalError],
-            ["transaction.fiscalizationComplete", this._hasFiscalizationCompleted],
+            ["transaction.hasFiscalizationCompleted", this._hasFiscalizationCompleted],
             ["transaction.tradeType", this._tradeType],
             ["transaction.signatureCollected", this.signatureCollected],
             ["transaction.itemPickupSignatureCollected", this.itemPickupSignatureCollected],

package/lib/domain/model/VoidInterfaces.js

@@ -1,8 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 function isVoidableLine(transactionLine) {
-    return (transactionLine.voided !== undefined &&
-        transactionLine.preventsTransactionVoid !== undefined);
+    /**
+     * Using "in" to check for the existence of these properties is faster than comparing
+     * to undefined since it is not evaluating the getter method and avoids the extra
+     * calculations on deeply nested decorators.
+     */
+    return "voided" in transactionLine && "preventsTransactionVoid" in transactionLine;
 }
 exports.isVoidableLine = isVoidableLine;
 function lineCanBeVoided(transactionLine) {

package/lib/domain/model/item/ItemLinePromotionDecorator.js

@@ -112,10 +112,18 @@ class ItemLinePromotionDecorator extends ItemLineBaseDiscountDecorator_1.ItemLin
             : this.decoratedTransactionLine.itemSelectedUnitPrice;
     }
     get extendedAmountExcludingTransactionDiscounts() {
-        const resultAmount = this.decoratedTransactionLine.extendedAmountExcludingTransactionDiscounts
+        /**
+         * Creating this constant so that the extendedAmountExcludingTransactionDiscounts
+         * getter on the decorated line is only accessed once.
+         * Accessing the property multiple times causes the calculations on decorated
+         * decorators to be performed multiple times that can be a performance issue on
+         * deeply nested decorators.
+         */
+        const decoratedExtendedAmountExcludingTransactionDiscounts = this.decoratedTransactionLine.extendedAmountExcludingTransactionDiscounts;
+        const resultAmount = decoratedExtendedAmountExcludingTransactionDiscounts
             .abs()
             .minus(this.adjustmentAmount.abs());
-        return this.decoratedTransactionLine.extendedAmountExcludingTransactionDiscounts.isNegative()
+        return decoratedExtendedAmountExcludingTransactionDiscounts.isNegative()
             ? resultAmount.times(-1) // return to negative value for returns.
             : resultAmount;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aptos-scp/scp-component-store-selling-features-domain-model",
-  "version": "2.10.0",
+  "version": "2.10.2",
   "description": "This component library provides the common components to handle the coordination of processing the business events from the UI.",
   "private": false,
   "license": "SEE LICENSE IN LICENSE.md",