@aptos-scp/scp-component-store-selling-features-domain-model 1.24.1 → 1.25.0

package/lib/domain/model/MerchandiseTransaction.js

@@ -785,7 +785,7 @@ class MerchandiseTransaction extends RetailTransaction_1.RetailTransaction {
         return this.getTransactionTotal(this.transactionTotalTaxExcludingPreviouslyCollected, this.transactionSubTotalExcludingPreviouslyCollected);
     }
     get transactionBalanceDue() {
-        return this.getTransactionBalanceDue(this.transactionTotal, this.transactionTotalTendered, true, this.transactionTotalPreviouslyPaidItemFee);
+        return this.getTransactionBalanceDue(this.transactionTotal, this.transactionTotalTendered, true);
     }
     get transactionBalanceDueExcludingPreviouslyCollected() {
         return this.getTransactionBalanceDue(this.transactionTotalExcludingPreviouslyCollected, this.transactionTotalTenderedExcludingPreviouslyCollected, true);
@@ -1310,14 +1310,9 @@ class MerchandiseTransaction extends RetailTransaction_1.RetailTransaction {
             .plus(this.transactionTotalDonations)
             .plus(transactionTotalPreviouslyPaidItemFee);
     }
-    getTransactionBalanceDue(totalAmount, totalTendered, removeTotalTendered, transactionTotalPreviouslyPaidItemFee) {
+    getTransactionBalanceDue(totalAmount, totalTendered, removeTotalTendered) {
         let balanceDue;
-        if (transactionTotalPreviouslyPaidItemFee) {
-            balanceDue = totalAmount.plus(transactionTotalPreviouslyPaidItemFee);
-        }
-        else {
-            balanceDue = totalAmount;
-        }
+        balanceDue = totalAmount;
         if (removeTotalTendered) {
             balanceDue = balanceDue.minus(totalTendered.plus(this.denominationRounding));
         }

package/lib/domain/model/fee/FeeLine.js

@@ -293,12 +293,9 @@ class FeeLine extends BaseTransactionLine_1.BaseTransactionLine {
      * @param sublines fee's sublines
      */
     setSublines(sublines) {
-        if (FeeLine.isPickupFulfilmentTransaction) {
-            const newLine = this.clone();
-            newLine._sublines = sublines;
-            return newLine;
-        }
-        throw new Error("Method not implemented.");
+        const newLine = this.clone();
+        newLine._sublines = sublines;
+        return newLine;
     }
     setItemLineReference(itemLineReference) {
         if (this.lineType === exports.ITEM_FEE_LINE_TYPE) {
@@ -703,8 +700,9 @@ function isTransactionFeeLine(transactionLine) {
 }
 exports.isTransactionFeeLine = isTransactionFeeLine;
 function isTransactionFeeRefundLine(transactionLine) {
-    return (transactionLine instanceof FeeLine ||
-        (transactionLine && transactionLine.lineType === exports.TRANSACTION_FEE_REFUND_LINE_TYPE));
+    return (transactionLine &&
+        transactionLine instanceof FeeLine &&
+        transactionLine.lineType === exports.TRANSACTION_FEE_REFUND_LINE_TYPE);
 }
 exports.isTransactionFeeRefundLine = isTransactionFeeRefundLine;
 function isBagFeeLine(transactionLine) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aptos-scp/scp-component-store-selling-features-domain-model",
-  "version": "1.24.1",
+  "version": "1.25.0",
   "description": "This component library provides the common components to handle the coordination of processing the business events from the UI.",
   "private": false,
   "license": "SEE LICENSE IN LICENSE.md",