@aprimediet/codewalker 1.2.0 → 1.4.0

package/src/format.test.ts

@@ -115,6 +115,154 @@ describe('formatCompact with lib rows', () => {
   });
 });
 
+describe('formatCompact with note rows', () => {
+  it('renders a glossary note row with [glossary] prefix', () => {
+    const rows: QueryResultRow[] = [{
+      id: 1, name: 'Idempotency Key', kind: 'glossary',
+      file_path: '', line_start: 0, line_end: 0,
+      signature: '', summary: 'A client-supplied key that makes retries safe.',
+      score: 0.5, source: 'note', note_kind: 'glossary', tags: 'api',
+    }];
+    const result = formatCompact(rows, null);
+    expect(result).toContain('Idempotency Key');
+    expect(result).toContain('glossary');
+    expect(result).toContain('[glossary]');
+    expect(result).toContain('A client-supplied key that makes retries safe.');
+  });
+
+  it('renders a decision note row with [decision] prefix', () => {
+    const rows: QueryResultRow[] = [{
+      id: 1, name: 'Use SQLite', kind: 'decision',
+      file_path: '', line_start: 0, line_end: 0,
+      signature: '', summary: 'Chosen for zero infra.',
+      score: 0.5, source: 'note', note_kind: 'decision', tags: '',
+    }];
+    const result = formatCompact(rows, null);
+    expect(result).toContain('Use SQLite');
+    expect(result).toContain('decision');
+    expect(result).toContain('[decision]');
+  });
+
+  it('renders mixed code + lib + note rows all on separate lines', () => {
+    const codeRow: QueryResultRow = {
+      id: 1, name: 'myFunc', kind: 'function',
+      file_path: 'src/util/helper.ts', line_start: 10, line_end: 20,
+      signature: '', summary: 'Does something', score: 0.5,
+    };
+    const libRow = makeLibRow();
+    const noteRow: QueryResultRow = {
+      id: 1, name: 'Retry Key', kind: 'glossary',
+      file_path: '', line_start: 0, line_end: 0,
+      signature: '', summary: 'Key for idempotent retries.',
+      score: 0.5, source: 'note', note_kind: 'glossary', tags: '',
+    };
+
+    const result = formatCompact([codeRow, libRow, noteRow], null);
+    expect(result).toContain('helper.ts:10-20');
+    expect(result).toContain('[hono@4.6.3]');
+    expect(result).toContain('[glossary]');
+    expect(result).toContain('Retry Key');
+    expect(result.split('\n')).toHaveLength(3);
+  });
+});
+
+describe('formatCompact with analysis rows', () => {
+  it('renders a coverage finding row with [coverage] prefix and severity', () => {
+    const rows: QueryResultRow[] = [{
+      id: 1, name: 'Low coverage: src/auth/token.ts', kind: 'coverage',
+      file_path: 'src/auth/token.ts', line_start: 0, line_end: 0,
+      signature: '', summary: 'Token path is under-tested.',
+      score: 0.5, source: 'analysis', finding_kind: 'coverage',
+      severity: 'warn', metric: '38% (24/63 lines)',
+    }];
+    const result = formatCompact(rows, null);
+    expect(result).toContain('Low coverage: src/auth/token.ts');
+    expect(result).toContain('[coverage]');
+    expect(result).toContain('warn');
+    expect(result).toContain('38%');
+    expect(result).toContain('token.ts');
+  });
+
+  it('renders a debt finding row with [debt] prefix', () => {
+    const rows: QueryResultRow[] = [{
+      id: 1, name: 'TODO: fix this', kind: 'debt',
+      file_path: 'src/a.ts', line_start: 5, line_end: 5,
+      signature: '', summary: 'Need to handle edge case',
+      score: 0.5, source: 'analysis', finding_kind: 'debt',
+      severity: 'info', metric: 'TODO',
+    }];
+    const result = formatCompact(rows, null);
+    expect(result).toContain('[debt]');
+    expect(result).toContain('TODO: fix this');
+    expect(result).toContain('info');
+  });
+
+  it('renders a practice finding row with [practice] prefix', () => {
+    const rows: QueryResultRow[] = [{
+      id: 1, name: 'Missing error handling', kind: 'practice',
+      file_path: 'src/api/route.ts', line_start: 15, line_end: 15,
+      signature: '', summary: 'No error handling in this function.',
+      score: 0.5, source: 'analysis', finding_kind: 'practice',
+      severity: 'high', metric: '',
+    }];
+    const result = formatCompact(rows, null);
+    expect(result).toContain('[practice]');
+    expect(result).toContain('high');
+  });
+
+  it('renders mixed code + analysis rows', () => {
+    const codeRow: QueryResultRow = {
+      id: 1, name: 'myFunc', kind: 'function',
+      file_path: 'src/util/helper.ts', line_start: 10, line_end: 20,
+      signature: '', summary: 'Does something', score: 0.5,
+    };
+    const analysisRow: QueryResultRow = {
+      id: 2, name: 'Low coverage', kind: 'coverage',
+      file_path: 'src/util/helper.ts', line_start: 0, line_end: 0,
+      signature: '', summary: 'Low coverage.',
+      score: 0.3, source: 'analysis', finding_kind: 'coverage',
+      severity: 'warn', metric: '30%',
+    };
+    const result = formatCompact([codeRow, analysisRow], null);
+    expect(result).toContain('helper.ts:10-20');
+    expect(result).toContain('[coverage]');
+    expect(result.split('\n')).toHaveLength(2);
+  });
+
+  it('renders mixed code + lib + note + analysis rows', () => {
+    const codeRow: QueryResultRow = {
+      id: 1, name: 'myFunc', kind: 'function',
+      file_path: 'src/util/helper.ts', line_start: 10, line_end: 20,
+      signature: '', summary: 'Does something', score: 0.5,
+    };
+    const libRow: QueryResultRow = {
+      id: 100, name: 'createMiddleware', kind: 'function',
+      file_path: 'hono/dist/helper.d.ts', line_start: 0, line_end: 0,
+      signature: '', summary: 'Define a typed middleware handler.',
+      score: 0.3, source: 'lib', lib: 'hono', version: '4.6.3',
+    };
+    const noteRow: QueryResultRow = {
+      id: 1, name: 'Retry Key', kind: 'glossary',
+      file_path: '', line_start: 0, line_end: 0,
+      signature: '', summary: 'Key for idempotent retries.',
+      score: 0.5, source: 'note', note_kind: 'glossary', tags: '',
+    };
+    const analysisRow: QueryResultRow = {
+      id: 2, name: 'Low coverage', kind: 'coverage',
+      file_path: 'src/util/helper.ts', line_start: 0, line_end: 0,
+      signature: '', summary: 'Low coverage.',
+      score: 0.3, source: 'analysis', finding_kind: 'coverage',
+      severity: 'warn', metric: '30%',
+    };
+
+    const result = formatCompact([codeRow, libRow, noteRow, analysisRow], null);
+    expect(result).toContain('[coverage]');
+    expect(result).toContain('[hono@4.6.3]');
+    expect(result).toContain('[glossary]');
+    expect(result.split('\n')).toHaveLength(4);
+  });
+});
+
 describe('formatCardBody', () => {
   it('returns the card body text', () => {
     const body = '# myFunc\n\nDoes something.\n';

package/src/format.ts

@@ -27,6 +27,19 @@ export function formatCompact(
   }
 
   const lines = rows.map((row) => {
+    if (row.source === "note" && row.note_kind) {
+      const prefix = `[${row.note_kind}]`;
+      const summary = truncate(row.summary || "", SUMMARY_MAX);
+      return `${row.name} · ${row.note_kind} · ${prefix} · ${summary}`;
+    }
+    if (row.source === "analysis") {
+      const kindTag = `[${row.finding_kind || "finding"}]`;
+      const sev = row.severity ? ` · ${row.severity}` : "";
+      const metric = row.metric ? ` · ${row.metric}` : "";
+      const loc = row.file_path ? ` · ${basename(row.file_path)}` : "";
+      const summary = truncate(row.summary || row.name || "", SUMMARY_MAX);
+      return `${row.name}${loc}${sev}${metric} · ${kindTag} · ${summary}`;
+    }
     if (row.source === "lib" && row.lib && row.version) {
       const origin = `[${row.lib}@${row.version}]`;
       const summary = truncate(row.summary || "", SUMMARY_MAX);

package/src/index.contract.test.ts

@@ -58,6 +58,35 @@ describe('index.ts contract', () => {
     expect(queryTool).toBeDefined();
     expect(queryTool!.description).toContain('code index');
 
+    // Check new v1.3 tools
+    const enrichTool = stub.tools.find(t => t.name === 'codewalker_enrich');
+    expect(enrichTool).toBeDefined();
+    expect(enrichTool!.description).toContain('summary');
+
+    const noteTool = stub.tools.find(t => t.name === 'codewalker_note');
+    expect(noteTool).toBeDefined();
+    expect(noteTool!.description).toContain('glossary');
+
+    // Check enrich tool parameters
+    const enrichParams = (enrichTool!.parameters as any);
+    expect(enrichParams.properties).toHaveProperty('card');
+    expect(enrichParams.properties).toHaveProperty('summary');
+
+    // Check note tool parameters
+    const noteParams = (noteTool!.parameters as any);
+    expect(noteParams.properties).toHaveProperty('type');
+    expect(noteParams.properties).toHaveProperty('title');
+    expect(noteParams.properties).toHaveProperty('body');
+
+    // Check v1.4 tools
+    const findingTool = stub.tools.find(t => t.name === 'codewalker_finding');
+    expect(findingTool).toBeDefined();
+    expect(findingTool!.description).toContain('finding');
+    const findingParams = (findingTool!.parameters as any);
+    expect(findingParams.properties).toHaveProperty('kind');
+    expect(findingParams.properties).toHaveProperty('title');
+    expect(findingParams.properties).toHaveProperty('body');
+
     // Check tool has a source parameter
     const toolParams = (queryTool!.parameters as any);
     expect(toolParams.properties).toHaveProperty('source');
@@ -142,4 +171,37 @@ describe('index.ts contract', () => {
     expect(cmd.description).toContain('libs [--dev]');
     expect(cmd.description).toContain('lib <pkg>');
   });
+
+  it('command description includes enrich, glossary, decisions subcommands', async () => {
+    const mod = await import('./index.ts');
+    const stub = createPiStub();
+    mod.default(stub.api as any);
+
+    const cmd = stub.commands.find(c => c.name === 'codewalker')!;
+    expect(cmd.description).toContain('enrich');
+    expect(cmd.description).toContain('glossary');
+    expect(cmd.description).toContain('decisions');
+  });
+
+  it('command description includes v1.4 subcommands (analyze, review, findings, conventions)', async () => {
+    const mod = await import('./index.ts');
+    const stub = createPiStub();
+    mod.default(stub.api as any);
+
+    const cmd = stub.commands.find(c => c.name === 'codewalker')!;
+    expect(cmd.description).toContain('analyze');
+    expect(cmd.description).toContain('review');
+    expect(cmd.description).toContain('findings');
+    expect(cmd.description).toContain('conventions');
+  });
+
+  it('codewalker_note tool accepts type="convention"', async () => {
+    const mod = await import('./index.ts');
+    const stub = createPiStub();
+    mod.default(stub.api as any);
+
+    const noteTool = stub.tools.find(t => t.name === 'codewalker_note')!;
+    const noteParams = (noteTool!.parameters as any);
+    expect(noteParams.properties.type.description).toContain('convention');
+  });
 });