@appzung/react-native-code-push 11.0.2 → 11.0.3

package/README.md

@@ -112,7 +112,7 @@ We try our best to maintain backwards compatibility of our plugin with previous
 | v0.71-v0.79             | 4.1+ (TLS 1.2+) | 9    | ✅       | ❌       | v8.3.2                         |
 | v0.71-v0.79             | 4.1+ (TLS 1.2+) | 15.5 | ✅       | ❌       | v9.0.2                         |
 | v0.71-v0.80             | 4.1+ (TLS 1.2+) | 15.5 | ✅       | ❌       | v10+                           |
-| v0.74-v0.81             | 4.1+ (TLS 1.2+) | 15.5 | ✅       | ✅       | v11+                           |
+| v0.74-v0.84             | 4.1+ (TLS 1.2+) | 15.5 | ✅       | ✅       | v11+                           |
 
 We work hard to respond to new RN releases, but they do occasionally break us. We will update this chart with each RN release, so that users can check to see what our "official" support is.
 
@@ -140,10 +140,28 @@ By default, and this is recommended for production environments, CodePush will c
 If you would like your app to discover updates more quickly, you can also choose to sync up with the CodePush server every time the app resumes from the background.
 
 ```javascript
-withCodePush({ checkFrequency: CheckFrequency.ON_APP_RESUME })(MyApp);
+import withCodePush, { CheckFrequency, InstallMode } from '@appzung/react-native-code-push';
+
+withCodePush({
+  checkFrequency: CheckFrequency.ON_APP_RESUME,
+})(MyApp);
+```
+
+For a more aggressive setup, you may choose to also install updates in the background or when the app resumes. Note that because the app would reload during update installation, the user might be slightly bothered unless you have a mechanism to come back to the exact same app state after restarting. You may minimize this discomfort using `minimumBackgroundDuration`.
+On Android in New Arch it is preferable to use ON_NEXT_RESUME instead of ON_NEXT_SUSPEND because it looks like React Native has a bug where network requests fail when React initializes in the background.
+
+```javascript
+import withCodePush, { CheckFrequency, InstallMode } from '@appzung/react-native-code-push';
+import { Platform } from 'react-native';
+
+withCodePush({
+  checkFrequency: CheckFrequency.ON_APP_RESUME,
+  installMode: Platform.OS === 'android' ? InstallMode.ON_NEXT_RESUME : InstallMode.ON_NEXT_SUSPEND,
+  minimumBackgroundDuration: 60 * 5, // if the app is suspended more than 5 minutes, install the update. If the app is restarted (killed and restarted) it will also install the update.
+})(MyApp);
 ```
 
-Alternatively, if you want fine-grained control over when the check happens (like a button press or timer interval), eg. in a staging environment, you can call [`CodePush.sync()`](docs/api-js/functions/sync.md) at any time with your desired `SyncOptions`, and turn off CodePush's automatic checking by specifying a manual `checkFrequency`:
+Alternatively, if you want fine-grained control over when the check happens (like a button press or timer interval), e.g. in a staging environment, you can call [`CodePush.sync()`](docs/api-js/functions/sync.md) at any time with your desired `SyncOptions`, and turn off CodePush's automatic checking by specifying a manual `checkFrequency`:
 
 ```javascript
 import withCodePush, { CheckFrequency, InstallMode, sync } from '@appzung/react-native-code-push';
@@ -285,3 +303,4 @@ Now you'll be able to see CodePush logs in either debug or release mode, on both
 | I've released an update for iOS but my Android app also shows an update and it breaks it                                                                                                                                    | Be sure you have different release channels for each platform in order to receive updates correctly                                                                                                                                                                                                                |
 | I've released new update but changes are not reflected                                                                                                                                                                      | Be sure that you are running app in modes other than Debug. In Debug mode, React Native app always downloads JS bundle generated by packager, so JS bundle downloaded by CodePush does not apply.                                                                                                                  |
 | Android compilation fails after migrating to AppZung with error "Task :app:checkReleaseAarMetadata FAILED A problem was found with the configuration of task ':app:checkReleaseAarMetadata' (type 'CheckAarMetadataTask')". | In `android/settings.gradle` remove the lines about CodePush. Be sure to read the other [migration steps](./docs/migrating-to-v10.md) carefully to review if you missed any others.                                                                                                                                |
+| `appzung releases deploy-react-native` fails with "SyntaxError: missing ) after argument list" in pnpm workspaces                                                                                                           | Use `--react-native-cli-path` flag to specify the path to the RN CLI JS file: `--react-native-cli-path=./node_modules/react-native/cli.js`                                                                                                                                                                         |

package/android/app/proguard-rules.pro

@@ -19,6 +19,7 @@
 # Invoked via reflection, when setting js bundle.
 -keepclassmembers class com.facebook.react.ReactInstanceManager {
     private final ** mBundleLoader;
+    private ** mAttachedReactRoots;
 }
 -keepclassmembers class com.facebook.react.runtime.ReactHostImpl {
     private final ** mReactHostDelegate;
@@ -27,5 +28,13 @@
 -keep interface com.facebook.react.runtime.ReactHostDelegate { *; }
 -keep class * implements com.facebook.react.runtime.ReactHostDelegate { *; }
 
+# Invoked via reflection, when resetting root views.
+-keepclassmembers interface com.facebook.react.ReactRoot {
+    public ** getRootViewGroup();
+}
+-keepclassmembers class * implements com.facebook.react.ReactRoot {
+    public ** getRootViewGroup();
+}
+
 # Can't find referenced class org.bouncycastle.**
 -dontwarn com.nimbusds.jose.**

package/android/app/src/main/java/com/appzung/codepush/react/CodePushNativeModule.java

@@ -7,6 +7,7 @@ import android.os.Handler;
 import android.os.Looper;
 import android.view.Choreographer;
 import android.view.View;
+import android.view.ViewGroup;
 
 import androidx.annotation.OptIn;
 
@@ -268,6 +269,7 @@ public class CodePushNativeModule extends BaseJavaModule {
                     @Override
                     public void run() {
                         try {
+                            resetReactRootViews(instanceManager);
                             instanceManager.recreateReactContextInBackground();
                             mCodePush.initializeUpdateAfterRestart();
                         } catch (Exception e) {
@@ -315,6 +317,26 @@ public class CodePushNativeModule extends BaseJavaModule {
         }
     }
 
+    private void resetReactRootViews(ReactInstanceManager instanceManager) throws NoSuchFieldException, IllegalAccessException {
+        Field mAttachedReactRootsField = instanceManager.getClass().getDeclaredField("mAttachedReactRoots");
+        mAttachedReactRootsField.setAccessible(true);
+        java.util.Set<?> mAttachedReactRoots = (java.util.Set<?>) mAttachedReactRootsField.get(instanceManager);
+        if (mAttachedReactRoots != null) {
+            for (Object reactRoot : mAttachedReactRoots) {
+                try {
+                    Method getRootViewGroupMethod = reactRoot.getClass().getMethod("getRootViewGroup");
+                    ViewGroup rootViewGroup = (ViewGroup) getRootViewGroupMethod.invoke(reactRoot);
+                    if (rootViewGroup != null) {
+                        rootViewGroup.removeAllViews();
+                        rootViewGroup.setId(View.NO_ID);
+                    }
+                } catch (Exception e) {
+                    CodePushUtils.log("Failed to reset root view: " + e.getMessage());
+                }
+            }
+        }
+    }
+
     // Use reflection to find the ReactInstanceManager. See #556 for a proposal for a less brittle way to approach this.
     private ReactInstanceManager resolveInstanceManager() throws NoSuchFieldException, IllegalAccessException {
         ReactInstanceManager instanceManager = CodePush.getReactInstanceManager();
@@ -686,7 +708,12 @@ public class CodePushNativeModule extends BaseJavaModule {
                                         if (installMode == CodePushInstallMode.IMMEDIATE.getValue()
                                                 || durationInBackground >= CodePushNativeModule.this.mMinimumBackgroundDuration) {
                                             CodePushUtils.log("Loading bundle on resume");
-                                            restartAppInternal(false);
+                                            new Handler(Looper.getMainLooper()).post(new Runnable() {
+                                                @Override
+                                                public void run() {
+                                                    restartAppInternal(false);
+                                                }
+                                            });
                                         }
                                     }
                                 }

package/lib/commonjs/internals/version.js

@@ -5,5 +5,5 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.version = void 0;
 // Generated by genversion.
-const version = exports.version = '11.0.2';
+const version = exports.version = '11.0.3';
 //# sourceMappingURL=version.js.map

package/lib/module/internals/version.js

@@ -1,5 +1,5 @@
 "use strict";
 
 // Generated by genversion.
-export const version = '11.0.2';
+export const version = '11.0.3';
 //# sourceMappingURL=version.js.map

package/lib/typescript/commonjs/src/internals/version.d.ts

@@ -1,2 +1,2 @@
-export declare const version = "11.0.2";
+export declare const version = "11.0.3";
 //# sourceMappingURL=version.d.ts.map

package/lib/typescript/module/src/internals/version.d.ts

@@ -1,2 +1,2 @@
-export declare const version = "11.0.2";
+export declare const version = "11.0.3";
 //# sourceMappingURL=version.d.ts.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@appzung/react-native-code-push",
-  "version": "11.0.2",
+  "version": "11.0.3",
   "description": "React Native plugin for the CodePush service",
   "author": "Louis Lagrange <lagrange.louis@gmail.com> (https://github.com/Minishlink)",
   "license": "MIT",
@@ -48,7 +48,7 @@
   },
   "repository": {
     "type": "git",
-    "url": "https://github.com/appzung/react-native-code-push"
+    "url": "git+https://github.com/appzung/react-native-code-push.git"
   },
   "dependencies": {
     "hoist-non-react-statics": "^3.3.2"

package/src/internals/version.ts

@@ -1,2 +1,2 @@
 // Generated by genversion.
-export const version = '11.0.2';
+export const version = '11.0.3';