@appsemble/utils 0.30.2 → 0.30.3

package/README.md

@@ -1,9 +1,9 @@
-# ![](https://gitlab.com/appsemble/appsemble/-/raw/0.30.2/config/assets/logo.svg) Appsemble Utilities
+# ![](https://gitlab.com/appsemble/appsemble/-/raw/0.30.3/config/assets/logo.svg) Appsemble Utilities
 
 > Internal utility functions used across multiple Appsemble projects.
 
 [![npm](https://img.shields.io/npm/v/@appsemble/utils)](https://www.npmjs.com/package/@appsemble/utils)
-[![GitLab CI](https://gitlab.com/appsemble/appsemble/badges/0.30.2/pipeline.svg)](https://gitlab.com/appsemble/appsemble/-/releases/0.30.2)
+[![GitLab CI](https://gitlab.com/appsemble/appsemble/badges/0.30.3/pipeline.svg)](https://gitlab.com/appsemble/appsemble/-/releases/0.30.3)
 [![Prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg)](https://prettier.io)
 
 ## Table of Contents
@@ -26,5 +26,5 @@ not guaranteed.
 
 ## License
 
-[LGPL-3.0-only](https://gitlab.com/appsemble/appsemble/-/blob/0.30.2/LICENSE.md) ©
+[LGPL-3.0-only](https://gitlab.com/appsemble/appsemble/-/blob/0.30.3/LICENSE.md) ©
 [Appsemble](https://appsemble.com)

package/api/paths/apps.js

@@ -121,11 +121,11 @@ export const pathItems = {
                 in: 'query',
             },
         ],
-        description: 'Get all existing apps.',
+        description: 'Get all publically available apps.',
         operationId: 'queryApps',
         responses: {
             200: {
-                description: 'The list of all apps.',
+                description: 'The list of all public apps.',
                 content: {
                     'application/json': {
                         schema: {

package/api/paths/users/current/apps.js

@@ -9,11 +9,11 @@ export const pathItems = {
                 in: 'query',
             },
         ],
-        description: 'Get all apps that are editable by the user.',
+        description: 'Get all apps from organizations that the user is in.',
         operationId: 'queryCurrentUserApps',
         responses: {
             200: {
-                description: 'The list of all editable apps.',
+                description: 'The list of all apps the user is in.',
                 content: {
                     'application/json': {
                         schema: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@appsemble/utils",
-  "version": "0.30.2",
+  "version": "0.30.3",
   "description": "Utility functions used in Appsemble internally",
   "keywords": [
     "app",
@@ -37,7 +37,7 @@
     "test": "vitest"
   },
   "dependencies": {
-    "@appsemble/types": "0.30.2",
+    "@appsemble/types": "0.30.3",
     "axios": "^1.0.0",
     "cron-parser": "^4.0.0",
     "date-fns": "^2.0.0",

package/remap.js

@@ -319,7 +319,10 @@ const mapperImplementations = {
             }
         }
         else if (typeof prop === 'number' || typeof prop === 'string') {
-            result = result[prop];
+            result =
+                Array.isArray(result) && typeof prop === 'number' && prop < 0
+                    ? result[result.length + prop]
+                    : result[prop];
         }
         return result;
     },

package/remap.test.js

@@ -1089,6 +1089,16 @@ describe('prop', () => {
             mappers: { prop: 'foo' },
             expected: null,
         },
+        'handle array input': {
+            input: ['one', 'two', 'three', 'four'],
+            mappers: { prop: 1 },
+            expected: 'two',
+        },
+        'handle array input and negative index': {
+            input: ['one', 'two', 'three', 'four'],
+            mappers: { prop: -3 },
+            expected: 'two',
+        },
     });
 });
 describe('random.choice', () => {

package/validation.js

@@ -1150,6 +1150,7 @@ export async function validateAppDefinition(definition, getBlockVersions, contro
         result = validator.validate(definition, {});
     }
     if (!definition) {
+        result.addError('App definition can not be null');
         return result;
     }
     const blocks = getAppBlocks(definition);

package/validation.test.js

@@ -2001,20 +2001,26 @@ describe('validateAppDefinition', () => {
             new ValidationError('there is no-one in the app, who has permissions to use this action', 'resource.get', undefined, ['controller', 'actions', 'onWhatever', 'resource']),
         ]);
     });
-    it('should ignore if an app is null', async () => {
+    it('should throw if an app is null', async () => {
         const result = await validateAppDefinition(null, () => []);
-        expect(result.valid).toBe(true);
-        expect(result.errors).toStrictEqual([]);
-    });
-    it('should if app pages are not an array', async () => {
-        const result = await validateAppDefinition(null, () => []);
-        expect(result.valid).toBe(true);
-        expect(result.errors).toStrictEqual([]);
+        expect(result.valid).toBe(false);
+        expect(result.errors).toStrictEqual([
+            expect.objectContaining({
+                message: 'App definition can not be null',
+                instance: null,
+                schema: {},
+            }),
+        ]);
     });
-    it('should report an error if app validation fails for an unexpected reason', async () => {
-        const result = await validateAppDefinition(null, () => []);
-        expect(result.valid).toBe(true);
-        expect(result.errors).toStrictEqual([]);
+    it('should report an error if the defaultPage does not exist', async () => {
+        const result = await validateAppDefinition({ name: 'Test App', pages: [], defaultPage: 'Test Page' }, () => []);
+        expect(result.valid).toBe(false);
+        expect(result.errors).toStrictEqual([
+            expect.objectContaining({
+                instance: 'Test Page',
+                message: 'does not refer to an existing page',
+            }),
+        ]);
     });
     it('should handle if an unexpected error occurs', async () => {
         const result = await validateAppDefinition({