@appsemble/utils 0.24.10 → 0.24.12

package/README.md

@@ -1,9 +1,9 @@
-# ![](https://gitlab.com/appsemble/appsemble/-/raw/0.24.10/config/assets/logo.svg) Appsemble Utilities
+# ![](https://gitlab.com/appsemble/appsemble/-/raw/0.24.12/config/assets/logo.svg) Appsemble Utilities
 
 > Internal utility functions used across multiple Appsemble projects.
 
 [![npm](https://img.shields.io/npm/v/@appsemble/utils)](https://www.npmjs.com/package/@appsemble/utils)
-[![GitLab CI](https://gitlab.com/appsemble/appsemble/badges/0.24.10/pipeline.svg)](https://gitlab.com/appsemble/appsemble/-/releases/0.24.10)
+[![GitLab CI](https://gitlab.com/appsemble/appsemble/badges/0.24.12/pipeline.svg)](https://gitlab.com/appsemble/appsemble/-/releases/0.24.12)
 [![Prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg)](https://prettier.io)
 
 ## Table of Contents
@@ -26,5 +26,5 @@ not guaranteed.
 
 ## License
 
-[LGPL-3.0-only](https://gitlab.com/appsemble/appsemble/-/blob/0.24.10/LICENSE.md) ©
+[LGPL-3.0-only](https://gitlab.com/appsemble/appsemble/-/blob/0.24.12/LICENSE.md) ©
 [Appsemble](https://appsemble.com)

package/api/components/schemas/UserPropertyDefinition.js

@@ -33,6 +33,8 @@ export const UserPropertyDefinition = {
             properties: {
                 schema: {
                     anyOf: [
+                        { $ref: '#/components/schemas/JSONSchemaInteger' },
+                        { $ref: '#/components/schemas/JSONSchemaArray' },
                         { $ref: '#/components/schemas/JSONSchemaString' },
                         { $ref: '#/components/schemas/JSONSchemaNumber' },
                         { $ref: '#/components/schemas/JSONSchemaEnum' },

package/api/paths/user.js

@@ -430,7 +430,7 @@ export const paths = {
                     'multipart/form-data': {
                         schema: {
                             type: 'object',
-                            required: ['password'],
+                            required: [],
                             properties: {
                                 name: {
                                     type: 'string',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@appsemble/utils",
-  "version": "0.24.10",
+  "version": "0.24.12",
   "description": "Utility functions used in Appsemble internally",
   "keywords": [
     "app",
@@ -37,7 +37,7 @@
     "test": "vitest"
   },
   "dependencies": {
-    "@appsemble/types": "0.24.10",
+    "@appsemble/types": "0.24.12",
     "axios": "^1.0.0",
     "cron-parser": "^4.0.0",
     "date-fns": "^2.0.0",

package/validation.js

@@ -76,6 +76,19 @@ function validateResourceSchemas(definition, report) {
         }
         const { schema } = resource;
         const prefix = ['resources', resourceName, 'schema'];
+        const reservedKeywords = new Set([
+            'created',
+            'updated',
+            'author',
+            'editor',
+            'seed',
+            'ephemeral',
+            'clonable',
+            'expires',
+        ]);
+        if (reservedKeywords.has(resourceName)) {
+            report(schema, 'is a reserved keyword', ['resources', resourceName]);
+        }
         validateJSONSchema(schema, prefix, report);
         if (!('type' in schema)) {
             report(schema, 'must define type object', prefix);

package/validation.test.js

@@ -866,6 +866,96 @@ describe('validateAppDefinition', () => {
             new ValidationError('does not exist in this app’s roles', 'Unknown', undefined, ['roles', 0]),
         ]);
     });
+    it('should validate resource types against reserved keywords', async () => {
+        const app = {
+            name: 'Test app',
+            defaultPage: 'Test Page',
+            pages: [
+                {
+                    name: 'Test Page',
+                    blocks: [],
+                },
+            ],
+            resources: {
+                created: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                updated: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                author: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                editor: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                seed: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                ephemeral: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                clonable: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+                expires: {
+                    schema: {
+                        type: 'object',
+                        properties: {
+                            name: { type: 'string' },
+                        },
+                    },
+                },
+            },
+        };
+        const result = await validateAppDefinition(app, () => []);
+        expect(result.valid).toBe(false);
+        expect(result.errors).toStrictEqual([
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'created']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'updated']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'author']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'editor']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'seed']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'ephemeral']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'clonable']),
+            new ValidationError('is a reserved keyword', { type: 'object', properties: { name: { type: 'string' } } }, undefined, ['resources', 'expires']),
+        ]);
+    });
     it('should validate the resource roles exist', async () => {
         const app = createTestApp();
         app.resources.person.roles = ['Unknown'];