@appsemble/lang-sdk 0.37.0 → 0.37.2

package/iterApp.js

@@ -97,34 +97,43 @@ export function iterPage(page, callbacks, prefix = []) {
         if ('actions' in page) {
             result = Object.entries(page.actions ?? {}).some(([key, action]) => iterAction(action, callbacks, [...prefix, 'actions', key]));
         }
-        return (result ||
-            (page.type === 'flow'
-                ? page.steps.some((step, index) => iterBlockList(step.blocks, callbacks, [...prefix, 'steps', index, 'blocks']))
-                : page.tabs
-                    ? page.tabs.some((tab, index) => iterBlockList(tab.blocks, callbacks, [...prefix, 'tabs', index, 'blocks']))
-                    : iterBlockList(page.definition?.foreach.blocks ?? [], callbacks, [
-                        ...prefix,
-                        'tabs',
-                        0,
-                        'blocks',
-                    ])));
+        if (result) {
+            return true;
+        }
+        if (page.type === 'flow') {
+            const { steps = [] } = page;
+            return steps.some((step, index) => iterBlockList(step.blocks ?? [], callbacks, [...prefix, 'steps', index, 'blocks']));
+        }
+        return page.tabs
+            ? page.tabs.some((tab, index) => iterBlockList(tab.blocks, callbacks, [...prefix, 'tabs', index, 'blocks']))
+            : iterBlockList(page.definition?.foreach.blocks ?? [], callbacks, [
+                ...prefix,
+                'tabs',
+                0,
+                'blocks',
+            ]);
     }
     if (page.type === 'loop') {
         let result = false;
         if ('actions' in page) {
             result = Object.entries(page.actions ?? {}).some(([key, action]) => iterAction(action, callbacks, [...prefix, 'actions', key]));
         }
-        return (result ||
-            ['steps.first', 'steps', 'steps.last'].some((suffix) => iterBlockList(page.foreach.blocks, callbacks, [...prefix, suffix, 'blocks'])));
+        if (result) {
+            return true;
+        }
+        const { foreach } = page;
+        return ['steps.first', 'steps', 'steps.last'].some((suffix) => iterBlockList(foreach?.blocks ?? [], callbacks, [...prefix, suffix, 'blocks']));
     }
     if (page.type === 'container') {
         let result = false;
-        for (const containerPage of page.pages) {
+        const { pages = [] } = page;
+        for (const containerPage of pages) {
             result = iterPage(containerPage, callbacks, prefix);
         }
         return result;
     }
-    return iterBlockList(page.blocks, callbacks, [...prefix, 'blocks']);
+    const { blocks = [] } = page;
+    return iterBlockList(blocks, callbacks, [...prefix, 'blocks']);
 }
 /**
  * Iterate over an app definition and call each callback if relevant.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@appsemble/lang-sdk",
-  "version": "0.37.0",
+  "version": "0.37.2",
   "description": "Language SDK for Appsemble",
   "keywords": [
     "app",

package/validation.js

@@ -55,7 +55,10 @@ function validateJSONSchema(schema, prefix, report) {
     if (schema.type !== 'object') {
         return;
     }
-    if (!('properties' in schema)) {
+    // An object that only defines `additionalProperties` (an open map, e.g. a
+    // dictionary of confidence scores) is a valid schema and does not need
+    // `properties`. Only require `properties` when there is no `additionalProperties`.
+    if (!('properties' in schema) && !schema.additionalProperties) {
         report(schema, 'is missing properties', prefix);
         return;
     }
@@ -69,6 +72,11 @@ function validateJSONSchema(schema, prefix, report) {
     for (const [key, propertySchema] of Object.entries(schema.properties ?? {})) {
         validateJSONSchema(propertySchema, [...prefix, 'properties', key], report);
     }
+    // Recurse into the `additionalProperties` sub schema so open maps are validated
+    // as thoroughly as `properties`. A boolean `additionalProperties` has no sub schema.
+    if (typeof schema.additionalProperties === 'object') {
+        validateJSONSchema(schema.additionalProperties, [...prefix, 'additionalProperties'], report);
+    }
 }
 /**
  * Validates the pages in the app definition to ensure there are no duplicate page names.