@applitools/spec-driver-playwright 1.3.29 → 1.3.30

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.3.30](https://github.com/applitools/eyes.sdk.javascript1/compare/js/spec-driver-playwright@1.3.29...js/spec-driver-playwright@1.3.30) (2023-10-19)
+
+
+### Bug Fixes
+
+* improve locator transformation to simple common selector ([#1981](https://github.com/applitools/eyes.sdk.javascript1/issues/1981)) ([579dedd](https://github.com/applitools/eyes.sdk.javascript1/commit/579dedd57304b2f2f2bd3a39bdead30bea7131f0))
+
 ## [1.3.29](https://github.com/applitools/eyes.sdk.javascript1/compare/js/spec-driver-playwright@1.3.28...js/spec-driver-playwright@1.3.29) (2023-10-17)
 
 

package/dist/spec-driver.js

@@ -93,12 +93,12 @@ function toSelector(selector) {
 exports.toSelector = toSelector;
 function toSimpleCommonSelector(selector) {
     if (utils.types.instanceOf(selector, 'Locator')) {
-        ;
-        [, selector] = selector.toString().match(/Locator@(.+)/);
+        selector = selector._selector;
     }
-    if (utils.types.isString(selector))
-        return { selector };
-    return selector;
+    else if (utils.types.instanceOf(selector, 'FrameLocator')) {
+        selector = selector._frameSelector;
+    }
+    return utils.types.isString(selector) ? { selector } : null;
 }
 exports.toSimpleCommonSelector = toSimpleCommonSelector;
 function extractContext(page) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/spec-driver-playwright",
-  "version": "1.3.29",
+  "version": "1.3.30",
   "keywords": [
     "playwright",
     "chrome devtools protocol",
@@ -35,9 +35,9 @@
     "lint": "run --top-level eslint '**/*.ts'",
     "build": "run --top-level tspc --project ./tsconfig.build.json",
     "test": "run --top-level mocha './test/**/*.spec.ts' --exit",
-    "setup": "yarn playwright:setup",
-    "playwright:setup": "sudo npx playwright install-deps",
-    "up:framework": "yarn add --dev --caret playwright${APPLITOOLS_FRAMEWORK_VERSION:+@$APPLITOOLS_FRAMEWORK_VERSION}"
+    "setup": "run playwright:setup",
+    "playwright:setup": "yarn playwright install --with-deps chromium firefox webkit",
+    "up:framework": "echo \"$(jq '.devDependencies.playwright = $ENV.APPLITOOLS_FRAMEWORK_VERSION' ./package.json)\" > ./package.json"
   },
   "dependencies": {
     "@applitools/driver": "1.14.4",
@@ -47,7 +47,7 @@
     "@applitools/api-extractor": "^1.2.22",
     "@applitools/test-utils": "^1.5.17",
     "@types/node": "^12.20.55",
-    "playwright": "^1.37.0"
+    "playwright": "^1.39.0"
   },
   "peerDependencies": {
     "playwright": ">=1.0.0"

package/types/index.d.ts

@@ -6,7 +6,7 @@ export function isElement(element: any): element is Element<Node>;
 export function isSelector(selector: any): selector is Selector;
 export function isStaleElementError(err: any): boolean;
 export function toSelector(selector: import('@applitools/driver').CommonSelector<Selector>): Selector;
-export function toSimpleCommonSelector(selector: Selector): import('@applitools/driver').CommonSelector;
+export function toSimpleCommonSelector(selector: Selector): null | import('@applitools/driver').CommonSelector;
 export function extractContext(page: Driver): Context;
 export function executeScript(frame: Context, script: string | ((arg: any) => any), arg: any): Promise<any>;
 export function findElement(frame: Context, selector: Selector, parent?: undefined | Element<Node>): Promise<null | Element<SVGElement | HTMLElement>>;