@applitools/screenshoter 3.4.3 → 3.4.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/screenshoter",
-  "version": "3.4.3",
+  "version": "3.4.6",
   "description": "Applitools universal screenshoter for web and native applications",
   "keywords": [
     "applitools",
@@ -70,17 +70,17 @@
     }
   },
   "dependencies": {
-    "@applitools/logger": "1.1.12",
-    "@applitools/snippets": "2.4.2",
-    "@applitools/utils": "1.3.8",
+    "@applitools/logger": "1.1.13",
+    "@applitools/snippets": "2.4.3",
+    "@applitools/utils": "1.3.9",
     "jpeg-js": "0.4.4",
     "png-async": "0.9.4"
   },
   "devDependencies": {
     "@applitools/bongo": "^2.1.5",
-    "@applitools/driver": "^1.9.4",
+    "@applitools/driver": "^1.9.9",
     "@applitools/scripts": "1.1.0",
-    "@applitools/spec-driver-webdriverio": "1.2.12",
+    "@applitools/spec-driver-webdriverio": "1.2.14",
     "@applitools/test-utils": "1.3.3",
     "appium": "^1.22.3",
     "chromedriver": "^101.0.0",

package/src/image.js

@@ -372,7 +372,9 @@ async function copy(dstImage, srcImage, offset) {
   for (let chunk = 0; chunk < srcHeight; ++chunk) {
     const srcOffset = chunk * srcImage.width * 4
     const dstOffset = ((dstY + chunk) * dstImage.width + dstX) * 4
-    dstImage.data.set(srcImage.data.subarray(srcOffset, srcOffset + chunkLength), dstOffset)
+    if (dstOffset >= 0) {
+      dstImage.data.set(srcImage.data.subarray(srcOffset, srcOffset + chunkLength), dstOffset)
+    }
   }
 
   return dstImage

package/src/take-stitched-screenshot.js

@@ -53,11 +53,11 @@ async function takeStitchedScreenshot({
     : scrollerRegion
   logger.log('Target region calculated: ', targetRegion)
 
-  const cropRegion = await driver.getRegionInViewport(context, targetRegion)
+  const cropRegion = utils.geometry.round(await driver.getRegionInViewport(context, targetRegion))
   logger.log('Crop region calculated: ', cropRegion)
   if (utils.geometry.isEmpty(cropRegion)) throw new Error('Screenshot region is out of viewport')
 
-  image.crop(withStatusBar ? utils.geometry.offset(cropRegion, {x: 0, y: driver.statusBarHeight}) : cropRegion)
+  image.crop(withStatusBar ? utils.geometry.offset(cropRegion, {x: 0, y: driver.statusBarSize}) : cropRegion)
   await image.debug({...debug, name: 'initial', suffix: 'region'})
 
   const contentRegion = utils.geometry.region({x: 0, y: 0}, contentSize)
@@ -77,7 +77,7 @@ async function takeStitchedScreenshot({
     region.width += expectedRemainingOffset.x
     logger.verbose('region after compensation', region)
   }
-  region = utils.geometry.round(region)
+  region = utils.geometry.floor(region)
 
   const [initialRegion, ...partRegions] = utils.geometry.divide(region, image.size, overlap)
   logger.verbose('Part regions', partRegions)
@@ -151,7 +151,7 @@ async function takeStitchedScreenshot({
     stitchedImage.frame(
       firstImage,
       lastImage,
-      withStatusBar ? utils.geometry.offset(cropRegion, {x: 0, y: driver.statusBarHeight}) : cropRegion,
+      withStatusBar ? utils.geometry.offset(cropRegion, {x: 0, y: driver.statusBarSize}) : cropRegion,
     )
     await stitchedImage.debug({...debug, name: 'framed'})
 

package/src/take-viewport-screenshot.js

@@ -99,7 +99,7 @@ function makeTakeMarkedScreenshot({driver, stabilization = {}, debug, logger}) {
     else image.scale(1 / driver.pixelRatio / driver.viewportScale)
 
     if (stabilization.rotate) image.rotate(stabilization.rotate)
-    else if (driver.orientation === 'landscape' && image.width < image.height) image.rotate(-90)
+    else if (driver.orientation.startsWith('landscape') && image.width < image.height) image.rotate(-90)
 
     if (stabilization.crop) image.crop(stabilization.crop)
     else {
@@ -126,7 +126,7 @@ function makeTakeMarkedScreenshot({driver, stabilization = {}, debug, logger}) {
       const image = makeImage(await driver.takeScreenshot())
 
       if (stabilization.rotate) image.rotate(stabilization.rotate)
-      else if (driver.orientation === 'landscape' && image.width < image.height) image.rotate(-90)
+      else if (driver.orientation.startsWith('landscape') && image.width < image.height) image.rotate(-90)
 
       await image.debug({...debug, name: 'marker'})
 
@@ -156,26 +156,24 @@ function makeTakeNativeScreenshot({driver, stabilization = {}, debug, logger}) {
     else image.scale(1 / driver.pixelRatio / driver.viewportScale)
 
     if (stabilization.rotate) image.rotate(stabilization.rotate)
-    else if (driver.orientation === 'landscape' && image.width < image.height) image.rotate(-90)
+    else if (driver.orientation.startsWith('landscape') && image.width < image.height) image.rotate(-90)
 
     if (stabilization.crop) image.crop(stabilization.crop)
     else {
-      const viewportSize = await driver.getViewportSize()
+      const viewportRegion = await driver.getViewportRegion()
+      const cropRegion = {...viewportRegion}
       if (withStatusBar) {
-        image.crop({x: 0, y: 0, width: viewportSize.width, height: viewportSize.height + driver.statusBarHeight})
-      } else if (driver.isAndroid && driver.orientation === 'landscape') {
-        image.crop({
-          top: driver.statusBarHeight,
-          bottom: driver.orientation === 'landscape' ? 0 : driver.navigationBarHeight,
-          left: driver.platformVersion >= 8 ? driver.navigationBarHeight : 0,
-          right: driver.platformVersion < 8 ? driver.navigationBarHeight : 0,
-        })
-      } else {
-        image.crop({x: 0, y: driver.statusBarHeight, width: viewportSize.width, height: viewportSize.height})
+        cropRegion.y = 0
+        cropRegion.height += driver.statusBarSize
       }
+      image.crop(cropRegion)
     }
 
-    await image.debug({...debug, name, suffix: `viewport${withStatusBar ? '-with-statusbar' : ''}`})
+    await image.debug({
+      ...debug,
+      name,
+      suffix: `viewport${withStatusBar ? '-with-statusbar' : ''}`,
+    })
 
     return image
   }