@applitools/eyes-storybook 3.63.8 → 3.63.9-debug-20260126

package/CHANGELOG.md

@@ -1,5 +1,38 @@
 # Changelog
 
+## [3.63.9](https://github.com/Applitools-Dev/sdk/compare/js/eyes-storybook@3.63.8...js/eyes-storybook@3.63.9) (2026-01-21)
+
+
+### Bug Fixes
+
+* handle page expiration with ad-hoc creation in renderStories | AD-12491 ([#3485](https://github.com/Applitools-Dev/sdk/issues/3485)) ([d10664b](https://github.com/Applitools-Dev/sdk/commit/d10664b16f5d518ffe2578c6b3547161f6d69581))
+
+
+### Dependencies
+
+* @applitools/dom-snapshot bumped to 4.15.7
+  #### Bug Fixes
+
+  * add fetchConcurrency to dom-snapshot | FLD-4062 ([#3486](https://github.com/Applitools-Dev/sdk/issues/3486)) ([f523791](https://github.com/Applitools-Dev/sdk/commit/f523791b9bc60029ec0b4b6914bc54e0110bd4a2))
+* @applitools/ufg-client bumped to 1.19.0
+  #### Features
+
+  * add `fetchConcurrency` parameter to `makeAutonomousCore` FLD-4063 ([#3480](https://github.com/Applitools-Dev/sdk/issues/3480)) ([df0c60d](https://github.com/Applitools-Dev/sdk/commit/df0c60d5e74703550dba036299db7360065524f6))
+* @applitools/core bumped to 4.56.0
+  #### Features
+
+  * add `fetchConcurrency` parameter to `makeAutonomousCore` FLD-4063 ([#3480](https://github.com/Applitools-Dev/sdk/issues/3480)) ([df0c60d](https://github.com/Applitools-Dev/sdk/commit/df0c60d5e74703550dba036299db7360065524f6))
+
+
+  #### Bug Fixes
+
+  * add fetchConcurrency to dom-snapshot | FLD-4062 ([#3486](https://github.com/Applitools-Dev/sdk/issues/3486)) ([f523791](https://github.com/Applitools-Dev/sdk/commit/f523791b9bc60029ec0b4b6914bc54e0110bd4a2))
+
+
+
+* @applitools/eyes bumped to 1.38.1
+
+
 ## [3.63.8](https://github.com/Applitools-Dev/sdk/compare/js/eyes-storybook@3.63.7...js/eyes-storybook@3.63.8) (2026-01-19)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/eyes-storybook",
-  "version": "3.63.8",
+  "version": "3.63.9-debug-20260126",
   "description": "",
   "keywords": [
     "applitools",
@@ -59,14 +59,14 @@
     "up:framework": "cd test/fixtures/storybook-versions/${APPLITOOLS_FRAMEWORK_VERSION} && npm ci"
   },
   "dependencies": {
-    "@applitools/core": "4.55.0",
+    "@applitools/core": "4.56.0",
     "@applitools/driver": "1.25.0",
-    "@applitools/eyes": "1.38.0",
+    "@applitools/eyes": "1.38.1",
     "@applitools/functional-commons": "1.6.0",
     "@applitools/logger": "2.2.7",
     "@applitools/monitoring-commons": "1.0.19",
     "@applitools/spec-driver-puppeteer": "1.7.0",
-    "@applitools/ufg-client": "1.18.3",
+    "@applitools/ufg-client": "1.19.0",
     "@applitools/utils": "1.14.1",
     "@inquirer/prompts": "7.0.1",
     "boxen": "4.2.0",
@@ -106,5 +106,15 @@
   },
   "publishConfig": {
     "access": "public"
+  },
+  "lavamoat": {
+    "allowScripts": {
+      "@applitools/core>ws>bufferutil": false,
+      "@applitools/core>ws>utf-8-validate": false,
+      "@storybook/react>@pmmmwh/react-refresh-webpack-plugin>core-js-pure": false,
+      "core-js": false,
+      "puppeteer": true,
+      "@storybook/react>core-js": false
+    }
   }
 }

package/src/getIframeUrl.js

@@ -3,7 +3,6 @@ const {URL} = require('url');
 
 function getIframeUrl(baseUrl) {
   const {origin, pathname, search} = new URL(baseUrl);
-  const searchParam = search && search.replace(/^\?/, '&');
 
   let baseUrlFixed = `${origin}${pathname.replace(/\/[^\/]+\.html/, '')}`;
 
@@ -11,10 +10,15 @@ function getIframeUrl(baseUrl) {
     baseUrlFixed += '/';
   }
 
-  const url = new URL(
-    `iframe.html?eyes-storybook=true${searchParam ? searchParam : ''}`,
-    baseUrlFixed,
-  );
+  const url = new URL('iframe.html', baseUrlFixed);
+  url.searchParams.set('eyes-storybook', 'true');
+  if (search) {
+    const origParams = new URLSearchParams(search);
+    for (const [k, v] of origParams) {
+      if (k === 'path') continue; // skip story selection on initial load
+      url.searchParams.set(k, v);
+    }
+  }
   return url.href;
 }
 

package/src/renderStories.js

@@ -18,7 +18,67 @@ function makeRenderStories({
   eventEmitter = new EventEmitter(),
   signal = new AbortController().signal,
 }) {
-  let newPageIdToAdd;
+  const sparePages = {
+    queue: [],
+    isPreparing: false,
+    add(pageId) {
+      this.queue.push(pageId);
+    },
+    async getOrCreatAdHoc() {
+      const pageId = this.queue.shift();
+      if (pageId) {
+        this.replenish();
+        return pageId;
+      }
+
+      logger.log(`[sparePages] queue empty, creating ad-hoc page`);
+      try {
+        const pageObj = await pagePool.createPage();
+        await sanityCheckForPage({page: pageObj.page, pageId: pageObj.pageId});
+        return pageObj.pageId;
+      } catch (e) {
+        logger.log(`[sparePages] failed to create ad-hoc page: ${e}`);
+        return null;
+      }
+    },
+    async replenish() {
+      if (this.queue.length > 0 || this.isPreparing) {
+        return;
+      }
+      this.isPreparing = true;
+      logger.log('[sparePages] preparing...');
+      try {
+        const [errorInCreate, pageObj] = await presult(pagePool.createPage());
+        if (errorInCreate) {
+          logger.log(
+            `[sparePages] error preparing new page. This is probably a fatal problem. ${errorInCreate}`,
+          );
+          return;
+        }
+
+        const {pageId, page} = pageObj;
+        logger.log(`[sparePages] new page is ready: ${pageId}`);
+        try {
+          await sanityCheckForPage({page, pageId});
+          logger.log(`[sparePages] adding page to queue: ${pageId}`);
+          this.add(pageId);
+        } catch (errorInSanity) {
+          logger.log(
+            `[sparePages] new page ${pageId} is corrupted. preparing new page.`,
+            errorInSanity,
+          );
+          // If the page is corrupted, we close it and try again immediately (in the finally block)
+          page.close().catch(() => {});
+        }
+      } finally {
+        this.isPreparing = false;
+        // If we are still empty, try again
+        if (this.queue.length === 0) {
+          this.replenish();
+        }
+      }
+    },
+  };
 
   return async function renderStories(stories, isIE) {
     let doneStories = 0;
@@ -33,7 +93,7 @@ function makeRenderStories({
     });
     eventEmitter.emit('progress', {doneStories, totalStories});
     spinner.start();
-    prepareNewPage();
+    sparePages.replenish();
 
     await processStoryLoop();
     await allStoriesPromise;
@@ -57,13 +117,17 @@ function makeRenderStories({
       const {page, pageId, markPageAsFree, removePage, getCreatedAt} = await pagePool.getFreePage();
       const livedTime = Date.now() - getCreatedAt();
       logger.log(`[prepareNewPage] got free page: ${pageId}, lived time: ${livedTime}`);
-      if (newPageIdToAdd && livedTime > maxPageTTL) {
-        logger.log(`[prepareNewPage] replacing page ${pageId} with page ${newPageIdToAdd}`);
-        removePage();
-        page.close();
-        pagePool.addToPool(newPageIdToAdd);
-        prepareNewPage();
-        return processStoryLoop();
+      if (livedTime > maxPageTTL) {
+        const replacementPageId = await sparePages.getOrCreatAdHoc();
+        if (replacementPageId) {
+          logger.log(`[prepareNewPage] replacing page ${pageId} with page ${replacementPageId}`);
+          removePage();
+          page.close();
+          pagePool.addToPool(replacementPageId);
+          return processStoryLoop();
+        } else {
+          logger.log(`[prepareNewPage] failed to replace expired page ${pageId}. Reusing it.`);
+        }
       }
       logger.log(`[page ${pageId}] waiting for queued renders`);
       // await waitForQueuedRenders(storyDataGap);
@@ -88,7 +152,7 @@ function makeRenderStories({
 
           if (
             error &&
-            /(Runtime.callFunctionOn timed out|Protocol error|Execution context was destroyed|timeout reached when trying to take DOM for story)/.test(
+            /(Runtime.callFunctionOn timed out|Protocol error|Execution context was destroyed|timeout reached when trying to take DOM for story|page evaluate timed out)/.test(
               error.message,
             )
           ) {
@@ -165,32 +229,6 @@ function makeRenderStories({
 
       return result;
     }
-
-    async function prepareNewPage() {
-      newPageIdToAdd = null;
-      logger.log('[prepareNewPage] preparing...');
-      const [errorInCreate, pageObj] = await presult(pagePool.createPage());
-      if (errorInCreate) {
-        logger.log(
-          `[prepareNewPage] error preparing new page. This is probably a fatal problem. ${errorInCreate}`,
-        );
-        return;
-      }
-
-      const {pageId, page} = pageObj;
-      logger.log(`[prepareNewPage] new page is ready: ${pageId}`);
-      try {
-        await sanityCheckForPage({page, pageId});
-        logger.log(`[prepareNewPage] setting new page for replacement: ${pageId}`);
-        newPageIdToAdd = pageId;
-      } catch (errorInSanity) {
-        logger.log(
-          `[prepareNewPage] new page ${pageId} is corrupted. preparing new page.`,
-          errorInSanity,
-        );
-        prepareNewPage();
-      }
-    }
   };
 }