@applitools/eyes-storybook 3.37.0 → 3.37.2

package/CHANGELOG.md

@@ -4,6 +4,20 @@
 
 
 
+## [3.37.2](https://github.com/applitools/eyes.sdk.javascript1/compare/js/eyes-storybook@3.37.1...js/eyes-storybook@3.37.2) (2023-07-18)
+
+
+### Performance Improvements
+
+* additional runtime improvements ([8a33a83](https://github.com/applitools/eyes.sdk.javascript1/commit/8a33a83d4911bdd3bebff646c983d5a2de512763))
+
+## [3.37.1](https://github.com/applitools/eyes.sdk.javascript1/compare/js/eyes-storybook@3.37.0...js/eyes-storybook@3.37.1) (2023-07-18)
+
+
+### Performance Improvements
+
+* improve runtime performance ([#1763](https://github.com/applitools/eyes.sdk.javascript1/issues/1763)) ([3efcc85](https://github.com/applitools/eyes.sdk.javascript1/commit/3efcc85df1d8ec09884bd6bae26758cc4d649f97))
+
 ## [3.37.0](https://github.com/applitools/eyes.sdk.javascript1/compare/js/eyes-storybook@3.36.0...js/eyes-storybook@3.37.0) (2023-07-18)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/eyes-storybook",
-  "version": "3.37.0",
+  "version": "3.37.2",
   "description": "",
   "keywords": [
     "applitools",
@@ -71,7 +71,7 @@
     "lodash.flatten": "4.4.0",
     "lodash.pick": "4.4.0",
     "ora": "3.4.0",
-    "puppeteer": "19.8.0",
+    "puppeteer": "20.8.3",
     "strip-ansi": "6.0.0",
     "throat": "6.0.1",
     "yargs": "17.7.2"
@@ -99,7 +99,7 @@
     "ua-parser-js": "^0.7.21"
   },
   "engines": {
-    "node": ">=14.15.0"
+    "node": ">=16.16.0"
   },
   "publishConfig": {
     "access": "public"

package/src/errMessages.js

@@ -34,7 +34,8 @@ ${chalk.green(
 `;
 
 function refineErrorMessage({prefix, error}) {
-  return `${prefix} ${error.message.replace('Evaluation failed: ', '')}`;
+  const message = error && error.message ? error.message : error;
+  return `${prefix} ${message.replace('Evaluation failed: ', '')}`;
 }
 
 function deprecationWarning({deprecatedThing, newThing, isDead}) {

package/src/eyesStorybook.js

@@ -161,19 +161,12 @@ async function eyesStorybook({
   try {
     const stories = await getStoriesWithSpinner();
 
-    if (CONCURRENT_TABS <= 3) {
-      await Promise.all(
-        new Array(CONCURRENT_TABS).fill().map(async () => {
-          const {pageId} = await pagePool.createPage();
-          pagePool.addToPool(pageId);
-        }),
-      );
-    } else {
-      for (const _x of new Array(CONCURRENT_TABS).fill()) {
+    await Promise.all(
+      Array.from({length: CONCURRENT_TABS}, async () => {
         const {pageId} = await pagePool.createPage();
         pagePool.addToPool(pageId);
-      }
-    }
+      }),
+    );
 
     const filteredStories = filterStories({stories, config});
     const storiesIncludingVariations = addVariationStories({
@@ -258,6 +251,7 @@ async function eyesStorybook({
   } finally {
     logger.log('total time: ', performance['renderStories']);
     logger.log('perf results', performance);
+    pagePool.isClosed = true;
     await browser.close();
     clearTimeout(memoryTimeout);
   }

package/src/initPage.js

@@ -34,6 +34,7 @@ function makeInitPage({iframeUrl, config, browser, logger, getTransitiongIntoIE,
     }
 
     page.on('close', async () => {
+      if (pagePool.isClosed) return;
       if (!getTransitiongIntoIE() && pagePool.isInPool(pageId)) {
         logger.log(
           `Puppeteer page closed [page ${pageId}] while still in page pool, creating a new one instead`,

package/src/pagePool.js

@@ -37,6 +37,7 @@ function createPagePool({initPage, logger}) {
         await removeAndAddPage(pageId);
       }
     },
+    isClosed: false,
   };
 
   return pagePool;