@applitools/eyes-storybook 3.36.0 → 3.37.1

package/CHANGELOG.md

@@ -4,6 +4,50 @@
 
 
 
+## [3.37.1](https://github.com/applitools/eyes.sdk.javascript1/compare/js/eyes-storybook@3.37.0...js/eyes-storybook@3.37.1) (2023-07-18)
+
+
+### Performance Improvements
+
+* improve runtime performance ([#1763](https://github.com/applitools/eyes.sdk.javascript1/issues/1763)) ([3efcc85](https://github.com/applitools/eyes.sdk.javascript1/commit/3efcc85df1d8ec09884bd6bae26758cc4d649f97))
+
+## [3.37.0](https://github.com/applitools/eyes.sdk.javascript1/compare/js/eyes-storybook@3.36.0...js/eyes-storybook@3.37.0) (2023-07-18)
+
+
+### Features
+
+* support retries on stuck requests ([#1773](https://github.com/applitools/eyes.sdk.javascript1/issues/1773)) ([4db470e](https://github.com/applitools/eyes.sdk.javascript1/commit/4db470ee6829c13cfaf7e521ef91e20854266edd))
+
+
+### Bug Fixes
+
+* fix lint config and remove extranous deps ([aea605c](https://github.com/applitools/eyes.sdk.javascript1/commit/aea605c4a1d6cca37d84b464af369cdbff3c6234))
+
+
+### Dependencies
+
+* @applitools/req bumped from 1.4.0 to 1.5.0
+  #### Features
+
+  * support retries on stuck requests ([be673bb](https://github.com/applitools/eyes.sdk.javascript1/commit/be673bb505c9b21d6aea37d86e88513e95e3cb02))
+* @applitools/ufg-client bumped from 1.4.1 to 1.5.0
+  #### Features
+
+  * support retries on stuck requests ([be673bb](https://github.com/applitools/eyes.sdk.javascript1/commit/be673bb505c9b21d6aea37d86e88513e95e3cb02))
+
+
+
+* @applitools/core bumped to 3.6.2
+
+* @applitools/core-base bumped from 1.4.0 to 1.4.1
+
+* @applitools/ec-client bumped from 1.7.0 to 1.7.1
+
+* @applitools/tunnel-client bumped from 1.1.0 to 1.1.1
+
+* @applitools/nml-client bumped from 1.5.2 to 1.5.3
+
+
 ## [3.36.0](https://github.com/applitools/eyes.sdk.javascript1/compare/js/eyes-storybook-v3.35.1...js/eyes-storybook@3.36.0) (2023-07-05)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/eyes-storybook",
-  "version": "3.36.0",
+  "version": "3.37.1",
   "description": "",
   "keywords": [
     "applitools",
@@ -25,15 +25,15 @@
     "dist"
   ],
   "scripts": {
-    "lint": "eslint '**/*.js'",
+    "lint": "run --top-level eslint '**/*.js'",
     "build": "rollup -c rollup.config.js",
     "build:heavy": "node scripts/bitmap.js",
     "test": "yarn build && yarn test:mocha && yarn lint",
-    "test:mocha": "mocha --no-timeouts --trace-warnings 'test/{unit,it,e2e}/*.test.js'",
-    "test:unit": "mocha --no-timeouts --trace-warnings 'test/unit/*.test.js'",
-    "test:it": "mocha --no-timeouts --trace-warnings 'test/it/*.test.js'",
-    "test:versions": "yarn build && yarn test:e2e:versions && yarn lint",
-    "test:e2e": "mocha --no-timeouts --trace-warnings 'test/e2e/*.e2e.test.js'",
+    "test:mocha": "run --top-level mocha --no-timeouts --trace-warnings 'test/{unit,it,e2e}/*.test.js'",
+    "test:unit": "run --top-level mocha --no-timeouts --trace-warnings 'test/unit/*.test.js'",
+    "test:it": "run --top-level mocha --no-timeouts --trace-warnings 'test/it/*.test.js'",
+    "test:versions": "run --top-level yarn build && yarn test:e2e:versions && yarn lint",
+    "test:e2e": "run --top-level mocha --no-timeouts --trace-warnings 'test/e2e/*.e2e.test.js'",
     "test:e2e:versions": "npx mocha --no-timeouts --trace-warnings --require test/fixtures/storybook-versions/mochaHooks.js test/versions/*.e2e.versions.test.js",
     "test:e2e:versions_local": "APPLITOOLS_FRAMEWORK_VERSION=latest npx mocha --no-timeouts --trace-warnings --require test/fixtures/storybook-versions/mochaHooks.js test/versions/*.e2e.versions.test.js",
     "test:heavy": "node bin/eyes-storybook.js -f test/fixtures/heavyStorybook/applitools.config.js",
@@ -57,14 +57,14 @@
     "postinstall": "node src/postinstall"
   },
   "dependencies": {
-    "@applitools/core": "3.5.0",
-    "@applitools/driver": "1.13.0",
+    "@applitools/core": "^3.6.2",
+    "@applitools/driver": "^1.13.1",
     "@applitools/functional-commons": "1.6.0",
-    "@applitools/logger": "2.0.5",
+    "@applitools/logger": "^2.0.5",
     "@applitools/monitoring-commons": "1.0.19",
-    "@applitools/spec-driver-puppeteer": "1.1.68",
-    "@applitools/ufg-client": "1.3.0",
-    "@applitools/utils": "1.5.0",
+    "@applitools/spec-driver-puppeteer": "^1.1.69",
+    "@applitools/ufg-client": "^1.5.0",
+    "@applitools/utils": "^1.5.0",
     "boxen": "4.2.0",
     "chalk": "3.0.0",
     "detect-port": "1.3.0",
@@ -74,34 +74,24 @@
     "puppeteer": "19.8.0",
     "strip-ansi": "6.0.0",
     "throat": "6.0.1",
-    "yargs": "^17.7.2"
+    "yargs": "17.7.2"
   },
   "devDependencies": {
-    "@applitools/bongo": "^4.0.0",
+    "@applitools/bongo": "^5.0.4",
     "@applitools/sdk-shared": "0.9.15",
     "@applitools/snaptdout": "^1.0.1",
     "@applitools/test-server": "^1.2.2",
+    "@babel/eslint-parser": "^7.22.9",
     "@storybook/addon-interactions": "^6.4.18",
     "@storybook/react": "^6.4.18",
     "@storybook/testing-library": "^0.0.9",
     "@testing-library/dom": "^5.6.1",
-    "babel-core": "^6.26.3",
-    "babel-eslint": "^10.1.0",
-    "babel-loader": "^8.0.6",
-    "babel-preset-env": "^1.7.0",
-    "babel-preset-react": "^6.24.1",
     "bitmap-manipulation": "^2.0.0",
     "chai": "^4.2.0",
     "core-js": "^3.6.1",
-    "eslint": "^6.6.0",
-    "eslint-plugin-mocha-no-only": "^1.1.0",
-    "eslint-plugin-node": "^10.0.0",
-    "eslint-plugin-prettier": "^3.1.1",
     "express": "^4.17.1",
     "filenamify": "^4.1.0",
-    "mocha": "^10.2.0",
     "node-fetch": "^2.6.0",
-    "prettier": "^1.19.1",
     "react": "^16.12.0",
     "react-dom": "^16.12.0",
     "rollup": "^1.28.0",

package/src/cli.js

@@ -18,7 +18,7 @@ const {presult} = require('@applitools/functional-commons');
 const chalk = require('chalk');
 const {performance, timeItAsync} = makeTiming();
 
-(async function() {
+(async function () {
   try {
     const argv = yargs
       .usage('Usage: $0 [options]')

package/src/eyesStorybook.js

@@ -161,19 +161,12 @@ async function eyesStorybook({
   try {
     const stories = await getStoriesWithSpinner();
 
-    if (CONCURRENT_TABS <= 3) {
-      await Promise.all(
-        new Array(CONCURRENT_TABS).fill().map(async () => {
-          const {pageId} = await pagePool.createPage();
-          pagePool.addToPool(pageId);
-        }),
-      );
-    } else {
-      for (const _x of new Array(CONCURRENT_TABS).fill()) {
+    await Promise.all(
+      Array.from({length: CONCURRENT_TABS}, async () => {
         const {pageId} = await pagePool.createPage();
         pagePool.addToPool(pageId);
-      }
-    }
+      }),
+    );
 
     const filteredStories = filterStories({stories, config});
     const storiesIncludingVariations = addVariationStories({
@@ -258,6 +251,7 @@ async function eyesStorybook({
   } finally {
     logger.log('total time: ', performance['renderStories']);
     logger.log('perf results', performance);
+    pagePool.isClosed = true;
     await browser.close();
     clearTimeout(memoryTimeout);
   }

package/src/initPage.js

@@ -34,6 +34,7 @@ function makeInitPage({iframeUrl, config, browser, logger, getTransitiongIntoIE,
     }
 
     page.on('close', async () => {
+      if (pagePool.isClosed) return;
       if (!getTransitiongIntoIE() && pagePool.isInPool(pageId)) {
         logger.log(
           `Puppeteer page closed [page ${pageId}] while still in page pool, creating a new one instead`,

package/src/pagePool.js

@@ -37,6 +37,7 @@ function createPagePool({initPage, logger}) {
         await removeAndAddPage(pageId);
       }
     },
+    isClosed: false,
   };
 
   return pagePool;

package/src/processResults.js

@@ -79,10 +79,10 @@ function processResults({
       `\nA total of ${unresolved.length} difference${pluralize(unresolved, [
         's were',
         ' was',
-      ])} found and ${errors.length} stor${pluralize(errors, [
-        'ies',
-        'y',
-      ])} failed for ${pluralize(errors, ['', 'an '])}unexpected error${pluralize(errors)}.`,
+      ])} found and ${errors.length} stor${pluralize(errors, ['ies', 'y'])} failed for ${pluralize(
+        errors,
+        ['', 'an '],
+      )}unexpected error${pluralize(errors)}.`,
     );
   } else if (warnForUnsavedNewTests) {
     const countText =

package/src/wrapBundle.js

@@ -2,7 +2,7 @@
 
 function wrapBundle(filename) {
   return {
-    generateBundle: function(_outputOptions, bundle) {
+    generateBundle: function (_outputOptions, bundle) {
       const bundleFile = bundle[`${filename}.js`];
 
       bundleFile.code = `

package/src/yargsOptions.js

@@ -54,7 +54,7 @@ module.exports = {
       'A string that represents a story title or a regex (starts and ends with /) to match stories title',
     requiresArg: false,
     string: true,
-    coerce: function(arg) {
+    coerce: function (arg) {
       if (arg.startsWith('/') && arg.endsWith('/')) {
         // create a regex and remove slashes from the start and end of the input
         return new RegExp(arg.substring(1, arg.length - 1));