@applitools/eyes-storybook 3.29.0 → 3.29.1

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 ## Unreleased
 
 
+## 3.29.1 - 2022/6/16
+
+### Features
+- Allowed `` values in custom properties
+- Add special attribute for pseudo elements
+- Support padding for regions in the following region types - ignoreRegions, layoutRegions, strictRegions, contentRegions
+### Bug fixes
+- Fixed broken links to enums implementation in the README.md
+- Fix rendering issues with Salesforce Lightning design system
+- Add timeout when attempting to get data for a story
+
 ## 3.29.0 - 2022/6/2
 
 ### Features

package/README.md

@@ -293,7 +293,7 @@ module.exports = {
 
 Possible values for screen orientation are `landscape` and `portrait`, and if no value is specified, the default is `portrait`.
 
-The list of device names is available at https://github.com/applitools/eyes.sdk.javascript1/blob/master/packages/eyes-sdk-core/lib/config/DeviceName.js
+The list of device names is available at https://github.com/applitools/eyes.sdk.javascript1/blob/master/packages/eyes-api/src/enums/DeviceName.ts
 
 In addition, it's possible to use chrome's device emulation with custom viewport sizes, pixel density and mobile mode, by passing `deviceScaleFactor` and `mobile` in addition to `width` and `height`. For example:
 
@@ -323,7 +323,7 @@ module.exports = {
 }
 ```
 
-The list of devices is available at https://github.com/applitools/eyes.sdk.javascript1/blob/master/packages/eyes-sdk-core/lib/config/IosDeviceName.js
+The list of devices is available at https://github.com/applitools/eyes.sdk.javascript1/blob/master/packages/eyes-api/src/enums/IosDeviceName.ts
 
 Possible values for `iosVersion` are:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/eyes-storybook",
-  "version": "3.29.0",
+  "version": "3.29.1",
   "description": "",
   "keywords": [
     "applitools",
@@ -18,6 +18,9 @@
   },
   "license": "SEE LICENSE IN LICENSE",
   "author": "Applitools Team <team@applitools.com>",
+  "aliases": [
+    "storybook"
+  ],
   "bin": {
     "eyes-storybook": "./bin/eyes-storybook.js"
   },
@@ -66,15 +69,15 @@
     }
   },
   "dependencies": {
-    "@applitools/driver": "1.8.15",
-    "@applitools/eyes-sdk-core": "13.6.28",
+    "@applitools/driver": "1.9.3",
+    "@applitools/eyes-sdk-core": "13.8.1",
     "@applitools/functional-commons": "1.6.0",
-    "@applitools/logger": "1.1.8",
+    "@applitools/logger": "1.1.11",
     "@applitools/monitoring-commons": "1.0.19",
-    "@applitools/spec-driver-puppeteer": "1.1.4",
-    "@applitools/test-server": "1.0.10",
-    "@applitools/utils": "1.3.3",
-    "@applitools/visual-grid-client": "15.12.37",
+    "@applitools/spec-driver-puppeteer": "1.1.5",
+    "@applitools/test-server": "1.0.11",
+    "@applitools/utils": "1.3.7",
+    "@applitools/visual-grid-client": "15.12.44",
     "boxen": "4.2.0",
     "chalk": "3.0.0",
     "detect-port": "1.3.0",
@@ -86,7 +89,7 @@
     "yargs": "15.4.1"
   },
   "devDependencies": {
-    "@applitools/bongo": "^2.1.1",
+    "@applitools/bongo": "^2.1.5",
     "@applitools/scripts": "^1.1.0",
     "@applitools/sdk-shared": "0.9.11",
     "@applitools/snaptdout": "^1.0.1",

package/src/getStoryData.js

@@ -1,5 +1,5 @@
 'use strict';
-const {presult} = require('@applitools/functional-commons');
+const {presult, ptimeoutWithError} = require('@applitools/functional-commons');
 const {ArgumentGuard} = require('@applitools/eyes-sdk-core');
 const renderStoryWithClientAPI = require('../dist/renderStoryWithClientAPI');
 const runRunBeforeScript = require('../dist/runRunBeforeScript');
@@ -7,6 +7,7 @@ const getStoryBaselineName = require('./getStoryBaselineName');
 const {URL} = require('url');
 const runRunAfterScript = require('../dist/runRunAfterScript');
 const waitFor = require('./waitFor');
+const PAGE_EVALUATE_TIMEOUT = 120000;
 
 function makeGetStoryData({logger, takeDomSnapshots, waitBeforeCapture, reloadPagePerStory}) {
   return async function getStoryData({story, storyUrl, page, browser, waitBeforeStory}) {
@@ -18,8 +19,21 @@ function makeGetStoryData({logger, takeDomSnapshots, waitBeforeCapture, reloadPa
       const currentUrl = page.url();
       const expectedQueryParams = eyesParameters ? eyesParameters.queryParams : undefined;
       if (urlQueryParamsEquals(currentUrl, expectedQueryParams)) {
-        const err = await page.evaluate(renderStoryWithClientAPI, story.index);
-        err && handleRenderStoryError(err);
+        try {
+          const err = await ptimeoutWithError(
+            page.evaluate(renderStoryWithClientAPI, story.index),
+            PAGE_EVALUATE_TIMEOUT,
+            'page evaluate timed out!',
+          );
+          logger.log(`[story data] done with page evaluate for story index: ${story.index}`);
+          err && handleRenderStoryError(err);
+        } catch (ex) {
+          if (!ex.message.includes('Eyes could not render stories properly'))
+            handleRenderStoryError(ex);
+          else {
+            throw ex;
+          }
+        }
       } else {
         await renderStoryLegacy();
       }