@applitools/eyes-cypress 3.57.0 → 3.57.1

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## [3.57.1](https://github.com/Applitools-Dev/sdk/compare/js/eyes-cypress@3.57.0...js/eyes-cypress@3.57.1) (2025-12-28)
+
+
+### Bug Fixes
+
+* improve error notification (UFG) | AD-12270 ([#3418](https://github.com/Applitools-Dev/sdk/issues/3418)) ([a4efc55](https://github.com/Applitools-Dev/sdk/commit/a4efc55cd178dc13096fbfb066c287b0d6a452d3))
+
+
+### Dependencies
+
+* @applitools/dom-snapshot bumped to 4.15.4
+  #### Bug Fixes
+
+  * CSS variables in Shadow DOM style tags not expanded | FLD-3790 ([#3427](https://github.com/Applitools-Dev/sdk/issues/3427)) ([3d84b5f](https://github.com/Applitools-Dev/sdk/commit/3d84b5f120dd5e72dea5ec77b5d446e7ca696d52))
+* @applitools/core bumped to 4.54.1
+  #### Bug Fixes
+
+  * improve error notification (UFG) | AD-12270 ([#3418](https://github.com/Applitools-Dev/sdk/issues/3418)) ([a4efc55](https://github.com/Applitools-Dev/sdk/commit/a4efc55cd178dc13096fbfb066c287b0d6a452d3))
+
+
+
+* @applitools/eyes bumped to 1.36.19
+
+
 ## [3.57.0](https://github.com/Applitools-Dev/sdk/compare/js/eyes-cypress@3.56.6...js/eyes-cypress@3.57.0) (2025-12-14)
 
 

package/dist/plugin/getErrorsAndDiffs.js

@@ -1,9 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+const NewTestError_1 = require("@applitools/eyes/dist/errors/NewTestError");
 function getErrorsAndDiffs(testResultsArr) {
     return testResultsArr.reduce(({ failed, diffs, passed }, testResults) => {
         if (testResults instanceof Error || testResults.error) {
-            failed.push(testResults);
+            if (testResults.error && Object.keys(testResults).length > 1) {
+                failed.push(testResults);
+            }
+            else {
+                failed.push(testResults instanceof Error ? testResults : new Error(testResults.error.message));
+            }
         }
         else {
             const testStatus = testResults.status;
@@ -13,7 +19,7 @@ function getErrorsAndDiffs(testResultsArr) {
             else {
                 if (testStatus === 'Unresolved') {
                     if (testResults.isNew) {
-                        testResults.error = new Error(`${testResults.name}. Please approve the new baseline at ${testResults.url}`);
+                        testResults.error = new NewTestError_1.NewTestError(`${testResults.name}. Please approve the new baseline at ${testResults.url}`);
                         failed.push(testResults);
                     }
                     else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/eyes-cypress",
-  "version": "3.57.0",
+  "version": "3.57.1",
   "homepage": "https://applitools.com/tutorials/sdks/cypress",
   "license": "SEE LICENSE IN LICENSE",
   "main": "./index.js",
@@ -41,7 +41,7 @@
     "test:ts:run": "yarn cypress$APPLITOOLS_FRAMEWORK_VERSION run --browser chrome --project ./test/e2e/ts --config-file ./cypress-$APPLITOOLS_FRAMEWORK_VERSION.config.ts",
     "test:coverage": "cd test/generic && yarn && MOCHA_GROUP=coverage APPLITOOLS_BATCH_NAME='JS Coverage Tests: eyes-cypress' APPLITOOLS_BATCH_ID=$(uuidgen) npx cypress run",
     "test:coverage:chrome": "cd test/generic && yarn && MOCHA_GROUP=coverage APPLITOOLS_BATCH_NAME='JS Coverage Tests: eyes-cypress' APPLITOOLS_BATCH_ID=$(uuidgen) npx cypress run --browser chrome",
-    "test:e2e": "MOCHA_GROUP=e2e mkdir -p test/fixtures/testAppCopies && run --top-level mocha --no-timeouts 'test/e2e/**/*.test.js'",
+    "test:e2e": "MOCHA_GROUP=e2e mkdir -p test/fixtures/testAppCopies && run --top-level mocha --no-timeouts 'test/e2e/**/*.test.js' --parallel --jobs 4",
     "test:components": "cd test/components && yarn && npx cypress run --component",
     "cypress": "cypress open --config-file test/fixtures/cypress-play.json",
     "cypress:new": "cd test/play && yarn && npx cypress open",
@@ -52,8 +52,8 @@
     "setup": "run --top-level xvfb:setup"
   },
   "dependencies": {
-    "@applitools/core": "4.54.0",
-    "@applitools/eyes": "1.36.18",
+    "@applitools/core": "4.54.1",
+    "@applitools/eyes": "1.36.19",
     "@applitools/functional-commons": "1.6.0",
     "@applitools/logger": "2.2.7",
     "@applitools/utils": "1.14.1",

package/src/browser/commands.js

@@ -6,6 +6,10 @@ const Socket = require('./socket')
 const {socketCommands} = require('./socketCommands')
 const {TestResultsSummaryData: TestResultsSummary} = require('@applitools/eyes/dist/output/TestResultsSummary')
 const {TestResultsData} = require('@applitools/eyes/dist/output/TestResults')
+const {NewTestError} = require('@applitools/eyes/dist/errors/NewTestError')
+const {TestFailedError} = require('@applitools/eyes/dist/errors/TestFailedError')
+const {DiffsFoundError} = require('@applitools/eyes/dist/errors/DiffsFoundError')
+
 const refer = new Refer()
 const target = refer.ref('__CYPRESS_DRIVER__')
 const socket = new Socket()
@@ -44,6 +48,11 @@ function getGlobalConfigProperty(prop) {
   return property ? (shouldParse.includes(prop) ? JSON.parse(property) : property) : undefined
 }
 
+function printToLog(message) {
+  Cypress.log({name: 'Eyes Log', message})
+  // cy.task('log', message)
+}
+
 // tasks = tapFile and closeBatch
 const shouldDoPostSpecTasks =
   !getGlobalConfigProperty('eyesIsDisabled') &&
@@ -53,8 +62,15 @@ const shouldCallAfterHook =
   (shouldDoPostSpecTasks || Cypress.config('eyesFailCypressOnDiff')) &&
   !Cypress.config('appliConfFile').failCypressAfterAllSpecs
 
+const notFailCypressAfterAllSpecs = !Cypress.config('appliConfFile').failCypressAfterAllSpecs
+
 Cypress.Commands.add('eyesGetAllTestResults', () => {
   Cypress.log({name: 'Eyes: getAllTestResults'})
+  printToLog(
+    `Eyes: getAllTestResults commands eyesFailCypressOnDiff:${Cypress.config(
+      'eyesFailCypressOnDiff',
+    )}, failCypressAfterAllSpecs:${Cypress.config('appliConfFile').failCypressAfterAllSpecs}`,
+  )
   return cy.then({timeout: 86400000}, async () => {
     if (isCurrentTestDisabled) {
       isCurrentTestDisabled = false
@@ -62,6 +78,11 @@ Cypress.Commands.add('eyesGetAllTestResults', () => {
     }
 
     const summary = await getSummary()
+    const hasErrors = summary.results?.some(({result}) => result.error !== undefined && isNonVisualTestError(result))
+    if (hasErrors && !shouldCallAfterHook && notFailCypressAfterAllSpecs) {
+      printToLog('Eyes: throwErrorIfExistsInSummary for all')
+      await throwErrorIfExistsInSummary(summary, true, true)
+    }
     return new TestResultsSummary({summary, core: {deleteTest}})
   })
 })
@@ -79,30 +100,14 @@ Cypress.Commands.add('eyesGetResults', (args = {}) => {
 if (shouldCallAfterHook) {
   after(() => {
     if (!manager) return
+    printToLog('Eyes: shouldCallAfterHook after each spec')
     return cy.then({timeout: 86400000}, async () => {
       if (isCurrentTestDisabled) {
         isCurrentTestDisabled = false
         return
       }
-      const resultConfig = {
-        showLogs: Cypress.config('appliConfFile').showLogs,
-        shouldThrowError: Cypress.config('eyesFailCypressOnDiff'),
-        isTextTerminal: Cypress.config('isTextTerminal'),
-        tapDirPath: Cypress.config('appliConfFile').tapDirPath,
-        tapFileName: Cypress.config('appliConfFile').tapFileName,
-        shouldCreateTapFile: shouldDoPostSpecTasks,
-      }
-
       const summary = await getSummary()
-      const testResults = summary.results.map(({result}) => result)
-      const message = await socket.request('Test.printTestResults', {testResults, resultConfig})
-      if (
-        !!getGlobalConfigProperty('eyesFailCypressOnDiff') &&
-        message &&
-        message.includes('Eyes-Cypress detected diffs or errors')
-      ) {
-        throw new Error(message)
-      }
+      await throwErrorIfExistsInSummary(summary, Cypress.config('eyesFailCypressOnDiff'), false)
     })
   })
 }
@@ -204,6 +209,61 @@ Cypress.Commands.add('debugHistory', async function () {
   return history
 })
 
+function isNewTestError(testResult) {
+  const result = testResult.error instanceof NewTestError
+  printToLog(`Eyes: isNewTestError result: ${result} for testResult.error: ${JSON.stringify(testResult.error)}`)
+  return result
+}
+
+function isTestFailedError(testResult) {
+  const result = testResult.error instanceof TestFailedError
+  printToLog(`Eyes: isTestFailedError result: ${result} for testResult.error: ${JSON.stringify(testResult.error)}`)
+  return result
+}
+
+function isDiffsFoundError(testResult) {
+  const result = testResult.error instanceof DiffsFoundError
+  printToLog(`Eyes: isDiffsFoundError result: ${result} for testResult.error: ${JSON.stringify(testResult.error)}`)
+  return result
+}
+
+function isNonVisualTestError(testResult) {
+  const result =
+    testResult.error && !isNewTestError(testResult) && !isTestFailedError(testResult) && !isDiffsFoundError(testResult)
+  printToLog(`Eyes: isNonVisualTestError result: ${result} for testResult.error: ${JSON.stringify(testResult.error)}`)
+  return result
+}
+
+async function throwErrorIfExistsInSummary(summary, shouldThrowError, shouldDisplayCriticalErrors) {
+  const resultConfig = {
+    showLogs: Cypress.config('appliConfFile').showLogs,
+    shouldThrowError: shouldThrowError,
+    isTextTerminal: Cypress.config('isTextTerminal'),
+    tapDirPath: Cypress.config('appliConfFile').tapDirPath,
+    tapFileName: Cypress.config('appliConfFile').tapFileName,
+    shouldCreateTapFile: shouldDoPostSpecTasks,
+  }
+  const testResults = summary.results?.map(({result}) => result) ?? []
+  const filteredTestResults = shouldDisplayCriticalErrors
+    ? testResults.filter(testResult => testResult.error && isNonVisualTestError(testResult))
+    : testResults // all results
+  const message = await socket.request('Test.printTestResults', {testResults: filteredTestResults, resultConfig})
+  printToLog(
+    `Eyes: throwErrorIfExistsInSummary ${
+      shouldDisplayCriticalErrors ? 'critical errors' : 'all errors'
+    }, results message: ${message}`,
+  )
+  if (
+    (!!getGlobalConfigProperty('eyesFailCypressOnDiff') &&
+      message &&
+      message.includes('Eyes-Cypress detected diffs or errors')) ||
+    (shouldDisplayCriticalErrors && filteredTestResults.length > 0 && message)
+  ) {
+    printToLog('Eyes: throwErrorIfExistsInSummary throwing error')
+    throw new Error(message)
+  }
+}
+
 function setRootContext() {
   cy.state('window').parent.document['applitools-marker'] = 'root-context'
 }

package/src/plugin/getErrorsAndDiffs.ts

@@ -1,8 +1,14 @@
+import {NewTestError} from '@applitools/eyes/dist/errors/NewTestError'
+
 export default function getErrorsAndDiffs(testResultsArr: any) {
   return testResultsArr.reduce(
     ({failed, diffs, passed}: any, testResults: any) => {
       if (testResults instanceof Error || testResults.error) {
-        failed.push(testResults)
+        if (testResults.error && Object.keys(testResults).length > 1) {
+          failed.push(testResults)
+        } else {
+          failed.push(testResults instanceof Error ? testResults : new Error(testResults.error.message))
+        }
       } else {
         const testStatus = testResults.status
         if (testStatus === 'Passed') {
@@ -10,7 +16,7 @@ export default function getErrorsAndDiffs(testResultsArr: any) {
         } else {
           if (testStatus === 'Unresolved') {
             if (testResults.isNew) {
-              testResults.error = new Error(
+              testResults.error = new NewTestError(
                 `${testResults.name}. Please approve the new baseline at ${testResults.url}`,
               )
               failed.push(testResults)