@applitools/driver 1.8.9 → 1.8.12

package/dist/context.js

@@ -479,8 +479,10 @@ class Context {
             const contextRegion = await currentContext.getClientRegion();
             // const contextScrollingRegion = await currentContext.getScrollingRegion()
             const parentContextInnerOffset = (_b = (await ((_a = currentContext.parent) === null || _a === void 0 ? void 0 : _a.getInnerOffset()))) !== null && _b !== void 0 ? _b : { x: 0, y: 0 };
-            if (utils.geometry.contains(contextRegion, region) && !utils.geometry.equals(contextRegion, region)) {
-                this._logger.log('Intersecting context region', region, 'with context region', contextRegion);
+            // TODO revisit
+            if (this.driver.isWeb ||
+                (!utils.geometry.equals(contextRegion, region) && utils.geometry.contains(contextRegion, region))) {
+                this._logger.log('Intersecting context region', contextRegion, 'with context region', region);
                 region = utils.geometry.intersect(contextRegion, utils.geometry.offset(region, contextRegion));
                 // region = utils.geometry.intersect(contextScrollingRegion, region)
                 region = utils.geometry.offsetNegative(region, parentContextInnerOffset);

package/dist/element.js

@@ -97,6 +97,27 @@ class Element {
             return this._spec.isEqualElements(this.context.target, this.target, element);
         }
     }
+    async contains(innerElement) {
+        const contains = await this.withRefresh(async () => {
+            innerElement = innerElement instanceof Element ? innerElement.target : innerElement;
+            if (this.driver.isWeb) {
+                this._logger.log('Checking if web element with selector', this.selector, 'contains element', innerElement);
+                return false; // TODO implement a snipped for web
+            }
+            else {
+                this._logger.log('Checking if native element with selector', this.selector, 'contains element', innerElement);
+                // appium doesn't have a way to check if an element is contained in another element, so juristic applied
+                if (await this.equals(innerElement))
+                    return false;
+                // if inner element region is located contained in the this element region, then it is contained
+                const region = await this._spec.getElementRegion(this.driver.target, this.target);
+                const innerRegion = await this._spec.getElementRegion(this.driver.target, innerElement);
+                return utils.geometry.contains(region, innerRegion);
+            }
+        });
+        this._logger.log('Element with selector', this.selector, contains ? 'contains' : `doesn't contain`, innerElement);
+        return contains;
+    }
     async init(context) {
         this._context = context;
         this._logger = context._logger;
@@ -123,13 +144,9 @@ class Element {
                 const normalizedRegion = await this.driver.normalizeRegion(region);
                 // if element is a child of scrolling element, then region location should be adjusted
                 const scrollingElement = await this.context.getScrollingElement();
-                if (scrollingElement) {
-                    const scrollingRegion = await this._spec.getElementRegion(this.driver.target, scrollingElement.target);
-                    if (utils.geometry.contains(scrollingRegion, region) && !(await this.equals(scrollingElement))) {
-                        return utils.geometry.offset(normalizedRegion, await scrollingElement.getScrollOffset());
-                    }
-                }
-                return normalizedRegion;
+                return (await (scrollingElement === null || scrollingElement === void 0 ? void 0 : scrollingElement.contains(this)))
+                    ? utils.geometry.offset(normalizedRegion, await scrollingElement.getScrollOffset())
+                    : normalizedRegion;
             }
         });
         this._logger.log('Extracted region', region);
@@ -288,7 +305,7 @@ class Element {
     }
     async scrollTo(offset) {
         return this.withRefresh(async () => {
-            offset = utils.geometry.round(offset);
+            offset = utils.geometry.round({ x: Math.max(offset.x, 0), y: Math.max(offset.y, 0) });
             if (this.driver.isWeb) {
                 let actualOffset = await this.context.execute(snippets.scrollTo, [this, offset]);
                 // iOS has an issue when scroll offset is read immediately after it is been set it will always return the exact value that was set

package/dist/spec-utils.js

@@ -23,7 +23,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
     return result;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.splitSelector = exports.transformSelector = exports.isSelector = exports.isCommonSelector = void 0;
+exports.withFastCache = exports.splitSelector = exports.transformSelector = exports.isSelector = exports.isCommonSelector = void 0;
 const utils = __importStar(require("@applitools/utils"));
 function isCommonSelector(spec, selector) {
     return (utils.types.isPlainObject(selector) &&
@@ -79,3 +79,24 @@ function splitSelector(spec, selector) {
     return { contextSelectors, elementSelector };
 }
 exports.splitSelector = splitSelector;
+function withFastCache(spec) {
+    const cache = new Map();
+    return Object.entries(spec).reduce((spec, [name, command]) => {
+        spec[name] = (...args) => {
+            const value = cache.get(command);
+            if ((value === null || value === void 0 ? void 0 : value.args.length) === args.length && value.args.every((arg, index) => arg === args[index])) {
+                return value.result;
+            }
+            else {
+                cache.delete(command);
+            }
+            const result = command(...args);
+            if (!(result instanceof Promise))
+                return result;
+            cache.set(command, { args, result });
+            return result.finally(() => setImmediate(() => cache.delete(command)));
+        };
+        return spec;
+    }, {});
+}
+exports.withFastCache = withFastCache;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/driver",
-  "version": "1.8.9",
+  "version": "1.8.12",
   "description": "Applitools universal framework wrapper",
   "keywords": [
     "applitools",

package/types/element.d.ts

@@ -31,6 +31,7 @@ export declare class Element<TDriver, TContext, TElement, TSelector> {
     get driver(): import("./driver").Driver<TDriver, TContext, TElement, TSelector>;
     get isRef(): boolean;
     equals(element: Element<TDriver, TContext, TElement, TSelector> | TElement): Promise<boolean>;
+    contains(innerElement: Element<TDriver, TContext, TElement, TSelector> | TElement): Promise<boolean>;
     init(context: Context<TDriver, TContext, TElement, TSelector>): Promise<this>;
     getRegion(): Promise<types.Region>;
     getClientRegion(): Promise<types.Region>;

package/types/spec-utils.d.ts

@@ -17,4 +17,5 @@ export declare function splitSelector<TSelector>(spec: Pick<types.SpecDriver<unk
     contextSelectors: types.Selector<TSelector>[];
     elementSelector: types.Selector<TSelector>;
 };
+export declare function withFastCache<TSpecDriver extends types.SpecDriver<unknown, unknown, unknown, unknown>>(spec: TSpecDriver): TSpecDriver;
 export {};