@applitools/driver 1.4.3 → 1.4.4

package/CHANGELOG.md

@@ -3,6 +3,11 @@
 ## Unreleased
 
 
+## 1.4.4 - 2021/12/20
+
+- improve native android app scrolling performance
+- fix bug with `Buffer.from` and base64
+
 ## 1.4.3 - 2021/12/17
 
 - convert base64 result of `spec.takeScreenshot` to `Buffer` before return it from `Driver`'s `takeScreenshot` method

package/dist/driver.js

@@ -392,7 +392,7 @@ class Driver {
     async takeScreenshot() {
         const image = await this._spec.takeScreenshot(this.target);
         if (utils.types.isString(image)) {
-            return Buffer.from(image.replace(/[\r\n]+/g, ''));
+            return Buffer.from(image.replace(/[\r\n]+/g, ''), 'base64');
         }
         return image;
     }

package/dist/element.js

@@ -289,6 +289,7 @@ class Element {
                 if (this.driver.isAndroid) {
                     remainingOffset = utils.geometry.scale(remainingOffset, this.driver.pixelRatio);
                 }
+                const actions = [];
                 const touchPadding = await this.getTouchPadding();
                 const xPadding = Math.max(Math.floor(effectiveRegion.width * 0.1), touchPadding);
                 const yTrack = Math.floor(effectiveRegion.y + effectiveRegion.height / 2); // center
@@ -299,7 +300,7 @@ class Element {
                 while (xRemaining > 0) {
                     const xRight = effectiveRegion.x + Math.min(xRemaining + xPadding, effectiveRegion.width - xPadding);
                     const [xStart, xEnd] = xDirection === 'right' ? [xRight, xLeft] : [xLeft, xRight];
-                    await this._spec.performAction(this.driver.target, [
+                    actions.push([
                         { action: 'press', y: yTrack, x: xStart },
                         { action: 'wait', ms: 100 },
                         { action: 'moveTo', y: yTrack, x: xStart + xGap },
@@ -320,7 +321,7 @@ class Element {
                 while (yRemaining > 0) {
                     const yTop = Math.max(yBottom - yRemaining, effectiveRegion.y + yPadding);
                     const [yStart, yEnd] = yDirection === 'down' ? [yBottom, yTop] : [yTop, yBottom];
-                    await this._spec.performAction(this.driver.target, [
+                    actions.push([
                         { action: 'press', x: xTrack, y: yStart },
                         { action: 'wait', ms: 100 },
                         { action: 'moveTo', x: xTrack, y: yStart + yGap },
@@ -332,6 +333,15 @@ class Element {
                     ]);
                     yRemaining -= yBottom - yTop;
                 }
+                // ios actions should be executed one-by-one sequentially, otherwise the result isn't stable
+                if (this.driver.isIOS) {
+                    for (const action of actions) {
+                        await this._spec.performAction(this.driver.target, action);
+                    }
+                }
+                else {
+                    await this._spec.performAction(this.driver.target, [].concat(...actions));
+                }
                 const actualScrollableRegion = await this.getClientRegion();
                 this._state.scrollOffset = utils.geometry.offsetNegative(requiredOffset, {
                     x: scrollableRegion.x - actualScrollableRegion.x,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/driver",
-  "version": "1.4.3",
+  "version": "1.4.4",
   "description": "Applitools universal framework wrapper",
   "keywords": [
     "applitools",