@applitools/core 4.54.2 → 4.54.3-debug

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [4.54.3](https://github.com/Applitools-Dev/sdk/compare/js/core@4.54.2...js/core@4.54.3) (2026-01-14)
+
+
+### Bug Fixes
+
+* `close`/`getResults` race condition ([#3450](https://github.com/Applitools-Dev/sdk/issues/3450)) ([2e5437d](https://github.com/Applitools-Dev/sdk/commit/2e5437dcfde6fda58d76227659ee249bfa3885a7))
+
 ## [4.54.2](https://github.com/Applitools-Dev/sdk/compare/js/core@4.54.1...js/core@4.54.2) (2026-01-11)
 
 

package/dist/automation/close.js

@@ -30,22 +30,25 @@ function makeClose({ eyes, driver, environments: defaultEnvironments, logger: ma
             logger.log('Command "close" starting filler tests for environments', settings.environments);
             await Promise.all(uniqueEnvironments.map(environment => eyes.getBaseEyes({ settings: { environment }, logger })));
         }
-        eyes.storage.forEach(async (item) => {
-            var _a, _b;
-            try {
-                const [eyes] = await Promise.all([item.eyes, ...item.jobs]);
+        eyes.storage.forEach(item => {
+            const closePromise = (async () => {
+                var _a, _b;
                 try {
-                    await eyes.close({ settings, logger });
+                    const [eyes] = await Promise.all([item.eyes, ...item.jobs]);
+                    try {
+                        await eyes.close({ settings, logger });
+                    }
+                    catch (error) {
+                        logger.warn('Command "close" received an error during performing, trying to perform abort instead', error);
+                        await eyes.abort({ settings, logger });
+                    }
                 }
                 catch (error) {
-                    logger.warn('Command "close" received an error during performing, trying to perform abort instead', error);
-                    await eyes.abort({ settings, logger });
+                    logger.warn('Command "close" received an error during waiting for eyes instances in background', error);
+                    await ((_b = (_a = error.info) === null || _a === void 0 ? void 0 : _a.eyes) === null || _b === void 0 ? void 0 : _b.abort({ settings, logger }));
                 }
-            }
-            catch (error) {
-                logger.warn('Command "close" received an error during waiting for eyes instances in background', error);
-                await ((_b = (_a = error.info) === null || _a === void 0 ? void 0 : _a.eyes) === null || _b === void 0 ? void 0 : _b.abort({ settings, logger }));
-            }
+            })();
+            item.jobs.push(closePromise);
         });
     };
 }

package/dist/autonomous/core.js

@@ -12,9 +12,9 @@ const open_eyes_1 = require("./open-eyes");
 const open_check_and_close_1 = require("./open-check-and-close");
 const register_default_scripts_1 = require("../ufg/utils/register-default-scripts");
 const calculate_estimated_time_1 = require("./calculate-estimated-time");
-function makeAutonomousCore({ spec, clients, base: defaultBase, asyncCache, agentId = 'core-autonomous', logger: defaultLogger, } = {}) {
+function makeAutonomousCore({ spec, clients, base: defaultBase, asyncCache, fetchConcurrency, agentId = 'core-autonomous', logger: defaultLogger, } = {}) {
     const logger = (0, logger_1.makeLogger)({ logger: defaultLogger, format: { label: 'core-autonomous' } });
-    const core = (0, core_1.makeCore)({ spec, clients, base: defaultBase, asyncCache, agentId, logger });
+    const core = (0, core_1.makeCore)({ spec, clients, base: defaultBase, asyncCache, fetchConcurrency, agentId, logger });
     return {
         type: 'autonomous',
         takeSnapshots: spec && (0, take_snapshots_1.makeTakeSnapshots)({ core, spec, logger }),

package/dist/ufg/take-snapshots.js

@@ -27,6 +27,7 @@ function makeTakeSnapshots({ core, spec, signal, logger: mainLogger }) {
         const { elementReferencesToMark, getGeneratedSelectors } = (0, to_generated_selectors_1.toGeneratedSelectors)({
             elementReferences,
             logger,
+            logDeprecations,
             // dead code - `transformElementReference` was used for NMG but it's not longer used anywhere
             transformElementReference: elementReference => { var _a; return ((0, driver_1.isSelector)(elementReference) && ((_a = spec === null || spec === void 0 ? void 0 : spec.toSimpleCommonSelector) === null || _a === void 0 ? void 0 : _a.call(spec, elementReference))) || undefined; },
         });
@@ -78,6 +79,7 @@ function makeTakeSnapshots({ core, spec, signal, logger: mainLogger }) {
         }
         else {
             // dead code - used for NMG
+            logDeprecations('takeSnapshots: taking native snapshots is no longer supported. How did you reach this message? (dead code)');
             const nmlClient = await core.getNMLClient({
                 driver,
                 settings: { ...account.eyesServer, supportedEnvironmentsUrl: account.supportedEnvironmentsUrl },
@@ -125,6 +127,18 @@ function makeTakeSnapshots({ core, spec, signal, logger: mainLogger }) {
             title,
             userAgent,
         }));
+        function logDeprecations(...args) {
+            core.logEvent({
+                settings: {
+                    level: 'Error',
+                    event: {
+                        type: 'SDK.unreachableCodeReached',
+                        message: args.join(' '),
+                    },
+                    ...account.eyesServer,
+                },
+            });
+        }
     };
 }
 exports.makeTakeSnapshots = makeTakeSnapshots;

package/dist/ufg/utils/to-generated-selectors.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.toGeneratedSelectors = void 0;
-function toGeneratedSelectors({ elementReferences, logger, transformElementReference, }) {
+function toGeneratedSelectors({ elementReferences, logger, transformElementReference, logDeprecations, }) {
     var _a, _b, _c;
     const elementReferencesToMark = [
         (_a = elementReferences.target) !== null && _a !== void 0 ? _a : [],
@@ -51,8 +51,9 @@ function toGeneratedSelectors({ elementReferences, logger, transformElementRefer
                 };
             });
         }
-        else {
+        else if (target || scrolling || calculate.length) {
             // the entire else statement should be a dead code that was used for NMG, will be removed later
+            logDeprecations('toGeneratedSelectors: `transformElementReference` was unexpectedly called.');
             target = elementReferences.target && transformElementReference(elementReferences.target);
             scrolling = elementReferences.scrolling && transformElementReference(elementReferences.scrolling);
             calculate = ((_c = elementReferences.calculate) !== null && _c !== void 0 ? _c : []).map(elementReference => {
@@ -61,7 +62,7 @@ function toGeneratedSelectors({ elementReferences, logger, transformElementRefer
                 return { originalSelector: selector, safeSelector: selector };
             });
         }
-        return { target: target, scrolling, calculate };
+        return { target, scrolling, calculate };
     }
 }
 exports.toGeneratedSelectors = toGeneratedSelectors;

package/dist/ufg/utils/to-safe-check-settings.js

@@ -47,9 +47,10 @@ function toSafeCheckSettings({ settings }) {
                 const { region, ...options } = utils.types.has(reference, 'region') ? reference : { region: reference };
                 if (isRegion(region))
                     return reference;
-                const { originalSelector, safeSelector } = selectors.calculate.shift();
-                if (!safeSelector)
+                const selectorInfo = selectors.calculate.shift();
+                if (!(selectorInfo === null || selectorInfo === void 0 ? void 0 : selectorInfo.safeSelector))
                     return [];
+                const { originalSelector, safeSelector } = selectorInfo;
                 return {
                     region: safeSelector,
                     regionId: utils.types.isString(originalSelector) ? originalSelector : originalSelector === null || originalSelector === void 0 ? void 0 : originalSelector.selector,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/core",
-  "version": "4.54.2",
+  "version": "4.54.3-debug",
   "homepage": "https://applitools.com",
   "bugs": {
     "url": "https://github.com/applitools/eyes.sdk.javascript1/issues"

package/types/autonomous/core.d.ts

@@ -12,8 +12,9 @@ type Options<TSpec extends SpecType> = {
     };
     base?: BaseCore;
     asyncCache?: AsyncCache;
+    fetchConcurrency?: number;
     agentId?: string;
     logger?: Logger;
 };
-export declare function makeAutonomousCore<TSpec extends SpecType>({ spec, clients, base: defaultBase, asyncCache, agentId, logger: defaultLogger, }?: Options<TSpec>): AutonomousCore<TSpec>;
+export declare function makeAutonomousCore<TSpec extends SpecType>({ spec, clients, base: defaultBase, asyncCache, fetchConcurrency, agentId, logger: defaultLogger, }?: Options<TSpec>): AutonomousCore<TSpec>;
 export {};

package/types/ufg/utils/to-generated-selectors.d.ts

@@ -1,7 +1,7 @@
 import { type SpecType, type ElementReference } from '@applitools/driver';
 import type { Logger } from '@applitools/logger';
 import { type Selector as UFGSelector } from '@applitools/ufg-client';
-export declare function toGeneratedSelectors<TSpec extends SpecType>({ elementReferences, logger, transformElementReference, }: {
+export declare function toGeneratedSelectors<TSpec extends SpecType>({ elementReferences, logger, transformElementReference, logDeprecations, }: {
     elementReferences: {
         target?: ElementReference<TSpec>;
         scrolling?: ElementReference<TSpec>;
@@ -9,6 +9,7 @@ export declare function toGeneratedSelectors<TSpec extends SpecType>({ elementRe
     };
     transformElementReference: (elementReference: ElementReference<TSpec>) => UFGSelector | undefined;
     logger: Logger;
+    logDeprecations: (...args: string[]) => void;
 }): {
     elementReferencesToMark: (string | TSpec["element"] | TSpec["secondary"]["element"] | TSpec["selector"] | TSpec["secondary"]["selector"] | {
         selector: string | TSpec["selector"] | TSpec["secondary"]["selector"];