@applitools/core 4.16.2 → 4.16.3

package/CHANGELOG.md

@@ -1,5 +1,37 @@
 # Changelog
 
+## [4.16.3](https://github.com/Applitools-Dev/sdk/compare/js/core@4.16.2...js/core@4.16.3) (2024-06-11)
+
+
+### Bug Fixes
+
+* cache nml client per driver session ([#2368](https://github.com/Applitools-Dev/sdk/issues/2368)) ([5840389](https://github.com/Applitools-Dev/sdk/commit/5840389f74111c0e0e68026389c755c59a027b74))
+
+
+### Dependencies
+
+* @applitools/spec-driver-webdriver bumped to 1.1.9
+
+* @applitools/spec-driver-selenium bumped to 1.5.80
+
+* @applitools/spec-driver-puppeteer bumped to 1.4.9
+
+* @applitools/driver bumped to 1.17.4
+  #### Bug Fixes
+
+  * cache nml client per driver session ([#2368](https://github.com/Applitools-Dev/sdk/issues/2368)) ([5840389](https://github.com/Applitools-Dev/sdk/commit/5840389f74111c0e0e68026389c755c59a027b74))
+* @applitools/screenshoter bumped to 3.8.33
+
+* @applitools/nml-client bumped to 1.8.7
+
+* @applitools/ec-client bumped to 1.8.9
+  #### Bug Fixes
+
+  * shadow dom self healing ([#2375](https://github.com/Applitools-Dev/sdk/issues/2375)) ([4d3a88c](https://github.com/Applitools-Dev/sdk/commit/4d3a88cbc3e05c3dd317afbb5de8d677368c346d))
+
+
+
+
 ## [4.16.2](https://github.com/Applitools-Dev/sdk/compare/js/core@4.16.1...js/core@4.16.2) (2024-06-01)
 
 

package/dist/automation/get-nml-client.js

@@ -1,42 +1,27 @@
 "use strict";
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.makeGetNMLClient = void 0;
 const nml_client_1 = require("@applitools/nml-client");
-const utils = __importStar(require("@applitools/utils"));
+const clients = new Map();
 function makeGetNMLClient({ client, logger: mainLogger }) {
-    const getNMLClientWithCache = utils.general.cachify(getNMLClient, ([options]) => client ? 'default' : [options.driver.guid, options.settings]);
-    if (client)
-        getNMLClientWithCache.setCachedValue('default', Promise.resolve(client));
-    return getNMLClientWithCache;
-    async function getNMLClient({ driver, settings, logger = mainLogger, }) {
+    return async function getNMLClient({ driver, settings, logger, }) {
+        if (client)
+            return client;
         logger = logger.extend(mainLogger);
-        const brokerUrl = await driver.extractBrokerUrl();
-        if (!brokerUrl)
-            throw new Error('Unable to extract broker url from the device');
-        return (0, nml_client_1.makeNMLClient)({ settings: { brokerUrl, ...settings }, logger });
-    }
+        const { sessionId } = await driver.getDriverInfo();
+        const cacheKey = sessionId ? JSON.stringify({ sessionId, settings }) : JSON.stringify({ guid: driver.guid, settings });
+        const clientFromCache = clients.get(cacheKey);
+        if (clientFromCache) {
+            return clientFromCache;
+        }
+        else {
+            const brokerUrl = await driver.extractBrokerUrl();
+            if (!brokerUrl)
+                throw new Error('Unable to extract broker url from the device');
+            const nmlClient = (0, nml_client_1.makeNMLClient)({ settings: { brokerUrl, ...settings }, logger });
+            clients.set(cacheKey, nmlClient);
+            return nmlClient;
+        }
+    };
 }
 exports.makeGetNMLClient = makeGetNMLClient;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/core",
-  "version": "4.16.2",
+  "version": "4.16.3",
   "homepage": "https://applitools.com",
   "bugs": {
     "url": "https://github.com/applitools/eyes.sdk.javascript1/issues"
@@ -77,15 +77,15 @@
     "@applitools/core-base": "1.15.2",
     "@applitools/dom-capture": "11.2.8",
     "@applitools/dom-snapshot": "4.11.2",
-    "@applitools/driver": "1.17.3",
-    "@applitools/ec-client": "1.8.8",
+    "@applitools/driver": "1.17.4",
+    "@applitools/ec-client": "1.8.9",
     "@applitools/logger": "2.0.17",
-    "@applitools/nml-client": "1.8.6",
+    "@applitools/nml-client": "1.8.7",
     "@applitools/req": "1.7.1",
-    "@applitools/screenshoter": "3.8.32",
+    "@applitools/screenshoter": "3.8.33",
     "@applitools/snippets": "2.4.26",
     "@applitools/socket": "1.1.17",
-    "@applitools/spec-driver-webdriver": "1.1.8",
+    "@applitools/spec-driver-webdriver": "1.1.9",
     "@applitools/ufg-client": "1.12.1",
     "@applitools/utils": "1.7.3",
     "@types/ws": "8.5.5",
@@ -100,8 +100,8 @@
   "devDependencies": {
     "@applitools/bongo": "^5.10.0",
     "@applitools/sea": "^1.0.0",
-    "@applitools/spec-driver-puppeteer": "^1.4.8",
-    "@applitools/spec-driver-selenium": "^1.5.79",
+    "@applitools/spec-driver-puppeteer": "^1.4.9",
+    "@applitools/spec-driver-selenium": "^1.5.80",
     "@applitools/test-server": "^1.2.2",
     "@applitools/test-utils": "^1.5.17",
     "@applitools/tunnel-client": "^1.5.4",

package/types/automation/get-nml-client.d.ts

@@ -5,13 +5,9 @@ type Options = {
     client?: NMLClient;
     logger: Logger;
 };
-export declare function makeGetNMLClient({ client, logger: mainLogger }: Options): (({ driver, settings, logger, }: {
+export declare function makeGetNMLClient({ client, logger: mainLogger }: Options): ({ driver, settings, logger, }: {
     driver: Driver<SpecType>;
     settings: Omit<NMLClientSettings, 'brokerUrl'>;
-    logger?: Logger | undefined;
-}) => Promise<NMLClient>) & {
-    getCachedValues(): Promise<NMLClient>[];
-    setCachedValue(key: any, value: Promise<NMLClient>): void;
-    clearCache(): void;
-};
+    logger: Logger;
+}) => Promise<NMLClient>;
 export {};

package/types/automation/types.d.ts

@@ -60,7 +60,7 @@ export interface Core<TSpec extends SpecType> extends Omit<BaseCore.Core, 'openE
     getNMLClient(options: {
         settings: Omit<NMLClientSettings, 'brokerUrl'>;
         driver: Driver<TSpec>;
-        logger?: Logger;
+        logger: Logger;
     }): Promise<NMLClient>;
     openEyes(options: {
         target?: DriverTarget<TSpec>;