@applitools/core 4.12.3 → 4.14.0

package/CHANGELOG.md

@@ -1,5 +1,125 @@
 # Changelog
 
+## [4.14.0](https://github.com/Applitools-Dev/sdk/compare/js/core@4.13.1...js/core@4.14.0) (2024-05-01)
+
+
+### Features
+
+* `matchTimeout` ([#2309](https://github.com/Applitools-Dev/sdk/issues/2309)) ([626529e](https://github.com/Applitools-Dev/sdk/commit/626529e839fd2a96ac0de98332f42873c0f387a4))
+
+
+### Bug Fixes
+
+* cache nml client per driver ([#2336](https://github.com/Applitools-Dev/sdk/issues/2336)) ([02c09a5](https://github.com/Applitools-Dev/sdk/commit/02c09a53eb6ca6340c93365908f4c485ab389c21))
+* support for using unicode and just using escape with numbers ([#2241](https://github.com/Applitools-Dev/sdk/issues/2241)) ([c59f47f](https://github.com/Applitools-Dev/sdk/commit/c59f47f73585d7f308c43c9ee1845e097a2111a3))
+
+
+### Dependencies
+
+* @applitools/dom-snapshot bumped to 4.11.1
+  #### Bug Fixes
+
+  * support for using unicode and just using escape with numbers ([#2241](https://github.com/Applitools-Dev/sdk/issues/2241)) ([c59f47f](https://github.com/Applitools-Dev/sdk/commit/c59f47f73585d7f308c43c9ee1845e097a2111a3))
+* @applitools/spec-driver-webdriver bumped to 1.1.7
+
+* @applitools/spec-driver-selenium bumped to 1.5.78
+
+* @applitools/spec-driver-puppeteer bumped to 1.4.7
+
+* @applitools/driver bumped to 1.17.2
+  #### Bug Fixes
+
+  * cache nml client per driver ([#2336](https://github.com/Applitools-Dev/sdk/issues/2336)) ([02c09a5](https://github.com/Applitools-Dev/sdk/commit/02c09a53eb6ca6340c93365908f4c485ab389c21))
+* @applitools/screenshoter bumped to 3.8.31
+
+* @applitools/nml-client bumped to 1.8.4
+
+* @applitools/ec-client bumped to 1.8.4
+
+* @applitools/core-base bumped to 1.13.0
+  #### Features
+
+  * `matchTimeout` ([#2309](https://github.com/Applitools-Dev/sdk/issues/2309)) ([626529e](https://github.com/Applitools-Dev/sdk/commit/626529e839fd2a96ac0de98332f42873c0f387a4))
+
+## [4.13.1](https://github.com/Applitools-Dev/sdk/compare/js/core@4.13.0...js/core@4.13.1) (2024-04-22)
+
+
+### Dependencies
+
+* @applitools/utils bumped to 1.7.2
+  #### Bug Fixes
+
+  * trigger release ([88ba29f](https://github.com/Applitools-Dev/sdk/commit/88ba29f358620a5c0f0861eb31e8929d0b611284))
+* @applitools/logger bumped to 2.0.16
+
+* @applitools/socket bumped to 1.1.16
+
+* @applitools/req bumped to 1.6.7
+
+* @applitools/image bumped to 1.1.11
+
+* @applitools/spec-driver-webdriver bumped to 1.1.6
+
+* @applitools/spec-driver-selenium bumped to 1.5.77
+
+* @applitools/spec-driver-puppeteer bumped to 1.4.6
+
+* @applitools/driver bumped to 1.17.1
+
+* @applitools/screenshoter bumped to 3.8.30
+
+* @applitools/nml-client bumped to 1.8.3
+
+* @applitools/tunnel-client bumped to 1.5.2
+
+* @applitools/ufg-client bumped to 1.11.2
+
+* @applitools/ec-client bumped to 1.8.3
+
+* @applitools/core-base bumped to 1.12.1
+  #### Bug Fixes
+
+  * environment override ([2b296e6](https://github.com/Applitools-Dev/sdk/commit/2b296e61cca6743d8d217ba99f2fba3a260fbdfa))
+
+
+
+
+## [4.13.0](https://github.com/Applitools-Dev/sdk/compare/js/core@4.12.3...js/core@4.13.0) (2024-04-22)
+
+
+### Features
+
+* ability to override baseline parameters per environment ([#2332](https://github.com/Applitools-Dev/sdk/issues/2332)) ([43b8b18](https://github.com/Applitools-Dev/sdk/commit/43b8b189fb3c9dd19aa3be372e8fcc0fe8edfa50))
+* report batchId and batchUrl to kobiton ([#2329](https://github.com/Applitools-Dev/sdk/issues/2329)) ([5be4356](https://github.com/Applitools-Dev/sdk/commit/5be4356d7f3cd96b70491325d4a788202c06720a))
+
+
+### Dependencies
+
+* @applitools/dom-snapshot bumped to 4.11.0
+  #### Features
+
+  * extract url from embed element ([#2285](https://github.com/Applitools-Dev/sdk/issues/2285)) ([3c4da0d](https://github.com/Applitools-Dev/sdk/commit/3c4da0dbd061cb2fc4313392196012ffd4601d0e))
+* @applitools/spec-driver-webdriver bumped to 1.1.5
+
+* @applitools/spec-driver-selenium bumped to 1.5.76
+
+* @applitools/spec-driver-puppeteer bumped to 1.4.5
+
+* @applitools/driver bumped to 1.17.0
+  #### Features
+
+  * report batchId and batchUrl to kobiton ([#2329](https://github.com/Applitools-Dev/sdk/issues/2329)) ([5be4356](https://github.com/Applitools-Dev/sdk/commit/5be4356d7f3cd96b70491325d4a788202c06720a))
+* @applitools/screenshoter bumped to 3.8.29
+
+* @applitools/nml-client bumped to 1.8.2
+
+* @applitools/ec-client bumped to 1.8.2
+
+* @applitools/core-base bumped to 1.12.0
+  #### Features
+
+  * ability to override baseline parameters per environment ([#2332](https://github.com/Applitools-Dev/sdk/issues/2332)) ([43b8b18](https://github.com/Applitools-Dev/sdk/commit/43b8b189fb3c9dd19aa3be372e8fcc0fe8edfa50))
+
 ## [4.12.3](https://github.com/Applitools-Dev/sdk/compare/js/core@4.12.2...js/core@4.12.3) (2024-04-17)
 
 

package/dist/automation/abort.js

@@ -1,9 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.makeAbort = void 0;
-const driver_1 = require("@applitools/driver");
 const uniquify_environments_1 = require("./utils/uniquify-environments");
-function makeAbort({ eyes, target, controller, environments: defaultEnvironments, spec, logger: mainLogger, }) {
+function makeAbort({ eyes, driver, controller, environments: defaultEnvironments, logger: mainLogger, }) {
     return async function abort({ settings, logger = mainLogger, } = {}) {
         var _a;
         logger = logger.extend(mainLogger);
@@ -18,9 +17,8 @@ function makeAbort({ eyes, target, controller, environments: defaultEnvironments
         }
         controller.abort();
         settings !== null && settings !== void 0 ? settings : (settings = {});
-        if (!settings.testMetadata && (0, driver_1.isDriver)(target, spec)) {
+        if (!settings.testMetadata && driver) {
             try {
-                const driver = await (0, driver_1.makeDriver)({ spec, driver: target, relaxed: true, logger });
                 settings.testMetadata = await driver.getSessionMetadata();
             }
             catch (error) {

package/dist/automation/close.js

@@ -1,9 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.makeClose = void 0;
-const driver_1 = require("@applitools/driver");
 const uniquify_environments_1 = require("./utils/uniquify-environments");
-function makeClose({ eyes, target, environments: defaultEnvironments, spec, logger: mainLogger, }) {
+function makeClose({ eyes, driver, environments: defaultEnvironments, logger: mainLogger, }) {
     return async function close({ settings, logger = mainLogger, } = {}) {
         var _a;
         logger = logger.extend(mainLogger);
@@ -17,9 +16,8 @@ function makeClose({ eyes, target, environments: defaultEnvironments, spec, logg
             eyes.running = false;
         }
         settings !== null && settings !== void 0 ? settings : (settings = {});
-        if (!settings.testMetadata && (0, driver_1.isDriver)(target, spec)) {
+        if (!settings.testMetadata && driver) {
             try {
-                const driver = await (0, driver_1.makeDriver)({ spec, driver: target, relaxed: true, logger });
                 settings.testMetadata = await driver.getSessionMetadata();
             }
             catch (error) {

package/dist/automation/utils/report-kobiton.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.reportKobiton = void 0;
+async function reportKobiton({ driver, settings, logger }) {
+    var _a;
+    // At this point, the driver might be closed already. The operation below could fail in this case
+    try {
+        if ((_a = (await (driver === null || driver === void 0 ? void 0 : driver.getEnvironment()))) === null || _a === void 0 ? void 0 : _a.isKobiton) {
+            const kobitonInfo = {
+                batchId: settings.batchId,
+                batchUrl: settings.resultsUrl,
+            };
+            logger.log('sending to kobiton', kobitonInfo);
+            await driver.execute('kobiton:assignApplitoolsInfo', kobitonInfo);
+        }
+    }
+    catch (err) {
+        logger.log('failed to send to kobiton', err);
+    }
+}
+exports.reportKobiton = reportKobiton;

package/dist/check.js

@@ -48,7 +48,7 @@ function makeCheck({ type: defaultType = 'classic', eyes, target: defaultTarget,
         (_g = settings.sendDom) !== null && _g !== void 0 ? _g : (settings.sendDom = eyes.test.account.rcaEnabled || settings.matchLevel === 'Layout' || settings.enablePatterns || settings.useDom);
         (_h = settings.autProxy) !== null && _h !== void 0 ? _h : (settings.autProxy = eyes.test.eyesServer.proxy);
         (_j = settings.useDom) !== null && _j !== void 0 ? _j : (settings.useDom = false);
-        (_k = (_q = settings).retryTimeout) !== null && _k !== void 0 ? _k : (_q.retryTimeout = 2000);
+        (_k = (_q = settings).retryTimeout) !== null && _k !== void 0 ? _k : (_q.retryTimeout = 0);
         settings.lazyLoad = settings.lazyLoad === true ? {} : settings.lazyLoad;
         if (settings.lazyLoad) {
             (_l = (_r = settings.lazyLoad).scrollLength) !== null && _l !== void 0 ? _l : (_r.scrollLength = 300);

package/dist/classic/check-and-close.js

@@ -53,8 +53,9 @@ function makeCheckAndClose({ eyes, target: defaultTarget, environments: defaultE
         const baseTargets = [];
         const baseSettings = [];
         const exactEnvironments = [];
+        let driver;
         if ((0, driver_1.isDriver)(target, spec)) {
-            const driver = await (0, driver_1.makeDriver)({ spec, driver: target, reset: target === defaultTarget, logger });
+            driver = await (0, driver_1.makeDriver)({ spec, driver: target, reset: target === defaultTarget, logger });
             await driver.currentContext.setScrollingElement((_b = settings.scrollRootElement) !== null && _b !== void 0 ? _b : null);
             const driverEnvironment = await driver.getEnvironment();
             uniqueEnvironments.forEach(environment => {
@@ -161,7 +162,7 @@ function makeCheckAndClose({ eyes, target: defaultTarget, environments: defaultE
                     environmentLogger.warn('Command "checkAndClose" was aborted before checking');
                     throw new abort_error_1.AbortError('Command "checkAndClose" was aborted before checking');
                 }
-                const baseEyes = await eyes.getBaseEyes({ settings: { environment }, logger: environmentLogger });
+                const baseEyes = await eyes.getBaseEyes({ settings: { environment, driver }, logger: environmentLogger });
                 try {
                     if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
                         environmentLogger.warn('Command "checkAndClose" was aborted before checking');

package/dist/classic/check.js

@@ -40,9 +40,11 @@ const utils = __importStar(require("@applitools/utils"));
 const lang = __importStar(require("../lang"));
 function makeCheck({ eyes, target: defaultTarget, environments: defaultEnvironments = [], spec, signal, logger: mainLogger, }) {
     return async function check({ target = defaultTarget, settings = {}, logger = mainLogger, } = {}) {
-        var _a, _b, _c;
+        var _a;
+        // logging
         logger = logger.extend(mainLogger);
         logger.log('Command "check" is called with settings', settings);
+        // input validation and sanitization
         if (!target)
             throw new Error('Method was called with no target');
         if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
@@ -50,172 +52,275 @@ function makeCheck({ eyes, target: defaultTarget, environments: defaultEnvironme
             throw new abort_error_1.AbortError('Command "check" was called after test was already aborted');
         }
         const uniqueEnvironments = (0, uniquify_environments_1.uniquifyEnvironments)((_a = settings.environments) !== null && _a !== void 0 ? _a : defaultEnvironments);
-        const baseTargets = [];
-        const baseSettings = [];
-        const exactEnvironments = [];
+        let driver = undefined;
         if ((0, driver_1.isDriver)(target, spec)) {
-            const driver = await (0, driver_1.makeDriver)({ spec, driver: target, reset: target === defaultTarget, logger });
-            await driver.currentContext.setScrollingElement((_b = settings.scrollRootElement) !== null && _b !== void 0 ? _b : null);
-            const driverEnvironment = await driver.getEnvironment();
-            uniqueEnvironments.forEach(environment => {
-                var _a, _b;
-                var _c, _d;
-                if (utils.types.has(environment, 'iosDeviceInfo')) {
-                    (_a = (_c = environment.iosDeviceInfo).version) !== null && _a !== void 0 ? _a : (_c.version = driverEnvironment.platformVersion);
+            driver = await (0, driver_1.makeDriver)({ spec, driver: target, reset: target === defaultTarget, logger });
+            if (settings.retryTimeout) {
+                // when retry timeout is set, retry checking until it passes or timeout is reached. This will stall the client test execution until it passes or timeout is reached to prevent the test from continuing and changing the state of the app
+                logger.log(`Retry timeout is set to ${settings.retryTimeout}ms - will retry checking until it passes or timeout is reached`);
+                const start = Date.now();
+                if (await isNewTest({ eyes, driver, environments: uniqueEnvironments, logger })) {
+                    await new Promise(resolve => setTimeout(resolve, settings.retryTimeout));
                 }
-                else if (utils.types.has(environment, 'androidDeviceInfo')) {
-                    (_b = (_d = environment.androidDeviceInfo).version) !== null && _b !== void 0 ? _b : (_d.version = driverEnvironment.platformVersion);
-                }
-                return environment;
-            });
-            if (settings.lazyLoad && driverEnvironment.isWeb) {
-                await (0, wait_for_lazy_load_1.waitForLazyLoad)({
-                    context: driver.currentContext,
-                    settings: settings.lazyLoad !== true ? settings.lazyLoad : {},
-                    logger,
-                });
-            }
-            if (driverEnvironment.isWeb ||
-                !((_c = driverEnvironment.applitoolsLib) === null || _c === void 0 ? void 0 : _c.instrumented) ||
-                settings.webview ||
-                settings.screenshotMode === 'default') {
-                let actualEnvironments = uniqueEnvironments;
-                if (settings.screenshotMode === 'default') {
-                    const { localEnvironment, renderEnvironments } = await (0, nml_client_1.getNMLEnvironmentsInfo)({
-                        environments: uniqueEnvironments,
-                        supportedEnvironmentsUrl: eyes.test.supportedEnvironmentsUrl,
-                        proxy: eyes.test.eyesServer.proxy,
-                        logger,
+                let asExpected = false, retries = 0;
+                do {
+                    retries++;
+                    // generate base targets (images to be compared) and settings for each environment
+                    const baseScreenshotsAndSettings = await generateBaseScreenshotsAndSettings(settings, uniqueEnvironments, eyes, logger, driver);
+                    const promises = baseScreenshotsAndSettings.map(async ({ exactEnvironment: environment, baseSetting: settings, baseTarget: target }) => {
+                        return await checkEnvironment({
+                            eyes,
+                            driver,
+                            target,
+                            environment,
+                            signal,
+                            logger,
+                            settings: {
+                                ...settings,
+                                replaceLast: retries > 1,
+                            },
+                        });
                     });
-                    actualEnvironments = localEnvironment ? [localEnvironment] : renderEnvironments;
-                }
-                const { elementReferences, getBaseCheckSettings } = (0, to_base_check_settings_1.toBaseCheckSettings)({ settings });
-                const screenshots = await (0, take_screenshots_1.takeScreenshots)({
-                    driver,
-                    settings: {
-                        ...settings,
-                        environments: actualEnvironments,
-                        regionsToCalculate: elementReferences.calculate,
-                        calculateView: !!settings.pageId,
-                        domSettings: settings.sendDom ? { proxy: eyes.test.eyesServer.proxy } : undefined,
-                    },
-                    logger,
-                });
-                exactEnvironments.push(...actualEnvironments);
-                screenshots.forEach(({ calculatedRegions, ...baseTarget }) => {
-                    baseTargets.push(baseTarget);
-                    baseSettings.push(getBaseCheckSettings({ calculatedRegions }));
-                });
+                    const results = await Promise.all(promises);
+                    asExpected = results.every(result => result.asExpected);
+                    if (retries === 1) {
+                        baseScreenshotsAndSettings.forEach(({ exactEnvironment }) => {
+                            // put dummy promises in storage to tell eyes.close that all checks hepped
+                            putInStorage(exactEnvironment, eyes, Promise.resolve());
+                        });
+                    }
+                } while (!asExpected && Date.now() - start < settings.retryTimeout);
             }
             else {
-                if (driverEnvironment.applitoolsLib.conflictingCapabilities) {
-                    const message = lang.applitoolsLibConflictingCapabilitiesWarning({
-                        conflictingCapabilities: driverEnvironment.applitoolsLib.conflictingCapabilities,
-                    });
-                    logger.console.log(chalk_1.default.yellow(message));
-                    logger.log(message);
-                }
-                const nmlClient = await eyes.core.getNMLClient({
-                    driver,
-                    settings: { ...eyes.test.eyesServer, supportedEnvironmentsUrl: eyes.test.supportedEnvironmentsUrl },
-                    logger,
+                // generate base targets (images to be compared) and settings for each environment
+                const baseScreenshotsAndSettings = await generateBaseScreenshotsAndSettings(settings, uniqueEnvironments, eyes, logger, driver);
+                // when no retry timeout is set, queue all environment checks against the server without stalling the client test execution
+                baseScreenshotsAndSettings.forEach(({ exactEnvironment: environment, baseSetting, baseTarget }) => {
+                    checkInTheBackground(environment, baseTarget, baseSetting);
                 });
-                if (settings.scrollRootElement || settings.region || (0, to_base_check_settings_1.hasCodedRegions)(settings))
-                    await nmlClient.preTakeScreenshot({ logger });
-                const { elementReferences, getBaseCheckSettings } = (0, to_base_check_settings_1.toBaseCheckSettings)({
-                    settings: {
-                        ...settings,
-                        ...(await (0, to_base_check_settings_1.extractMobileElementsIntoCheckSettings)({ settings, driver, logger })),
-                    },
-                });
-                const calculate = elementReferences.calculate;
-                const screenshots = await nmlClient.takeScreenshots({
-                    settings: {
-                        environments: uniqueEnvironments,
-                        fully: settings.fully,
-                        stitchMode: settings.stitchMode,
-                        hideScrollbars: settings.hideScrollbars,
-                        hideCaret: settings.hideScrollbars,
-                        overlap: settings.overlap,
-                        waitBeforeCapture: settings.waitBeforeCapture,
-                        waitBetweenStitches: settings.waitBetweenStitches,
-                        lazyLoad: settings.lazyLoad,
-                        name: settings.name,
-                        region: elementReferences.target,
-                        selectorsToFindRegionsFor: calculate.map(({ name }) => name),
-                        scrollRootElement: elementReferences.scrolling,
-                    },
-                    logger,
+            }
+        }
+        else {
+            uniqueEnvironments.forEach(environment => checkInTheBackground(environment, target, settings));
+        }
+        function checkInTheBackground(environment, target, settings) {
+            putInStorage(environment, eyes, checkEnvironment({ eyes, driver, target, environment, signal, logger, settings }));
+        }
+    };
+    function putInStorage(environment, eyes, promise) {
+        const key = (0, to_environment_key_1.toEnvironmentKey)(environment);
+        let item = eyes.storage.get(key);
+        if (!item) {
+            item = { eyes: utils.promises.makeControlledPromise(), jobs: [] };
+            eyes.storage.set(key, item);
+        }
+        item.jobs.push(promise.then());
+        return item;
+    }
+}
+exports.makeCheck = makeCheck;
+async function isNewTest({ eyes, driver, environments, logger, }) {
+    const environmentLogger = logger.extend({ tags: [`environment-${utils.general.shortid()}`] });
+    return (await Promise.all(environments.map(async (environment) => await eyes.getBaseEyes({ settings: { environment, driver }, logger: environmentLogger }))))
+        .map(baseEyes => baseEyes.test.isNew)
+        .some(isNew => isNew);
+}
+async function checkEnvironment({ eyes, driver, target, environment, signal, logger, settings, }) {
+    var _a, _b;
+    const environmentLogger = logger.extend({ tags: [`environment-${utils.general.shortid()}`] });
+    environmentLogger.log('Command "check" is called with settings', settings);
+    try {
+        if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
+            abortError({ logger: environmentLogger, message: 'Command "check" was aborted before checking' });
+        }
+        const baseEyes = await eyes.getBaseEyes({ settings: { environment, driver }, logger: environmentLogger });
+        try {
+            if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
+                abortError({
+                    logger: environmentLogger,
+                    message: `Command "check" was aborted before checking`,
                 });
-                screenshots.forEach(({ environment, calculateRegions, ...baseTarget }) => {
-                    const aggregateCalculatedRegions = [];
-                    calculate.forEach(({ reference }, index) => {
-                        const regions = calculateRegions === null || calculateRegions === void 0 ? void 0 : calculateRegions[index];
-                        if (regions) {
-                            aggregateCalculatedRegions.push({ regions, selector: reference });
-                        }
-                        else {
-                            logger.log(`Regions "${reference}" was not found in the screenshot`);
-                        }
-                    });
-                    exactEnvironments.push(environment);
-                    baseTargets.push({ ...baseTarget, isTransformed: true });
-                    baseSettings.push(getBaseCheckSettings({
-                        calculatedRegions: aggregateCalculatedRegions,
-                    }));
+            }
+            else if (!baseEyes.running) {
+                abortError({
+                    logger: environmentLogger,
+                    message: `Check on environment with id "${(_a = baseEyes.test.environment) === null || _a === void 0 ? void 0 : _a.environmentId}" was aborted during one of the previous steps`,
                 });
             }
+            return await baseEyes.check({
+                target,
+                settings: settings,
+                logger: environmentLogger,
+            });
         }
-        else {
-            exactEnvironments.push(...uniqueEnvironments);
-            baseTargets.push(target);
-            baseSettings.push(settings);
+        catch (error) {
+            environmentLogger.error(`Check on environment with id "${(_b = baseEyes.test.environment) === null || _b === void 0 ? void 0 : _b.environmentId}" failed due to an error`, error);
+            if (baseEyes.running && !(signal === null || signal === void 0 ? void 0 : signal.aborted))
+                baseEyes.abort({ logger: environmentLogger, settings: { reason: error } });
         }
-        const promises = exactEnvironments.map(async (environment, index) => {
-            var _a, _b, _c;
-            const environmentLogger = logger.extend({ tags: [`environment-${utils.general.shortid()}`] });
-            try {
-                if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
-                    environmentLogger.warn('Command "check" was aborted before checking');
-                    throw new abort_error_1.AbortError('Command "check" was aborted before checking');
-                }
-                const baseEyes = await eyes.getBaseEyes({ settings: { environment }, logger: environmentLogger });
-                try {
-                    if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
-                        environmentLogger.warn('Command "check" was aborted before checking');
-                        throw new abort_error_1.AbortError('Command "check" was aborted before checking');
-                    }
-                    else if (!baseEyes.running) {
-                        environmentLogger.warn(`Check on environment with id "${(_a = baseEyes.test.environment) === null || _a === void 0 ? void 0 : _a.environmentId}" was aborted during one of the previous steps`);
-                        throw new abort_error_1.AbortError(`Check on environment with id "${(_b = baseEyes.test.environment) === null || _b === void 0 ? void 0 : _b.environmentId}" was aborted during one of the previous steps`);
-                    }
-                    await baseEyes.check({
-                        target: baseTargets[index],
-                        settings: baseSettings[index],
-                        logger: environmentLogger,
-                    });
-                }
-                catch (error) {
-                    environmentLogger.error(`Check on environment with id "${(_c = baseEyes.test.environment) === null || _c === void 0 ? void 0 : _c.environmentId}" failed due to an error`, error);
-                    if (baseEyes.running && !(signal === null || signal === void 0 ? void 0 : signal.aborted))
-                        await baseEyes.abort({ logger: environmentLogger, settings: { reason: error } });
-                }
+    }
+    catch (error) {
+        environmentLogger.error(`Environment with id ${environment.environmentId} failed before checking started due to an error`, error);
+        error.info = { ...error.info, userTestId: eyes.test.userTestId, environment };
+        throw error;
+    }
+    return { asExpected: false };
+}
+/**
+ * @throws {AbortError}
+ */
+function abortError({ logger, message }) {
+    logger.warn(message);
+    throw new abort_error_1.AbortError(message);
+}
+/**
+ * create base targets (array of screenshots) and base settings (array of check settings) for each environment
+ */
+async function generateBaseScreenshotsAndSettings(settings, uniqueEnvironments, eyes, logger, driver) {
+    var _a;
+    const driverEnvironment = await driver.getEnvironment();
+    uniqueEnvironments = addMobileDeviceInfo(uniqueEnvironments, driverEnvironment);
+    await beforeScreenshot();
+    const shouldTakeWebScreenshot = driverEnvironment.isWeb ||
+        !((_a = driverEnvironment.applitoolsLib) === null || _a === void 0 ? void 0 : _a.instrumented) ||
+        settings.webview ||
+        settings.screenshotMode === 'default';
+    if (shouldTakeWebScreenshot) {
+        return await takeWebScreenshot({
+            driver,
+            settings,
+            environments: uniqueEnvironments,
+            logger,
+            eyes,
+        });
+    }
+    else {
+        // take screenshot using NML
+        checkConflictingCapabilities();
+        return await takeNMLScreenshot({
+            driver,
+            settings,
+            environments: uniqueEnvironments,
+            logger,
+            eyes,
+        });
+    }
+    async function beforeScreenshot() {
+        var _a;
+        await driver.currentContext.setScrollingElement((_a = settings.scrollRootElement) !== null && _a !== void 0 ? _a : null);
+        if (settings.lazyLoad && driverEnvironment.isWeb) {
+            await (0, wait_for_lazy_load_1.waitForLazyLoad)({
+                context: driver.currentContext,
+                settings: settings.lazyLoad !== true ? settings.lazyLoad : {},
+                logger,
+            });
+        }
+    }
+    function checkConflictingCapabilities() {
+        var _a;
+        if ((_a = driverEnvironment.applitoolsLib) === null || _a === void 0 ? void 0 : _a.conflictingCapabilities) {
+            const message = lang.applitoolsLibConflictingCapabilitiesWarning({
+                conflictingCapabilities: driverEnvironment.applitoolsLib.conflictingCapabilities,
+            });
+            logger.console.log(chalk_1.default.yellow(message));
+            logger.log(message);
+        }
+    }
+    function addMobileDeviceInfo(environments, driverEnvironment) {
+        return environments.map(environment => {
+            var _a, _b;
+            var _c, _d;
+            if (utils.types.has(environment, 'iosDeviceInfo')) {
+                (_a = (_c = environment.iosDeviceInfo).version) !== null && _a !== void 0 ? _a : (_c.version = driverEnvironment.platformVersion);
             }
-            catch (error) {
-                environmentLogger.error(`Environment with id ${environment.environmentId} failed before checking started due to an error`, error);
-                error.info = { ...error.info, userTestId: eyes.test.userTestId, environment };
-                throw error;
+            else if (utils.types.has(environment, 'androidDeviceInfo')) {
+                (_b = (_d = environment.androidDeviceInfo).version) !== null && _b !== void 0 ? _b : (_d.version = driverEnvironment.platformVersion);
             }
+            return environment;
+        });
+    }
+}
+async function takeWebScreenshot({ driver, settings, environments, logger, eyes, }) {
+    let actualEnvironments = environments;
+    if (settings.screenshotMode === 'default') {
+        const { localEnvironment, renderEnvironments } = await (0, nml_client_1.getNMLEnvironmentsInfo)({
+            environments: environments,
+            supportedEnvironmentsUrl: eyes.test.supportedEnvironmentsUrl,
+            proxy: eyes.test.eyesServer.proxy,
+            logger,
         });
-        exactEnvironments.forEach((environment, index) => {
-            const key = (0, to_environment_key_1.toEnvironmentKey)(environment);
-            let item = eyes.storage.get(key);
-            if (!item) {
-                item = { eyes: utils.promises.makeControlledPromise(), jobs: [] };
-                eyes.storage.set(key, item);
+        actualEnvironments = localEnvironment ? [localEnvironment] : renderEnvironments;
+    }
+    const { elementReferences, getBaseCheckSettings } = (0, to_base_check_settings_1.toBaseCheckSettings)({ settings });
+    const screenshots = await (0, take_screenshots_1.takeScreenshots)({
+        driver,
+        settings: {
+            ...settings,
+            environments: actualEnvironments,
+            regionsToCalculate: elementReferences.calculate,
+            calculateView: !!settings.pageId,
+            domSettings: settings.sendDom ? { proxy: eyes.test.eyesServer.proxy } : undefined,
+        },
+        logger,
+    });
+    return screenshots.map(({ calculatedRegions, ...baseTarget }, i) => {
+        return {
+            baseTarget,
+            baseSetting: getBaseCheckSettings({ calculatedRegions }),
+            exactEnvironment: actualEnvironments[i],
+        };
+    });
+}
+async function takeNMLScreenshot({ driver, settings, environments, logger, eyes, }) {
+    const nmlClient = await eyes.core.getNMLClient({
+        driver,
+        settings: { ...eyes.test.eyesServer, supportedEnvironmentsUrl: eyes.test.supportedEnvironmentsUrl },
+        logger,
+    });
+    if (settings.scrollRootElement || settings.region || (0, to_base_check_settings_1.hasCodedRegions)(settings))
+        await nmlClient.preTakeScreenshot({ logger });
+    const { elementReferences, getBaseCheckSettings } = (0, to_base_check_settings_1.toBaseCheckSettings)({
+        settings: {
+            ...settings,
+            ...(await (0, to_base_check_settings_1.extractMobileElementsIntoCheckSettings)({ settings, driver, logger })),
+        },
+    });
+    const calculate = elementReferences.calculate;
+    const screenshots = await nmlClient.takeScreenshots({
+        settings: {
+            environments: environments,
+            fully: settings.fully,
+            stitchMode: settings.stitchMode,
+            hideScrollbars: settings.hideScrollbars,
+            hideCaret: settings.hideScrollbars,
+            overlap: settings.overlap,
+            waitBeforeCapture: settings.waitBeforeCapture,
+            waitBetweenStitches: settings.waitBetweenStitches,
+            lazyLoad: settings.lazyLoad,
+            name: settings.name,
+            region: elementReferences.target,
+            selectorsToFindRegionsFor: calculate.map(({ name }) => name),
+            scrollRootElement: elementReferences.scrolling,
+        },
+        logger,
+    });
+    return screenshots.map(({ calculateRegions, ...baseTarget }) => {
+        const aggregateCalculatedRegions = [];
+        calculate.forEach(({ reference }, index) => {
+            const regions = calculateRegions === null || calculateRegions === void 0 ? void 0 : calculateRegions[index];
+            if (regions) {
+                aggregateCalculatedRegions.push({ regions, selector: reference });
+            }
+            else {
+                logger.log(`Regions "${reference}" was not found in the screenshot`);
             }
-            item.jobs.push(promises[index]);
         });
-    };
+        return {
+            baseTarget: { ...baseTarget, isTransformed: true },
+            baseSetting: getBaseCheckSettings({
+                calculatedRegions: aggregateCalculatedRegions,
+            }),
+            exactEnvironment: baseTarget.environment,
+        };
+    });
 }
-exports.makeCheck = makeCheck;

package/dist/classic/get-base-eyes.js

@@ -26,6 +26,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.makeGetBaseEyes = void 0;
 const to_environment_key_1 = require("../automation/utils/to-environment-key");
 const utils = __importStar(require("@applitools/utils"));
+const report_kobiton_1 = require("../automation/utils/report-kobiton");
 function makeGetBaseEyes({ settings: defaultSettings, eyes, logger: mainLogger, }) {
     const getBaseEyesWithCache = utils.general.wrap(getBaseEyes, (getBaseEyes, options) => {
         const key = (0, to_environment_key_1.toEnvironmentKey)(options.settings.environment);
@@ -43,7 +44,7 @@ function makeGetBaseEyes({ settings: defaultSettings, eyes, logger: mainLogger,
         var _a;
         logger = logger.extend(mainLogger);
         logger.log(`Command "getBaseEyes" is called with settings`, settings);
-        return eyes.core.base.openEyes({
+        const baseEyes = await eyes.core.base.openEyes({
             settings: {
                 ...defaultSettings,
                 fallbackBaselineId: (_a = settings.environment) === null || _a === void 0 ? void 0 : _a.fallbackBaselineId,
@@ -51,6 +52,8 @@ function makeGetBaseEyes({ settings: defaultSettings, eyes, logger: mainLogger,
             },
             logger,
         });
+        (0, report_kobiton_1.reportKobiton)({ driver: settings.driver, settings: baseEyes.test, logger });
+        return baseEyes;
     }
 }
 exports.makeGetBaseEyes = makeGetBaseEyes;

package/dist/classic/open-eyes.js

@@ -76,8 +76,8 @@ function makeOpenEyes({ core, spec, logger: mainLogger }) {
                 getBaseEyes: (0, get_base_eyes_1.makeGetBaseEyes)({ settings, eyes, logger }),
                 check: (0, check_1.makeCheck)({ eyes, target: driver, environments, spec, signal, logger }),
                 checkAndClose: (0, check_and_close_1.makeCheckAndClose)({ eyes, target: driver, environments, spec, signal, logger }),
-                close: (0, close_1.makeClose)({ eyes, target: driver, environments, spec, logger }),
-                abort: (0, abort_1.makeAbort)({ eyes, target: driver, environments, spec, controller, logger }),
+                close: (0, close_1.makeClose)({ eyes, driver, environments, logger }),
+                abort: (0, abort_1.makeAbort)({ eyes, driver, environments, controller, logger }),
                 getResults: (0, get_results_1.makeGetResults)({ eyes, logger }),
             };
         });

package/dist/core.js

@@ -26,6 +26,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.makeCore = void 0;
 const logger_1 = require("@applitools/logger");
 const core_base_1 = require("@applitools/core-base");
+const core_1 = require("./classic/core");
+const core_2 = require("./ufg/core");
 const get_viewport_size_1 = require("./automation/get-viewport-size");
 const set_viewport_size_1 = require("./automation/set-viewport-size");
 const get_account_info_1 = require("./get-account-info");
@@ -50,6 +52,10 @@ function makeCore({ spec, clients, base: defaultBase, concurrency = utils.genera
     if (environment.sdk)
         (0, validate_sdk_version_1.validateSdkVersion)(environment.sdk, { logger });
     const base = defaultBase !== null && defaultBase !== void 0 ? defaultBase : (0, core_base_1.makeCore)({ agentId, concurrency, cwd, logger });
+    const cores = {
+        ufg: (0, core_2.makeCore)({ spec, clients, base, asyncCache, logger }),
+        classic: (0, core_1.makeCore)({ spec, clients, base, logger }),
+    };
     return utils.general.extend(base, core => {
         return {
             base: base,
@@ -58,11 +64,23 @@ function makeCore({ spec, clients, base: defaultBase, concurrency = utils.genera
             getNMLClient: (0, get_nml_client_1.makeGetNMLClient)({ client: clients === null || clients === void 0 ? void 0 : clients.nml, logger }),
             getECClient: (0, get_ec_client_1.makeGetECClient)({ logger }),
             getAccountInfo: (0, get_account_info_1.makeGetAccountInfo)({ core, logger }),
-            makeManager: (0, make_manager_1.makeMakeManager)({ spec, clients, core, agentId, cwd, environment, asyncCache, logger }),
+            // Note: `defaultBase` is passesd for `base`, and `cores` is not passed here on purpose, so that a manager will create its own base, which would apply the correct concurrency value that was passed to the manager.
+            // `defaultBase` is here for testing purposes
+            makeManager: (0, make_manager_1.makeMakeManager)({
+                spec,
+                clients,
+                core,
+                base: defaultBase,
+                agentId,
+                cwd,
+                environment,
+                asyncCache,
+                logger,
+            }),
             locate: (0, locate_1.makeLocate)({ spec, core, logger }),
             locateText: (0, locate_text_1.makeLocateText)({ spec, core, logger }),
             extractText: (0, extract_text_1.makeExtractText)({ spec, core, logger }),
-            openEyes: (0, open_eyes_1.makeOpenEyes)({ spec, clients, core, environment, asyncCache, logger }),
+            openEyes: (0, open_eyes_1.makeOpenEyes)({ spec, clients, core, cores, environment, asyncCache, logger }),
             closeBatch: (0, close_batch_1.makeCloseBatch)({ core, logger }),
             deleteTest: (0, delete_test_1.makeDeleteTest)({ core, logger }),
         };

package/dist/make-manager.js

@@ -44,8 +44,8 @@ function makeMakeManager({ spec, clients, core, base: defaultBase, agentId: defa
         logger.log('Command "makeManager" is called with settings', settings);
         const base = defaultBase !== null && defaultBase !== void 0 ? defaultBase : (0, core_base_1.makeCore)({ agentId: settings.agentId, concurrency: settings.concurrency, cwd, logger });
         const cores = {
-            ufg: (0, core_2.makeCore)({ spec, base, fetchConcurrency: settings.fetchConcurrency, asyncCache, logger }),
-            classic: (0, core_1.makeCore)({ spec, base, logger }),
+            ufg: (0, core_2.makeCore)({ spec, clients, base, fetchConcurrency: settings.fetchConcurrency, asyncCache, logger }),
+            classic: (0, core_1.makeCore)({ spec, clients, base, logger }),
         };
         const storage = [];
         return {

package/dist/ufg/check-and-close.js

@@ -66,7 +66,7 @@ function makeCheckAndClose({ eyes, target: defaultTarget, environments: defaultE
         let userAgent;
         const driver = spec && (0, driver_1.isDriver)(target, spec)
             ? await (0, driver_1.makeDriver)({ spec, driver: target, reset: target === defaultTarget, logger })
-            : null;
+            : undefined;
         if (driver) {
             const environment = await driver.getEnvironment();
             const currentContext = driver.currentContext;
@@ -148,7 +148,7 @@ function makeCheckAndClose({ eyes, target: defaultTarget, environments: defaultE
                     },
                     logger: environmentLogger,
                 });
-                const baseEyes = await eyes.getBaseEyes({ settings: { environment }, logger });
+                const baseEyes = await eyes.getBaseEyes({ settings: { environment, driver }, logger });
                 try {
                     if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
                         environmentLogger.warn('Command "check" was aborted before rendering');

package/dist/ufg/check.js

@@ -66,7 +66,7 @@ function makeCheck({ eyes, target: defaultTarget, environments: defaultEnvironme
         let userAgent;
         const driver = spec && (0, driver_1.isDriver)(target, spec)
             ? await (0, driver_1.makeDriver)({ spec, driver: target, reset: target === defaultTarget, logger })
-            : null;
+            : undefined;
         if (driver) {
             const environment = await driver.getEnvironment();
             const currentContext = driver.currentContext;
@@ -148,7 +148,7 @@ function makeCheck({ eyes, target: defaultTarget, environments: defaultEnvironme
                     },
                     logger: environmentLogger,
                 });
-                const baseEyes = await eyes.getBaseEyes({ settings: { environment }, logger: environmentLogger });
+                const baseEyes = await eyes.getBaseEyes({ settings: { environment, driver }, logger: environmentLogger });
                 try {
                     if (signal === null || signal === void 0 ? void 0 : signal.aborted) {
                         environmentLogger.warn('Command "check" was aborted before rendering');

package/dist/ufg/get-base-eyes.js

@@ -25,6 +25,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.makeGetBaseEyes = void 0;
 const utils = __importStar(require("@applitools/utils"));
+const report_kobiton_1 = require("../automation/utils/report-kobiton");
 function makeGetBaseEyes({ settings: defaultSettings, eyes, logger: mainLogger, }) {
     const getBaseEyesWithCache = utils.general.wrap(getBaseEyes, (getBaseEyes, options) => {
         const key = JSON.stringify(options.settings.environment);
@@ -54,14 +55,24 @@ function makeGetBaseEyes({ settings: defaultSettings, eyes, logger: mainLogger,
             settings: { environment: settings.environment },
             logger,
         });
-        return eyes.core.base.openEyes({
+        const baseEyes = await eyes.core.base.openEyes({
             settings: {
                 ...defaultSettings,
                 fallbackBaselineId: (_a = settings.environment) === null || _a === void 0 ? void 0 : _a.fallbackBaselineId,
-                environment: { ...defaultSettings.environment, ...environment, properties: settings.environment.properties },
+                environment: {
+                    ...defaultSettings.environment,
+                    ...environment,
+                    os: settings.environment.os,
+                    displayOs: settings.environment.displayOs,
+                    hostingApp: settings.environment.hostingApp,
+                    displayHostingApp: settings.environment.displayHostingApp,
+                    properties: settings.environment.properties,
+                },
             },
             logger,
         });
+        (0, report_kobiton_1.reportKobiton)({ driver: settings.driver, settings: baseEyes.test, logger });
+        return baseEyes;
     }
 }
 exports.makeGetBaseEyes = makeGetBaseEyes;

package/dist/ufg/open-eyes.js

@@ -76,8 +76,8 @@ function makeOpenEyes({ core, spec, logger: mainLogger }) {
                 getBaseEyes: (0, get_base_eyes_1.makeGetBaseEyes)({ settings, eyes, logger }),
                 check: (0, check_1.makeCheck)({ eyes, target: driver, environments, spec, signal, logger }),
                 checkAndClose: (0, check_and_close_1.makeCheckAndClose)({ eyes, target: driver, environments, spec, signal, logger }),
-                close: (0, close_1.makeClose)({ eyes, target: driver, logger }),
-                abort: (0, abort_1.makeAbort)({ eyes, target: driver, spec, controller, logger }),
+                close: (0, close_1.makeClose)({ eyes, driver, logger }),
+                abort: (0, abort_1.makeAbort)({ eyes, driver, controller, logger }),
                 getResults: (0, get_results_1.makeGetResults)({ eyes, logger }),
             };
         });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/core",
-  "version": "4.12.3",
+  "version": "4.14.0",
   "homepage": "https://applitools.com",
   "bugs": {
     "url": "https://github.com/applitools/eyes.sdk.javascript1/issues"
@@ -74,20 +74,20 @@
     }
   },
   "dependencies": {
-    "@applitools/core-base": "1.11.1",
+    "@applitools/core-base": "1.13.0",
     "@applitools/dom-capture": "11.2.6",
-    "@applitools/dom-snapshot": "4.10.0",
-    "@applitools/driver": "1.16.6",
-    "@applitools/ec-client": "1.8.1",
-    "@applitools/logger": "2.0.15",
-    "@applitools/nml-client": "1.8.1",
-    "@applitools/req": "1.6.6",
-    "@applitools/screenshoter": "3.8.28",
+    "@applitools/dom-snapshot": "4.11.1",
+    "@applitools/driver": "1.17.2",
+    "@applitools/ec-client": "1.8.4",
+    "@applitools/logger": "2.0.16",
+    "@applitools/nml-client": "1.8.4",
+    "@applitools/req": "1.6.7",
+    "@applitools/screenshoter": "3.8.31",
     "@applitools/snippets": "2.4.25",
-    "@applitools/socket": "1.1.15",
-    "@applitools/spec-driver-webdriver": "1.1.4",
-    "@applitools/ufg-client": "1.11.1",
-    "@applitools/utils": "1.7.1",
+    "@applitools/socket": "1.1.16",
+    "@applitools/spec-driver-webdriver": "1.1.7",
+    "@applitools/ufg-client": "1.11.2",
+    "@applitools/utils": "1.7.2",
     "@types/ws": "8.5.5",
     "abort-controller": "3.0.0",
     "chalk": "4.1.2",
@@ -100,11 +100,11 @@
   "devDependencies": {
     "@applitools/bongo": "^5.10.0",
     "@applitools/sea": "^1.0.0",
-    "@applitools/spec-driver-puppeteer": "^1.4.4",
-    "@applitools/spec-driver-selenium": "^1.5.75",
+    "@applitools/spec-driver-puppeteer": "^1.4.7",
+    "@applitools/spec-driver-selenium": "^1.5.78",
     "@applitools/test-server": "^1.2.2",
     "@applitools/test-utils": "^1.5.17",
-    "@applitools/tunnel-client": "^1.5.1",
+    "@applitools/tunnel-client": "^1.5.2",
     "@types/node": "^12.20.55",
     "@types/selenium-webdriver": "^4.1.2",
     "@types/semver": "^7.5.4",

package/types/automation/abort.d.ts

@@ -1,16 +1,15 @@
-import type { DriverTarget, Eyes, AbortSettings, Environment } from './types';
+import type { Eyes, AbortSettings, Environment } from './types';
 import { type Logger } from '@applitools/logger';
 import { type AbortController } from 'abort-controller';
-import { type SpecType, type SpecDriver } from '@applitools/driver';
+import { type Driver, type SpecType } from '@applitools/driver';
 type Options<TSpec extends SpecType> = {
     eyes: Eyes<TSpec>;
-    target?: DriverTarget<TSpec>;
+    driver?: Driver<TSpec>;
     controller: AbortController;
     environments?: Environment[];
-    spec?: SpecDriver<TSpec>;
     logger: Logger;
 };
-export declare function makeAbort<TSpec extends SpecType>({ eyes, target, controller, environments: defaultEnvironments, spec, logger: mainLogger, }: Options<TSpec>): ({ settings, logger, }?: {
+export declare function makeAbort<TSpec extends SpecType>({ eyes, driver, controller, environments: defaultEnvironments, logger: mainLogger, }: Options<TSpec>): ({ settings, logger, }?: {
     settings?: AbortSettings | undefined;
     logger?: Logger | undefined;
 }) => Promise<void>;

package/types/automation/close.d.ts

@@ -1,14 +1,13 @@
-import type { DriverTarget, Eyes, CloseSettings, Environment } from '../ufg/types';
+import type { Eyes, CloseSettings, Environment } from '../ufg/types';
 import { type Logger } from '@applitools/logger';
-import { type SpecType, type SpecDriver } from '@applitools/driver';
+import { type Driver, type SpecType } from '@applitools/driver';
 type Options<TSpec extends SpecType> = {
     eyes: Eyes<TSpec>;
-    target?: DriverTarget<TSpec>;
+    driver?: Driver<TSpec>;
     environments?: Environment[];
-    spec?: SpecDriver<TSpec>;
     logger: Logger;
 };
-export declare function makeClose<TSpec extends SpecType>({ eyes, target, environments: defaultEnvironments, spec, logger: mainLogger, }: Options<TSpec>): ({ settings, logger, }?: {
+export declare function makeClose<TSpec extends SpecType>({ eyes, driver, environments: defaultEnvironments, logger: mainLogger, }: Options<TSpec>): ({ settings, logger, }?: {
     settings?: CloseSettings | undefined;
     logger?: Logger | undefined;
 }) => Promise<void>;

package/types/automation/types.d.ts

@@ -33,6 +33,10 @@ export interface AndroidDeviceEnvironment {
 }
 export type RenderEnvironment = (DesktopBrowserEnvironment | ChromeEmulationDeviceEnvironment | IOSDeviceEnvironment | AndroidDeviceEnvironment) & {
     environmentId?: string;
+    os?: string;
+    displayOs?: string;
+    hostingApp?: string;
+    displayHostingApp?: string;
     properties?: BaseCore.CustomProperty[];
     fallbackBaselineId?: string;
 };
@@ -42,7 +46,7 @@ export type ExactEnvironment = BaseCore.Environment & {
     fallbackBaselineId?: string;
 };
 export type Environment = RenderEnvironment | ExactEnvironment;
-export interface Core<TSpec extends SpecType> extends BaseCore.Core {
+export interface Core<TSpec extends SpecType> extends Omit<BaseCore.Core, 'openEyes'> {
     readonly base: BaseCore.Core;
     getViewportSize?(options: {
         target: DriverTarget<TSpec>;
@@ -80,11 +84,11 @@ export interface Core<TSpec extends SpecType> extends BaseCore.Core {
         logger?: Logger;
     }): Promise<string[]>;
 }
-export interface Eyes<TSpec extends SpecType> extends BaseCore.Eyes {
+export interface Eyes<TSpec extends SpecType> extends Omit<BaseCore.Eyes, 'core' | 'check' | 'checkAndClose'> {
     readonly core: Core<TSpec>;
     readonly storage: EyesStorage;
     getBaseEyes(options: {
-        settings: GetBaseEyesSettings;
+        settings: GetBaseEyesSettings<TSpec>;
         logger?: Logger;
     }): Promise<BaseCore.Eyes>;
     check(options?: {
@@ -114,8 +118,9 @@ export type EyesStorage = Map<string, {
     eyes: ControlledPromise<BaseCore.Eyes>;
     jobs: Promise<void>[];
 }>;
-export interface GetBaseEyesSettings {
+export interface GetBaseEyesSettings<TSpec extends SpecType> {
     environment: Environment;
+    driver?: Driver<TSpec>;
 }
 export type LazyLoadOptions = {
     scrollLength?: number;

package/types/automation/utils/report-kobiton.d.ts

@@ -0,0 +1,12 @@
+import type { Driver, SpecType } from '@applitools/driver';
+import type { Logger } from '@applitools/logger';
+type Options<TSpec extends SpecType> = {
+    driver?: Driver<TSpec>;
+    settings: {
+        batchId: string;
+        resultsUrl: string;
+    };
+    logger: Logger;
+};
+export declare function reportKobiton<TSpec extends SpecType>({ driver, settings, logger }: Options<TSpec>): Promise<void>;
+export {};

package/types/classic/get-base-eyes.d.ts

@@ -8,7 +8,7 @@ type Options<TSpec extends SpecType> = {
     logger: Logger;
 };
 export declare function makeGetBaseEyes<TSpec extends SpecType>({ settings: defaultSettings, eyes, logger: mainLogger, }: Options<TSpec>): ({ settings, logger, }: {
-    settings: GetBaseEyesSettings;
+    settings: GetBaseEyesSettings<TSpec>;
     logger?: Logger | undefined;
 }) => Promise<BaseEyes>;
 export {};

package/types/open-eyes.d.ts

@@ -11,7 +11,7 @@ type Options<TSpec extends SpecType, TType extends 'classic' | 'ufg'> = {
     };
     batch?: Batch;
     core: Core<TSpec, TType>;
-    cores?: {
+    cores: {
         [TKey in 'classic' | 'ufg']: TypedCore<TSpec, TKey>;
     };
     spec?: SpecDriver<TSpec>;

package/types/ufg/get-base-eyes.d.ts

@@ -9,7 +9,7 @@ type Options<TSpec extends SpecType> = {
     logger: Logger;
 };
 export declare function makeGetBaseEyes<TSpec extends SpecType>({ settings: defaultSettings, eyes, logger: mainLogger, }: Options<TSpec>): ({ settings, logger, }: {
-    settings: GetBaseEyesSettings;
+    settings: GetBaseEyesSettings<TSpec>;
     logger?: Logger | undefined;
 }) => Promise<BaseEyes>;
 export {};