@applitools/core 2.3.5 → 2.3.7

package/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 ## Unreleased
 
+## 2.3.7 - 2023/2/23
+
+### Features
+- Added caching for broker url to avoid looking for the nml element multiple times
+- Passing density metric for PPI support in the sdk
+### Bug fixes
+- Fixed issue with universal protocol when manager ref was deleted once `EyesManager.getResults` was called
+- Fixed vulnerabilities of EC client
+
+## 2.3.6 - 2023/2/17
+
+### Features
+### Bug fixes
+- Update some type declarations
+
 ## 2.3.5 - 2023/2/17
 
 ### Features

package/dist/core.js

@@ -52,7 +52,7 @@ function makeCore({ spec, concurrency, core, agentId = 'core', cwd = process.cwd
         locateText: (0, locate_text_1.makeLocateText)({ spec, core, logger }),
         extractText: (0, extract_text_1.makeExtractText)({ spec, core, logger }),
         openEyes: (0, open_eyes_1.makeOpenEyes)({ spec, core, concurrency, logger }),
-        makeManager: (0, make_manager_1.makeMakeManager)({ spec, concurrency, agentId, logger }),
+        makeManager: (0, make_manager_1.makeMakeManager)({ spec, core, concurrency, agentId, logger }),
         closeBatch: (0, close_batch_1.makeCloseBatch)({ core, logger }),
         deleteTest: (0, delete_test_1.makeDeleteTest)({ core, logger }),
         makeECClient: (0, make_ec_client_1.makeMakeECClient)({ core, logger }),

package/dist/ufg/utils/take-snapshots.js

@@ -18,7 +18,6 @@ exports.takeSnapshots = void 0;
 const take_dom_snapshots_1 = require("./take-dom-snapshots");
 const take_vhses_1 = require("./take-vhses");
 const nml_client_1 = require("@applitools/nml-client");
-const extract_broker_url_1 = require("./extract-broker-url");
 __exportStar(require("./take-dom-snapshots"), exports);
 __exportStar(require("./take-vhses"), exports);
 async function takeSnapshots({ driver, settings, hooks, provides, logger, }) {
@@ -26,7 +25,7 @@ async function takeSnapshots({ driver, settings, hooks, provides, logger, }) {
         return (0, take_dom_snapshots_1.takeDomSnapshots)({ driver, settings, hooks, provides, logger });
     }
     else {
-        const brokerUrl = await (0, extract_broker_url_1.extractBrokerUrl)({ driver, logger });
+        const brokerUrl = await driver.extractBrokerUrl();
         if (brokerUrl) {
             return (await (0, nml_client_1.takeSnapshots)({ url: brokerUrl, settings, logger }));
         }

package/dist/universal/core-server.js

@@ -142,9 +142,7 @@ printStdout = false, ...handlerOptions } = {}) {
         });
         socket.command('EyesManager.getResults', async ({ manager, ...options }) => {
             var _a;
-            const results = (_a = refer.deref(manager)) === null || _a === void 0 ? void 0 : _a.getResults(options);
-            refer.destroy(manager);
-            return results;
+            return (_a = refer.deref(manager)) === null || _a === void 0 ? void 0 : _a.getResults(options);
         });
         socket.command('Eyes.check', async ({ eyes, ...options }) => {
             var _a;
@@ -164,9 +162,7 @@ printStdout = false, ...handlerOptions } = {}) {
         });
         socket.command('Eyes.getResults', async ({ eyes, ...options }) => {
             var _a;
-            const results = (_a = refer.deref(eyes)) === null || _a === void 0 ? void 0 : _a.getResults(options);
-            refer.destroy(eyes);
-            return results;
+            return (_a = refer.deref(eyes)) === null || _a === void 0 ? void 0 : _a.getResults(options);
         });
         socket.command('Debug.getHistory', async () => {
             return getHistory();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/core",
-  "version": "2.3.5",
+  "version": "2.3.7",
   "homepage": "https://applitools.com",
   "bugs": {
     "url": "https://github.com/applitools/eyes.sdk.javascript1/issues"
@@ -50,7 +50,7 @@
     "build:bin:arm64": "pkg . --target node14-linux-arm64 --output ./bin/core-linux-arm64",
     "build:bin:zip": "zip -j ./bin/core.zip $(find ./bin -type f -not -name '*.zip' -not -name '*.tar.gz' | xargs)",
     "build:bin:tgz": "tar -czf ./bin/core.tar.gz $(find ./bin -type f -not -name '*.zip' -not -name '*.tar.gz' | xargs)",
-    "test": "mocha --no-timeouts -r ts-node/register --parallel --jobs 15 --exit --exclude './test/bin/**' './test/**/*.spec.ts'",
+    "test": "mocha --config .mocharc.cvg.js",
     "test:sanity": "yarn test:unit",
     "test:bin": "mocha --no-timeouts -r ts-node/register --parallel --jobs 15 './test/bin/**/*.spec.ts'",
     "test:e2e": "mocha --no-timeouts -r ts-node/register --parallel --jobs 15 './test/e2e/**/*.spec.ts'",
@@ -62,7 +62,7 @@
     "deps": "bongo deps",
     "preversion": "bongo preversion --verify-pending-changes --skip-deps",
     "version": "bongo version --with-pending-changes",
-    "postversion": "bongo postversion --skip-release-notification"
+    "postversion": "bongo postversion"
   },
   "pkg": {
     "scripts": "./dist/cli/cli.js",
@@ -73,19 +73,19 @@
     ]
   },
   "dependencies": {
-    "@applitools/core-base": "1.1.38",
+    "@applitools/core-base": "1.1.39",
     "@applitools/dom-capture": "11.2.1",
     "@applitools/dom-snapshot": "4.7.3",
-    "@applitools/driver": "1.11.31",
-    "@applitools/ec-client": "1.2.10",
+    "@applitools/driver": "1.11.34",
+    "@applitools/ec-client": "1.2.11",
     "@applitools/logger": "1.1.46",
-    "@applitools/nml-client": "1.3.35",
+    "@applitools/nml-client": "1.3.37",
     "@applitools/req": "1.1.30",
-    "@applitools/screenshoter": "3.7.27",
+    "@applitools/screenshoter": "3.7.28",
     "@applitools/snippets": "2.4.15",
     "@applitools/socket": "1.0.8",
-    "@applitools/spec-driver-webdriver": "1.0.11",
-    "@applitools/ufg-client": "1.1.26",
+    "@applitools/spec-driver-webdriver": "1.0.14",
+    "@applitools/ufg-client": "1.1.27",
     "@applitools/utils": "1.3.30",
     "@types/ws": "8.5.4",
     "abort-controller": "3.0.0",
@@ -98,9 +98,10 @@
   },
   "devDependencies": {
     "@applitools/bongo": "^2.2.5",
-    "@applitools/spec-driver-puppeteer": "^1.1.43",
-    "@applitools/spec-driver-selenium": "^1.5.28",
-    "@applitools/spec-driver-webdriverio": "^1.4.26",
+    "@applitools/sdk-coverage-tests": "^2.7.10",
+    "@applitools/spec-driver-puppeteer": "^1.1.46",
+    "@applitools/spec-driver-selenium": "^1.5.31",
+    "@applitools/spec-driver-webdriverio": "^1.4.29",
     "@applitools/test-server": "^1.1.26",
     "@applitools/test-utils": "^1.5.12",
     "@types/mocha": "^9.1.1",
@@ -109,6 +110,7 @@
     "@types/yargs": "^17.0.22",
     "chromedriver": "^106.0.0",
     "mocha": "^10.0.0",
+    "mocha-multi": "^1.1.7",
     "nock": "^13.2.8",
     "pkg": "^5.8.0",
     "png-async": "^0.9.4",

package/types/ufg/utils/generate-safe-selectors.d.ts

@@ -9,7 +9,7 @@ export declare function generateSafeSelectors<TSpec extends SpecType>({ context,
         elementReference: ElementReference<TSpec>;
     } | {
         safeSelector: CommonSelector<never>;
-        originalSelector: import("@applitools/driver").Selector<never> | null;
+        originalSelector: CommonSelector<never> | null;
         elementReference: ElementReference<TSpec>;
     })[];
     cleanupGeneratedSelectors: () => Promise<void>;

package/dist/ufg/utils/extract-broker-url.js

@@ -1,52 +0,0 @@
-"use strict";
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.extractBrokerUrl = void 0;
-const utils = __importStar(require("@applitools/utils"));
-async function extractBrokerUrl({ driver, logger, }) {
-    if (!driver.isNative)
-        return null;
-    logger.log('Broker url extraction is started');
-    const element = await driver.element({ type: 'accessibility id', selector: 'Applitools_View' });
-    if (!element)
-        return null;
-    try {
-        let result;
-        do {
-            result = JSON.parse(await element.getText());
-            if (result.nextPath) {
-                logger.log('Broker url was extraction finished successfully with value', result.nextPath);
-                return result.nextPath;
-            }
-            await utils.general.sleep(1000);
-        } while (!result.error);
-        logger.error('Broker url extraction has failed with error', result.error);
-        return null;
-    }
-    catch (error) {
-        return null;
-    }
-}
-exports.extractBrokerUrl = extractBrokerUrl;

package/types/ufg/utils/extract-broker-url.d.ts

@@ -1,6 +0,0 @@
-import { type SpecType, type Driver } from '@applitools/driver';
-import { type Logger } from '@applitools/logger';
-export declare function extractBrokerUrl<TSpec extends SpecType>({ driver, logger, }: {
-    driver: Driver<TSpec>;
-    logger: Logger;
-}): Promise<string | null>;