@applitools/core 2.3.3 → 2.3.5

package/CHANGELOG.md

@@ -2,6 +2,20 @@
 
 ## Unreleased
 
+## 2.3.5 - 2023/2/17
+
+### Features
+- Improve logging in core server
+### Bug fixes
+- Fixed issue when core server was hanging if any command was called immediately after `Core.makeCore` command
+- Fixed issue when `StaticDriver` and `StaticElement` were not recognized as a valid driver or element objects
+
+## 2.3.4 - 2023/2/16
+
+### Features
+### Bug fixes
+- Fixed ws types
+
 ## 2.3.3 - 2023/2/16
 
 ### Features

package/dist/universal/core-server.js

@@ -19,11 +19,18 @@ printStdout = false, ...handlerOptions } = {}) {
     var _a, _b;
     const logDirname = (_a = process.env.APPLITOOLS_LOG_DIR) !== null && _a !== void 0 ? _a : path_1.default.resolve(os_1.default.tmpdir(), `applitools-logs`);
     const baseLogger = (0, logger_1.makeLogger)({
-        handler: { type: 'rolling file', name: 'eyes', dirname: logDirname },
-        label: 'eyes',
+        handler: { type: 'rolling file', name: 'universal', dirname: logDirname },
+        label: 'core-universal',
         level: 'info',
         colors: false,
     });
+    baseLogger.log('Core universal is going to be initialized with options', {
+        debug,
+        shutdownMode,
+        idleTimeout,
+        printStdout,
+        ...handlerOptions,
+    });
     const { server, port } = await (0, ws_server_1.makeServer)({ ...handlerOptions, debug });
     // eslint-disable-next-line no-console
     console.log(port); // NOTE: this is a part of the generic protocol
@@ -34,7 +41,7 @@ printStdout = false, ...handlerOptions } = {}) {
     }
     if (!printStdout)
         process.stdout.write = () => true; // NOTE: prevent any write to stdout
-    baseLogger.log('Universal core is initialized on port', port);
+    baseLogger.log('Core universal is started on port', port);
     let idle;
     let serverClosed = false;
     if (shutdownMode === 'stdin') {
@@ -76,7 +83,7 @@ printStdout = false, ...handlerOptions } = {}) {
             },
         });
         logger.console.log(`Logs saved in: ${logDirname}`);
-        const core = await socket.wait('Core.makeCore', ({ agentId, cwd, spec }) => {
+        const corePromise = socket.wait('Core.makeCore', ({ agentId, cwd, spec }) => {
             return (0, core_1.makeCore)({
                 agentId: `eyes-universal/${require('../../package.json').version}/${agentId}`,
                 spec: spec === 'webdriver' ? spec_driver_webdriver_1.default : (0, spec_driver_1.makeSpec)({ socket, spec }),
@@ -85,36 +92,46 @@ printStdout = false, ...handlerOptions } = {}) {
             });
         });
         socket.command('Core.getAccountInfo', async (options) => {
+            const core = await corePromise;
             return core.getAccountInfo(options);
         });
         socket.command('Core.getViewportSize', async (options) => {
             var _a;
+            const core = await corePromise;
             return (_a = core.getViewportSize) === null || _a === void 0 ? void 0 : _a.call(core, options);
         });
         socket.command('Core.setViewportSize', async (options) => {
             var _a;
+            const core = await corePromise;
             return (_a = core.setViewportSize) === null || _a === void 0 ? void 0 : _a.call(core, options);
         });
         socket.command('Core.closeBatch', async (options) => {
+            const core = await corePromise;
             return core.closeBatch(options);
         });
         socket.command('Core.deleteTest', async (options) => {
+            const core = await corePromise;
             return core.deleteTest(options);
         });
         socket.command('Core.locate', async (options) => {
+            const core = await corePromise;
             return core.locate(options);
         });
         socket.command('Core.locateText', async (options) => {
+            const core = await corePromise;
             return core.locateText(options);
         });
         socket.command('Core.extractText', async (options) => {
+            const core = await corePromise;
             return core.extractText(options);
         });
         socket.command('Core.makeECClient', async (options) => {
+            const core = await corePromise;
             const client = await core.makeECClient(options);
             return { url: client.url };
         });
         socket.command('Core.makeManager', async (options) => {
+            const core = await corePromise;
             return refer.ref(await core.makeManager(options));
         });
         socket.command('EyesManager.openEyes', async ({ manager, ...options }) => {
@@ -133,6 +150,10 @@ printStdout = false, ...handlerOptions } = {}) {
             var _a;
             return (_a = refer.deref(eyes)) === null || _a === void 0 ? void 0 : _a.check(options);
         });
+        socket.command('Eyes.checkAndClose', async ({ eyes, ...options }) => {
+            var _a;
+            return (_a = refer.deref(eyes)) === null || _a === void 0 ? void 0 : _a.checkAndClose(options);
+        });
         socket.command('Eyes.close', async ({ eyes, ...options }) => {
             var _a;
             return (_a = refer.deref(eyes)) === null || _a === void 0 ? void 0 : _a.close(options);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applitools/core",
-  "version": "2.3.3",
+  "version": "2.3.5",
   "homepage": "https://applitools.com",
   "bugs": {
     "url": "https://github.com/applitools/eyes.sdk.javascript1/issues"
@@ -77,16 +77,17 @@
     "@applitools/dom-capture": "11.2.1",
     "@applitools/dom-snapshot": "4.7.3",
     "@applitools/driver": "1.11.31",
-    "@applitools/ec-client": "1.2.9",
+    "@applitools/ec-client": "1.2.10",
     "@applitools/logger": "1.1.46",
     "@applitools/nml-client": "1.3.35",
     "@applitools/req": "1.1.30",
     "@applitools/screenshoter": "3.7.27",
     "@applitools/snippets": "2.4.15",
-    "@applitools/socket": "1.0.7",
-    "@applitools/spec-driver-webdriver": "1.0.10",
+    "@applitools/socket": "1.0.8",
+    "@applitools/spec-driver-webdriver": "1.0.11",
     "@applitools/ufg-client": "1.1.26",
     "@applitools/utils": "1.3.30",
+    "@types/ws": "8.5.4",
     "abort-controller": "3.0.0",
     "chalk": "4.1.2",
     "node-fetch": "2.6.7",
@@ -105,7 +106,6 @@
     "@types/mocha": "^9.1.1",
     "@types/node": "12",
     "@types/selenium-webdriver": "^4.1.2",
-    "@types/ws": "^8.5.4",
     "@types/yargs": "^17.0.22",
     "chromedriver": "^106.0.0",
     "mocha": "^10.0.0",