@applicaster/zapp-react-native-utils 16.0.0-alpha.5402127570 → 16.0.0-alpha.5548956531

package/modalState/RemoteEditableCollection.ts

@@ -0,0 +1,189 @@
+import { BehaviorSubject, Observable } from "rxjs";
+import { Content, MenuItem, Operation } from "./types";
+import { EditableCollection } from "./EditableCollection";
+import { actionExecutor } from "../actionsExecutor/ActionExecutor";
+import { createLogger } from "../logger";
+
+const { log_warning, log_error } = createLogger({
+  subsystem: "modalState",
+  category: "RemoteEditableCollection",
+});
+
+export class RemoteEditableCollection implements EditableCollection {
+  public items$: Observable<MenuItem[]>;
+  public operations: Operation[];
+  private itemsSubject: BehaviorSubject<MenuItem[]>;
+  private refetch: () => Promise<void>;
+  private content: Content;
+
+  constructor(content: Content, refetch: () => Promise<void>) {
+    this.content = content;
+    this.refetch = refetch;
+    this.operations = content.dynamicCollection?.operations || [];
+    this.itemsSubject = new BehaviorSubject<MenuItem[]>(content.items || []);
+    this.items$ = this.itemsSubject.asObservable();
+  }
+
+  /**
+   * Replace the current items with an authoritative server list (called after
+   * a successful mutation reloads the feed). Overrides optimistic state.
+   */
+  sync(items: MenuItem[]): void {
+    this.itemsSubject.next(items);
+  }
+
+  async remove(index: number): Promise<void> {
+    const items = this.itemsSubject.value;
+    const snapshot = [...items];
+    const item = items[index];
+
+    if (!item) return;
+
+    // Optimistic update
+    const newItems = items.filter((_, i) => i !== index);
+    this.itemsSubject.next(newItems);
+
+    try {
+      await this.executeActionAlias(item, "remove_item");
+      await this.refetch();
+    } catch (e) {
+      log_error("Remove failed, rolling back", { error: e });
+      this.itemsSubject.next(snapshot);
+    }
+  }
+
+  async move(itemIds: string[]): Promise<void> {
+    const items = this.itemsSubject.value;
+    const snapshot = [...items];
+
+    if (itemIds && itemIds.length > 0) {
+      const itemMap = new Map(items.map((item) => [item.id, item]));
+      const newItems: MenuItem[] = [];
+
+      itemIds.forEach((id) => {
+        const found = itemMap.get(id);
+        if (found) newItems.push(found);
+      });
+
+      items.forEach((item) => {
+        if (!newItems.includes(item)) newItems.push(item);
+      });
+
+      this.itemsSubject.next(newItems);
+
+      try {
+        const targetItem = newItems[0] || items[0];
+
+        await this.executeActionAlias(targetItem, "reorder_item", {
+          itemIds,
+        });
+
+        await this.refetch();
+      } catch (e) {
+        console.error("[RemoteEditableCollection] move failed:", e);
+        log_error("Move failed, rolling back", { error: e });
+        this.itemsSubject.next(snapshot);
+      }
+    }
+  }
+
+  async add(_item?: MenuItem): Promise<void> {
+    const items = this.itemsSubject.value;
+    const snapshot = [...items];
+
+    const addEvents = this.content.dynamicCollection?.events?.add;
+
+    if (!addEvents || addEvents.length === 0) {
+      log_warning("No events.add action found for create collection operation");
+
+      return;
+    }
+
+    try {
+      for (const action of addEvents) {
+        await actionExecutor.handleAction(action as any);
+      }
+
+      await this.refetch();
+    } catch (e) {
+      log_error("Add/create collection failed", { error: e });
+      this.itemsSubject.next(snapshot);
+    }
+  }
+
+  async deleteCollection(): Promise<void> {
+    const items = this.itemsSubject.value;
+    const snapshot = [...items];
+
+    this.itemsSubject.next([]);
+
+    try {
+      const firstItem = items[0];
+
+      if (firstItem) {
+        await this.executeActionAlias(firstItem, "clear_collection");
+      }
+
+      await this.refetch();
+    } catch (e) {
+      log_error("deleteCollection failed, rolling back", { error: e });
+      this.itemsSubject.next(snapshot);
+    }
+  }
+
+  private async executeActionAlias(
+    item: MenuItem,
+    alias: string,
+    data?: Record<string, unknown>
+  ): Promise<void> {
+    const entryActions = item.entryActions || [];
+
+    const actionGroup = entryActions.find((ea) => ea.button?.alias === alias);
+
+    console.log("[RemoteEditableCollection] executeActionAlias:", {
+      alias,
+      itemId: item.id,
+      entryActionsCount: entryActions.length,
+      availableAliases: entryActions.map((ea) => ea.button?.alias),
+      foundActionGroup: !!actionGroup,
+      data,
+    });
+
+    if (!actionGroup || !actionGroup.actions) {
+      log_warning(`No entry action found for alias "${alias}"`, {
+        itemId: item.id,
+      });
+
+      return;
+    }
+
+    // Execute each action in the group
+    for (const action of actionGroup.actions) {
+      const actionToExecute = data
+        ? {
+            ...action,
+            options: {
+              ...action.options,
+              ...data,
+              data: {
+                ...(action.options?.data || {}),
+                ...data,
+              },
+            },
+          }
+        : action;
+
+      console.log(
+        "[RemoteEditableCollection] handling action:",
+        actionToExecute
+      );
+
+      await actionExecutor.handleAction(
+        actionToExecute as any,
+        {
+          entry: item as any,
+        } as any
+      );
+    }
+  }
+}

package/modalState/__tests__/ContentViewModel.editable.test.ts

@@ -0,0 +1,69 @@
+import { ContentViewModel } from "../ContentViewModel";
+import { loadItemsFromSource } from "../../actionsExecutor/actions/openBottomSheet";
+import { EditableCollectionRegistry } from "../EditableCollectionRegistry";
+import { EditableCollection } from "../EditableCollection";
+import { BehaviorSubject } from "rxjs";
+import type { MenuItem } from "../types";
+
+jest.mock("../../actionsExecutor/actions/openBottomSheet", () => ({
+  loadItemsFromSource: jest.fn(),
+}));
+
+const load = loadItemsFromSource as jest.Mock;
+
+describe("ContentViewModel — editable collection", () => {
+  beforeEach(() => {
+    (EditableCollectionRegistry as any).providers = {};
+    jest.clearAllMocks();
+  });
+
+  it("resolves the collection once and syncs fresh items on refetch (no recreation)", async () => {
+    const sync = jest.fn();
+
+    const collection: EditableCollection = {
+      items$: new BehaviorSubject<MenuItem[]>([]).asObservable(),
+      operations: ["remove"],
+      sync,
+    };
+
+    const factory = jest.fn(() => collection);
+    EditableCollectionRegistry.register("@{provider/test}", factory);
+
+    const serverItems: MenuItem[] = [{ id: "1", title: "Fetched" }];
+
+    load.mockResolvedValue({
+      items: serverItems,
+      role: "dynamic_collection",
+      dynamicCollection: {
+        operations: ["remove"],
+        provider: "@{provider/test}",
+      },
+    });
+
+    const viewModel = new ContentViewModel({
+      title: "Queue",
+      items: [],
+      itemsUrl: "pipesv2://queue-action",
+      dynamicCollection: {
+        operations: ["remove"],
+        provider: "@{provider/test}",
+      },
+    });
+
+    // constructor resolves the provider, then refetches (items empty + itemsUrl)
+    await new Promise(process.nextTick);
+
+    expect(viewModel.editableCollection).toBe(collection);
+    // factory used exactly once — instance reused, not rebuilt on refetch
+    expect(factory).toHaveBeenCalledTimes(1);
+    // authoritative server items pushed into the existing instance
+    expect(sync).toHaveBeenLastCalledWith(serverItems);
+
+    sync.mockClear();
+
+    await viewModel.refetch();
+
+    expect(factory).toHaveBeenCalledTimes(1);
+    expect(sync).toHaveBeenCalledWith(serverItems);
+  });
+});

package/modalState/__tests__/ContentViewModel.test.ts

@@ -0,0 +1,165 @@
+import { ContentViewModel } from "../ContentViewModel";
+import { loadItemsFromSource } from "../../actionsExecutor/actions/openBottomSheet";
+
+jest.mock("../../actionsExecutor/actions/openBottomSheet", () => ({
+  loadItemsFromSource: jest.fn(),
+}));
+
+describe("ContentViewModel", () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it("should initialize with items and not fetch if itemsUrl is not provided", () => {
+    const content = {
+      title: "Test Menu",
+      items: [{ title: "Item 1" }, { title: "Item 2" }],
+    };
+
+    const viewModel = new ContentViewModel(content);
+
+    expect(viewModel.getState()).toEqual({
+      items: content.items,
+      isLoading: false,
+      role: undefined,
+      behavior: undefined,
+    });
+
+    expect(loadItemsFromSource).not.toHaveBeenCalled();
+  });
+
+  it("seeds role and behavior from Content", () => {
+    const viewModel = new ContentViewModel({
+      title: "Playlists",
+      items: [{ title: "A" }],
+      role: "collection_selector",
+      behavior: { selectMode: "multi", currentSelection: ["a"] },
+    });
+
+    expect(viewModel.getState().role).toBe("collection_selector");
+
+    expect(viewModel.getState().behavior).toEqual({
+      selectMode: "multi",
+      currentSelection: ["a"],
+    });
+  });
+
+  it("should trigger fetch on init if items is empty and itemsUrl is present", async () => {
+    const mockItems = [{ title: "Fetched Item" }];
+
+    (loadItemsFromSource as jest.Mock).mockResolvedValueOnce({
+      items: mockItems,
+      role: "collection_selector",
+      behavior: { selectMode: "multi", currentSelection: [] },
+    });
+
+    const content = {
+      title: "Test Menu",
+      items: [],
+      itemsUrl: "http://example.com/items",
+    };
+
+    const viewModel = new ContentViewModel(content);
+
+    // Initial state should be loading
+    expect(viewModel.getState().isLoading).toBe(true);
+
+    // Wait for the asynchronous refetch to complete
+    await new Promise(process.nextTick);
+
+    expect(loadItemsFromSource).toHaveBeenCalledWith(
+      expect.stringMatching(/^http:\/\/example\.com\/items\?_t=\d+$/)
+    );
+
+    expect(viewModel.getState()).toEqual({
+      items: mockItems,
+      isLoading: false,
+      role: "collection_selector",
+      behavior: { selectMode: "multi", currentSelection: [] },
+    });
+  });
+
+  it("updates role and behavior on refetch", async () => {
+    (loadItemsFromSource as jest.Mock)
+      .mockResolvedValueOnce({
+        items: [{ title: "First" }],
+        role: "collection_selector",
+        behavior: { selectMode: "multi", currentSelection: [] },
+      })
+      .mockResolvedValueOnce({
+        items: [{ title: "Second", isSelected: true }],
+        role: "collection_selector",
+        behavior: { selectMode: "multi", currentSelection: ["2"] },
+      });
+
+    const viewModel = new ContentViewModel({
+      title: "Test Menu",
+      items: [],
+      itemsUrl: "http://example.com/items",
+    });
+
+    await new Promise(process.nextTick);
+
+    await viewModel.refetch();
+
+    expect(viewModel.getState().items[0].title).toBe("Second");
+    expect(viewModel.getState().behavior?.currentSelection).toEqual(["2"]);
+    expect(viewModel.getState().role).toBe("collection_selector");
+  });
+
+  it("should notify subscribers of state changes", async () => {
+    const mockItems = [{ title: "Fetched Item" }];
+
+    (loadItemsFromSource as jest.Mock).mockResolvedValue({
+      items: mockItems,
+    });
+
+    const content = {
+      title: "Test Menu",
+      items: [],
+      itemsUrl: "http://example.com/items",
+    };
+
+    const viewModel = new ContentViewModel(content);
+
+    // Wait for constructor's refetch to finish
+    await new Promise(process.nextTick);
+
+    const listener = jest.fn();
+    const unsubscribe = viewModel.subscribe(listener);
+
+    await viewModel.refetch();
+
+    expect(listener).toHaveBeenCalled();
+    expect(viewModel.getState().items).toEqual(mockItems);
+
+    unsubscribe();
+    listener.mockClear();
+
+    await viewModel.refetch();
+    expect(listener).not.toHaveBeenCalled();
+  });
+
+  it("should handle error states during fetching", async () => {
+    const error = new Error("Network Error");
+    (loadItemsFromSource as jest.Mock).mockRejectedValueOnce(error);
+
+    const content = {
+      title: "Test Menu",
+      items: [],
+      itemsUrl: "http://example.com/items",
+    };
+
+    const viewModel = new ContentViewModel(content);
+
+    await new Promise(process.nextTick);
+
+    expect(viewModel.getState()).toEqual({
+      items: [],
+      isLoading: false,
+      error: "Network Error",
+      role: undefined,
+      behavior: undefined,
+    });
+  });
+});

package/modalState/__tests__/EditableCollectionRegistry.test.ts

@@ -0,0 +1,112 @@
+import {
+  EditableCollectionRegistry,
+  resolveEditableCollection,
+} from "../EditableCollectionRegistry";
+import { RemoteEditableCollection } from "../RemoteEditableCollection";
+import { EditableCollection } from "../EditableCollection";
+import { BehaviorSubject } from "rxjs";
+import type { Content, MenuItem } from "../types";
+
+function fakeCollection(): EditableCollection {
+  return {
+    items$: new BehaviorSubject<MenuItem[]>([]).asObservable(),
+    operations: [],
+  };
+}
+
+const refetch = jest.fn().mockResolvedValue(undefined);
+
+describe("EditableCollectionRegistry", () => {
+  beforeEach(() => {
+    // reset the static registry between tests
+    (EditableCollectionRegistry as any).providers = {};
+    jest.clearAllMocks();
+  });
+
+  it("registers and resolves a provider factory (new instance per call)", () => {
+    const instance = fakeCollection();
+    const factory = jest.fn(() => instance);
+    EditableCollectionRegistry.register("@{provider/x}", factory);
+
+    const resolved = EditableCollectionRegistry.getProvider("@{provider/x}");
+
+    expect(resolved).toBe(instance);
+    expect(factory).toHaveBeenCalledTimes(1);
+  });
+
+  it("returns null for an unknown provider token", () => {
+    expect(EditableCollectionRegistry.getProvider("@{provider/missing}")).toBe(
+      null
+    );
+  });
+});
+
+describe("resolveEditableCollection", () => {
+  beforeEach(() => {
+    (EditableCollectionRegistry as any).providers = {};
+    jest.clearAllMocks();
+  });
+
+  it("returns null when there are no dynamicCollection options", () => {
+    const content = { items: [] } as unknown as Content;
+
+    expect(resolveEditableCollection(content, refetch)).toBe(null);
+  });
+
+  it("resolves a local provider by token", () => {
+    const instance = fakeCollection();
+    EditableCollectionRegistry.register("@{provider/queue}", () => instance);
+
+    const content = {
+      items: [],
+      dynamicCollection: {
+        operations: ["remove"],
+        provider: "@{provider/queue}",
+      },
+    } as unknown as Content;
+
+    expect(resolveEditableCollection(content, refetch)).toBe(instance);
+  });
+
+  it("returns null (and does not throw) for an unregistered provider token", () => {
+    const content = {
+      items: [],
+      dynamicCollection: {
+        operations: ["remove"],
+        provider: "@{provider/unregistered}",
+      },
+    } as unknown as Content;
+
+    expect(resolveEditableCollection(content, refetch)).toBe(null);
+  });
+
+  it("builds a RemoteEditableCollection when a postUrl is present", () => {
+    const content = {
+      items: [],
+      dynamicCollection: {
+        operations: ["remove"],
+        postUrl: "https://x/cloud-events",
+      },
+    } as unknown as Content;
+
+    expect(resolveEditableCollection(content, refetch)).toBeInstanceOf(
+      RemoteEditableCollection
+    );
+  });
+
+  it("prefers a provider token over postUrl", () => {
+    const instance = fakeCollection();
+    EditableCollectionRegistry.register("@{provider/queue}", () => instance);
+
+    const content = {
+      items: [],
+      dynamicCollection: {
+        operations: ["remove"],
+        provider: "@{provider/queue}",
+        postUrl: "https://x/cloud-events",
+      },
+    } as unknown as Content;
+
+    expect(resolveEditableCollection(content, refetch)).toBe(instance);
+  });
+});

package/modalState/__tests__/ModalOrchestrator.phase3.test.ts

@@ -0,0 +1,28 @@
+import { modalOrchestrator } from "../ModalOrchestrator";
+import { modalStore } from "../store";
+
+describe("ModalOrchestrator phase 3", () => {
+  beforeEach(() => {
+    modalOrchestrator.close();
+    modalStore.getState().dismissModal();
+  });
+
+  it("does not forward styleVariant", () => {
+    modalOrchestrator.open({
+      content: {
+        title: "Playlists",
+        items: [{ title: "Favorites" }],
+        role: "collection_selector",
+        behavior: { selectMode: "multi", currentSelection: [] },
+      },
+    });
+
+    const props = (modalStore.getState().modalState.screen as any)
+      ?.modalBottomSheetContentProps;
+
+    expect(props.styleVariant).toBeUndefined();
+    expect(props.viewModel).toBeDefined();
+    expect(props.viewModel.getState().role).toBe("collection_selector");
+    expect(props.title).toBe("Playlists");
+  });
+});