@applicaster/zapp-react-native-utils 16.0.0-alpha.1232235100 → 16.0.0-alpha.1314750780

package/appUtils/contextKeysManager/__tests__/setKey/failure/failedToSaveInStorage.test.ts

@@ -38,10 +38,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -68,12 +64,6 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedSecureStorage.getItem).not.toHaveBeenCalled();
     expect(mockedSecureStorage.setItem).not.toHaveBeenCalled();
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      storageLevel
-    );
   });
 
   it("returns false if failed to saved with storage-level=persisted", async () => {
@@ -112,10 +102,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -142,12 +128,6 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedSecureStorage.getItem).not.toHaveBeenCalled();
     expect(mockedSecureStorage.setItem).not.toHaveBeenCalled();
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      storageLevel
-    );
   });
 
   it("returns false if failed to saved with storage-level=secure", async () => {
@@ -186,10 +166,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -216,12 +192,6 @@ describe("Context Keys Manager - setKey", () => {
       value,
       "namespace"
     );
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      storageLevel
-    );
   });
 
   it("returns false if failed to saved with storage-level=undefined", async () => {
@@ -259,10 +229,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value });
 
@@ -289,11 +255,5 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedSecureStorage.getItem).not.toHaveBeenCalled();
     expect(mockedSecureStorage.setItem).not.toHaveBeenCalled();
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      StorageLevel.default
-    );
   });
 });

package/appUtils/contextKeysManager/__tests__/setKey/failure/invalidKey.test.ts

@@ -48,7 +48,7 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedLogger.warn).toHaveBeenCalledWith({
       message:
-        "Provided key is not valid - expecing an object with namespace and key properties",
+        "Provided key is not valid - expecting an object with namespace and key properties",
       data: { key },
     });
 
@@ -105,7 +105,7 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedLogger.warn).toHaveBeenCalledWith({
       message:
-        "Provided key is not valid - expecing an object with namespace and key properties",
+        "Provided key is not valid - expecting an object with namespace and key properties",
       data: { key },
     });
 
@@ -162,7 +162,7 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedLogger.warn).toHaveBeenCalledWith({
       message:
-        "Provided key is not valid - expecing an object with namespace and key properties",
+        "Provided key is not valid - expecting an object with namespace and key properties",
       data: { key },
     });
 
@@ -217,7 +217,7 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedLogger.warn).toHaveBeenCalledWith({
       message:
-        "Provided key is not valid - expecing an object with namespace and key properties",
+        "Provided key is not valid - expecting an object with namespace and key properties",
       data: { key },
     });
 

package/appUtils/contextKeysManager/__tests__/setKey/{success/saveItemAndReference.test.ts → success.test.ts}

@@ -1,5 +1,5 @@
-import { ContextKeysManager } from "../../..";
-import { StorageLevel } from "../../../consts";
+import { ContextKeysManager } from "../..";
+import { StorageLevel } from "../../consts";
 
 describe("Context Keys Manager - setKey", () => {
   it("returns true if saved with success with storage-level=undefined", async () => {
@@ -37,10 +37,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -62,12 +58,6 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedSecureStorage.getItem).not.toHaveBeenCalled();
     expect(mockedSecureStorage.setItem).not.toHaveBeenCalled();
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      StorageLevel.default
-    );
   });
 
   it("returns true if saved with success with storage-level=default", async () => {
@@ -105,10 +95,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -130,12 +116,6 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedSecureStorage.getItem).not.toHaveBeenCalled();
     expect(mockedSecureStorage.setItem).not.toHaveBeenCalled();
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      StorageLevel.default
-    );
   });
 
   it("returns true if saved with success with storage-level=persisted", async () => {
@@ -173,10 +153,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -198,12 +174,6 @@ describe("Context Keys Manager - setKey", () => {
 
     expect(mockedSecureStorage.getItem).not.toHaveBeenCalled();
     expect(mockedSecureStorage.setItem).not.toHaveBeenCalled();
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      storageLevel
-    );
   });
 
   it("returns true if saved with success with storage-level=secure", async () => {
@@ -241,10 +211,6 @@ describe("Context Keys Manager - setKey", () => {
       secureStorage: mockedSecureStorage,
     });
 
-    const setReferenceForKey = jest
-      .spyOn(contextManager, "setReferenceForKey")
-      .mockResolvedValueOnce(true);
-
     // run
     const result = await contextManager.setKey({ key, value, storageLevel });
 
@@ -266,11 +232,5 @@ describe("Context Keys Manager - setKey", () => {
       value,
       "namespace"
     );
-
-    expect(setReferenceForKey).toHaveBeenCalledWith(
-      "key",
-      "namespace",
-      storageLevel
-    );
   });
 });

package/appUtils/contextKeysManager/index.ts

@@ -1,6 +1,6 @@
 import { isNil } from "@applicaster/zapp-react-native-utils/utils";
 
-import { StorageLevel, StorageType } from "./consts";
+import { StorageLevel } from "./consts";
 import {
   getNamespaceAndKey,
   keyIsValid,
@@ -59,18 +59,14 @@ type Setup = {
   sessionStorage?: Storage;
   localStorage?: Storage;
   secureStorage?: Storage;
-  referenceStorage?: Storage;
 };
 
-export const REFERENCE_NAMESPACE = "applicaster.v2.references";
-
 export class ContextKeysManager {
   private static _instance: ContextKeysManager;
   private _logger: Logger;
   private _sessionStorage: Storage;
   private _localStorage: Storage;
   private _secureStorage: Storage;
-  private _referenceStorage: Storage;
 
   public static get instance() {
     if (!this._instance) {
@@ -79,7 +75,6 @@ export class ContextKeysManager {
         sessionStorage: SessionStorage,
         localStorage: LocalStorage,
         secureStorage: SecureStorage,
-        referenceStorage: SessionStorage,
       });
 
       this._instance = instance;
@@ -94,13 +89,11 @@ export class ContextKeysManager {
     sessionStorage = SessionStorage,
     localStorage = LocalStorage,
     secureStorage = SecureStorage,
-    referenceStorage = SessionStorage,
-  }: Setup) {
+  }: Setup = {}) {
     this._logger = logger;
     this._sessionStorage = sessionStorage;
     this._localStorage = localStorage;
     this._secureStorage = secureStorage;
-    this._referenceStorage = referenceStorage;
   }
 
   private parseKey(key: KeyName): ParsedKeyAndNamespace {
@@ -109,7 +102,7 @@ export class ContextKeysManager {
     if (!keyIsValid(parsedKey)) {
       this._logger.warn({
         message:
-          "Provided key is not valid - expecing an object with namespace and key properties",
+          "Provided key is not valid - expecting an object with namespace and key properties",
         data: { key },
       });
 
@@ -119,41 +112,6 @@ export class ContextKeysManager {
     return { isValid: true, ...parsedKey };
   }
 
-  // GET
-  public async getKeyByReference(
-    key: string,
-    namespace: string
-  ): Promise<ValueOrNothing> {
-    // 1) look for storage
-    // 2) if storage found - look value in it
-    // 3) if storage not found return NOTHING
-
-    return this._referenceStorage
-      .getItem(buildNamespaceKey(key, namespace), REFERENCE_NAMESPACE)
-      .then((storage: StorageType | unknown) => {
-        switch (storage) {
-          case StorageType.session:
-            return this._sessionStorage.getItem(key, namespace);
-          case StorageType.local:
-            return this._localStorage.getItem(key, namespace);
-          case StorageType.secure:
-            return this._secureStorage.getItem(key, namespace);
-          default:
-            // unknown storage
-            return NOTHING;
-        }
-      })
-      .catch((error) => {
-        // something went wrong
-        this._logger.warn({
-          message: error.message,
-          data: { key, namespace },
-        });
-
-        return NOTHING;
-      });
-  }
-
   public async getKeys(
     keys: Array<KeyName>,
     contextObj?: { key: string; required?: boolean }[]
@@ -228,19 +186,7 @@ export class ContextKeysManager {
       return NOTHING;
     }
 
-    // at first - try to find by reference
-    // if not found, look in session > local > secure
-
-    const resultByReference = await this.getKeyByReference(
-      parsedKey,
-      parsedNamespace
-    );
-
-    if (!isNil(resultByReference)) {
-      return resultByReference;
-    }
-
-    // try to full-search
+    // look in session > local > secure
     try {
       const resultFromSessionStorage = await this._sessionStorage.getItem(
         parsedKey,
@@ -284,41 +230,6 @@ export class ContextKeysManager {
   // GET
 
   // SET
-  public async setReferenceForKey(
-    key: string,
-    namespace: string,
-    storageLevel: StorageLevel
-  ): Promise<boolean> {
-    return this._referenceStorage
-      .setItem(
-        buildNamespaceKey(key, namespace),
-        storageLevel,
-        REFERENCE_NAMESPACE
-      )
-      .then((result) => {
-        if (savingResultIsSuccess(result)) {
-          return true;
-        }
-
-        this._logger.warn({
-          message:
-            "While saving reference - reference storage return non expected value: true",
-          data: { key, namespace, storageLevel },
-        });
-
-        return false;
-      })
-      .catch((error) => {
-        // something went wrong
-        this._logger.warn({
-          message: error.message,
-          data: { key, namespace, storageLevel },
-        });
-
-        return false;
-      });
-  }
-
   // for all keys where saving were succeed return true
   // for others return false
   public async setKeys(
@@ -352,29 +263,36 @@ export class ContextKeysManager {
     }
 
     try {
+      let setItemResult: boolean;
+
       switch (storageLevel) {
         case StorageLevel.persisted:
-          return await Promise.all([
-            this._localStorage.setItem(parsedKey, value, parsedNamespace),
-            this.setReferenceForKey(parsedKey, parsedNamespace, storageLevel),
-          ]).then(([setItemResult]) => {
-            return savingResultIsSuccess(setItemResult);
-          });
+          setItemResult = await this._localStorage.setItem(
+            parsedKey,
+            value,
+            parsedNamespace
+          );
+
+          break;
         case StorageLevel.secure:
-          return await Promise.all([
-            this._secureStorage.setItem(parsedKey, value, parsedNamespace),
-            this.setReferenceForKey(parsedKey, parsedNamespace, storageLevel),
-          ]).then(([setItemResult]) => {
-            return savingResultIsSuccess(setItemResult);
-          });
+          setItemResult = await this._secureStorage.setItem(
+            parsedKey,
+            value,
+            parsedNamespace
+          );
+
+          break;
         default:
-          return await Promise.all([
-            this._sessionStorage.setItem(parsedKey, value, parsedNamespace),
-            this.setReferenceForKey(parsedKey, parsedNamespace, storageLevel),
-          ]).then(([setItemResult]) => {
-            return savingResultIsSuccess(setItemResult);
-          });
+          setItemResult = await this._sessionStorage.setItem(
+            parsedKey,
+            value,
+            parsedNamespace
+          );
+
+          break;
       }
+
+      return savingResultIsSuccess(setItemResult);
     } catch (error) {
       // something went wrong
       this._logger.warn({
@@ -388,24 +306,6 @@ export class ContextKeysManager {
   // SET
 
   // REMOVE
-  public async removeReferenceForKey(
-    key: string,
-    namespace: string
-  ): Promise<boolean> {
-    return this._referenceStorage
-      .removeItem(buildNamespaceKey(key, namespace), REFERENCE_NAMESPACE)
-      .then(() => true)
-      .catch((error) => {
-        // something went wrong
-        this._logger.warn({
-          message: error.message,
-          data: { key, namespace },
-        });
-
-        return false;
-      });
-  }
-
   public async removeKey(key: KeyName): Promise<boolean> {
     const {
       isValid: isValidKey,
@@ -422,7 +322,6 @@ export class ContextKeysManager {
       this._sessionStorage.removeItem(parsedKey, parsedNamespace),
       this._localStorage.removeItem(parsedKey, parsedNamespace),
       this._secureStorage.removeItem(parsedKey, parsedNamespace),
-      this.removeReferenceForKey(parsedKey, parsedNamespace),
     ])
       .then(() => true)
       .catch((error) => {