@applicaster/zapp-react-native-utils 12.0.0-rc.19 → 12.0.0-rc.20

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/zapp-react-native-utils",
-  "version": "12.0.0-rc.19",
+  "version": "12.0.0-rc.20",
   "description": "Applicaster Zapp React Native utilities package",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,7 +28,7 @@
   },
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
-    "@applicaster/applicaster-types": "12.0.0-rc.19",
+    "@applicaster/applicaster-types": "12.0.0-rc.20",
     "buffer": "^5.2.1",
     "camelize": "^1.0.0",
     "create-react-context": "^0.2.3",

package/reactHooks/cell-click/__tests__/index.test.js

@@ -1,7 +1,6 @@
 import * as React from "react";
 import { cleanup, renderHook } from "@testing-library/react-hooks";
 import { CellTapContext } from "@applicaster/zapp-react-native-ui-components/Contexts/CellTapContext";
-import { waitFor } from "@testing-library/react-native";
 
 const navigator = {
   getPathname: () => "pathnameMock",
@@ -65,16 +64,12 @@ describe("useCellClick", () => {
     cleanup();
   });
 
-  it("runs onCellTap", async () => {
+  it("runs onCellTap", () => {
     const { result } = renderHook(() => useCellClick(mockProps), { wrapper });
     const useCellClickHook = result.current;
 
     useCellClickHook();
 
-    await waitFor(() => {
-      expect(onCellTap).toHaveBeenCalled();
-    });
-
     expect(onCellTap).toHaveBeenCalled();
     cleanup();
   });

package/reactHooks/cell-click/index.ts

@@ -53,7 +53,7 @@ export const useCellClick = (props: Props) => {
   );
 
   const onPress = React.useCallback(
-    async (_item?: ZappEntry | any, _index?: number) => {
+    (_item?: ZappEntry | any, _index?: number) => {
       // Making sure we are not getting GestureResponderEvent in here.
       const isZappEntry = _item?.id && _item?.type;
       const selectedItem = isZappEntry ? _item : props.item;
@@ -70,7 +70,7 @@ export const useCellClick = (props: Props) => {
       logOnPress(selectedItem, pathname, component, onCellTap);
 
       if (selectedItem) {
-        await actionExecutor?.handleEntryActions(selectedItem);
+        actionExecutor?.handleEntryActions(selectedItem);
       }
 
       if (selectedItem?.type?.value === "action") {
@@ -79,31 +79,21 @@ export const useCellClick = (props: Props) => {
             url: selectedItem.link.href,
           });
         }
-
-        return;
-      }
-
-      if (typeof onCellTap === "function") {
-        onCellTap(selectedItem, _index);
-
-        return;
-      }
-
-      const targetScreen = component?.data?.target;
-
-      if (!targetScreen) {
-        return;
-      }
-
-      const isCellOnCurrentScreen = currentRoute === pathname;
-
-      if (isCellOnCurrentScreen || pathname === "videoModal") {
-        push(
-          R.when(
-            () => targetScreen,
-            R.mergeLeft({ screen_type: targetScreen }),
-          )(selectedItem),
-        );
+      } else {
+        if (typeof onCellTap === "function") {
+          onCellTap(selectedItem, _index);
+        } else {
+          if (currentRoute === pathname || pathname === "videoModal") {
+            const targetScreen = component?.data?.target;
+
+            push(
+              R.when(
+                () => targetScreen,
+                R.mergeLeft({ screen_type: targetScreen })
+              )(selectedItem)
+            );
+          }
+        }
       }
     },
     [