@applicaster/zapp-react-native-ui-components 16.0.0-rc.66 → 16.0.0-rc.67

package/Components/MasterCell/DefaultComponents/Toggle.tsx

@@ -16,13 +16,7 @@ type Props = {
 export const Toggle = (props: Props) => {
   const { style, item, action, cellState } = props;
 
-  const {
-    trackColor,
-    trackColorActive,
-    thumbColor,
-    thumbColorActive,
-    iosBackgroundColor,
-  } = style;
+  const { trackColor, trackColorActive, thumbColor, thumbColorActive } = style;
 
   // `focused_selected` is the selected state with a finger on the row, so the
   // switch has to read as on for both. Leaving it out reads a pressed selected
@@ -73,7 +67,6 @@ export const Toggle = (props: Props) => {
     <Switch
       trackColor={{ false: trackColor, true: trackColorActive }}
       thumbColor={isSelected ? thumbColorActive : thumbColor}
-      ios_backgroundColor={iosBackgroundColor}
       onValueChange={onPress}
       value={isSelected}
     />

package/Components/MasterCell/DefaultComponents/__tests__/Toggle.test.tsx

@@ -25,7 +25,6 @@ const style = {
   trackColorActive: "rgba(4,207,153,1)",
   thumbColor: "rgba(255,255,255,1)",
   thumbColorActive: "rgba(255,255,255,1)",
-  iosBackgroundColor: "rgba(0,0,0,1)",
 } as any;
 
 const item = { id: "true", title: "I agree" } as any;
@@ -87,10 +86,6 @@ describe("Toggle with an empty action identifier", () => {
     expect(mockInitialEntryState).not.toHaveBeenCalled();
   });
 
-  // ios_backgroundColor paints behind the track, so trackColor does not cover
-  // it and it has to be forwarded on its own. It was dropped once while the
-  // destructure feeding it was being reformatted, and nothing caught that.
-  //
   // Asserted on the Switch element rather than the rendered host component:
   // what Toggle owns is the props it hands to Switch, and React Native rewrites
   // them into platform-specific ones (tintColor, a style entry) underneath.
@@ -100,9 +95,18 @@ describe("Toggle with an empty action identifier", () => {
     expect(UNSAFE_getByType(Switch).props).toMatchObject({
       trackColor: { false: style.trackColor, true: style.trackColorActive },
       thumbColor: style.thumbColor,
-      ios_backgroundColor: style.iosBackgroundColor,
     });
   });
+
+  // ios_backgroundColor paints an opaque layer behind the track that the track
+  // color cannot cover, which on iOS reads as a halo around the switch. The
+  // switch is left on its platform default instead, so the prop must stay
+  // unset even if a style happens to carry a color for it.
+  it("does not set an iOS background color on the switch", () => {
+    const { UNSAFE_getByType } = renderToggle("", "default");
+
+    expect(UNSAFE_getByType(Switch).props.ios_backgroundColor).toBeUndefined();
+  });
 });
 
 describe("Toggle with an action plugin identifier", () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/zapp-react-native-ui-components",
-  "version": "16.0.0-rc.66",
+  "version": "16.0.0-rc.67",
   "description": "Applicaster Zapp React Native ui components for the Quick Brick App",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,10 +28,10 @@
   },
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
-    "@applicaster/applicaster-types": "16.0.0-rc.66",
-    "@applicaster/zapp-react-native-bridge": "16.0.0-rc.66",
-    "@applicaster/zapp-react-native-redux": "16.0.0-rc.66",
-    "@applicaster/zapp-react-native-utils": "16.0.0-rc.66",
+    "@applicaster/applicaster-types": "16.0.0-rc.67",
+    "@applicaster/zapp-react-native-bridge": "16.0.0-rc.67",
+    "@applicaster/zapp-react-native-redux": "16.0.0-rc.67",
+    "@applicaster/zapp-react-native-utils": "16.0.0-rc.67",
     "fast-json-stable-stringify": "^2.1.0",
     "promise": "^8.3.0",
     "react-native-sortables": "1.7.1",