@applicaster/zapp-react-native-ui-components 15.0.0-rc.39 → 15.0.0-rc.40
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/Components/Cell/Cell.tsx +8 -3
- package/Components/MasterCell/DefaultComponents/BorderContainerView/__tests__/index.test.tsx +16 -1
- package/Components/MasterCell/DefaultComponents/BorderContainerView/index.tsx +36 -2
- package/Components/MasterCell/DefaultComponents/LiveImage/index.tsx +10 -6
- package/Components/MasterCell/DefaultComponents/Text/index.tsx +8 -8
- package/Components/MasterCell/index.tsx +2 -0
- package/Components/Tabs/TV/Tabs.tsx +20 -3
- package/index.d.ts +7 -0
- package/package.json +5 -5
package/Components/Cell/Cell.tsx
CHANGED
|
@@ -208,14 +208,14 @@ export class CellComponent extends React.Component<Props, State> {
|
|
|
208
208
|
this.accessibilityManager.readText({
|
|
209
209
|
text: " ",
|
|
210
210
|
});
|
|
211
|
-
} else {
|
|
211
|
+
} else if (this.state.cellFocused) {
|
|
212
212
|
this.accessibilityManager.readText({
|
|
213
213
|
text: `${positionLabel}`,
|
|
214
214
|
});
|
|
215
215
|
}
|
|
216
216
|
}
|
|
217
217
|
|
|
218
|
-
componentDidUpdate(prevProps: Readonly<Props>) {
|
|
218
|
+
componentDidUpdate(prevProps: Readonly<Props>, prevState: Readonly<State>) {
|
|
219
219
|
if (prevProps.item !== this.props.item) {
|
|
220
220
|
this.setState({
|
|
221
221
|
hasFocusableInside: this.props.CellRenderer.hasFocusableInside?.(
|
|
@@ -224,7 +224,12 @@ export class CellComponent extends React.Component<Props, State> {
|
|
|
224
224
|
});
|
|
225
225
|
}
|
|
226
226
|
|
|
227
|
-
|
|
227
|
+
if (
|
|
228
|
+
prevState.cellFocused !== this.state.cellFocused ||
|
|
229
|
+
this.state.hasFocusableInside
|
|
230
|
+
) {
|
|
231
|
+
this.handleAccessibilityFocus(this.props.index, this.props.dataLength);
|
|
232
|
+
}
|
|
228
233
|
}
|
|
229
234
|
|
|
230
235
|
render() {
|
package/Components/MasterCell/DefaultComponents/BorderContainerView/__tests__/index.test.tsx
CHANGED
|
@@ -1,8 +1,8 @@
|
|
|
1
|
+
import * as React from "react";
|
|
1
2
|
import {
|
|
2
3
|
BorderContainerView,
|
|
3
4
|
getBorderPadding, // Export for testing (using a double underscore prefix is a common convention)
|
|
4
5
|
} from "../index";
|
|
5
|
-
import * as React from "react";
|
|
6
6
|
import { render } from "@testing-library/react-native";
|
|
7
7
|
import { toNumberWithDefaultZero } from "@applicaster/zapp-react-native-utils/numberUtils";
|
|
8
8
|
import { View } from "react-native";
|
|
@@ -11,6 +11,15 @@ jest.mock("@applicaster/zapp-react-native-utils/numberUtils", () => ({
|
|
|
11
11
|
toNumberWithDefaultZero: jest.fn((value) => Number(value) || 0),
|
|
12
12
|
}));
|
|
13
13
|
|
|
14
|
+
jest.mock(
|
|
15
|
+
"@applicaster/zapp-react-native-utils/appUtils/accessibilityManager/hooks",
|
|
16
|
+
() => ({
|
|
17
|
+
useAccessibilityManager: jest.fn(() => ({
|
|
18
|
+
addHeading: jest.fn(),
|
|
19
|
+
})),
|
|
20
|
+
})
|
|
21
|
+
);
|
|
22
|
+
|
|
14
23
|
describe("BorderContainerView", () => {
|
|
15
24
|
describe("getBorderPadding", () => {
|
|
16
25
|
it("returns 0 for inside", () => {
|
|
@@ -42,6 +51,8 @@ describe("BorderContainerView", () => {
|
|
|
42
51
|
};
|
|
43
52
|
|
|
44
53
|
const borderPosition = null;
|
|
54
|
+
const mockEntry = { id: "test-entry" } as ZappEntry;
|
|
55
|
+
const mockHasFocusableInside = jest.fn(() => false);
|
|
45
56
|
|
|
46
57
|
const { queryByTestId } = render(
|
|
47
58
|
<BorderContainerView
|
|
@@ -52,6 +63,10 @@ describe("BorderContainerView", () => {
|
|
|
52
63
|
borderPaddingRight={toNumberWithDefaultZero(padding.paddingRight)}
|
|
53
64
|
borderPaddingBottom={toNumberWithDefaultZero(padding.paddingBottom)}
|
|
54
65
|
borderPaddingLeft={toNumberWithDefaultZero(padding.paddingLeft)}
|
|
66
|
+
hasFocusableInside={mockHasFocusableInside}
|
|
67
|
+
entry={mockEntry}
|
|
68
|
+
state="focused"
|
|
69
|
+
hasTextLabels={false}
|
|
55
70
|
>
|
|
56
71
|
<View testID="child" />
|
|
57
72
|
</BorderContainerView>
|
|
@@ -1,10 +1,16 @@
|
|
|
1
|
-
import {
|
|
2
|
-
import * as React from "react";
|
|
1
|
+
import React, { useMemo, useContext, useEffect } from "react";
|
|
3
2
|
import { ImageStyle, StyleSheet, View, ViewStyle } from "react-native";
|
|
3
|
+
import { useAccessibilityManager } from "@applicaster/zapp-react-native-utils/appUtils/accessibilityManager/hooks";
|
|
4
|
+
import { toNumberWithDefaultZero } from "@applicaster/zapp-react-native-utils/numberUtils";
|
|
5
|
+
import { MeasurementPortalContext } from "../../../MeasurmentsPortal/MeasurementsPortal";
|
|
4
6
|
|
|
5
7
|
type BorderPosition = "inside" | "outside" | "center";
|
|
6
8
|
|
|
7
9
|
interface Props {
|
|
10
|
+
hasFocusableInside: (entry: ZappEntry) => boolean;
|
|
11
|
+
entry: ZappEntry;
|
|
12
|
+
state: CellState;
|
|
13
|
+
hasTextLabels: boolean;
|
|
8
14
|
style: ImageStyle | ViewStyle;
|
|
9
15
|
borderPosition: BorderPosition;
|
|
10
16
|
borderPaddingTop: number;
|
|
@@ -118,8 +124,36 @@ export const BorderContainerView = (props: Props) => {
|
|
|
118
124
|
borderPaddingLeft,
|
|
119
125
|
style,
|
|
120
126
|
children,
|
|
127
|
+
hasFocusableInside,
|
|
128
|
+
entry,
|
|
129
|
+
state,
|
|
130
|
+
hasTextLabels,
|
|
121
131
|
} = props;
|
|
122
132
|
|
|
133
|
+
const accessibilityManager = useAccessibilityManager();
|
|
134
|
+
const isMeasurement = useContext(MeasurementPortalContext);
|
|
135
|
+
|
|
136
|
+
const isImageOnlyCell = useMemo(
|
|
137
|
+
() =>
|
|
138
|
+
!hasFocusableInside(entry) &&
|
|
139
|
+
!hasTextLabels &&
|
|
140
|
+
state === "focused" &&
|
|
141
|
+
!isMeasurement?.measuringInProgress,
|
|
142
|
+
[
|
|
143
|
+
hasFocusableInside,
|
|
144
|
+
entry,
|
|
145
|
+
hasTextLabels,
|
|
146
|
+
state,
|
|
147
|
+
isMeasurement?.measuringInProgress,
|
|
148
|
+
]
|
|
149
|
+
);
|
|
150
|
+
|
|
151
|
+
useEffect(() => {
|
|
152
|
+
if (isImageOnlyCell && entry?.title) {
|
|
153
|
+
accessibilityManager.addHeading(String(entry.title));
|
|
154
|
+
}
|
|
155
|
+
}, [isImageOnlyCell, entry?.title]);
|
|
156
|
+
|
|
123
157
|
const padding =
|
|
124
158
|
borderPosition === "outside"
|
|
125
159
|
? {
|
|
@@ -9,6 +9,7 @@ import { useTrackCurrentAutoScrollingElement } from "@applicaster/zapp-react-nat
|
|
|
9
9
|
import { useUIComponentContext } from "@applicaster/zapp-react-native-ui-components/Contexts/UIComponentContext";
|
|
10
10
|
import { getPropComponentType } from "@applicaster/zapp-react-native-utils/cellUtils";
|
|
11
11
|
import { findPluginByIdentifier } from "@applicaster/zapp-react-native-utils/pluginUtils";
|
|
12
|
+
import { useAccessibilityState } from "@applicaster/zapp-react-native-utils/appUtils/accessibilityManager/hooks";
|
|
12
13
|
|
|
13
14
|
type LiveImageProps = {
|
|
14
15
|
item: ZappEntry;
|
|
@@ -108,8 +109,7 @@ const prepareEntry = (entry) => {
|
|
|
108
109
|
};
|
|
109
110
|
}
|
|
110
111
|
|
|
111
|
-
const previewPlayback =
|
|
112
|
-
entry.extensions?.["brightcove"]?.["preview_playback"];
|
|
112
|
+
const previewPlayback = entry.extensions?.brightcove?.preview_playback;
|
|
113
113
|
|
|
114
114
|
if (previewPlayback) {
|
|
115
115
|
return {
|
|
@@ -117,14 +117,14 @@ const prepareEntry = (entry) => {
|
|
|
117
117
|
extensions: {
|
|
118
118
|
...entry.extensions,
|
|
119
119
|
brightcove: {
|
|
120
|
-
...entry?.extensions?.
|
|
120
|
+
...entry?.extensions?.brightcove,
|
|
121
121
|
video_id: previewPlayback,
|
|
122
122
|
},
|
|
123
123
|
},
|
|
124
124
|
};
|
|
125
125
|
}
|
|
126
126
|
|
|
127
|
-
if (entry.extensions?.
|
|
127
|
+
if (entry.extensions?.brightcove?.video_id) {
|
|
128
128
|
return entry;
|
|
129
129
|
}
|
|
130
130
|
|
|
@@ -174,7 +174,7 @@ const getPlayerConfig = (player_screen_id, actionIdentifier) => {
|
|
|
174
174
|
// TODO: Add more dict if needed from the screen component, styles, data etc
|
|
175
175
|
return {
|
|
176
176
|
playerPluginId: playerScreen?.type ?? DEFAULT_PLAYER_IDENTIFIER,
|
|
177
|
-
screenConfig: playerScreen?.
|
|
177
|
+
screenConfig: playerScreen?.general,
|
|
178
178
|
};
|
|
179
179
|
}
|
|
180
180
|
|
|
@@ -206,6 +206,9 @@ const LiveImageComponent = (props: LiveImageProps) => {
|
|
|
206
206
|
state,
|
|
207
207
|
} = props;
|
|
208
208
|
|
|
209
|
+
const accessibilityState = useAccessibilityState({});
|
|
210
|
+
const isScreenReaderEnabled = accessibilityState.screenReaderEnabled;
|
|
211
|
+
|
|
209
212
|
const component = useUIComponentContext();
|
|
210
213
|
|
|
211
214
|
// Fix for blinking on state change
|
|
@@ -239,7 +242,8 @@ const LiveImageComponent = (props: LiveImageProps) => {
|
|
|
239
242
|
getFocusedState(state, componentType, isCurrentlyFocused) &&
|
|
240
243
|
playableEntry &&
|
|
241
244
|
cellUUID &&
|
|
242
|
-
isSupportedTVForLiveImage()
|
|
245
|
+
isSupportedTVForLiveImage() &&
|
|
246
|
+
!isScreenReaderEnabled;
|
|
243
247
|
|
|
244
248
|
return (
|
|
245
249
|
<>
|
|
@@ -52,14 +52,14 @@ const _Text = ({
|
|
|
52
52
|
: textTransform(transformText, _label);
|
|
53
53
|
|
|
54
54
|
React.useLayoutEffect(() => {
|
|
55
|
-
|
|
56
|
-
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|
|
61
|
-
|
|
62
|
-
|
|
55
|
+
if (cellFocused) {
|
|
56
|
+
switch (otherProps.state) {
|
|
57
|
+
case "focused":
|
|
58
|
+
accessibilityManager.addHeading(textLabel);
|
|
59
|
+
break;
|
|
60
|
+
case "focused_selected":
|
|
61
|
+
accessibilityManager.addHeading(`${textLabel}, Selected`);
|
|
62
|
+
break;
|
|
63
63
|
}
|
|
64
64
|
}
|
|
65
65
|
}, [cellFocused, otherProps.state, textLabel]);
|
|
@@ -8,6 +8,7 @@ import { isEmptyOrNil } from "@applicaster/zapp-react-native-utils/cellUtils";
|
|
|
8
8
|
import { focusManager } from "@applicaster/zapp-react-native-utils/appUtils/focusManager";
|
|
9
9
|
import { FocusableGroup } from "@applicaster/zapp-react-native-ui-components/Components/FocusableGroup";
|
|
10
10
|
import { Focusable } from "@applicaster/zapp-react-native-ui-components/Components/Focusable";
|
|
11
|
+
import { useAccessibilityManager } from "@applicaster/zapp-react-native-utils/appUtils/accessibilityManager/hooks";
|
|
11
12
|
import { Gutter } from "../Gutter";
|
|
12
13
|
import Tab from "./Tab";
|
|
13
14
|
import { getStyles } from "./styles";
|
|
@@ -28,11 +29,14 @@ const TabsComponent = ({
|
|
|
28
29
|
style,
|
|
29
30
|
selectedEntryIndex,
|
|
30
31
|
setSelectedEntry,
|
|
32
|
+
accessibility,
|
|
31
33
|
}: TabsProps & Partial<TabsSelectionContextType>) => {
|
|
32
34
|
const configuration = useConfiguration();
|
|
33
35
|
const config = applyFontConfig(configuration);
|
|
34
36
|
const styles = useMemo(() => getStyles(config), [config]);
|
|
35
37
|
|
|
38
|
+
const accessibilityManager = useAccessibilityManager({});
|
|
39
|
+
|
|
36
40
|
const {
|
|
37
41
|
tab_bar_gutter: horizontalGutter,
|
|
38
42
|
tab_bar_background_image: bgImage,
|
|
@@ -60,10 +64,20 @@ const TabsComponent = ({
|
|
|
60
64
|
);
|
|
61
65
|
|
|
62
66
|
const onListElementFocus = useCallback(
|
|
63
|
-
(index) => {
|
|
67
|
+
(index, isSelected: boolean, item: ZappEntry) => {
|
|
68
|
+
if (isSelected) {
|
|
69
|
+
accessibilityManager.readText({
|
|
70
|
+
text: `${accessibility?.selectedHint} ${item.title}`,
|
|
71
|
+
});
|
|
72
|
+
} else {
|
|
73
|
+
accessibilityManager.readText({
|
|
74
|
+
text: `${accessibility?.hint} ${item.title}`,
|
|
75
|
+
});
|
|
76
|
+
}
|
|
77
|
+
|
|
64
78
|
scrollToSelectedIndex(index, VIEW_POSITION);
|
|
65
79
|
},
|
|
66
|
-
[scrollToSelectedIndex]
|
|
80
|
+
[scrollToSelectedIndex, accessibility]
|
|
67
81
|
);
|
|
68
82
|
|
|
69
83
|
const renderItem = useCallback(
|
|
@@ -94,7 +108,7 @@ const TabsComponent = ({
|
|
|
94
108
|
id={itemId}
|
|
95
109
|
testID={itemId}
|
|
96
110
|
preferredFocus={isSelected}
|
|
97
|
-
onFocus={() => onListElementFocus(index)}
|
|
111
|
+
onFocus={() => onListElementFocus(index, isSelected, item)}
|
|
98
112
|
onPress={() => setSelectedEntry && setSelectedEntry(item)}
|
|
99
113
|
style={style}
|
|
100
114
|
>
|
|
@@ -149,6 +163,9 @@ const TabsComponent = ({
|
|
|
149
163
|
shouldUsePreferredFocus
|
|
150
164
|
isWithMemory={false}
|
|
151
165
|
nextFocusDown={parentFocus?.nextFocusDown}
|
|
166
|
+
onFocus={() => {
|
|
167
|
+
accessibilityManager.addHeading(accessibility?.announcement);
|
|
168
|
+
}}
|
|
152
169
|
>
|
|
153
170
|
<View style={tabs}>
|
|
154
171
|
<ImageBackground
|
package/index.d.ts
CHANGED
|
@@ -228,6 +228,12 @@ declare type TabsSelectionContextType = {
|
|
|
228
228
|
selectedEntryIndex: number;
|
|
229
229
|
};
|
|
230
230
|
|
|
231
|
+
declare type TabsAccessibility = {
|
|
232
|
+
announcement?: string;
|
|
233
|
+
selectedHint?: string;
|
|
234
|
+
hint?: string;
|
|
235
|
+
};
|
|
236
|
+
|
|
231
237
|
declare type TabsProps = {
|
|
232
238
|
entry: ZappEntry[];
|
|
233
239
|
groupId: string;
|
|
@@ -235,6 +241,7 @@ declare type TabsProps = {
|
|
|
235
241
|
focused?: boolean;
|
|
236
242
|
parentFocus?: ParentFocus;
|
|
237
243
|
style?: ReactViewStyle;
|
|
244
|
+
accessibility?: TabsAccessibility;
|
|
238
245
|
};
|
|
239
246
|
|
|
240
247
|
declare type TabContentProps = {
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@applicaster/zapp-react-native-ui-components",
|
|
3
|
-
"version": "15.0.0-rc.
|
|
3
|
+
"version": "15.0.0-rc.40",
|
|
4
4
|
"description": "Applicaster Zapp React Native ui components for the Quick Brick App",
|
|
5
5
|
"main": "index.js",
|
|
6
6
|
"types": "index.d.ts",
|
|
@@ -28,10 +28,10 @@
|
|
|
28
28
|
},
|
|
29
29
|
"homepage": "https://github.com/applicaster/quickbrick#readme",
|
|
30
30
|
"dependencies": {
|
|
31
|
-
"@applicaster/applicaster-types": "15.0.0-rc.
|
|
32
|
-
"@applicaster/zapp-react-native-bridge": "15.0.0-rc.
|
|
33
|
-
"@applicaster/zapp-react-native-redux": "15.0.0-rc.
|
|
34
|
-
"@applicaster/zapp-react-native-utils": "15.0.0-rc.
|
|
31
|
+
"@applicaster/applicaster-types": "15.0.0-rc.40",
|
|
32
|
+
"@applicaster/zapp-react-native-bridge": "15.0.0-rc.40",
|
|
33
|
+
"@applicaster/zapp-react-native-redux": "15.0.0-rc.40",
|
|
34
|
+
"@applicaster/zapp-react-native-utils": "15.0.0-rc.40",
|
|
35
35
|
"promise": "^8.3.0",
|
|
36
36
|
"url": "^0.11.0",
|
|
37
37
|
"uuid": "^3.3.2"
|