@applicaster/zapp-react-native-ui-components 14.0.19-rc.0 → 14.0.19

package/Components/River/RiverItem.tsx

@@ -13,6 +13,7 @@ import { riverLogger } from "./logger";
 import { tvPluginsWithCellRenderer } from "../../const";
 import { isTV } from "@applicaster/zapp-react-native-utils/reactUtils";
 import type { BehaviorSubject } from "rxjs";
+import { isNilOrEmpty } from "@applicaster/zapp-react-native-utils/reactUtils/helpers";
 
 export type RiverItemType = {
   item: ZappUIComponent;
@@ -110,33 +111,38 @@ function RiverItemComponent(props: RiverItemType) {
     CellRenderer = undefined;
   }
 
-  React.useEffect(() => {
-    riverLogger.log({
-      message: "mounting component",
-      data: { item, feedUrl, Component, CellRenderer },
-      jsOnly: true,
-    });
+  const isComponentMissing = isNilOrEmpty(Component);
 
-    if (!CellRenderer && !isGroup(item)) {
+  /**
+   * TODO: Move this plugin existence check further up the stack (before ComponentsMap).
+   * Filtering items at the list-rendering or data-processing level would prevent
+   * mounting RiverItem entirely for missing components.
+   */
+  React.useEffect(() => {
+    if (isComponentMissing) {
       riverLogger.warning({
-        message: "Cell Renderer is null - will fallback to default cell",
-        data: { item, CellRenderer },
+        message: `Component ${item.component_type} is null - skipping rendering`,
+      });
+
+      onLoadFinished(index);
+    } else {
+      riverLogger.log({
+        message: "mounting component",
+        data: { item, feedUrl, Component, CellRenderer },
         jsOnly: true,
       });
+
+      if (!CellRenderer && !isGroup(item)) {
+        riverLogger.warning({
+          message: "Cell Renderer is null - will fallback to default cell",
+          data: { item, CellRenderer },
+          jsOnly: true,
+        });
+      }
     }
   }, []);
 
-  if (!readyToBeDisplayed) {
-    return null;
-  }
-
-  if (Component === null || typeof Component === "undefined") {
-    riverLogger.warning({
-      message: `Component ${item.component_type} is null - skipping rendering`,
-    });
-
-    onLoadFinished(index);
-
+  if (!readyToBeDisplayed || isComponentMissing) {
     return null;
   }
 

package/Components/ZappUIComponent/index.tsx

@@ -144,12 +144,23 @@ New signature: {Component, ErrorComponent, LoadingComponent, options}`
       [props, parent]
     );
 
+    const hasError = !!zappPipesData?.error;
+
     React.useEffect(() => {
       if (!skipOnLoadFinished && !isLoading) {
         onLoadFinished();
       }
     }, [isLoading]);
 
+    React.useEffect(() => {
+      if (hasError) {
+        onLoadFailed?.({
+          error: zappPipesData.error,
+          index: componentIndex,
+        });
+      }
+    }, [hasError, componentIndex, onLoadFailed, zappPipesData?.error]);
+
     if (isDataSourceEmpty(props) && allowsEmptyDataSource) {
       return RenderComponent(Component, componentProps);
     }
@@ -158,12 +169,7 @@ New signature: {Component, ErrorComponent, LoadingComponent, options}`
       return RenderComponent(LoadingComponent || Placeholder, componentProps);
     }
 
-    if (zappPipesData?.error) {
-      onLoadFailed?.({
-        error: zappPipesData.error,
-        index: componentIndex,
-      });
-
+    if (hasError) {
       return RenderComponent(ErrorComponent, componentProps);
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/zapp-react-native-ui-components",
-  "version": "14.0.19-rc.0",
+  "version": "14.0.19",
   "description": "Applicaster Zapp React Native ui components for the Quick Brick App",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,10 +28,10 @@
   },
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
-    "@applicaster/applicaster-types": "14.0.19-rc.0",
-    "@applicaster/zapp-react-native-bridge": "14.0.19-rc.0",
-    "@applicaster/zapp-react-native-redux": "14.0.19-rc.0",
-    "@applicaster/zapp-react-native-utils": "14.0.19-rc.0",
+    "@applicaster/applicaster-types": "14.0.19",
+    "@applicaster/zapp-react-native-bridge": "14.0.19",
+    "@applicaster/zapp-react-native-redux": "14.0.19",
+    "@applicaster/zapp-react-native-utils": "14.0.19",
     "fast-json-stable-stringify": "^2.1.0",
     "promise": "^8.3.0",
     "url": "^0.11.0",