@applicaster/zapp-react-native-ui-components 12.0.4-alpha.7284824515 → 12.0.4-rc.0

package/Components/VideoLive/PlayerLiveImageComponent.tsx

@@ -244,27 +244,25 @@ const PlayerLiveImageComponent = (props: Props) => {
   }, [item.id]);
 
   React.useEffect(() => {
-    if (isMeasurement(item) || !playerManager) {
-      return;
-    }
-
-    const isPlayerRegistered = playerManager.isPlayerRegistered(playerId);
+    if (playerManager) {
+      const isPlayerRegistered = playerManager.isPlayerRegistered(playerId);
 
-    if (isPlayerRegistered) {
-      log_error(
-        `PlayerLiveImageComponent: player ${playerId} already registered`
-      );
-    } else {
-      playerManager.registerPlayer({
-        id: playerId,
-        playerController: controller,
-      });
+      if (isPlayerRegistered) {
+        log_error(
+          `PlayerLiveImageComponent: player ${playerId} already registered`
+        );
+      } else {
+        playerManager.registerPlayer({
+          id: playerId,
+          playerController: controller,
+        });
 
-      return () => {
-        playerManager.unregisterPlayer(playerId);
-      };
+        return () => {
+          playerManager.unregisterPlayer(playerId);
+        };
+      }
     }
-  }, [liveImageItem, playerId, controller, item.id]);
+  }, [liveImageItem, playerId, controller]);
 
   const onPositionUpdated = React.useCallback(
     (data) => {

package/Components/VideoLive/__tests__/PlayerLiveImageComponent.test.tsx

@@ -5,7 +5,6 @@ import * as PlayerFactory from "@applicaster/zapp-react-native-utils/appUtils/pl
 import { Player } from "@applicaster/zapp-react-native-utils/appUtils/playerManager/player";
 import { ThemeContext } from "@applicaster/zapp-react-native-utils/theme";
 import * as navigationHooks from "@applicaster/zapp-react-native-utils/reactHooks/navigation";
-import { playerManager } from "@applicaster/zapp-react-native-utils/appUtils/playerManager";
 
 import { PlayerLiveImage } from "../PlayerLiveImageComponent";
 import * as useNavigationHooks from "@applicaster/zapp-react-native-utils/reactHooks/navigation/useNavigation";
@@ -34,7 +33,7 @@ const mockStore = configureStore();
 
 const store = mockStore({ appData: {} });
 
-const Wrapper = ({ children }: { children: React.ReactNode }) => (
+const Wrapper = ({ children }: { children: React.ReactChildren }) => (
   /* @ts-ignore */
   <Provider store={store}>
     <ThemeContext.Provider
@@ -114,53 +113,4 @@ describe("PlayerLiveImageComponent", () => {
 
     // TODO: implement this test
   });
-
-  it("should register the player for normal item", () => {
-    render(
-      <Wrapper>
-        <PlayerLiveImage {...defaultProps} />
-      </Wrapper>
-    );
-
-    const isPlayerRegistered = playerManager.isPlayerRegistered(
-      defaultProps.playerId
-    );
-
-    expect(isPlayerRegistered).toBe(true);
-  });
-
-  it("should unregister the player for normal item", () => {
-    const component = render(
-      <Wrapper>
-        <PlayerLiveImage {...defaultProps} />
-      </Wrapper>
-    );
-
-    component.unmount();
-
-    const isPlayerRegistered = playerManager.isPlayerRegistered(
-      defaultProps.playerId
-    );
-
-    expect(isPlayerRegistered).toBe(false);
-  });
-
-  it("should not register the player for 'pre-measurement' item", () => {
-    const props = {
-      ...defaultProps,
-      item: {
-        ...defaultProps.item,
-        id: "pre-measurement-1",
-      },
-    };
-
-    render(
-      <Wrapper>
-        <PlayerLiveImage {...props} />
-      </Wrapper>
-    );
-
-    const isPlayerRegistered = playerManager.isPlayerRegistered(props.playerId);
-    expect(isPlayerRegistered).toBe(false);
-  });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/zapp-react-native-ui-components",
-  "version": "12.0.4-alpha.7284824515",
+  "version": "12.0.4-rc.0",
   "description": "Applicaster Zapp React Native ui components for the Quick Brick App",
   "main": "index.js",
   "types": "index.d.ts",
@@ -34,10 +34,10 @@
     "redux-mock-store": "^1.5.3"
   },
   "dependencies": {
-    "@applicaster/applicaster-types": "12.0.4-alpha.7284824515",
-    "@applicaster/zapp-react-native-bridge": "12.0.4-alpha.7284824515",
-    "@applicaster/zapp-react-native-redux": "12.0.4-alpha.7284824515",
-    "@applicaster/zapp-react-native-utils": "12.0.4-alpha.7284824515",
+    "@applicaster/applicaster-types": "12.0.4-rc.0",
+    "@applicaster/zapp-react-native-bridge": "12.0.4-rc.0",
+    "@applicaster/zapp-react-native-redux": "12.0.4-rc.0",
+    "@applicaster/zapp-react-native-utils": "12.0.4-rc.0",
     "promise": "^8.3.0",
     "react-router-native": "^5.1.2",
     "url": "^0.11.0",