@applicaster/zapp-react-native-bridge 16.0.0-rc.47 → 16.0.0-rc.49

package/ZappStorage/LocalStorage/index.ts

@@ -7,6 +7,8 @@ import {
   getItemError,
   setItemError,
   removeItemError,
+  throwUndefinedKeyError,
+  throwUndefinedValueError,
 } from "../errors";
 
 import { Storage, stringifyIfNeeded } from "../Storage";
@@ -14,6 +16,11 @@ import { platformSelect } from "@applicaster/zapp-react-native-utils/reactUtils"
 
 const storage = "LocalStorage";
 
+const UNDEFINED_KEY_MESSAGE = "Requested key is null or undefined";
+
+const UNDEFINED_VALUE_MESSAGE =
+  "Value to set in storage cannot be null or undefined";
+
 function getDefaultLocalStorage<T = NativeLocalStorageI>(): T {
   const { LocalStorage } = NativeModules as NativeModulesStatic & {
     LocalStorage: T;
@@ -80,6 +87,12 @@ class LocalStorageModule extends Storage {
   }
 
   async setKeychainItem(key, value, namespace = DEFAULT_NAMESPACE) {
+    if (!key) throwUndefinedKeyError(storage, UNDEFINED_KEY_MESSAGE);
+
+    if (typeof value === "undefined" || value === null) {
+      throwUndefinedValueError(storage, UNDEFINED_VALUE_MESSAGE, key);
+    }
+
     try {
       const result = await LocalStorage.setKeychainItem(
         key,

package/ZappStorage/__mocks__/storageMock.ts

@@ -70,6 +70,11 @@ export class SecureStorageMock extends StorageMock {
     this.securedItems = new Map();
   }
 
+  __clear() {
+    super.__clear();
+    this.securedItems = new Map();
+  }
+
   async getKeychainItem(key, namespace = DEFAULT_NAMESPACE) {
     if (key.includes("fail")) throw new Error("failed to get secure item");
 

package/ZappStorage/__tests__/__snapshots__/localStorage.test.ts.snap

@@ -23,3 +23,13 @@ exports[`localStorage setItem throws if there is an error in the native module 1
 exports[`localStorage setItem throws if value is null 1`] = `"Value to set in storage cannot be null or undefined"`;
 
 exports[`localStorage setItem throws if value is undefined 1`] = `"Value to set in storage cannot be null or undefined"`;
+
+exports[`localStorage setKeychainItem throws if key is null 1`] = `"Requested key is null or undefined"`;
+
+exports[`localStorage setKeychainItem throws if key is undefined 1`] = `"Requested key is null or undefined"`;
+
+exports[`localStorage setKeychainItem throws if there is an error in the native module 1`] = `"An error occured while setting an item in native secure  storage: failed to set secure item"`;
+
+exports[`localStorage setKeychainItem throws if value is null 1`] = `"Value to set in storage cannot be null or undefined"`;
+
+exports[`localStorage setKeychainItem throws if value is undefined 1`] = `"Value to set in storage cannot be null or undefined"`;

package/ZappStorage/__tests__/localStorage.test.ts

@@ -262,6 +262,104 @@ describe("localStorage", () => {
     });
   });
 
+  describe("setKeychainItem", () => {
+    beforeEach(async () => {
+      NativeLocalStorage.__clear();
+    });
+
+    it("sets an item in secure storage", async () => {
+      const key = "test_key";
+      const value = "test_value";
+      const result = await localStorage.setKeychainItem(key, value);
+
+      expect(result).toBe(true);
+
+      expect(
+        NativeLocalStorage.securedItems.get(DEFAULT_NAMESPACE).get(key)
+      ).toEqual(value);
+    });
+
+    it("works as a bound method", async () => {
+      const key = "test_key";
+      const value = "test_value";
+      const setKeychainItem = localStorage.setKeychainItem;
+      const result = await setKeychainItem(key, value);
+
+      expect(result).toBe(true);
+
+      expect(
+        NativeLocalStorage.securedItems.get(DEFAULT_NAMESPACE).get(key)
+      ).toEqual(value);
+    });
+
+    it("stringifies the value if its not a string", async () => {
+      const key = "test_key";
+      const value = { objVal: "test_value" };
+
+      const result = await localStorage.setKeychainItem(key, value);
+
+      expect(result).toBe(true);
+
+      expect(
+        NativeLocalStorage.securedItems.get(DEFAULT_NAMESPACE).get(key)
+      ).toEqual(JSON.stringify(value));
+    });
+
+    it("sets a value in a specific namespace", async () => {
+      const key = "test_key";
+      const value = "test_value";
+      const namespace = "test_namespace";
+      const result = await localStorage.setKeychainItem(key, value, namespace);
+
+      expect(result).toBe(true);
+
+      expect(NativeLocalStorage.securedItems.get(namespace).get(key)).toEqual(
+        value
+      );
+    });
+
+    it("throws if key is null", async () => {
+      const value = "test_value";
+
+      expect(() =>
+        localStorage.setKeychainItem(null, value)
+      ).rejects.toThrowErrorMatchingSnapshot();
+    });
+
+    it("throws if key is undefined", async () => {
+      const value = "test_value";
+
+      expect(() =>
+        localStorage.setKeychainItem(undefined, value)
+      ).rejects.toThrowErrorMatchingSnapshot();
+    });
+
+    it("throws if value is null", async () => {
+      const key = "test_key";
+
+      expect(() =>
+        localStorage.setKeychainItem(key, null)
+      ).rejects.toThrowErrorMatchingSnapshot();
+    });
+
+    it("throws if value is undefined", async () => {
+      const key = "test_key";
+
+      expect(() =>
+        localStorage.setKeychainItem(key, undefined)
+      ).rejects.toThrowErrorMatchingSnapshot();
+    });
+
+    it("throws if there is an error in the native module", async () => {
+      const key = "fail";
+      const value = "value";
+
+      expect(() =>
+        localStorage.setKeychainItem(key, value)
+      ).rejects.toThrowErrorMatchingSnapshot();
+    });
+  });
+
   describe("getItem", () => {
     beforeAll(setUpStorage);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/zapp-react-native-bridge",
-  "version": "16.0.0-rc.47",
+  "version": "16.0.0-rc.49",
   "description": "Applicaster Zapp React Native modules",
   "main": "index.js",
   "types": "index.d.ts",
@@ -32,7 +32,7 @@
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
     "@applicaster/zapp-pipes-dev-kit": "1.4.7",
-    "@applicaster/zapp-react-native-utils": "16.0.0-rc.47",
+    "@applicaster/zapp-react-native-utils": "16.0.0-rc.49",
     "md5": "^2.3.0",
     "uuid": "^3.3.2"
   },