@applicaster/quick-brick-core 16.0.0-rc.53 → 16.0.0-rc.54

package/App/NotificationToastRenderer/NotificationToastManager.ts

@@ -24,11 +24,13 @@ export interface ToastStyle {
   letterSpacing?: number;
 }
 
+export const DEFAULT_TOAST_TIMEOUT = 4000;
+
 export interface ToastPayload {
   id?: string;
   message: string;
   extraMessage?: string; // secondary line; TV renderers show it as a subtitle, mobile ignores it
-  timeout?: number; // ms; if omitted, toast stays until dismissed
+  timeout?: number; // ms; defaults to DEFAULT_TOAST_TIMEOUT (4000) if omitted
   style?: ToastStyle;
   [key: string]: unknown;
 }
@@ -122,7 +124,11 @@ class NotificationToastManager {
   };
 
   private handleShowToast = (payload: ToastPayload) => {
-    const item = { ...payload, id: payload.id ?? String(this.nextId++) };
+    const item = {
+      ...payload,
+      id: payload.id ?? String(this.nextId++),
+      timeout: payload.timeout ?? DEFAULT_TOAST_TIMEOUT,
+    };
 
     const queuedIndex = this.queue.findIndex((queued) => queued.id === item.id);
 

package/App/NotificationToastRenderer/__tests__/NotificationToastManager.test.ts

@@ -1,6 +1,7 @@
 import {
   notificationToastManager,
   NOTIFICATION_TOAST_EVENTS,
+  DEFAULT_TOAST_TIMEOUT,
 } from "../NotificationToastManager";
 import { postEvent } from "@applicaster/zapp-react-native-utils/reactHooks/useSubscriberFor";
 
@@ -210,4 +211,27 @@ describe("NotificationToastManager", () => {
 
     expect(onShow).not.toHaveBeenCalled();
   });
+
+  it("defaults timeout to DEFAULT_TOAST_TIMEOUT (4000ms) when omitted and auto-hides", () => {
+    const onShow = jest.fn();
+    const onHide = jest.fn();
+    on(NOTIFICATION_TOAST_EVENTS.SHOW, onShow);
+    on(NOTIFICATION_TOAST_EVENTS.HIDE, onHide);
+
+    notificationToastManager.showToast({
+      message: "Added to queue",
+    });
+
+    expect(onShow).toHaveBeenCalledWith(
+      expect.objectContaining({
+        message: "Added to queue",
+        timeout: DEFAULT_TOAST_TIMEOUT,
+      }),
+      expect.any(Function)
+    );
+
+    jest.advanceTimersByTime(DEFAULT_TOAST_TIMEOUT);
+
+    expect(onHide).toHaveBeenCalledTimes(1);
+  });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/quick-brick-core",
-  "version": "16.0.0-rc.53",
+  "version": "16.0.0-rc.54",
   "description": "Core package for Applicaster's Quick Brick App",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,13 +28,13 @@
   },
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
-    "@applicaster/applicaster-types": "16.0.0-rc.53",
-    "@applicaster/quick-brick-core-plugins": "16.0.0-rc.53",
-    "@applicaster/zapp-pipes-v2-client": "16.0.0-rc.53",
-    "@applicaster/zapp-react-native-bridge": "16.0.0-rc.53",
-    "@applicaster/zapp-react-native-redux": "16.0.0-rc.53",
-    "@applicaster/zapp-react-native-ui-components": "16.0.0-rc.53",
-    "@applicaster/zapp-react-native-utils": "16.0.0-rc.53",
+    "@applicaster/applicaster-types": "16.0.0-rc.54",
+    "@applicaster/quick-brick-core-plugins": "16.0.0-rc.54",
+    "@applicaster/zapp-pipes-v2-client": "16.0.0-rc.54",
+    "@applicaster/zapp-react-native-bridge": "16.0.0-rc.54",
+    "@applicaster/zapp-react-native-redux": "16.0.0-rc.54",
+    "@applicaster/zapp-react-native-ui-components": "16.0.0-rc.54",
+    "@applicaster/zapp-react-native-utils": "16.0.0-rc.54",
     "atob": "^2.1.2",
     "axios": "^0.28.0",
     "btoa": "^1.2.1",