@applicaster/quick-brick-core 15.1.4-alpha.3111505113 → 15.1.4-alpha.5560334611

package/App/ActionSetters/index.ts

@@ -20,10 +20,6 @@ const warnUndefinedContext = (context) =>
     data: { context },
   });
 
-type Subscription = {
-  [x: string]: () => any;
-};
-
 const getModuleContext = R.path(["module", "context"]);
 
 const getContexts = R.compose(
@@ -63,24 +59,39 @@ const useSubscribeToActionProviders = () => {
 export const useRiverInitialState = () => {
   const key = "getRiverInitialState";
   const actionProvidersSubscriptions = useSubscribeToActionProviders();
+  // Capture river-init promises once. Re-calling getRiverInitialState() on every
+  // context re-render causes thrash and can drop already-completed observables.
+  // Plugins should return Promise.resolve() when already initialized (not undefined).
+  const capturedPromisesRef = React.useRef<Promise<unknown>[] | null>(null);
+
+  if (
+    capturedPromisesRef.current === null &&
+    actionProvidersSubscriptions.length > 0
+  ) {
+    const providersWithMethod = actionProvidersSubscriptions.filter(
+      (item) => item?.[key]
+    );
+    const promises = providersWithMethod
+      .map((item) => item[key]())
+      .filter(Boolean) as Promise<unknown>[];
+
+    // Lock when every river-init provider returned a promise, or none expose it.
+    // Retry while a provider still returns undefined (getInitialState not started).
+    if (
+      providersWithMethod.length === 0 ||
+      promises.length === providersWithMethod.length
+    ) {
+      capturedPromisesRef.current = promises;
+    }
+  }
 
-  const subscriptions = React.useMemo(() => {
-    if (!actionProvidersSubscriptions.length) return undefined;
-
-    return actionProvidersSubscriptions.reduce((acc, item) => {
-      const riverInitialStatePromise = item[key]?.();
-
-      if (riverInitialStatePromise) {
-        acc.push(riverInitialStatePromise);
-      }
-
-      return acc;
-    }, [] as Subscription[]);
-  }, [actionProvidersSubscriptions]);
+  if (!actionProvidersSubscriptions.length) {
+    return undefined;
+  }
 
-  if (!actionProvidersSubscriptions.length) return undefined;
-
-  return subscriptions;
+  return capturedPromisesRef.current === null
+    ? undefined
+    : capturedPromisesRef.current;
 };
 
 const getActionInitialStateSetters = (key) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/quick-brick-core",
-  "version": "15.1.4-alpha.3111505113",
+  "version": "15.1.4-alpha.5560334611",
   "description": "Core package for Applicaster's Quick Brick App",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,13 +28,13 @@
   },
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
-    "@applicaster/applicaster-types": "15.1.4-alpha.3111505113",
-    "@applicaster/quick-brick-core-plugins": "15.1.4-alpha.3111505113",
-    "@applicaster/zapp-pipes-v2-client": "15.1.4-alpha.3111505113",
-    "@applicaster/zapp-react-native-bridge": "15.1.4-alpha.3111505113",
-    "@applicaster/zapp-react-native-redux": "15.1.4-alpha.3111505113",
-    "@applicaster/zapp-react-native-ui-components": "15.1.4-alpha.3111505113",
-    "@applicaster/zapp-react-native-utils": "15.1.4-alpha.3111505113",
+    "@applicaster/applicaster-types": "15.1.4-alpha.5560334611",
+    "@applicaster/quick-brick-core-plugins": "15.1.4-alpha.5560334611",
+    "@applicaster/zapp-pipes-v2-client": "15.1.4-alpha.5560334611",
+    "@applicaster/zapp-react-native-bridge": "15.1.4-alpha.5560334611",
+    "@applicaster/zapp-react-native-redux": "15.1.4-alpha.5560334611",
+    "@applicaster/zapp-react-native-ui-components": "15.1.4-alpha.5560334611",
+    "@applicaster/zapp-react-native-utils": "15.1.4-alpha.5560334611",
     "atob": "^2.1.2",
     "axios": "^0.28.0",
     "btoa": "^1.2.1",