@applicaster/quick-brick-core 15.0.0-alpha.4200413542 → 15.0.0-alpha.4225160176

package/App/NavigationProvider/NavigationProvider.tsx

@@ -7,7 +7,7 @@ import {
   getTargetRoute,
   usesVideoModal,
 } from "@applicaster/zapp-react-native-utils/navigationUtils";
-import { last } from "@applicaster/zapp-react-native-utils/utils";
+import { clone, last } from "@applicaster/zapp-react-native-utils/utils";
 import {
   allowedOrientationsForScreen,
   useGetScreenOrientation,
@@ -246,22 +246,24 @@ export function NavigationProvider({ children }: Props) {
     const screen = rivers[screenId];
     const parent = findParent(context, navigator.currentRoute);
 
+    const entryClone = clone(entry);
+
     if (!screen) {
       logger.warn({
         message: `Cannot resolve type mapping for ${screenId} id`,
-        data: { entry, screenId },
+        data: { entry: entryClone, screenId },
       });
 
       return;
     }
 
     if (parent) {
-      entry.parent = parent?.data;
+      entryClone.parent = parent?.data;
 
-      entry.parentId = parent?.id;
+      entryClone.parentId = parent?.id;
     }
 
-    dispatch(setNestedContent(pathname, entry, screen));
+    dispatch(setNestedContent(pathname, entryClone, screen));
   };
 
   const pushItem = (item, options = {}) => {

package/App/NavigationProvider/__tests__/navigationProvider.test.tsx

@@ -450,4 +450,56 @@ describe("<NavigationProvider />", () => {
       });
     });
   });
+
+  describe("setNestedScreenContent", () => {
+    it("should clone the entry object before modifying it", () => {
+      const originalEntry = {
+        id: "test-entry",
+        type: {
+          value: "feed",
+        },
+        title: "Test Entry",
+      };
+
+      const entryBeforeCall = structuredClone(originalEntry);
+
+      act(() => {
+        const view = getByTestId(wrapper, "WrapperView");
+        view.props.navigator.setNestedScreenContent(originalEntry, "A1234");
+      });
+
+      // Verify that the original entry object has not been modified
+      expect(originalEntry).toEqual(entryBeforeCall);
+      expect(originalEntry.parent).toBeUndefined();
+      expect(originalEntry.parentId).toBeUndefined();
+    });
+
+    it("should not mutate the original entry when parent exists", () => {
+      // First push a route to create a parent context
+      act(() => {
+        const view = getByTestId(wrapper, "WrapperView");
+        view.props.navigator.push(rivers.A1234);
+      });
+
+      const originalEntry = {
+        id: "test-entry",
+        type: {
+          value: "feed",
+        },
+        title: "Test Entry",
+      };
+
+      const entryBeforeCall = structuredClone(originalEntry);
+
+      act(() => {
+        const view = getByTestId(wrapper, "WrapperView");
+        view.props.navigator.setNestedScreenContent(originalEntry, "B4567");
+      });
+
+      // Verify that the original entry object has not been modified
+      expect(originalEntry).toEqual(entryBeforeCall);
+      expect(originalEntry.parent).toBeUndefined();
+      expect(originalEntry.parentId).toBeUndefined();
+    });
+  });
 });

package/App/NavigationProvider/navigator/selectors.ts

@@ -60,7 +60,7 @@ export const previousStackEntriesSelector = createSelector(
 export const lastEntrySelector = createSelector(
   navigationStackSelector,
   R.compose(R.last, R.when(R.has("mainStack"), R.prop("mainStack")))
-) as (state: any) => any; // TODO: tighten type to NavigationScreenState
+) as (state: any) => NavigationScreenState | undefined;
 
 // Selector extracting identifiers of plugins requiring startup execution
 export const startUpHookPluginIdentifiersSelector = createSelector(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@applicaster/quick-brick-core",
-  "version": "15.0.0-alpha.4200413542",
+  "version": "15.0.0-alpha.4225160176",
   "description": "Core package for Applicaster's Quick Brick App",
   "main": "index.js",
   "types": "index.d.ts",
@@ -28,13 +28,13 @@
   },
   "homepage": "https://github.com/applicaster/quickbrick#readme",
   "dependencies": {
-    "@applicaster/applicaster-types": "15.0.0-alpha.4200413542",
-    "@applicaster/quick-brick-core-plugins": "15.0.0-alpha.4200413542",
-    "@applicaster/zapp-pipes-v2-client": "15.0.0-alpha.4200413542",
-    "@applicaster/zapp-react-native-bridge": "15.0.0-alpha.4200413542",
-    "@applicaster/zapp-react-native-redux": "15.0.0-alpha.4200413542",
-    "@applicaster/zapp-react-native-ui-components": "15.0.0-alpha.4200413542",
-    "@applicaster/zapp-react-native-utils": "15.0.0-alpha.4200413542",
+    "@applicaster/applicaster-types": "15.0.0-alpha.4225160176",
+    "@applicaster/quick-brick-core-plugins": "15.0.0-alpha.4225160176",
+    "@applicaster/zapp-pipes-v2-client": "15.0.0-alpha.4225160176",
+    "@applicaster/zapp-react-native-bridge": "15.0.0-alpha.4225160176",
+    "@applicaster/zapp-react-native-redux": "15.0.0-alpha.4225160176",
+    "@applicaster/zapp-react-native-ui-components": "15.0.0-alpha.4225160176",
+    "@applicaster/zapp-react-native-utils": "15.0.0-alpha.4225160176",
     "atob": "^2.1.2",
     "axios": "^0.28.0",
     "btoa": "^1.2.1",