@appforge-ci/core 0.1.1

package/dist/api-client.test.js

@@ -0,0 +1,305 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { ApiClient, ApiError, apiErrorMessage } from "./api-client.js";
+/**
+ * `ApiClient.request` is the shared HTTP wrapper every single call the
+ * dashboard, CLI, and admin CLI make to the control-plane API goes
+ * through — auth header injection, JSON parsing (including the
+ * empty-body case), routing to the admin Worker vs. the customer-facing
+ * one, and wrapping a non-2xx response into `ApiError`. None of it had
+ * ever been exercised, despite being the single most foundational piece
+ * of shared code in `packages/core`. `fetchImpl` is a small, additive,
+ * optional test seam on `ApiClientOptions` (same "defaults to the real
+ * thing" shape `followBuildLogs`/`waitForCommandResolution` already
+ * established) — every real caller omits it and gets the real global
+ * `fetch`, unchanged.
+ */
+function fakeFetch(handler) {
+    return (async (url, init) => {
+        const result = handler(url, init);
+        const text = "text" in result ? result.text : JSON.stringify(result.body);
+        return {
+            ok: result.status >= 200 && result.status < 300,
+            status: result.status,
+            text: async () => text,
+        };
+    });
+}
+test("request sends a bearer token when one is configured, and none at all when it isn't", async () => {
+    let capturedAuth;
+    const withToken = new ApiClient({
+        baseUrl: "https://api.test",
+        token: "afk_secret",
+        fetchImpl: fakeFetch((_, init) => {
+            capturedAuth = init.headers.authorization;
+            return { status: 200, body: { user: { id: "u1" }, orgs: [] } };
+        }),
+    });
+    await withToken.me();
+    assert.equal(capturedAuth, "Bearer afk_secret");
+    let sawAuthHeader = true;
+    const withoutToken = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((_, init) => {
+            sawAuthHeader = "authorization" in init.headers;
+            return { status: 200, body: { packs: [] } };
+        }),
+    });
+    await withoutToken.listTokenPacks();
+    assert.equal(sawAuthHeader, false);
+});
+test("request JSON-serializes a request body, and sends none at all for a bodyless call", async () => {
+    let capturedBody;
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((_, init) => {
+            capturedBody = init.body;
+            return { status: 201, body: { token: "t", user: {}, org: {} } };
+        }),
+    });
+    await client.signup("a@example.com", "password1234", undefined, "Acme");
+    assert.equal(capturedBody, JSON.stringify({ email: "a@example.com", password: "password1234", name: undefined, orgName: "Acme" }));
+    let bodylessCaptured = "not yet set";
+    const bodylessClient = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((_, init) => {
+            bodylessCaptured = init.body;
+            return { status: 200, body: { user: {}, orgs: [] } };
+        }),
+    });
+    await bodylessClient.me();
+    assert.equal(bodylessCaptured, undefined);
+});
+test("request throws ApiError with the real status and parsed body on a non-2xx response", async () => {
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch(() => ({ status: 402, body: { error: "insufficient tokens" } })),
+    });
+    await assert.rejects(() => client.triggerBuild({ appId: "app-1", workflow: "default" }), (err) => {
+        assert.ok(err instanceof ApiError);
+        assert.equal(err.status, 402);
+        assert.deepEqual(err.body, { error: "insufficient tokens" });
+        return true;
+    });
+});
+// Regression pin: a real deployment sits behind Cloudflare's edge, which
+// can return a plain-text/HTML error page (a gateway timeout, a WAF
+// block, a rate-limit page) instead of the JSON apps/api's/apps/admin-
+// api's own jsonErrorHandler always produces from inside the Worker
+// itself. Before this fix, `JSON.parse`-ing that unconditionally crashed
+// every caller with a raw, uncatchable SyntaxError instead of the
+// ApiError they already know how to catch.
+test("request wraps a non-JSON error body in ApiError instead of crashing on JSON.parse", async () => {
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch(() => ({ status: 524, text: "<html>Gateway Timeout</html>" })),
+    });
+    await assert.rejects(() => client.triggerBuild({ appId: "app-1", workflow: "default" }), (err) => {
+        assert.ok(err instanceof ApiError);
+        assert.equal(err.status, 524);
+        assert.equal(err.body, "<html>Gateway Timeout</html>");
+        return true;
+    });
+});
+// Same edge-error scenario, but on an ok-looking status — rarer, but a
+// caller still deserves a clear thrown error over an uncatchable
+// SyntaxError with no status or context at all.
+test("request throws a clear error (not a raw SyntaxError) on a 2xx response with a non-JSON body", async () => {
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch(() => ({ status: 200, text: "<html>ok?</html>" })),
+    });
+    await assert.rejects(() => client.me(), (err) => {
+        assert.ok(err instanceof Error);
+        assert.ok(!(err instanceof SyntaxError), "must not leak a raw JSON.parse SyntaxError to the caller");
+        assert.match(err.message, /expected a JSON response/);
+        return true;
+    });
+});
+test("request treats an empty response body as null rather than throwing on JSON.parse", async () => {
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch(() => ({ status: 200, text: "" })),
+    });
+    const result = await client.deleteAgent("org-1", "agent-1");
+    assert.equal(result, null);
+});
+/**
+ * Regression test for this cycle's fix: `getOtaManifest` is typed
+ * `Promise<OtaManifest | null>`, matching the real server's behavior —
+ * `apps/api/src/routes/ota.ts` answers "already up to date"/"no active
+ * release"/"not in this install's staged rollout" with a genuine HTTP
+ * 204 and a truly empty body (`c.body(null, 204)`), the overwhelmingly
+ * common response for a polling OTA-check endpoint. Before this fix,
+ * `request()`'s empty-body fallback resolved to `undefined`, not `null`
+ * — silently breaking that declared type contract. Any caller written
+ * against the type, doing the natural `if (manifest === null) return;`,
+ * would instead fall through and crash on `undefined.bundleUrl` on
+ * every single "nothing to do" response. `fakeFetch`'s `text: ""` shape
+ * (not `body: null`, which serializes to the *string* `"null"` and
+ * parses back fine either way) is what actually reproduces a real 204's
+ * empty body.
+ */
+test("getOtaManifest resolves to null (not undefined) on a real empty-body 204, matching its declared type", async () => {
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch(() => ({ status: 204, text: "" })),
+    });
+    const manifest = await client.getOtaManifest("app-1", "production", "key-1");
+    assert.equal(manifest, null);
+});
+test("admin-Worker methods hit adminApiUrl when configured, and fall back to baseUrl otherwise", async () => {
+    let capturedUrl;
+    const withAdminUrl = new ApiClient({
+        baseUrl: "https://api.test",
+        adminApiUrl: "https://admin.test",
+        fetchImpl: fakeFetch((url) => {
+            capturedUrl = url;
+            return { status: 200, body: { agents: [] } };
+        }),
+    });
+    await withAdminUrl.listAgents("org-1");
+    assert.equal(capturedUrl, "https://admin.test/orgs/org-1/agents");
+    let fallbackUrl;
+    const withoutAdminUrl = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((url) => {
+            fallbackUrl = url;
+            return { status: 200, body: { agents: [] } };
+        }),
+    });
+    await withoutAdminUrl.listAgents("org-1");
+    assert.equal(fallbackUrl, "https://api.test/orgs/org-1/agents");
+});
+// Regression pin: `verifyEmail`/`resendVerification` (this cycle's fix)
+// used to not exist on `ApiClient` at all — the dashboard's own
+// verification link had no method to call, so the token from a real
+// signup verification email had no client-side way to ever be redeemed.
+// This just pins the request shape (method, path, body); the dashboard
+// page that calls it is covered separately in apps/dashboard.
+test("verifyEmail POSTs the token to /auth/verify-email; resendVerification POSTs no body to /auth/resend-verification", async () => {
+    let captured;
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((url, init) => {
+            captured = { url, method: init.method, body: init.body };
+            return { status: 200, body: { ok: true } };
+        }),
+    });
+    await client.verifyEmail("tok_abc123");
+    assert.deepEqual(captured, {
+        url: "https://api.test/auth/verify-email",
+        method: "POST",
+        body: JSON.stringify({ token: "tok_abc123" }),
+    });
+    await client.resendVerification();
+    assert.deepEqual(captured, {
+        url: "https://api.test/auth/resend-verification",
+        method: "POST",
+        body: undefined,
+    });
+});
+// Regression pin: `changePassword` used to not exist on `ApiClient` at
+// all — there was no password-rotation route anywhere in the product
+// (found by a fresh Explore-subagent survey). Pins the request shape
+// only; the dashboard panel that calls it is covered separately.
+test("changePassword POSTs currentPassword/newPassword to /auth/change-password", async () => {
+    let captured;
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((url, init) => {
+            captured = { url, method: init.method, body: init.body };
+            return { status: 200, body: { ok: true } };
+        }),
+    });
+    await client.changePassword("old-pw", "a-brand-new-password");
+    assert.deepEqual(captured, {
+        url: "https://api.test/auth/change-password",
+        method: "POST",
+        body: JSON.stringify({ currentPassword: "old-pw", newPassword: "a-brand-new-password" }),
+    });
+});
+test("getOtaManifest URL-encodes a channel name containing '/', matching the other OTA methods", async () => {
+    let capturedUrl;
+    const client = new ApiClient({
+        baseUrl: "https://api.test",
+        fetchImpl: fakeFetch((url) => {
+            capturedUrl = url;
+            return { status: 200, body: null };
+        }),
+    });
+    await client.getOtaManifest("app-1", "beta/ios", "key-1");
+    assert.ok(capturedUrl?.includes("/ota/beta%2Fios/manifest"), capturedUrl);
+    assert.ok(!capturedUrl?.includes("/ota/beta/ios/manifest"), capturedUrl);
+});
+// `AbortSignal.timeout`'s own internal timer is unref'd (confirmed
+// directly: a bare `node -e` script with nothing else scheduled exits
+// before the timer ever fires) — harmless in a real long-running process
+// (the dashboard's own event loop, a CLI command already doing other
+// work), but a test whose only pending work is the awaited call has
+// nothing else keeping it alive. A trivial ref'd interval for the
+// duration of the call fixes that — same helper shape `packages/agent`'s
+// own `api.test.ts`/`self-update.test.ts` already established for the
+// identical issue there.
+function withRefKeepAlive(fn) {
+    const keepAlive = setInterval(() => { }, 1000);
+    return fn().finally(() => clearInterval(keepAlive));
+}
+/**
+ * The actual bug this cycle's fix closes: before it, `request()`'s one
+ * `fetch` call — the single method every dashboard page, CLI command, and
+ * admin-cli command funnels every network call through — had no timeout
+ * at all. A connection that stalls after opening (a network partition, a
+ * proxy holding the connection open without sending further bytes, a hung
+ * Worker instance) left the returned promise pending forever: a CLI
+ * command would hang the terminal indefinitely with no error printed, and
+ * a dashboard page's data-loading call would leave its loading state
+ * stuck with no way to recover short of a full refresh. The mock fetch
+ * mimics what a real `fetch` does once aborted — reject once the signal
+ * fires — to isolate "does request() actually wire the signal through"
+ * from "does AbortSignal.timeout itself work" (a language feature, not
+ * this codebase's to test). Passes a tiny `requestTimeoutMs` via the
+ * constructor's test seam rather than waiting out the real
+ * `DEFAULT_REQUEST_TIMEOUT_MS`.
+ */
+test("request times out instead of hanging forever when the connection stalls", async () => {
+    await withRefKeepAlive(() => {
+        const client = new ApiClient({
+            baseUrl: "https://api.test",
+            requestTimeoutMs: 20,
+            fetchImpl: (async (_url, init) => {
+                return new Promise((_resolve, reject) => {
+                    init?.signal?.addEventListener("abort", () => reject(new Error("The operation was aborted")));
+                });
+            }),
+        });
+        return assert.rejects(() => client.me());
+    });
+});
+/**
+ * `apiErrorMessage` — the shared "what should the user see" extraction
+ * pulled out after the identical bug (an `ApiError`'s raw
+ * `API error ${status}: {...}` wire string shown instead of the
+ * server's own `body.error` text) was found and fixed independently in
+ * `Login.tsx`/`Signup.tsx`/`Device.tsx`/`VerifyEmail.tsx` and
+ * `VncViewer.tsx`'s own `vncViewerErrorMessage`. See ROADMAP.md's
+ * "shared apiErrorMessage helper" entry for the ~30 remaining call
+ * sites this is meant to eventually replace.
+ */
+test("apiErrorMessage extracts the server's body.error for an ApiError that has one", () => {
+    const err = new ApiError(409, { error: "app has an active build — wait for it to finish or cancel it first" });
+    assert.equal(apiErrorMessage(err, "fallback"), "app has an active build — wait for it to finish or cancel it first");
+});
+test("apiErrorMessage falls back to the ApiError's own message when body.error is missing or not a string", () => {
+    assert.equal(apiErrorMessage(new ApiError(500, {}), "fallback"), new ApiError(500, {}).message);
+    assert.equal(apiErrorMessage(new ApiError(500, { error: 42 }), "fallback"), new ApiError(500, { error: 42 }).message);
+    assert.equal(apiErrorMessage(new ApiError(500, null), "fallback"), new ApiError(500, null).message);
+});
+test("apiErrorMessage uses a plain Error's own message, never the ApiError-only body.error path", () => {
+    assert.equal(apiErrorMessage(new Error("network down"), "fallback"), "network down");
+});
+test("apiErrorMessage uses the caller's fallback for a non-Error throw", () => {
+    assert.equal(apiErrorMessage("some string throw", "fallback"), "fallback");
+    assert.equal(apiErrorMessage(undefined, "fallback"), "fallback");
+});
+//# sourceMappingURL=api-client.test.js.map

package/dist/api-client.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"api-client.test.js","sourceRoot":"","sources":["../src/api-client.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,SAAS,EAAE,QAAQ,EAAE,eAAe,EAAE,MAAM,iBAAiB,CAAC;AAEvE;;;;;;;;;;;;GAYG;AACH,SAAS,SAAS,CAChB,OAAiH;IAEjH,OAAO,CAAC,KAAK,EAAE,GAAW,EAAE,IAAiB,EAAE,EAAE;QAC/C,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;QAClC,MAAM,IAAI,GAAG,MAAM,IAAI,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAC1E,OAAO;YACL,EAAE,EAAE,MAAM,CAAC,MAAM,IAAI,GAAG,IAAI,MAAM,CAAC,MAAM,GAAG,GAAG;YAC/C,MAAM,EAAE,MAAM,CAAC,MAAM;YACrB,IAAI,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI;SACX,CAAC;IAChB,CAAC,CAA4B,CAAC;AAChC,CAAC;AAED,IAAI,CAAC,oFAAoF,EAAE,KAAK,IAAI,EAAE;IACpG,IAAI,YAAgC,CAAC;IACrC,MAAM,SAAS,GAAG,IAAI,SAAS,CAAC;QAC9B,OAAO,EAAE,kBAAkB;QAC3B,KAAK,EAAE,YAAY;QACnB,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE;YAC/B,YAAY,GAAI,IAAI,CAAC,OAAkC,CAAC,aAAa,CAAC;YACtE,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,CAAC;QACjE,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,SAAS,CAAC,EAAE,EAAE,CAAC;IACrB,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,mBAAmB,CAAC,CAAC;IAEhD,IAAI,aAAa,GAAG,IAAI,CAAC;IACzB,MAAM,YAAY,GAAG,IAAI,SAAS,CAAC;QACjC,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE;YAC/B,aAAa,GAAG,eAAe,IAAK,IAAI,CAAC,OAAkC,CAAC;YAC5E,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,CAAC;QAC9C,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,YAAY,CAAC,cAAc,EAAE,CAAC;IACpC,MAAM,CAAC,KAAK,CAAC,aAAa,EAAE,KAAK,CAAC,CAAC;AACrC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mFAAmF,EAAE,KAAK,IAAI,EAAE;IACnG,IAAI,YAAqB,CAAC;IAC1B,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE;YAC/B,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC;YACzB,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,KAAK,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,EAAE,GAAG,EAAE,EAAE,EAAE,EAAE,CAAC;QAClE,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,MAAM,CAAC,MAAM,CAAC,eAAe,EAAE,cAAc,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC;IACxE,MAAM,CAAC,KAAK,CAAC,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,KAAK,EAAE,eAAe,EAAE,QAAQ,EAAE,cAAc,EAAE,IAAI,EAAE,SAAS,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC,CAAC,CAAC;IAEnI,IAAI,gBAAgB,GAAY,aAAa,CAAC;IAC9C,MAAM,cAAc,GAAG,IAAI,SAAS,CAAC;QACnC,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE;YAC/B,gBAAgB,GAAG,IAAI,CAAC,IAAI,CAAC;YAC7B,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,CAAC;QACvD,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,cAAc,CAAC,EAAE,EAAE,CAAC;IAC1B,MAAM,CAAC,KAAK,CAAC,gBAAgB,EAAE,SAAS,CAAC,CAAC;AAC5C,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oFAAoF,EAAE,KAAK,IAAI,EAAE;IACpG,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,KAAK,EAAE,qBAAqB,EAAE,EAAE,CAAC,CAAC;KACtF,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,OAAO,CAClB,GAAG,EAAE,CAAC,MAAM,CAAC,YAAY,CAAC,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC,EAClE,CAAC,GAAY,EAAE,EAAE;QACf,MAAM,CAAC,EAAE,CAAC,GAAG,YAAY,QAAQ,CAAC,CAAC;QACnC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;QAC9B,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,IAAI,EAAE,EAAE,KAAK,EAAE,qBAAqB,EAAE,CAAC,CAAC;QAC7D,OAAO,IAAI,CAAC;IACd,CAAC,CACF,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,yEAAyE;AACzE,oEAAoE;AACpE,uEAAuE;AACvE,oEAAoE;AACpE,yEAAyE;AACzE,kEAAkE;AAClE,2CAA2C;AAC3C,IAAI,CAAC,mFAAmF,EAAE,KAAK,IAAI,EAAE;IACnG,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,8BAA8B,EAAE,CAAC,CAAC;KACpF,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,OAAO,CAClB,GAAG,EAAE,CAAC,MAAM,CAAC,YAAY,CAAC,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC,EAClE,CAAC,GAAY,EAAE,EAAE;QACf,MAAM,CAAC,EAAE,CAAC,GAAG,YAAY,QAAQ,CAAC,CAAC;QACnC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;QAC9B,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,8BAA8B,CAAC,CAAC;QACvD,OAAO,IAAI,CAAC;IACd,CAAC,CACF,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,uEAAuE;AACvE,iEAAiE;AACjE,gDAAgD;AAChD,IAAI,CAAC,6FAA6F,EAAE,KAAK,IAAI,EAAE;IAC7G,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,CAAC;KACxE,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,OAAO,CAClB,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,EAAE,EACjB,CAAC,GAAY,EAAE,EAAE;QACf,MAAM,CAAC,EAAE,CAAC,GAAG,YAAY,KAAK,CAAC,CAAC;QAChC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,YAAY,WAAW,CAAC,EAAE,0DAA0D,CAAC,CAAC;QACrG,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,EAAE,0BAA0B,CAAC,CAAC;QACtD,OAAO,IAAI,CAAC;IACd,CAAC,CACF,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kFAAkF,EAAE,KAAK,IAAI,EAAE;IAClG,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,CAAC;KACxD,CAAC,CAAC;IACH,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,WAAW,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;IAC5D,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,IAAI,CAAC,CAAC;AAC7B,CAAC,CAAC,CAAC;AAEH;;;;;;;;;;;;;;;GAeG;AACH,IAAI,CAAC,sGAAsG,EAAE,KAAK,IAAI,EAAE;IACtH,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,CAAC;KACxD,CAAC,CAAC;IACH,MAAM,QAAQ,GAAG,MAAM,MAAM,CAAC,cAAc,CAAC,OAAO,EAAE,YAAY,EAAE,OAAO,CAAC,CAAC;IAC7E,MAAM,CAAC,KAAK,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;AAC/B,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0FAA0F,EAAE,KAAK,IAAI,EAAE;IAC1G,IAAI,WAA+B,CAAC;IACpC,MAAM,YAAY,GAAG,IAAI,SAAS,CAAC;QACjC,OAAO,EAAE,kBAAkB;QAC3B,WAAW,EAAE,oBAAoB;QACjC,SAAS,EAAE,SAAS,CAAC,CAAC,GAAG,EAAE,EAAE;YAC3B,WAAW,GAAG,GAAG,CAAC;YAClB,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,CAAC;QAC/C,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,YAAY,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;IACvC,MAAM,CAAC,KAAK,CAAC,WAAW,EAAE,sCAAsC,CAAC,CAAC;IAElE,IAAI,WAA+B,CAAC;IACpC,MAAM,eAAe,GAAG,IAAI,SAAS,CAAC;QACpC,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,GAAG,EAAE,EAAE;YAC3B,WAAW,GAAG,GAAG,CAAC;YAClB,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,CAAC;QAC/C,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,eAAe,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;IAC1C,MAAM,CAAC,KAAK,CAAC,WAAW,EAAE,oCAAoC,CAAC,CAAC;AAClE,CAAC,CAAC,CAAC;AAEH,wEAAwE;AACxE,gEAAgE;AAChE,oEAAoE;AACpE,wEAAwE;AACxE,uEAAuE;AACvE,8DAA8D;AAC9D,IAAI,CAAC,kHAAkH,EAAE,KAAK,IAAI,EAAE;IAClI,IAAI,QAAoE,CAAC;IACzE,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE;YACjC,QAAQ,GAAG,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,CAAC,MAAgB,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC;YACnE,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,EAAE,CAAC;QAC7C,CAAC,CAAC;KACH,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,WAAW,CAAC,YAAY,CAAC,CAAC;IACvC,MAAM,CAAC,SAAS,CAAC,QAAQ,EAAE;QACzB,GAAG,EAAE,oCAAoC;QACzC,MAAM,EAAE,MAAM;QACd,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,KAAK,EAAE,YAAY,EAAE,CAAC;KAC9C,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,kBAAkB,EAAE,CAAC;IAClC,MAAM,CAAC,SAAS,CAAC,QAAQ,EAAE;QACzB,GAAG,EAAE,2CAA2C;QAChD,MAAM,EAAE,MAAM;QACd,IAAI,EAAE,SAAS;KAChB,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,uEAAuE;AACvE,qEAAqE;AACrE,qEAAqE;AACrE,iEAAiE;AACjE,IAAI,CAAC,2EAA2E,EAAE,KAAK,IAAI,EAAE;IAC3F,IAAI,QAAoE,CAAC;IACzE,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE;YACjC,QAAQ,GAAG,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,CAAC,MAAgB,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC;YACnE,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,EAAE,CAAC;QAC7C,CAAC,CAAC;KACH,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,cAAc,CAAC,QAAQ,EAAE,sBAAsB,CAAC,CAAC;IAC9D,MAAM,CAAC,SAAS,CAAC,QAAQ,EAAE;QACzB,GAAG,EAAE,uCAAuC;QAC5C,MAAM,EAAE,MAAM;QACd,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,eAAe,EAAE,QAAQ,EAAE,WAAW,EAAE,sBAAsB,EAAE,CAAC;KACzF,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0FAA0F,EAAE,KAAK,IAAI,EAAE;IAC1G,IAAI,WAA+B,CAAC;IACpC,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;QAC3B,OAAO,EAAE,kBAAkB;QAC3B,SAAS,EAAE,SAAS,CAAC,CAAC,GAAG,EAAE,EAAE;YAC3B,WAAW,GAAG,GAAG,CAAC;YAClB,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC;QACrC,CAAC,CAAC;KACH,CAAC,CAAC;IACH,MAAM,MAAM,CAAC,cAAc,CAAC,OAAO,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC;IAC1D,MAAM,CAAC,EAAE,CAAC,WAAW,EAAE,QAAQ,CAAC,0BAA0B,CAAC,EAAE,WAAW,CAAC,CAAC;IAC1E,MAAM,CAAC,EAAE,CAAC,CAAC,WAAW,EAAE,QAAQ,CAAC,wBAAwB,CAAC,EAAE,WAAW,CAAC,CAAC;AAC3E,CAAC,CAAC,CAAC;AAEH,mEAAmE;AACnE,sEAAsE;AACtE,yEAAyE;AACzE,qEAAqE;AACrE,oEAAoE;AACpE,kEAAkE;AAClE,yEAAyE;AACzE,sEAAsE;AACtE,yBAAyB;AACzB,SAAS,gBAAgB,CAAI,EAAoB;IAC/C,MAAM,SAAS,GAAG,WAAW,CAAC,GAAG,EAAE,GAAE,CAAC,EAAE,IAAI,CAAC,CAAC;IAC9C,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,aAAa,CAAC,SAAS,CAAC,CAAC,CAAC;AACtD,CAAC;AAED;;;;;;;;;;;;;;;;GAgBG;AACH,IAAI,CAAC,yEAAyE,EAAE,KAAK,IAAI,EAAE;IACzF,MAAM,gBAAgB,CAAC,GAAG,EAAE;QAC1B,MAAM,MAAM,GAAG,IAAI,SAAS,CAAC;YAC3B,OAAO,EAAE,kBAAkB;YAC3B,gBAAgB,EAAE,EAAE;YACpB,SAAS,EAAE,CAAC,KAAK,EAAE,IAAY,EAAE,IAAkB,EAAE,EAAE;gBACrD,OAAO,IAAI,OAAO,CAAW,CAAC,QAAQ,EAAE,MAAM,EAAE,EAAE;oBAChD,IAAI,EAAE,MAAM,EAAE,gBAAgB,CAAC,OAAO,EAAE,GAAG,EAAE,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,2BAA2B,CAAC,CAAC,CAAC,CAAC;gBAChG,CAAC,CAAC,CAAC;YACL,CAAC,CAA4B;SAC9B,CAAC,CAAC;QACH,OAAO,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,EAAE,EAAE,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH;;;;;;;;;GASG;AACH,IAAI,CAAC,+EAA+E,EAAE,GAAG,EAAE;IACzF,MAAM,GAAG,GAAG,IAAI,QAAQ,CAAC,GAAG,EAAE,EAAE,KAAK,EAAE,oEAAoE,EAAE,CAAC,CAAC;IAC/G,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,GAAG,EAAE,UAAU,CAAC,EAAE,oEAAoE,CAAC,CAAC;AACvH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qGAAqG,EAAE,GAAG,EAAE;IAC/G,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,IAAI,QAAQ,CAAC,GAAG,EAAE,EAAE,CAAC,EAAE,UAAU,CAAC,EAAE,IAAI,QAAQ,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC;IAChG,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,IAAI,QAAQ,CAAC,GAAG,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,EAAE,UAAU,CAAC,EAAE,IAAI,QAAQ,CAAC,GAAG,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC;IACtH,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,IAAI,QAAQ,CAAC,GAAG,EAAE,IAAI,CAAC,EAAE,UAAU,CAAC,EAAE,IAAI,QAAQ,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC;AACtG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2FAA2F,EAAE,GAAG,EAAE;IACrG,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,IAAI,KAAK,CAAC,cAAc,CAAC,EAAE,UAAU,CAAC,EAAE,cAAc,CAAC,CAAC;AACvF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAC5E,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,mBAAmB,EAAE,UAAU,CAAC,EAAE,UAAU,CAAC,CAAC;IAC3E,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,SAAS,EAAE,UAAU,CAAC,EAAE,UAAU,CAAC,CAAC;AACnE,CAAC,CAAC,CAAC"}

package/dist/build-cost.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=build-cost.test.d.ts.map

package/dist/build-cost.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"build-cost.test.d.ts","sourceRoot":"","sources":["../src/build-cost.test.ts"],"names":[],"mappings":""}

package/dist/build-cost.test.js

@@ -0,0 +1,21 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { getBuildCostTokens, BUILD_COST_TOKENS, BUILD_COST_TOKENS_BY_PLATFORM } from "./types.js";
+test("getBuildCostTokens returns the flat default for every known platform (no pricing change bundled)", () => {
+    for (const platform of ["ios", "android", "flutter", "react-native"]) {
+        assert.equal(getBuildCostTokens(platform), BUILD_COST_TOKENS);
+    }
+});
+test("getBuildCostTokens converts the DB's underscore storage format (react_native)", () => {
+    assert.equal(getBuildCostTokens("react_native"), BUILD_COST_TOKENS_BY_PLATFORM["react-native"]);
+});
+test("getBuildCostTokens falls back to the flat default for an unrecognized platform instead of throwing", () => {
+    assert.equal(getBuildCostTokens("some-future-platform"), BUILD_COST_TOKENS);
+});
+test("BUILD_COST_TOKENS_BY_PLATFORM has an entry for every Platform", () => {
+    const platforms = ["ios", "android", "flutter", "react-native"];
+    for (const platform of platforms) {
+        assert.equal(typeof BUILD_COST_TOKENS_BY_PLATFORM[platform], "number");
+    }
+});
+//# sourceMappingURL=build-cost.test.js.map

package/dist/build-cost.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"build-cost.test.js","sourceRoot":"","sources":["../src/build-cost.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,6BAA6B,EAAE,MAAM,YAAY,CAAC;AAElG,IAAI,CAAC,kGAAkG,EAAE,GAAG,EAAE;IAC5G,KAAK,MAAM,QAAQ,IAAI,CAAC,KAAK,EAAE,SAAS,EAAE,SAAS,EAAE,cAAc,CAAU,EAAE,CAAC;QAC9E,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,QAAQ,CAAC,EAAE,iBAAiB,CAAC,CAAC;IAChE,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+EAA+E,EAAE,GAAG,EAAE;IACzF,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,cAAc,CAAC,EAAE,6BAA6B,CAAC,cAAc,CAAC,CAAC,CAAC;AAClG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oGAAoG,EAAE,GAAG,EAAE;IAC9G,MAAM,CAAC,KAAK,CAAC,kBAAkB,CAAC,sBAAsB,CAAC,EAAE,iBAAiB,CAAC,CAAC;AAC9E,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+DAA+D,EAAE,GAAG,EAAE;IACzE,MAAM,SAAS,GAAG,CAAC,KAAK,EAAE,SAAS,EAAE,SAAS,EAAE,cAAc,CAAU,CAAC;IACzE,KAAK,MAAM,QAAQ,IAAI,SAAS,EAAE,CAAC;QACjC,MAAM,CAAC,KAAK,CAAC,OAAO,6BAA6B,CAAC,QAAQ,CAAC,EAAE,QAAQ,CAAC,CAAC;IACzE,CAAC;AACH,CAAC,CAAC,CAAC"}

package/dist/index.d.ts

@@ -0,0 +1,8 @@
+export * from "./types.js";
+export * from "./schemas.js";
+export * from "./api-client.js";
+export * from "./agent-readiness.js";
+export * from "./ota-rollout.js";
+export * from "./ota-bundle-hash.js";
+export * from "./ota-artifact.js";
+//# sourceMappingURL=index.d.ts.map

package/dist/index.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,cAAc,YAAY,CAAC;AAC3B,cAAc,cAAc,CAAC;AAC7B,cAAc,iBAAiB,CAAC;AAChC,cAAc,sBAAsB,CAAC;AACrC,cAAc,kBAAkB,CAAC;AACjC,cAAc,sBAAsB,CAAC;AACrC,cAAc,mBAAmB,CAAC"}

package/dist/index.js

@@ -0,0 +1,8 @@
+export * from "./types.js";
+export * from "./schemas.js";
+export * from "./api-client.js";
+export * from "./agent-readiness.js";
+export * from "./ota-rollout.js";
+export * from "./ota-bundle-hash.js";
+export * from "./ota-artifact.js";
+//# sourceMappingURL=index.js.map

package/dist/index.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA,cAAc,YAAY,CAAC;AAC3B,cAAc,cAAc,CAAC;AAC7B,cAAc,iBAAiB,CAAC;AAChC,cAAc,sBAAsB,CAAC;AACrC,cAAc,kBAAkB,CAAC;AACjC,cAAc,sBAAsB,CAAC;AACrC,cAAc,mBAAmB,CAAC"}

package/dist/ota-artifact.d.ts

@@ -0,0 +1,41 @@
+/**
+ * Picks which of a build's artifacts is "the OTA bundle" — shared by
+ * `apps/api/src/routes/ota.ts` (dashboard "promote build to OTA
+ * release" action) and `apps/admin-api/src/routes/agents.ts`
+ * (`POST /builds/:buildId/complete`'s auto-promote path). Both used to
+ * inline this as a single flat `Array.prototype.find` predicate:
+ *
+ * ```js
+ * artifacts.find(
+ *   (a) => a.fileName.endsWith(".ota.zip") || a.fileName.includes("ota") || a.fileName.endsWith(".bundle"),
+ * ) ?? artifacts[0]
+ * ```
+ *
+ * That was a real bug, not just duplicated logic: `find`'s three OR'd
+ * clauses have no priority between them — it returns whichever array
+ * element satisfies *any one* of the three first, so a build's very
+ * first artifact whose filename merely *contains* the substring "ota"
+ * (`quota-report.json`, `rotation-test.log`, `annotation-summary.xml`)
+ * would win over a real `app-release.ota.zip` listed later, purely
+ * because artifacts are read back in upload order
+ * (`packages/db/src/builds.ts`'s `listArtifacts`, `ORDER BY createdAt
+ * ASC`), which mirrors the order a workflow's own `artifacts:` glob
+ * patterns are listed in `appforge.yaml` — entirely ordinary config,
+ * e.g. a test-report glob listed before the release-bundle glob. The
+ * consequence: the wrong file gets promoted as the OTA release,
+ * `GET /apps/:appId/ota/:channel/manifest` hands it out to every
+ * client on that channel, and a device attempting to apply a JSON/log
+ * file as an app update breaks the update flow (or crashes the app, if
+ * it's loaded as a JS bundle) — with admin-api's auto-publish path
+ * (any workflow with `ota: {...}` that succeeds) doing this with no
+ * human review at all.
+ *
+ * Fixed by ranking, not flat-OR'ing: a precise match
+ * (`.ota.zip`/`.bundle` suffix) always wins over the loose substring
+ * heuristic, which only ever gets a chance if nothing precise matched
+ * anywhere in the list — never mid-scan against a single element.
+ */
+export declare function pickOtaArtifact<T extends {
+    fileName: string;
+}>(artifacts: T[]): T | undefined;
+//# sourceMappingURL=ota-artifact.d.ts.map

package/dist/ota-artifact.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-artifact.d.ts","sourceRoot":"","sources":["../src/ota-artifact.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAoCG;AACH,wBAAgB,eAAe,CAAC,CAAC,SAAS;IAAE,QAAQ,EAAE,MAAM,CAAA;CAAE,EAAE,SAAS,EAAE,CAAC,EAAE,GAAG,CAAC,GAAG,SAAS,CAM7F"}

package/dist/ota-artifact.js

@@ -0,0 +1,43 @@
+/**
+ * Picks which of a build's artifacts is "the OTA bundle" — shared by
+ * `apps/api/src/routes/ota.ts` (dashboard "promote build to OTA
+ * release" action) and `apps/admin-api/src/routes/agents.ts`
+ * (`POST /builds/:buildId/complete`'s auto-promote path). Both used to
+ * inline this as a single flat `Array.prototype.find` predicate:
+ *
+ * ```js
+ * artifacts.find(
+ *   (a) => a.fileName.endsWith(".ota.zip") || a.fileName.includes("ota") || a.fileName.endsWith(".bundle"),
+ * ) ?? artifacts[0]
+ * ```
+ *
+ * That was a real bug, not just duplicated logic: `find`'s three OR'd
+ * clauses have no priority between them — it returns whichever array
+ * element satisfies *any one* of the three first, so a build's very
+ * first artifact whose filename merely *contains* the substring "ota"
+ * (`quota-report.json`, `rotation-test.log`, `annotation-summary.xml`)
+ * would win over a real `app-release.ota.zip` listed later, purely
+ * because artifacts are read back in upload order
+ * (`packages/db/src/builds.ts`'s `listArtifacts`, `ORDER BY createdAt
+ * ASC`), which mirrors the order a workflow's own `artifacts:` glob
+ * patterns are listed in `appforge.yaml` — entirely ordinary config,
+ * e.g. a test-report glob listed before the release-bundle glob. The
+ * consequence: the wrong file gets promoted as the OTA release,
+ * `GET /apps/:appId/ota/:channel/manifest` hands it out to every
+ * client on that channel, and a device attempting to apply a JSON/log
+ * file as an app update breaks the update flow (or crashes the app, if
+ * it's loaded as a JS bundle) — with admin-api's auto-publish path
+ * (any workflow with `ota: {...}` that succeeds) doing this with no
+ * human review at all.
+ *
+ * Fixed by ranking, not flat-OR'ing: a precise match
+ * (`.ota.zip`/`.bundle` suffix) always wins over the loose substring
+ * heuristic, which only ever gets a chance if nothing precise matched
+ * anywhere in the list — never mid-scan against a single element.
+ */
+export function pickOtaArtifact(artifacts) {
+    return (artifacts.find((a) => a.fileName.endsWith(".ota.zip") || a.fileName.endsWith(".bundle")) ??
+        artifacts.find((a) => a.fileName.includes("ota")) ??
+        artifacts[0]);
+}
+//# sourceMappingURL=ota-artifact.js.map

package/dist/ota-artifact.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-artifact.js","sourceRoot":"","sources":["../src/ota-artifact.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAoCG;AACH,MAAM,UAAU,eAAe,CAAiC,SAAc;IAC5E,OAAO,CACL,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;QACxF,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC;QACjD,SAAS,CAAC,CAAC,CAAC,CACb,CAAC;AACJ,CAAC"}

package/dist/ota-artifact.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=ota-artifact.test.d.ts.map

package/dist/ota-artifact.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-artifact.test.d.ts","sourceRoot":"","sources":["../src/ota-artifact.test.ts"],"names":[],"mappings":""}

package/dist/ota-artifact.test.js

@@ -0,0 +1,44 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { pickOtaArtifact } from "./ota-artifact.js";
+test("pickOtaArtifact picks a precise .ota.zip suffix match over an earlier, unrelated artifact", () => {
+    const artifacts = [
+        { fileName: "app-release.apk" },
+        { fileName: "index.android.ota.zip" },
+    ];
+    assert.equal(pickOtaArtifact(artifacts), artifacts[1]);
+});
+test("pickOtaArtifact picks a precise .bundle suffix match over an earlier, unrelated artifact", () => {
+    const artifacts = [{ fileName: "app-release.apk" }, { fileName: "index.android.bundle" }];
+    assert.equal(pickOtaArtifact(artifacts), artifacts[1]);
+});
+test("pickOtaArtifact regression: a loose substring match listed FIRST no longer beats a precise match listed later", () => {
+    // This is the exact bug: a flat `Array.find` with three OR'd clauses
+    // has no priority between them, so it returns whichever element
+    // satisfies ANY clause first. "quota-report.json" merely *contains*
+    // "ota" — it isn't a real OTA bundle — but under the old code it was
+    // returned outright since it's first in the array and .find never
+    // looked further once it matched.
+    const artifacts = [
+        { fileName: "quota-report.json" },
+        { fileName: "app-release.ota.zip" },
+    ];
+    assert.equal(pickOtaArtifact(artifacts), artifacts[1]);
+    // The old, buggy predicate for comparison — proves this is the exact
+    // regression being fixed, not a hypothetical.
+    const oldPick = (arts) => arts.find((a) => a.fileName.endsWith(".ota.zip") || a.fileName.includes("ota") || a.fileName.endsWith(".bundle")) ??
+        arts[0];
+    assert.equal(oldPick(artifacts), artifacts[0]);
+});
+test("pickOtaArtifact falls back to the loose substring match only when nothing precise matches anywhere", () => {
+    const artifacts = [{ fileName: "app-release.apk" }, { fileName: "rotation-test.log" }];
+    assert.equal(pickOtaArtifact(artifacts), artifacts[1]);
+});
+test("pickOtaArtifact falls back to artifacts[0] when nothing matches at all", () => {
+    const artifacts = [{ fileName: "app-release.apk" }, { fileName: "build.log" }];
+    assert.equal(pickOtaArtifact(artifacts), artifacts[0]);
+});
+test("pickOtaArtifact returns undefined for an empty artifacts array", () => {
+    assert.equal(pickOtaArtifact([]), undefined);
+});
+//# sourceMappingURL=ota-artifact.test.js.map

package/dist/ota-artifact.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-artifact.test.js","sourceRoot":"","sources":["../src/ota-artifact.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,eAAe,EAAE,MAAM,mBAAmB,CAAC;AAEpD,IAAI,CAAC,2FAA2F,EAAE,GAAG,EAAE;IACrG,MAAM,SAAS,GAAG;QAChB,EAAE,QAAQ,EAAE,iBAAiB,EAAE;QAC/B,EAAE,QAAQ,EAAE,uBAAuB,EAAE;KACtC,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;AACzD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0FAA0F,EAAE,GAAG,EAAE;IACpG,MAAM,SAAS,GAAG,CAAC,EAAE,QAAQ,EAAE,iBAAiB,EAAE,EAAE,EAAE,QAAQ,EAAE,sBAAsB,EAAE,CAAC,CAAC;IAC1F,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;AACzD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+GAA+G,EAAE,GAAG,EAAE;IACzH,qEAAqE;IACrE,gEAAgE;IAChE,oEAAoE;IACpE,qEAAqE;IACrE,kEAAkE;IAClE,kCAAkC;IAClC,MAAM,SAAS,GAAG;QAChB,EAAE,QAAQ,EAAE,mBAAmB,EAAE;QACjC,EAAE,QAAQ,EAAE,qBAAqB,EAAE;KACpC,CAAC;IAEF,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;IAEvD,qEAAqE;IACrE,8CAA8C;IAC9C,MAAM,OAAO,GAAG,CAAC,IAAsB,EAAE,EAAE,CACzC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC;QACjH,IAAI,CAAC,CAAC,CAAC,CAAC;IACV,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;AACjD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oGAAoG,EAAE,GAAG,EAAE;IAC9G,MAAM,SAAS,GAAG,CAAC,EAAE,QAAQ,EAAE,iBAAiB,EAAE,EAAE,EAAE,QAAQ,EAAE,mBAAmB,EAAE,CAAC,CAAC;IACvF,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;AACzD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;IAClF,MAAM,SAAS,GAAG,CAAC,EAAE,QAAQ,EAAE,iBAAiB,EAAE,EAAE,EAAE,QAAQ,EAAE,WAAW,EAAE,CAAC,CAAC;IAC/E,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,SAAS,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;AACzD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;IAC1E,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,EAAE,CAAC,EAAE,SAAS,CAAC,CAAC;AAC/C,CAAC,CAAC,CAAC"}

package/dist/ota-bundle-hash.d.ts

@@ -0,0 +1,38 @@
+/**
+ * Derives an OTA release's `bundleHash` from the promoted build's R2
+ * storage key (`builds/${buildId}/${fileName}`, see
+ * `apps/admin-api/src/lib/storage.ts` / `apps/api/src/lib/storage.ts`'s
+ * `artifactKey`). Both `apps/api/src/routes/ota.ts` (dashboard "promote
+ * build to OTA release" action) and `apps/admin-api/src/routes/
+ * agents.ts` (`POST /builds/:buildId/complete`'s auto-promote path,
+ * `packages/agent`'s only actual caller since it never sends its own
+ * `input.ota.bundleHash` — see `packages/agent/src/lib/builder.ts`)
+ * used to inline this as `storageKey.replace(/[^a-zA-Z0-9]/g,
+ * "").slice(-32)`.
+ *
+ * That `.slice(-32)` was a collision bug, not a stylistic choice:
+ * `buildId` is always exactly 32 alphanumeric characters (a
+ * dash-stripped `crypto.randomUUID()`, see `packages/db/src/id.ts`), so
+ * for any artifact `fileName` with 32 or more alphanumeric characters
+ * (ordinary for a descriptive OTA bundle name, e.g.
+ * "react-native-ota-bundle-production.zip"), keeping only the *last* 32
+ * characters of the stripped key drops the build-specific `buildId`
+ * entirely and keeps only a fixed suffix of `fileName` — making
+ * `bundleHash` an app-wide *constant* across every future release for
+ * that app. The manifest endpoint's `currentHash ===
+ * activeRelease.bundleHash` check (`ota.ts`'s `GET /apps/:appId/ota/
+ * :channel/manifest`) then permanently returns `204 No Content`
+ * ("already up to date") for that app, silently breaking OTA delivery
+ * the moment a device picks up one release with that hash.
+ *
+ * The fix: don't truncate at all. `bundleHash`'s DB column
+ * (`migrations/0012_ota_updates.sql`) is unconstrained `TEXT`, and
+ * every consumer either compares it for equality (`ota.ts`'s manifest
+ * check, `packages/agent`) or truncates it further purely for display
+ * (`AppDetail.tsx`, `packages/cli/src/commands/ota.ts`'s
+ * `formatReleaseLine`) — nothing depends on a fixed 32-character
+ * length, so keeping the whole stripped key preserves full
+ * build-specific entropy with no downstream breakage.
+ */
+export declare function deriveOtaBundleHash(storageKey: string): string;
+//# sourceMappingURL=ota-bundle-hash.d.ts.map

package/dist/ota-bundle-hash.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-bundle-hash.d.ts","sourceRoot":"","sources":["../src/ota-bundle-hash.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAmCG;AACH,wBAAgB,mBAAmB,CAAC,UAAU,EAAE,MAAM,GAAG,MAAM,CAE9D"}

package/dist/ota-bundle-hash.js

@@ -0,0 +1,40 @@
+/**
+ * Derives an OTA release's `bundleHash` from the promoted build's R2
+ * storage key (`builds/${buildId}/${fileName}`, see
+ * `apps/admin-api/src/lib/storage.ts` / `apps/api/src/lib/storage.ts`'s
+ * `artifactKey`). Both `apps/api/src/routes/ota.ts` (dashboard "promote
+ * build to OTA release" action) and `apps/admin-api/src/routes/
+ * agents.ts` (`POST /builds/:buildId/complete`'s auto-promote path,
+ * `packages/agent`'s only actual caller since it never sends its own
+ * `input.ota.bundleHash` — see `packages/agent/src/lib/builder.ts`)
+ * used to inline this as `storageKey.replace(/[^a-zA-Z0-9]/g,
+ * "").slice(-32)`.
+ *
+ * That `.slice(-32)` was a collision bug, not a stylistic choice:
+ * `buildId` is always exactly 32 alphanumeric characters (a
+ * dash-stripped `crypto.randomUUID()`, see `packages/db/src/id.ts`), so
+ * for any artifact `fileName` with 32 or more alphanumeric characters
+ * (ordinary for a descriptive OTA bundle name, e.g.
+ * "react-native-ota-bundle-production.zip"), keeping only the *last* 32
+ * characters of the stripped key drops the build-specific `buildId`
+ * entirely and keeps only a fixed suffix of `fileName` — making
+ * `bundleHash` an app-wide *constant* across every future release for
+ * that app. The manifest endpoint's `currentHash ===
+ * activeRelease.bundleHash` check (`ota.ts`'s `GET /apps/:appId/ota/
+ * :channel/manifest`) then permanently returns `204 No Content`
+ * ("already up to date") for that app, silently breaking OTA delivery
+ * the moment a device picks up one release with that hash.
+ *
+ * The fix: don't truncate at all. `bundleHash`'s DB column
+ * (`migrations/0012_ota_updates.sql`) is unconstrained `TEXT`, and
+ * every consumer either compares it for equality (`ota.ts`'s manifest
+ * check, `packages/agent`) or truncates it further purely for display
+ * (`AppDetail.tsx`, `packages/cli/src/commands/ota.ts`'s
+ * `formatReleaseLine`) — nothing depends on a fixed 32-character
+ * length, so keeping the whole stripped key preserves full
+ * build-specific entropy with no downstream breakage.
+ */
+export function deriveOtaBundleHash(storageKey) {
+    return storageKey.replace(/[^a-zA-Z0-9]/g, "");
+}
+//# sourceMappingURL=ota-bundle-hash.js.map

package/dist/ota-bundle-hash.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-bundle-hash.js","sourceRoot":"","sources":["../src/ota-bundle-hash.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAmCG;AACH,MAAM,UAAU,mBAAmB,CAAC,UAAkB;IACpD,OAAO,UAAU,CAAC,OAAO,CAAC,eAAe,EAAE,EAAE,CAAC,CAAC;AACjD,CAAC"}

package/dist/ota-bundle-hash.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=ota-bundle-hash.test.d.ts.map

package/dist/ota-bundle-hash.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"ota-bundle-hash.test.d.ts","sourceRoot":"","sources":["../src/ota-bundle-hash.test.ts"],"names":[],"mappings":""}