@appcorp/fusion-storybook 0.2.0 → 0.2.2

package/base-modules/admission/form.js

@@ -77,7 +77,8 @@ export const AdmissionForm = () => {
                 },
             });
         }
-    }, [id, dispatch, workspace]);
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, [id, dispatch]);
     return (_jsxs("div", { className: "grid grid-cols-1 gap-2 space-y-2", children: [_jsx("h4", { className: "m-0 p-0", children: t("formSectionStudentInformation") }), _jsxs("div", { className: "grid grid-cols-5 gap-4", children: [_jsx(EnhancedInput, { error: errors.firstName, id: "firstName", info: t("formFirstNameInfo"), label: t("formFirstNameLabel"), onChange: (e) => handleChange("firstName", e.target.value), placeholder: t("formFirstNamePlaceholder"), required: true, type: "text", value: firstName || "" }), _jsx(EnhancedInput, { error: errors.lastName, id: "lastName", info: t("formLastNameInfo"), label: t("formLastNameLabel"), onChange: (e) => handleChange("lastName", e.target.value), placeholder: t("formLastNamePlaceholder"), required: true, type: "text", value: lastName || "" }), _jsx(EnhancedInput, { error: errors.studentIdNumber, id: "studentIdNumber", info: t("formStudentIdNumberInfo"), label: t("formStudentIdNumberLabel"), onChange: (e) => handleChange("studentIdNumber", e.target.value), placeholder: t("formStudentIdNumberPlaceholder"), required: true, type: "text", value: studentIdNumber || "" }), _jsx(EnhancedCombobox, { emptyText: t("formNoGenderOptionsEmpty"), error: errors.gender, id: "gender", info: t("formGenderInfo"), label: t("formGenderLabel"), required: true, onValueChange: (value) => handleChange("gender", value), options: [
                             { label: t("formOptionMale"), value: GENDER.MALE },
                             { label: t("formOptionFemale"), value: GENDER.FEMALE },

package/base-modules/admission/page.js

@@ -52,7 +52,7 @@ const createComponentInstances = () => ({
     moreActions: _jsx(AdmissionMoreActions, {}),
     view: _jsx(AdmissionView, {}),
 });
-const createAdmissionConfig = ({ cancelLabel, dispatch, drawerTitle, labelActions, labelClass, labelEnabled, labelFirstName, labelId, labelLastName, labelRegistrationCode, labelStatus, saveLabel, searchPlaceholder, tableDescription, tableTitle, }) => {
+const createAdmissionConfig = ({ cancelLabel, dispatch, drawer, drawerTitle, labelActions, labelClass, labelEnabled, labelFirstName, labelId, labelLastName, labelRegistrationCode, labelStatus, saveLabel, searchPlaceholder, tableDescription, tableTitle, }) => {
     const components = createComponentInstances();
     return {
         moduleName: "admission",
@@ -76,7 +76,7 @@ const createAdmissionConfig = ({ cancelLabel, dispatch, drawerTitle, labelAction
         tableDescription,
         tableTitle,
         viewContent: components.view,
-        size: "small",
+        size: drawer === ADMISSION_DRAWER.FORM_DRAWER ? "full" : "small",
         onClearFilters: () => {
             dispatch({ type: ADMISSION_ACTION_TYPES.RESET_FORM });
         },
@@ -88,12 +88,10 @@ const createAdmissionConfig = ({ cancelLabel, dispatch, drawerTitle, labelAction
 const GenericAdmissionPage = createGenericModulePage();
 const AdmissionPageInner = (props) => {
     const context = useAdmissionModule();
-    // Memoize config creation - INTENTIONALLY EXCLUDE drawer state to prevent infinite loops
-    // The drawer state changing (from clicking buttons) would recreate this config,
-    // causing unnecessary re-renders and state updates. Since config should be stable
-    // across drawer state changes, we exclude it from dependencies.
+    // Memoize config creation - destructure props to avoid object reference changes
     const admissionConfig = useMemo(() => createAdmissionConfig({
         dispatch: context.dispatch,
+        drawer: context.state.drawer,
         cancelLabel: props.cancelLabel,
         drawerTitle: props.drawerTitle,
         labelActions: props.labelActions,
@@ -110,6 +108,7 @@ const AdmissionPageInner = (props) => {
         tableTitle: props.tableTitle,
     }), [
         context.dispatch,
+        context.state.drawer,
         props.cancelLabel,
         props.drawerTitle,
         props.labelActions,
@@ -125,11 +124,6 @@ const AdmissionPageInner = (props) => {
         props.tableDescription,
         props.tableTitle,
     ]);
-    // Dynamically apply drawer size to config for proper drawer sizing
-    // This allows size to change without recreating the entire config
-    const admissionConfigWithSize = useMemo(() => (Object.assign(Object.assign({}, admissionConfig), { size: context.state.drawer === ADMISSION_DRAWER.FORM_DRAWER
-            ? "full"
-            : "small" })), [admissionConfig, context.state.drawer]);
     const hasPermission = resolveRbacPermissions({
         userRole: props.userRole,
         moduleName: "Admission",
@@ -137,7 +131,7 @@ const AdmissionPageInner = (props) => {
     if (!hasPermission) {
         return _jsx(RbacNoAccess, { moduleName: "Admission" });
     }
-    return (_jsx("div", { className: "p-4", children: _jsx(GenericAdmissionPage, { overrideConfig: admissionConfigWithSize, context: context, tableBodyCols: tableBodyCols }) }));
+    return (_jsx("div", { className: "p-4", children: _jsx(GenericAdmissionPage, { overrideConfig: admissionConfig, context: context, tableBodyCols: tableBodyCols }) }));
 };
 // ============================================================================
 // PAGE EXPORTS

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@appcorp/fusion-storybook",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "scripts": {
     "build-storybook": "storybook build",
     "build:next": "next build",